Re: [fedora-arm] Quick update on prelink
Great. Also confirmed cross-prelink independently derived my patch. Strong confidence there but still concerns overall that I have the ball on. Thanks very much, Brendan. Brendan Conoboy b...@redhat.com wrote: On 04/04/2012 02:24 AM, Jon Masters wrote: Try this trivial patch to src/get.c that educates prelink about our linker (so it won't try to prelink the linker itself). This will then pass the testsuite. On the one hand, if this is all it is it's almost annoying that I went to the lengths to understand how it works before looking at it in detail, but on the other Jakub has told me there's not a lot of good data on prelink-on-arm so I need to do more code review /anyway/. Please try this patch and see what happens. I've installed the prelink package from arm.koji on an armv5tel rootfs, let prelink run its cron job, and the resulting system appears to be working normally. -- Brendan Conoboy / Red Hat, Inc. / b...@redhat.com ___ arm mailing list arm@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/arm ___ arm mailing list arm@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/arm
Re: [fedora-arm] Quick update on prelink
On 04/02/2012 03:57 AM, Jon Masters wrote: Slight disruption over the weekend, but I re-read the ELF spec, Jakub's paper, and started poking at the source. In large part, I wanted to make sure someone was tracking this for future AArch64 stuff. But now, I'll get back to actually fixing the problem, with an update to follow. Try this trivial patch to src/get.c that educates prelink about our linker (so it won't try to prelink the linker itself). This will then pass the testsuite. On the one hand, if this is all it is it's almost annoying that I went to the lengths to understand how it works before looking at it in detail, but on the other Jakub has told me there's not a lot of good data on prelink-on-arm so I need to do more code review /anyway/. Please try this patch and see what happens. Jon. diff -urNp prelink_orig/src/get.c prelink/src/get.c --- prelink_orig/src/get.c 2009-06-12 08:01:48.0 -0400 +++ prelink/src/get.c 2012-04-04 05:08:47.0 -0400 @@ -30,6 +30,7 @@ int is_ldso_soname (const char *soname) { if (! strcmp (soname, ld-linux.so.2) + || ! strcmp (soname, ld-linux.so.3) || ! strcmp (soname, ld.so.1) || ! strcmp (soname, ld-linux-ia64.so.2) || ! strcmp (soname, ld-linux-x86-64.so.2) ___ arm mailing list arm@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/arm
Re: [fedora-arm] Quick update on prelink
On 04/04/2012 02:24 AM, Jon Masters wrote: Try this trivial patch to src/get.c that educates prelink about our linker (so it won't try to prelink the linker itself). This will then pass the testsuite. On the one hand, if this is all it is it's almost annoying that I went to the lengths to understand how it works before looking at it in detail, but on the other Jakub has told me there's not a lot of good data on prelink-on-arm so I need to do more code review /anyway/. Please try this patch and see what happens. I've installed the prelink package from arm.koji on an armv5tel rootfs, let prelink run its cron job, and the resulting system appears to be working normally. -- Brendan Conoboy / Red Hat, Inc. / b...@redhat.com ___ arm mailing list arm@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/arm