Re: [aspectj-users] Trying to weave but get error

2020-03-18 Thread Alexander Kriegisch
> I wish it was that easy. We have 24 modules in a maven multi-module
> project.

I was not implying for you to expose your full project but to condense
it into an MCVE [1] reproducing the problem because there are many
things I don't know such as:

  -- Java version
  -- AspectJ version
  -- AspectJ Maven version and what exactly was changed in your (or
 someone else's) fork. There is one semi official fork I also use
 for Java 9+ AspectJ projects, but I have no idea if you are using
 that one or not.
  -- Is the error an AspectJ problem as it seems from the stack trace or
 maybe related to the Maven plugin?
  -- Which source file(s) does it fail to compile or weave?
  -- Do you use compile-time or binary weaving?

And several others. So please provide an MCVE. It could be as simple as
a source file reproducing the error when compiled manually by ajc
(AspectJ compiler) or a small Maven project. Whether the project also
contains the source code generation step or you just copy some generated
files into the project is not so important as long as the problem is
**reproducible**.

[1] https://stackoverflow.com/help/mcve

> I guess I need to make sure the generated sources are compiled before
> ajc.

Actually no, that should not be necessary. Ajc is a full drop-in
replacement for Javac.

Regards
-- 
Alexander Kriegisch
https://scrum-master.de


Mikael Petterson schrieb am 18.03.2020 21:29 (GMT +07:00):
> 
> Hi,
> 
> 
> I wish it was that easy. We have 24 modules in a maven multi-module
> project.
> 
> 
> One module has java template classes and then in another module,
> module-actions, we generate java code from these templates:
> 
> 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ module-actions
> ---^M
> 
> [INFO] Deleting C:\Users\me\git\prod\module-actions\target^M
> 
> [INFO] ^M
> 
> [INFO] --- build-helper-maven-plugin:3.0.0:add-source (add-source) @
> module-actions ---^M
> 
> [INFO] Source directory:
> C:\Users\me\git\prod\module-actions\target\generated-sources\annotations
> added.^M
> 
> [INFO] ^M
> 
> [INFO] --- aspectj-maven-plugin:1.11.1-FORK:compile (compile_with_aspectj)
> @ module-actions ---^M
> 
> 
> The version of aspectj-maven-plugin is for jdk 11 support. It was urgent
> at the time.
> 
> 
> I guess I need to make sure the generated sources are compiled before ajc.
> 
> 
> br,
> 
> 
> //mike
> 
> 
> 
> 
> Från: aspectj-users-boun...@eclipse.org
>  för Alexander Kriegisch
> 
> Skickat: den 18 mars 2020 12:36
> Till: aspectj-users@eclipse.org 
> Ämne: Re: [aspectj-users] Trying to weave but get error
> 
> 
> Hi Mikael.
> 
> How about a reproducible POM + Java + AspectJ project, maybe on GitHub?
> 
> I also don't know what kind of fork you are using:
> 
> > aspectj-maven-plugin:1.11.1-FORK
> 
> Thanks for an update with more info. :-)
> --
> Alexander Kriegisch
> https://scrum-master.de
> 
> 
> Mikael Petterson schrieb am 18.03.2020 19:27 (GMT +07:00):
> >
> > Hi,
> >
> >
> > We are trying to compile to compile a project ajc and get:
> >
> >
> > Failed to execute goal
> > org.codehaus.mojo:aspectj-maven-plugin:1.11.1-FORK:compile
> > (compile_with_aspectj) on project msran-jcat-extension-actions: AJC
> > compiler errors:
> >
> > [ERROR] error Unexpected error during ACG processing:
> > java.lang.NullPointerException
> >
> >
> > I know you are not maintainer of aspectj-maven-plugin but since you are
> > more familiar with the core I wonder if you have any ideas?
> >
> >
> > br,
> >
> >
> > //mike
> >
> >
> > Here is the more details of stacktrace:
> >
> >
> > java.lang.NullPointerException
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.sourceStart(SourceTypeBinding.java:2472)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.MethodBinding.sourceStart(MethodBinding.java:1331)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.determineSourceStart(TypeElementImpl.java:98)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.getSourceStart(TypeElementImpl.java:71)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:64)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:1)
> >
> >
> > at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
> >
> >
> > at java.util.TimSort.sort(TimSort.java:220)
> >
> >
> > at java.util.Arrays.sort(Arrays.java:1512)
> >
> >
> > at java.util.ArrayList.sort(ArrayList.java:1462)
> >
> >
> > at java.util.Collections.sort(Collections.java:175)
> >
> >
> > at
> >
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.getEnclosedElements(TypeElementImpl.java:165)
> >
> >
> > at
> >
> com.ericss

Re: [aspectj-users] Trying to weave but get error

2020-03-18 Thread Mikael Petterson
Hi,

I wish it was that easy. We have 24 modules in a maven multi-module project.

One module has java template classes and then in another module, 
module-actions, we generate java code from these templates:


[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ module-actions ---^M

[INFO] Deleting C:\Users\me\git\prod\module-actions\target^M

[INFO] ^M

[INFO] --- build-helper-maven-plugin:3.0.0:add-source (add-source) @ 
module-actions ---^M

[INFO] Source directory: 
C:\Users\me\git\prod\module-actions\target\generated-sources\annotations 
added.^M

[INFO] ^M

[INFO] --- aspectj-maven-plugin:1.11.1-FORK:compile (compile_with_aspectj) @ 
module-actions ---^M

The version of aspectj-maven-plugin is for jdk 11 support. It was urgent at the 
time.

I guess I need to make sure the generated sources are compiled before ajc.

br,

//mike






Från: aspectj-users-boun...@eclipse.org  för 
Alexander Kriegisch 
Skickat: den 18 mars 2020 12:36
Till: aspectj-users@eclipse.org 
Ämne: Re: [aspectj-users] Trying to weave but get error

Hi Mikael.

How about a reproducible POM + Java + AspectJ project, maybe on GitHub?

I also don't know what kind of fork you are using:

> aspectj-maven-plugin:1.11.1-FORK

Thanks for an update with more info. :-)
--
Alexander Kriegisch
https://scrum-master.de


Mikael Petterson schrieb am 18.03.2020 19:27 (GMT +07:00):
>
> Hi,
>
>
> We are trying to compile to compile a project ajc and get:
>
>
> Failed to execute goal
> org.codehaus.mojo:aspectj-maven-plugin:1.11.1-FORK:compile
> (compile_with_aspectj) on project msran-jcat-extension-actions: AJC
> compiler errors:
>
> [ERROR] error Unexpected error during ACG processing:
> java.lang.NullPointerException
>
>
> I know you are not maintainer of aspectj-maven-plugin but since you are
> more familiar with the core I wonder if you have any ideas?
>
>
> br,
>
>
> //mike
>
>
> Here is the more details of stacktrace:
>
>
> java.lang.NullPointerException
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.sourceStart(SourceTypeBinding.java:2472)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.MethodBinding.sourceStart(MethodBinding.java:1331)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.determineSourceStart(TypeElementImpl.java:98)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.getSourceStart(TypeElementImpl.java:71)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:64)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:1)
>
>
> at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
>
>
> at java.util.TimSort.sort(TimSort.java:220)
>
>
> at java.util.Arrays.sort(Arrays.java:1512)
>
>
> at java.util.ArrayList.sort(ArrayList.java:1462)
>
>
> at java.util.Collections.sort(Collections.java:175)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.getEnclosedElements(TypeElementImpl.java:165)
>
>
> at
> com.ericsson.msran.generator.util.ElementUtil.getEnumValues(ElementUtil.java:566)
>
>
> at
> com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:89)
>
>
> at
> com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:1)
>
>
> at
> com.ericsson.msran.generator.check.CodingRule.doCheck(CodingRule.java:70)
>
>
> at
> com.ericsson.msran.generator.check.CodingRuleExecutor$1.check(CodingRuleExecutor.java:39)
>
>
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:35)
>
>
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:1)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.VariableElementImpl.accept(VariableElementImpl.java:57)
>
>
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
>
>
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
>
>
> at
> javax.lang.model.util.ElementScanner6.visitType(ElementScanner6.java:178)
>
>
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:29)
>
>
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:1)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.accept(TypeElementImpl.java:136)
>
>
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
>
>
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
>
>
> at
> javax.lang.model.util.ElementScanner6.visitPackage(ElementScanner6.java:167)
>
>
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.PackageElementImpl.accept(PackageElementImpl.java:51)
>
>
> at 

Re: [aspectj-users] Trying to weave but get error

2020-03-18 Thread Alexander Kriegisch
Hi Mikael.

How about a reproducible POM + Java + AspectJ project, maybe on GitHub?

I also don't know what kind of fork you are using:

> aspectj-maven-plugin:1.11.1-FORK

Thanks for an update with more info. :-)
-- 
Alexander Kriegisch
https://scrum-master.de


Mikael Petterson schrieb am 18.03.2020 19:27 (GMT +07:00):
> 
> Hi,
> 
> 
> We are trying to compile to compile a project ajc and get:
> 
> 
> Failed to execute goal
> org.codehaus.mojo:aspectj-maven-plugin:1.11.1-FORK:compile
> (compile_with_aspectj) on project msran-jcat-extension-actions: AJC
> compiler errors:
> 
> [ERROR] error Unexpected error during ACG processing:
> java.lang.NullPointerException
> 
> 
> I know you are not maintainer of aspectj-maven-plugin but since you are
> more familiar with the core I wonder if you have any ideas?
> 
> 
> br,
> 
> 
> //mike
> 
> 
> Here is the more details of stacktrace:
> 
> 
> java.lang.NullPointerException
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.sourceStart(SourceTypeBinding.java:2472)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.lookup.MethodBinding.sourceStart(MethodBinding.java:1331)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.determineSourceStart(TypeElementImpl.java:98)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.getSourceStart(TypeElementImpl.java:71)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:64)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:1)
> 
> 
> at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
> 
> 
> at java.util.TimSort.sort(TimSort.java:220)
> 
> 
> at java.util.Arrays.sort(Arrays.java:1512)
> 
> 
> at java.util.ArrayList.sort(ArrayList.java:1462)
> 
> 
> at java.util.Collections.sort(Collections.java:175)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.getEnclosedElements(TypeElementImpl.java:165)
> 
> 
> at
> com.ericsson.msran.generator.util.ElementUtil.getEnumValues(ElementUtil.java:566)
> 
> 
> at
> com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:89)
> 
> 
> at
> com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:1)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRule.doCheck(CodingRule.java:70)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleExecutor$1.check(CodingRuleExecutor.java:39)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:35)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:1)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.VariableElementImpl.accept(VariableElementImpl.java:57)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
> 
> 
> at
> javax.lang.model.util.ElementScanner6.visitType(ElementScanner6.java:178)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:29)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:1)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.accept(TypeElementImpl.java:136)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
> 
> 
> at
> javax.lang.model.util.ElementScanner6.visitPackage(ElementScanner6.java:167)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.PackageElementImpl.accept(PackageElementImpl.java:51)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
> 
> 
> at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
> 
> 
> at
> com.ericsson.msran.generator.check.CodingRuleExecutor.checkAll(CodingRuleExecutor.java:46)
> 
> 
> at
> com.ericsson.msran.generator.ActionAnnotationProcessor.checkCodingRules(ActionAnnotationProcessor.java:228)
> 
> 
> at
> com.ericsson.msran.generator.ActionAnnotationProcessor.process(ActionAnnotationProcessor.java:149)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:139)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.round(RoundDispatcher.java:121)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.BaseAnnotationProcessorManager.processAnnotations(BaseAnnotationProcessorManager.java:159)
> 
> 
> at
> org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:9

[aspectj-users] Trying to weave but get error

2020-03-18 Thread Mikael Petterson
Hi,

We are trying to compile to compile a project ajc and get:
Failed to execute goal 
org.codehaus.mojo:aspectj-maven-plugin:1.11.1-FORK:compile 
(compile_with_aspectj) on project msran-jcat-extension-actions: AJC compiler 
errors:
[ERROR] error Unexpected error during ACG processing: 
java.lang.NullPointerException

I know you are not maintainer of aspectj-maven-plugin but since you are more 
familiar with the core I wonder if you have any ideas?

br,

//mike

Here is the more details of stacktrace:


java.lang.NullPointerException
at 
org.aspectj.org.eclipse.jdt.internal.compiler.lookup.SourceTypeBinding.sourceStart(SourceTypeBinding.java:2472)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.lookup.MethodBinding.sourceStart(MethodBinding.java:1331)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.determineSourceStart(TypeElementImpl.java:98)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.getSourceStart(TypeElementImpl.java:71)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:64)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl$SourceLocationComparator.compare(TypeElementImpl.java:1)
at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
at java.util.TimSort.sort(TimSort.java:220)
at java.util.Arrays.sort(Arrays.java:1512)
at java.util.ArrayList.sort(ArrayList.java:1462)
at java.util.Collections.sort(Collections.java:175)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.getEnclosedElements(TypeElementImpl.java:165)
at 
com.ericsson.msran.generator.util.ElementUtil.getEnumValues(ElementUtil.java:566)
at 
com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:89)
at 
com.ericsson.msran.generator.check.ActionAttributeCodingRules$3.check(ActionAttributeCodingRules.java:1)
at 
com.ericsson.msran.generator.check.CodingRule.doCheck(CodingRule.java:70)
at 
com.ericsson.msran.generator.check.CodingRuleExecutor$1.check(CodingRuleExecutor.java:39)
at 
com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:35)
at 
com.ericsson.msran.generator.check.CodingRuleScanner.visitVariable(CodingRuleScanner.java:1)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.VariableElementImpl.accept(VariableElementImpl.java:57)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
at 
javax.lang.model.util.ElementScanner6.visitType(ElementScanner6.java:178)
at 
com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:29)
at 
com.ericsson.msran.generator.check.CodingRuleScanner.visitType(CodingRuleScanner.java:1)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.TypeElementImpl.accept(TypeElementImpl.java:136)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
at 
javax.lang.model.util.ElementScanner6.visitPackage(ElementScanner6.java:167)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.model.PackageElementImpl.accept(PackageElementImpl.java:51)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:146)
at javax.lang.model.util.ElementScanner6.scan(ElementScanner6.java:133)
at 
com.ericsson.msran.generator.check.CodingRuleExecutor.checkAll(CodingRuleExecutor.java:46)
at 
com.ericsson.msran.generator.ActionAnnotationProcessor.checkCodingRules(ActionAnnotationProcessor.java:228)
at 
com.ericsson.msran.generator.ActionAnnotationProcessor.process(ActionAnnotationProcessor.java:149)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:139)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.round(RoundDispatcher.java:121)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.BaseAnnotationProcessorManager.processAnnotations(BaseAnnotationProcessorManager.java:159)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:952)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:448)
at 
org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:424)
at 
org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1107)
at 
org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:276)