date:20200320

Re: [aspectj-users] Trying to weave but get error

2020-03-20 Thread Mikael Petterson

Hi,

I replaced mojohaus version with
com.nickwongdev
aspectj-maven-plugin
${aspectj.maven.plugin.version}

and these versions:

1.12.6
1.9.5

Still the same problem.

Two questions comes to my mind:


  1.  I my multi-module project is it possible to exclude the failing module? 
Today I have added settings for aspectj in parent pom.xml
  2.  If it is a classpath problem how could it have been working before I 
introduced aspectj? Would it not be possible to add generated classes to 
classpath for aspectj?

br,

//mike







Från: aspectj-users-boun...@eclipse.org  för 
Alexander Kriegisch 
Skickat: den 19 mars 2020 07:37
Till: aspectj-users@eclipse.org 
Ämne: Re: [aspectj-users] Trying to weave but get error

>>> The version of aspectj-maven-plugin is for jdk 11 support. It was
>>> urgent at the time.

> https://github.com/mojohaus/aspectj-maven-plugin/commit/c4164ff

No, this commit was about Java 9/10 support.

>> -- AspectJ version

> [Mikael] 1.9.1

That release also was about Java 10 support:
https://www.eclipse.org/aspectj/doc/released/README-191.html

Java 11 support came one release later:
https://www.eclipse.org/aspectj/doc/released/README-192.html

1.9.3 was Java 12, 1.9.4 had a couple of important bugfixes, 1.9.5 supports 
Java 13.

My recommendation is to use this fork:
https://mvnrepository.com/artifact/com.nickwongdev/aspectj-maven-plugin/1.12.6

It should support AspectJ 1.9.5 (please also upgrade) and up to Java 13.
The Mojohaus maintainer knows about it and got a pull request. IntelliJ
IDEA's new 2020.x version will support it too for importing AspectJ
projects.

> ...\InjectedFunctionForRegressionChecker.java:6:0::0
> The import ...RegressionSetInjectableFunctionAction cannot be resolved

This rather seems to be some kind of classpath problem, maybe not even
directly related to AspectJ, but impossible to say for sure without the
MCVE.


--
Alexander Kriegisch
https://scrum-master.de
___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users
___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users

Re: [aspectj-users] Trying to weave but get error

2020-03-20 Thread Alexander Kriegisch

Mikael,

I hope you understand that I want to stop speculating until I have an MCVE 
reproducing the problem.

Regards
-- 
Alexander Kriegisch
https://scrum-master.de


Mikael Petterson schrieb am 20.03.2020 14:04 (GMT +07:00):
> 
> Hi,
> 
> 
> I replaced mojohaus version with
> 
> 
> com.nickwongdev
> 
> aspectj-maven-plugin
> 
> ${aspectj.maven.plugin.version}
> 
> 
> and these versions:
> 
> 
> 1.12.6
> 1.9.5
> 
> 
> Still the same problem.
> 
> 
> Two questions comes to my mind:
> 
> 
>   I my multi-module project is it possible to exclude the failing module?
>   Today I have added settings for aspectj in parent pom.xml
>   If it is a classpath problem how could it have been working before I
>   introduced aspectj? Would it not be possible to add generated classes to
>   classpath for aspectj?
> 
> 
> br,
> 
> 
> //mike
> 
> 
> 
> 
> Från: aspectj-users-boun...@eclipse.org
>  för Alexander Kriegisch
> 
> Skickat: den 19 mars 2020 07:37
> Till: aspectj-users@eclipse.org 
> Ämne: Re: [aspectj-users] Trying to weave but get error
> 
> 
> >>> The version of aspectj-maven-plugin is for jdk 11 support. It was
> >>> urgent at the time.
> 
> >
> https://github.com/mojohaus/aspectj-maven-plugin/commit/c4164ff
> 
> No, this commit was about Java 9/10 support.
> 
> >> -- AspectJ version
> 
> > [Mikael] 1.9.1
> 
> That release also was about Java 10 support:
> https://www.eclipse.org/aspectj/doc/released/README-191.html
> 
> Java 11 support came one release later:
> https://www.eclipse.org/aspectj/doc/released/README-192.html
> 
> 1.9.3 was Java 12, 1.9.4 had a couple of important bugfixes, 1.9.5
> supports Java 13.
> 
> My recommendation is to use this fork:
> https://mvnrepository.com/artifact/com.nickwongdev/aspectj-maven-plugin/1.12.6
> 
> It should support AspectJ 1.9.5 (please also upgrade) and up to Java 13.
> The Mojohaus maintainer knows about it and got a pull request. IntelliJ
> IDEA's new 2020.x version will support it too for importing AspectJ
> projects.
> 
> > ...\InjectedFunctionForRegressionChecker.java:6:0::0
> > The import ...RegressionSetInjectableFunctionAction cannot be resolved
> 
> This rather seems to be some kind of classpath problem, maybe not even
> directly related to AspectJ, but impossible to say for sure without the
> MCVE.
> 
> 
> --
> Alexander Kriegisch
> https://scrum-master.de
> ___
> aspectj-users mailing list
> aspectj-users@eclipse.org
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/aspectj-users
> 
> 

___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users

Re: [aspectj-users] Trying to weave but get error

2020-03-20 Thread Martin Gainty

be careful including artifacts from untested repositories..see below


From: aspectj-users-boun...@eclipse.org  on 
behalf of Mikael Petterson 
Sent: Friday, March 20, 2020 3:04 AM
To: aspectj-users@eclipse.org 
Subject: Re: [aspectj-users] Trying to weave but get error

Hi,

I replaced mojohaus version with
com.nickwongdev
aspectj-maven-plugin
${aspectj.maven.plugin.version}

and these versions:

1.12.6
1.9.5

Still the same problem.

Two questions comes to my mind:


  1.  I my multi-module project is it possible to exclude the failing module? 
Today I have added settings for aspectj in parent pom.xml

MG>if you only have one artifact to exclude try
MG>--projects '!module-to-exclude'

  2.  If it is a classpath problem how could it have been working before I 
introduced aspectj? Would it not be possible to add generated classes to 
classpath for aspectj?

MG> yes using directory parameter within configuration by executing 
build-helper-maven-plugin

  org.codehaus.mojo
  build-helper-maven-plugin
  1.12
  

  add-test-resource
  generate-test-sources
  
add-test-resource
  
  

  
path/to/additional/test/resources

  **/folder-to-exclude/**
MG>
MG>hth
MG>Martin

//mike







Från: aspectj-users-boun...@eclipse.org  för 
Alexander Kriegisch 
Skickat: den 19 mars 2020 07:37
Till: aspectj-users@eclipse.org 
Ämne: Re: [aspectj-users] Trying to weave but get error

>>> The version of aspectj-maven-plugin is for jdk 11 support. It was
>>> urgent at the time.

> https://github.com/mojohaus/aspectj-maven-plugin/commit/c4164ff

No, this commit was about Java 9/10 support.

>> -- AspectJ version

> [Mikael] 1.9.1

That release also was about Java 10 support:
https://www.eclipse.org/aspectj/doc/released/README-191.html

Java 11 support came one release later:
https://www.eclipse.org/aspectj/doc/released/README-192.html

1.9.3 was Java 12, 1.9.4 had a couple of important bugfixes, 1.9.5 supports 
Java 13.

My recommendation is to use this fork:
https://mvnrepository.com/artifact/com.nickwongdev/aspectj-maven-plugin/1.12.6

It should support AspectJ 1.9.5 (please also upgrade) and up to Java 13.
The Mojohaus maintainer knows about it and got a pull request. IntelliJ
IDEA's new 2020.x version will support it too for importing AspectJ
projects.

> ...\InjectedFunctionForRegressionChecker.java:6:0::0
> The import ...RegressionSetInjectableFunctionAction cannot be resolved

This rather seems to be some kind of classpath problem, maybe not even
directly related to AspectJ, but impossible to say for sure without the
MCVE.


--
Alexander Kriegisch
https://scrum-master.de
___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users
___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users

Re: [aspectj-users] Trying to weave but get error

2020-03-20 Thread Alexander Kriegisch

Martin Gainty schrieb am 20.03.2020 18:36 (GMT +07:00):

> be careful including artifacts from untested repositories..see below

This is available on Maven Central. Furthermore, it is open source and as I 
said, the fork was created because the original plugin was not maintained for a 
very long time. Both Nick and I contacted the Mojohaus people and asked them to 
review and accept the pull request, then publish a new upstream release - so 
far without any effect. For the last few years this 'nickwongdev' fork has been 
the only clean way to work with AspectJ in Maven with Java versions 9+. So 
please gather some information next time before irritating other people with 
unspecific warning messages. Thank you.

-- 
Alexander Kriegisch
https://scrum-master.de


> From: aspectj-users-boun...@eclipse.org
>  on behalf of Mikael Petterson
> 
> Sent: Friday, March 20, 2020 3:04 AM
> To: aspectj-users@eclipse.org 
> Subject: Re: [aspectj-users] Trying to weave but get error
> 
> 
> Hi,
> 
> 
> I replaced mojohaus version with
> 
> 
> com.nickwongdev
> 
> aspectj-maven-plugin
> 
> ${aspectj.maven.plugin.version}
> 
> 
> and these versions:
> 
> 
> 1.12.6
> 1.9.5
> 
> 
> Still the same problem.
> 
> 
> Two questions comes to my mind:
> 
> 
>   I my multi-module project is it possible to exclude the failing module?
>   Today I have added settings for aspectj in parent pom.xml
>   
>   MG>if you only have one artifact to exclude try
>   MG>--projects '!module-to-exclude'
>   
>   If it is a classpath problem how could it have been working before I
>   introduced aspectj? Would it not be possible to add generated classes to
>   classpath for aspectj?
> 
> 
> MG> yes using directory parameter within configuration by executing
> build-helper-maven-plugin
> 
>  org.codehaus.mojo
>  build-helper-maven-plugin
>  1.12
>  
>  
>  add-test-resource
>  generate-test-sources
>  
>  add-test-resource
>  
>  
>  
>  
>  path/to/additional/test/resources
>  
>  **/folder-to-exclude/**
> MG>
> MG>hth MG>Martin
> 
> 
> //mike
> 
> 
> 
> 
> Från: aspectj-users-boun...@eclipse.org
>  för Alexander Kriegisch
> 
> Skickat: den 19 mars 2020 07:37
> Till: aspectj-users@eclipse.org 
> Ämne: Re: [aspectj-users] Trying to weave but get error
> 
> 
> >>> The version of aspectj-maven-plugin is for jdk 11 support. It was
> >>> urgent at the time.
> 
> >
> https://github.com/mojohaus/aspectj-maven-plugin/commit/c4164ff
> 
> No, this commit was about Java 9/10 support.
> 
> >> -- AspectJ version
> 
> > [Mikael] 1.9.1
> 
> That release also was about Java 10 support:
> https://www.eclipse.org/aspectj/doc/released/README-191.html
> 
> Java 11 support came one release later:
> https://www.eclipse.org/aspectj/doc/released/README-192.html
> 
> 1.9.3 was Java 12, 1.9.4 had a couple of important bugfixes, 1.9.5
> supports Java 13.
> 
> My recommendation is to use this fork:
> https://mvnrepository.com/artifact/com.nickwongdev/aspectj-maven-plugin/1.12.6
> 
> It should support AspectJ 1.9.5 (please also upgrade) and up to Java 13.
> The Mojohaus maintainer knows about it and got a pull request. IntelliJ
> IDEA's new 2020.x version will support it too for importing AspectJ
> projects.
> 
> > ...\InjectedFunctionForRegressionChecker.java:6:0::0
> > The import ...RegressionSetInjectableFunctionAction cannot be resolved
> 
> This rather seems to be some kind of classpath problem, maybe not even
> directly related to AspectJ, but impossible to say for sure without the
> MCVE.
> 
> 
> --
> Alexander Kriegisch
> https://scrum-master.de
> ___
> aspectj-users mailing list
> aspectj-users@eclipse.org
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/aspectj-users
> 
> 

___
aspectj-users mailing list
aspectj-users@eclipse.org
To unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/aspectj-users

Re: [aspectj-users] Trying to weave but get error

2020-03-20 Thread Mikael Petterson

Hi all,

I guess @Martin Gainty statement about security was 
had it's best intentions but not very well substantiated.

@Alexander Kriegisch we had the same 
experience as you and were really pushed to get a new release. Since no answers 
from project maintainers, that is the least you can ask for in a community 
based world, we hade to fork and make release. I looked at the new project, 
nickwongdev' , and it had a one major improvement which was one master pom and 
modules.

So to the final part, yes I let you wait for the best to last. I have solved 
the issue.

This part in the failing pom.xml fixed it:



${project.build.directory}/classes


I don't really know why but it does. Found it after googling for sometime ( 
thinking I cannot be the first person encountering this).

All help was greatly appreciated from you all!

br,

//mike

In parent pom for all maven modules we have:

1.12.6
1.9.5

and



com.nickwongdev
aspectj-maven-plugin
${aspectj.maven.plugin.version}

1.8 

**/*.java
**/*.aj


**/generated-sources/annotations/**

src/main/aspect
src/test/aspect
true



com.company.library
aspectj-impl





compile_with_aspectj

compile





org.aspectj
aspectjrt
${aspectj.version}


org.aspectj
aspectjtools
${aspectj.version}


com.company.library
aspectj-impl
${aspectj.impl}





And in the module with annotation processing and that failed:



com.nickwongdev
aspectj-maven-plugin
${aspectj.maven.plugin.version}

1.8 
true
ignore


${project.build.directory}/classes



com.company.library
aspectj-impl





compile_with_aspectj

compile





org.aspectj
aspectjrt
${aspectj.version}


org.aspectj
aspectjtools
${aspectj.version}


com.company.library
aspectj-impl
${aspectj.impl}







Från: aspectj-users-boun...@eclipse.org  för 
Alexander Kriegisch 
Skickat: den 20 mars 2020 14:28
Till: aspectj-users@eclipse.org 
Ämne: Re: [aspectj-users] Trying to weave but get error

Martin Gainty schrieb am 20.03.2020 18:36 (GMT +07:00):

> be careful including artifacts from untested repositories..see below

This is available on Maven Central. Furthermore, it is open source and as I 
said, the fork was created because the original plugin was not maintained for a 
very long time. Both Nick and I contacted the Mojohaus people and asked them to 
review and accept the pull request, then publish a new upstream release - so 
far without any effect. For the last few years this 'nickwongdev' fork has been 
the only clean way to work with AspectJ in Maven with Java versions 9+. So 
please gather some information next time before irritating other people with 
unspecific warning messages. Thank you.

--
Alexander Kriegisch
https://scrum-master.de


> From: aspectj-users-boun...@eclipse.org
>  on behalf of Mikael Petterson
> 
> Sent: Friday, March 20, 2020 3:04 AM
> To: aspectj-users@eclipse.org 
> Subject: Re: [aspectj-users] Trying to weave but get error
>
>
> Hi,
>
>
> I replaced mojohaus version with
>
>
> com.nickwongdev
>
> aspectj-maven-plugin
>
> ${aspectj.maven.plugin.version}
>
>
> and these versions:
>
>
> 1.12.6
> 1.9.5
>
>
> Still the same problem.
>
>
> Two questions comes to my mind:
>
>
>I my multi-module project is it possible to exclude the failing module?
>Today I have added settings for aspectj in parent pom.xml
>
>MG>if you only have one artifact to exclude try
>MG>--projects '!module-to-exclude'
>
>If it is a classpath problem how could it have been working before I
>introduced aspectj? Would it not be possible to add generated classes 
> to
>classpath for aspectj?
>
>
> MG> yes using directory parameter within configuration by executing
> build-helper-maven-plugin
> 
>  org.codehaus.mojo
>  build-helper-maven-plugin
>  1.12
>  
>  
>  add-test-resource
>  generate-test-sources
>  
>  add-test-resource
>  
>  
>  
>  
>  path/to/additional/test/resources
>  
>  **/folder-to-exclude/**
> MG>
> MG>hth MG>Martin
>
>
> //mike
>
>
> 
>
> Från: aspectj-users-boun...@eclipse.org
>  för Alexander Kriegisch
> 
> Skickat: den 19 mars 2020 07:37
> Till: aspectj-users@eclipse.org 
> Ämne: Re: [aspectj-users] Trying to weave but get error
>
>
> >>> The version of aspectj-maven-plugin is for jdk 11 support. It was
> >>> urgent at the time.
>
> >
> https://github.com/mojohaus/aspectj-maven-plugin/commit/c4164ff
>
> No, this commit was about Java 9/10 support.
>
> >> -- AspectJ version
>
> > [Mikael] 1.9.1
>
> That release also was about Java 10 support:
> https://www.eclipse.org/aspectj/doc/released/README-191.html
>
> Java 11 support came one release later:
> https://www.eclipse.org/aspectj/doc/released/README-192.html
>
> 1.9.3 was Java 12, 1.9.4 had a couple of important bugfixes, 1.9.5
> supports Java 13.
>
> My recommendation is to use this fork:
> https://mvnrepository.com/artifact/com.nickwongdev/aspectj-maven-plugin/1.12.6
>

Re: [aspectj-users] Trying to weave but get error

Re: [aspectj-users] Trying to weave but get error

Re: [aspectj-users] Trying to weave but get error

Re: [aspectj-users] Trying to weave but get error

Re: [aspectj-users] Trying to weave but get error

5 matches

Site Navigation

Mail list logo

Footer information