[asterisk-dev] [Code Review] 3041: app_record: Add an option that allows DTMF '0' to act as an additional terminator

2013-12-03 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3041/
---

Review request for Asterisk Developers, Mark Michelson and rmudgett.


Repository: Asterisk


Description
---

If the option is in use and '0' is used to exit the application, 
${RECORD_STATUS} will also be set to 'OPERATOR' instead of 'DTMF'.
Pretty straight forward.


Diffs
-

  /trunk/apps/app_record.c 403345 

Diff: https://reviewboard.asterisk.org/r/3041/diff/


Testing
---

Tested with and without 'o' option to make sure normal exit DTMF still resulted 
in exiting with 'DTMF' for ${RECORD_STATUS}
Tested that the 'o' option made '0' DTMF result in 'OPERATOR' for 
${RECORD_STATUS}. Also that this takes precedence when using the any terminator 
option.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.8.0-rc5 Now Available

2013-12-03 Thread Asterisk Development Team 

The Asterisk Development Team has announced the releases of:
DAHDI-Linux-v2.8.0-rc5
DAHDI-Tools-v2.8.0-rc5
dahdi-linux-complete-2.8.0-rc5+2.8.0-rc5

This release is available for immediate download at:
http://downloads.asterisk.org/pub/telephony/dahdi-linux
http://downloads.asterisk.org/pub/telephony/dahdi-tools
http://downloads.asterisk.org/pub/telephony/dahdi-linux-complete

*** THIS RC FIXES CENTOS 6.5 "PDE_DATA" build issue ***

In version 2.8 we have introduced two new drivers:
wcte43x - For Digium's new line of 2/4 span T1/E1 cards
wcaxx - For Digium's new line of analog fxs/fxo cards

We introduced a common library called "wcxb" which ties the previous two
drivers, plus the recently introduced wcte13xp driver, together into one common
base.

dahdi-linux-complete tarballs now include all firmware necessary to build
without an internet connection.

Issues closed in this release:
https://issues.asterisk.org/jira/browse/DAHLIN-331

Shortlog of changes since v2.7.0.1:
Oron Peled (16):
  xpp: Serialize dahdi registration
  xpp: refactor FXS ring settings
  xpp: FXS: ring/mwi settings: a sysfs interface
  xpp: ring/mwi settings: add to FXS init script
  add a 'location' attribute to sysfs (dahdi_device):
  dahdi: add "tools_rootdir" module parameter
  Also send DAHDI_TOOLS_ROOTDIR with device events
  live_dahdi: load "dahdi" with tools_rootdir=$DESTDIR
  remove udev rules: moved to dahdi-tools
  sysfs: create symlink "ddev" to device of span
  dahdi: Rename span 'master' as 'master_span'
  .gitignore: *.ko.unsigned
  Rename "pinned spans" to "assigned spans"
  xpp: automatic dahdi_registration by default
  sysfs: new driver attribute: master_span
  Makefile: new 'make-dist' target

Russ Meyerriecks (3):
  wcte13xp: Migrate to wcxb library
  wcte13xp: Hold framer in reset to stop xmit on modprobe -r
  wcte13xp: Improve maintenance functions and error counters

Shaun Ruffell (28):
  dahdi_config: Remove unused NO_DCDC definition.
  dahdi: Clear DAHDI_ALARM_NOTOPEN when spans are re-initialized.
  dahdi: Fix placement of '/' in output of /proc/dahdi/x
  dahdi: Work around missing KBUILD_MODNAME
  dahdi: Backport try_wait_for_completion() and list_first_entry()
  wct4xxp: Print warning in dmesg if span priority is not set correctly.
  wct4xxp: Fix bipolar error insertion test mode.
  wct4xxp: VPM companding switch print is now debug only.
  wct4xxp: If linemode changed via sysfs, reset the complete part.
  wct4xxp, wcte13xp: Move the octasic DSP code into separate module.
  wcaxx: New driver for A4A/A4B/A8A/A8B analog cards.
  wcaxx: Update A4B firmware to version 0b0017
  wcxb: Update the firmware meta block during flash update.
  wcte43x: Do not grab reglock in handle_transmit/handle_receive.
  wcte43x: Remove 'dcxo' debug attribute.
  oct612x: Make dependent on dahdi.ko
  dahdi_dynamic: Create a span type for dynamic spans.
  wcaxx: Use startup/shutdown callbacks to protect access to channel 
registers.
  wctdm24xxp: Remove assigned callback.
  dahdi: Remove "ddev" symlink before unregistering the span device.
  dahdi: CentOS 6.5 backported PDE_DATA definition.
  wcxb: is_pcie -> pci_is_pcie()
  wcxb: Do not access cur_transfer/cur_msg outside of lock.
  wcaxx: Add extra dummy read when checking for single fxs modules.
  wcte43x: Update firmware to version e0017.
  dahdi: Replace drv_attr with drv_groups on kernels > 3.12.
  Revert "wcaxx: Use startup/shutdown callbacks to protect access to channel 
registers."
  dahdi: Fix previous CentOS 6.5 commit.

Shaun RuffellL (1):
  wcaxx: Remove some left over debugging trace statements.

Tzafrir Cohen (6):
  xpp: Firmware for Astribanks 2.02
  xpp: Firmware for Astribanks 2.02: Makefile
  xpp: USB_FW.202.hex: provide as a symlink
  xpp: mark an AB as failed if it gives bad desc
  xpp: Fail loading if no module on first slot
  Ignore some more firmware files

Wendell Thompson (2):
  wcte13xp: Use interrupts for Falc alarms and signaling
  wcte43x: Add driver for TE435/TE235 digital cards.



The diffstat from the v2.7.0.1 release:
 .gitignore|9 +
 Makefile  |   28 +-
 README|   17 +-
 build_tools/genudevrules  |   40 -
 build_tools/live_dahdi|2 +-
 build_tools/make_dist |   26 +
 drivers/dahdi/Kbuild  |   21 +-
 drivers/dahdi/dahdi-base.c|   74 +-
 drivers/dahdi/dahdi-sysfs.c   |  150 +-
 drivers/dahdi/dahdi_dynamic.c |4 +
 drivers/dahdi/firmware/Makefile   |   71 +-
 drivers/dahdi/oct612x/Kbuild  |   32 +
 drivers/dahdi/oct612x/oct612x-user.c

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-03 Thread Kevin Harwell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/
---

(Updated Dec. 3, 2013, 2:12 p.m.)


Review request for Asterisk Developers.


Changes
---

Updated based on review findings/feedback.

Going with Mark Michelson's #2 suggestion: Sending to an arbitray URI now 
requires a default outbound endpoint that can be specified under the global 
options section within pjsip.conf.

Also fixed a couple minor off nominal memory leaks in res_pjsip_messaging.


Repository: Asterisk


Description
---

Added the ability to send messages to a URI (an associated endpoint is no 
longer needed). 


Diffs (updated)
-

  branches/12/res/res_pjsip_messaging.c 403341 
  branches/12/res/res_pjsip/pjsip_configuration.c 403341 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 403341 
  branches/12/res/res_pjsip/config_global.c 403341 
  branches/12/res/res_pjsip.c 403341 
  branches/12/include/asterisk/res_pjsip.h 403341 
  branches/12/configs/pjsip.conf.sample 403341 

Diff: https://reviewboard.asterisk.org/r/2944/diff/


Testing
---

Had the PJSIP message module send a SIP message to a specified IP address.


Thanks,

Kevin Harwell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] DAHDI-Linux and DAHDI-Tools 2.7.0.2 Now Available

2013-12-03 Thread Asterisk Development Team 

The Asterisk Development Team has announced the releases of:
DAHDI-Linux-v2.7.0.2
DAHDI-Tools-v2.7.0.2
dahdi-linux-complete-2.7.0.2+2.7.0.2

This release is available for immediate download at:
http://downloads.asterisk.org/pub/telephony/dahdi-linux
http://downloads.asterisk.org/pub/telephony/dahdi-tools
http://downloads.asterisk.org/pub/telephony/dahdi-linux-complete

*** THIS RELEASE FIXES CENTOS 6.5 "PDE_DATA" build issue ***

dahdi-linux-complete tarballs now include all firmware necessary to build
without an internet connection.

Issues closed in this release:
https://issues.asterisk.org/jira/browse/DAHLIN-331

Shortlog of changes since v2.7.0.1:
Shaun Ruffell (2):
  dahdi: CentOS 6.5 backported PDE_DATA definition.
  dahdi: Fix previous CentOS 6.5 commit.


The diffstat from the v2.7.0.1 release:
 include/dahdi/kernel.h |   12 
 1 file changed, 12 insertions(+)


For a full list of changes in these releases, please see the shortlog at:
http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=shortlog;h=refs/tags/v2.7.0.2
http://git.asterisk.org/gitweb/?p=dahdi/tools.git;a=shortlog;h=refs/tags/v2.7.0.2

Issues found in this release can be reported in the DAHDI-Linux [1] and
DAHDI-Tools [2] projects at https://issues.asterisk.org/jira

[1] https://issues.asterisk.org/jira/browse/DAHLIN
[2] https://issues.asterisk.org/jira/browse/DAHTOOL

Thank you for your continued support of Asterisk!

--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
  http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-03 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3040/#review10297
---



/branches/12/main/bridge.c


This function may need to clear the other transfer variable if it exists on 
the channel since there are two now.


- rmudgett


On Dec. 2, 2013, 9:22 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3040/
> ---
> 
> (Updated Dec. 2, 2013, 9:22 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> There were still a few cases in which ATTENDEDTRANSFER and BLINDTRANSFER 
> wouldn't be set on channels involved with blind and attended transfers. This 
> would happen with features that were initialized by channel driver specific 
> mechanisms in multiparty calls. This patch resolves those cases while 
> attempted to keep the behavior for setting those variables as consistent as 
> possible.
> 
> 
> Diffs
> -
> 
>   /branches/12/main/bridge.c 403068 
> 
> Diff: https://reviewboard.asterisk.org/r/3040/diff/
> 
> 
> Testing
> ---
> 
> Test One - single peer tansfers
> 1. Started a two way call between two chan_sip channels.
> 2. SIP atxfer'd it to an extension that would display the ATTENDEDTRANSFER 
> and BLINDTRANSFER variables
> 3. repeated test with SIP blindxfer and compared the results.
> 
> Without patch:
> Blind transfer variable would be present on blind transfer, attended transfer 
> variable would be present on attended transfer.
> 
> With patch:
> No behavioral change
> 
> Test Two - transferring three party calls
> 1. Started a two way call between two chan_sip channels.
> 2. Feature ATXfer'd to a local channel that would screech something about 
> weasels every few seconds. Merged into a 3 way call with *3.
> 3. SIP atxfer'd the bridge to an extension that would display 
> ATTENDEDTRANSFER and BLINDTRANSFER variables
> 3. repeated test with SIP blindxfer and compared the results.
> 
> Without patch:
> Attended transfer variables weren't set at all.
> Blind transfer variables would be set on the channels that were already in 
> the bridge, but not on the local channel that was used to transfer.
> 
> With patch:
> Attended transfer variable set for all channels in the bridge as well as the 
> local channel used for the transfer.
> Blind transer variables set for all channels in the bridge as well as the 
> local channel used for the transfer.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-03 Thread Mark Michelson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3040/#review10296
---

Ship it!


Ship It!

- Mark Michelson


On Dec. 2, 2013, 9:22 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3040/
> ---
> 
> (Updated Dec. 2, 2013, 9:22 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> There were still a few cases in which ATTENDEDTRANSFER and BLINDTRANSFER 
> wouldn't be set on channels involved with blind and attended transfers. This 
> would happen with features that were initialized by channel driver specific 
> mechanisms in multiparty calls. This patch resolves those cases while 
> attempted to keep the behavior for setting those variables as consistent as 
> possible.
> 
> 
> Diffs
> -
> 
>   /branches/12/main/bridge.c 403068 
> 
> Diff: https://reviewboard.asterisk.org/r/3040/diff/
> 
> 
> Testing
> ---
> 
> Test One - single peer tansfers
> 1. Started a two way call between two chan_sip channels.
> 2. SIP atxfer'd it to an extension that would display the ATTENDEDTRANSFER 
> and BLINDTRANSFER variables
> 3. repeated test with SIP blindxfer and compared the results.
> 
> Without patch:
> Blind transfer variable would be present on blind transfer, attended transfer 
> variable would be present on attended transfer.
> 
> With patch:
> No behavioral change
> 
> Test Two - transferring three party calls
> 1. Started a two way call between two chan_sip channels.
> 2. Feature ATXfer'd to a local channel that would screech something about 
> weasels every few seconds. Merged into a 3 way call with *3.
> 3. SIP atxfer'd the bridge to an extension that would display 
> ATTENDEDTRANSFER and BLINDTRANSFER variables
> 3. repeated test with SIP blindxfer and compared the results.
> 
> Without patch:
> Attended transfer variables weren't set at all.
> Blind transfer variables would be set on the channels that were already in 
> the bridge, but not on the local channel that was used to transfer.
> 
> With patch:
> Attended transfer variable set for all channels in the bridge as well as the 
> local channel used for the transfer.
> Blind transer variables set for all channels in the bridge as well as the 
> local channel used for the transfer.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Scheduler problem

2013-12-03 Thread Kaloyan Kovachev 

Hello,
i am still fighting this problem without much success. Some times it 
works fine for weeks and then suddenly crashes.


What i have found so far, is that bridge config is somehow disappearing 
during the call - how could that happen?


In my scheduler callback i have separated the checks to pinpoint the 
structure causing the crash and:

The datastore structure is in place
The two channels are in place
struct ast_bridge_config *config when accessed is causing the crash

I have added a flag in the datastore structure, which i set immediately 
after the call to ast_bridge_call() and the flag is not set during a 
crash, so ...


How is it possible for the config to disappear during a call? How to 
prevent it?


On 2013-10-23 13:32, Kaloyan Kovachev wrote:

Hello list,
i have some crashes from time to time accessing the data from a
callback function and can't find any reason.

The scheduler thread is created from a wrapper around
ast_bridge_call() function and is running while the channels are
bridged. After ast_bridge_call() returns the schedule is removed with
ast_sched_del() inside a scheduler thread lock, then it is unlocked to
run some other code and just after that, the datastore (and the
structure passed to the callback it contains) is freed. This is also
done inside a scheduler thread lock and a channel lock.

I can't think of any way the callback is called without the datastore
(and it's callback data) being present, but still there is a crash
inside the callback when the callback data is accessed ... What i am
missing here?!


--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
  http://lists.digium.com/mailman/listinfo/asterisk-dev