Re: [asterisk-dev] starpy
On Mon, Mar 26, 2018 at 4:55 AM, Corey Farrell wrote: > I'm working on some PR's to update the Asterisk testsuite to be compatible > with Python3 (without breaking Python2). An issue I've hit is starpy. A PR > to deal with compatibility was started but never finished. Can we move > starpy to gerrit.asterisk.org and convert the github repository to a mirror > the same way Asterisk and the testsuite are done? starpy is a critical > dependency of the Asterisk testsuite and PR's on github.com do not get > proper attention since most Asterisk developers do not follow it. Using > gerrit to perform active work would ensure important PR's do not go stale. I don't have a problem with this. Anybody else have any thoughts/concerns? -- Matthew Fredrickson Digium, Inc. | Engineering Manager 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] starpy
did you use starpy to do click to call On Tue, Mar 27, 2018 at 8:48 AM, Matt Fredrickson wrote: > On Mon, Mar 26, 2018 at 4:55 AM, Corey Farrell wrote: > > I'm working on some PR's to update the Asterisk testsuite to be > compatible > > with Python3 (without breaking Python2). An issue I've hit is starpy. > A PR > > to deal with compatibility was started but never finished. Can we move > > starpy to gerrit.asterisk.org and convert the github repository to a > mirror > > the same way Asterisk and the testsuite are done? starpy is a critical > > dependency of the Asterisk testsuite and PR's on github.com do not get > > proper attention since most Asterisk developers do not follow it. Using > > gerrit to perform active work would ensure important PR's do not go > stale. > > I don't have a problem with this. Anybody else have any thoughts/concerns? > > -- > Matthew Fredrickson > Digium, Inc. | Engineering Manager > 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: >http://lists.digium.com/mailman/listinfo/asterisk-dev > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] starpy
Any other items not in Gerrit? +1 on getting all the things in the same place. On Tue, Mar 27, 2018 at 10:48 AM, Matt Fredrickson wrote: > On Mon, Mar 26, 2018 at 4:55 AM, Corey Farrell wrote: > > I'm working on some PR's to update the Asterisk testsuite to be > compatible > > with Python3 (without breaking Python2). An issue I've hit is starpy. > A PR > > to deal with compatibility was started but never finished. Can we move > > starpy to gerrit.asterisk.org and convert the github repository to a > mirror > > the same way Asterisk and the testsuite are done? starpy is a critical > > dependency of the Asterisk testsuite and PR's on github.com do not get > > proper attention since most Asterisk developers do not follow it. Using > > gerrit to perform active work would ensure important PR's do not go > stale. > > I don't have a problem with this. Anybody else have any thoughts/concerns? > > -- > Matthew Fredrickson > Digium, Inc. | Engineering Manager > 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: >http://lists.digium.com/mailman/listinfo/asterisk-dev > -- - Andrew "lathama" Latham - -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] starpy
How can i do click to call via web with python On Tue, Mar 27, 2018 at 9:15 AM, Andrew Latham wrote: > Any other items not in Gerrit? +1 on getting all the things in the same > place. > > On Tue, Mar 27, 2018 at 10:48 AM, Matt Fredrickson > wrote: > >> On Mon, Mar 26, 2018 at 4:55 AM, Corey Farrell wrote: >> > I'm working on some PR's to update the Asterisk testsuite to be >> compatible >> > with Python3 (without breaking Python2). An issue I've hit is starpy. >> A PR >> > to deal with compatibility was started but never finished. Can we move >> > starpy to gerrit.asterisk.org and convert the github repository to a >> mirror >> > the same way Asterisk and the testsuite are done? starpy is a critical >> > dependency of the Asterisk testsuite and PR's on github.com do not get >> > proper attention since most Asterisk developers do not follow it. Using >> > gerrit to perform active work would ensure important PR's do not go >> stale. >> >> I don't have a problem with this. Anybody else have any >> thoughts/concerns? >> >> -- >> Matthew Fredrickson >> Digium, Inc. | Engineering Manager >> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA >> >> -- >> _ >> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >> >> asterisk-dev mailing list >> To UNSUBSCRIBE or update options visit: >>http://lists.digium.com/mailman/listinfo/asterisk-dev >> > > > > -- > - Andrew "lathama" Latham - > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: >http://lists.digium.com/mailman/listinfo/asterisk-dev > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] starpy
On Tue, Mar 27, 2018 at 12:48 PM, Matt Fredrickson wrote: > On Mon, Mar 26, 2018 at 4:55 AM, Corey Farrell wrote: >> I'm working on some PR's to update the Asterisk testsuite to be compatible >> with Python3 (without breaking Python2). An issue I've hit is starpy. A PR >> to deal with compatibility was started but never finished. Can we move >> starpy to gerrit.asterisk.org and convert the github repository to a mirror >> the same way Asterisk and the testsuite are done? starpy is a critical >> dependency of the Asterisk testsuite and PR's on github.com do not get >> proper attention since most Asterisk developers do not follow it. Using >> gerrit to perform active work would ensure important PR's do not go stale. > > I don't have a problem with this. Anybody else have any thoughts/concerns? > +1 to move Gerrit I've there some time ago. I've working in the same points of Corey time ago. There [1] Pull Request still there for starpy and a [2] previous work to add support to the testsuite 1: https://github.com/asterisk/starpy/pull/40 2: https://gerrit.asterisk.org/#/c/4074/ -- Rodrigo Ramírez Norambuena http://www.rodrigoramirez.com/ -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] ast_monitor_start has no effect.... sometimes
On Fri, Mar 23, 2018 at 3:00 PM, Steve Murphy wrote:
> Hello--
>
> I guess I have a weird situation, in that we use a separate process to
> turn on call recording for a channel. It gets bridge join events via AMI
> and send a StartMonitor action via AMI back to asterisk.
>
> The trouble is, that depending on the machine, the phase of the moon, and
> who knows what else, the request takes longer cometimes, and the
> ast_monitor_start has no effect.
>
> On a good day, the channels are both Locally RTP bridged, and the
> native_rtp technology is started, the res_monitor start comes in and then
> "switching from native_rtp to simple_bridge gets done, I see both channels
> put in a dummy bridge, the native_rtp is stopped, the
> ast_channel_make_compatible_helper chooses ulaw, and the simple_bridge
> technology is started.
> I see 3 more messages about "Bridge x is already using the new
> technology (simple_bridge), and I see __ast_read() copying packets into the
> recording files.
>
> On a bad day, I see the channels are both Locally RTP bridged, and the
> native_rtp technology is started. I see the "Bridge x is already using
> the new technology (native_rtp) twice, then the __ast_monitor_start is run,
> and that's it. The packets are forwarded without any __ast_read() calls,
> and no packets are copied to the recording files. (They are in WAV format,
> with only the 60-byte header in the files)
>
> Is there something I need to do to get the bridge into simple_bridge tech
> when we start the monitor?
>
This is a bug with res_monitor. Please file an issue.
The ast_monitor_start() function needs to check if the channel is in a
bridge after it has set the monitor
structure on the channel and set the unbridged flag to have the bridging
system reevaluate the bridge
technology.
In res_monitor.c:ast_monitor_start():
ast_channel_monitor_set(chan, monitor);
ast_monitor_set_state(chan, AST_MONITOR_RUNNING);
+
+ if (ast_channel_is_bridged(chan)) {
+ ast_channel_set_unbridged_nolock(chan, 1);
+ }
+
/* so we know this call has been monitored in case we need to bill for it
or something */
pbx_builtin_setvar_helper(chan, "__MONITORED","true");
MixMonitor does not have this problem. When MinMonitor attaches its
audiohook
existing code that I've added above for Monitor causes the bridge to
reevaluate.
I think a better place is in channel_internal_api.c instead as it will
happen for starting, stopping,
and masquarading channels with monitor:
void ast_channel_monitor_set(struct ast_channel *chan, struct
ast_channel_monitor *value)
{
chan->monitor = value;
+ if (ast_channel_internal_bridge(chan)) {
+ast_channel_set_unbridged_nolock(chan, 1);
+ }
}
Richard
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
