Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
> On May 28, 2014, 9:40 a.m., wdoekes wrote: > > Ship It! Do I need to re-submit this to get it applied to the trunk where it is also a bug or will this happen automatically? - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/#review11983 --- On May 28, 2014, 9:42 a.m., Peter Whisker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3567/ > --- > > (Updated May 28, 2014, 9:42 a.m.) > > > Review request for Asterisk Developers and Igor Goncharovsky. > > > Bugs: ASTERISK-23792 > https://issues.asterisk.org/jira/browse/ASTERISK-23792 > > > Repository: Asterisk > > > Description > --- > > There is a conditional exit from a mutexed area of code which does not unlock > before the return. > > > Diffs > - > > /branches/11/channels/chan_unistim.c 414674 > > Diff: https://reviewboard.asterisk.org/r/3567/diff/ > > > Testing > --- > > Inspection and build > > > Thanks, > > Peter Whisker > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 28, 2014, 4:42 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Igor Goncharovsky. Changes --- Committed in revision 414677 Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs - /branches/11/channels/chan_unistim.c 414674 Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 28, 2014, 8:06 a.m.) Review request for Asterisk Developers and Igor Goncharovsky. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs - /branches/11/channels/chan_unistim.c 414674 Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 28, 2014, 7:59 a.m.) Review request for Asterisk Developers and Igor Goncharovsky. Changes --- Amended as suggested by wdoekes - now patched against branches/11 and simply moved the unlock up four lines. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs (updated) - /branches/11/channels/chan_unistim.c 414674 Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 27, 2014, 8:32 a.m.) Review request for Asterisk Developers and Igor Goncharovsky. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs (updated) - /tags/11.9.0/channels/chan_unistim.c 414555 Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build File Attachments Problem uploading as diff https://reviewboard.asterisk.org/media/uploaded/files/2014/05/27/4c7a38c5-c4d6-4bec-8d7f-21f4af7098e4__chan_unistim.diff Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 27, 2014, 8:32 a.m.) Review request for Asterisk Developers and Igor Goncharovsky. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs - /tags/11.9.0/channels/chan_unistim.c 414555 Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- (Updated May 27, 2014, 8:28 a.m.) Review request for Asterisk Developers and Igor Goncharovsky. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs - Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build File Attachments (updated) Problem uploading as diff https://reviewboard.asterisk.org/media/uploaded/files/2014/05/27/4c7a38c5-c4d6-4bec-8d7f-21f4af7098e4__chan_unistim.diff Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3567: [channels/chan_unistim.c]: Possible unlocked mutex
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3567/ --- Review request for Asterisk Developers and Igor Goncharovsky. Bugs: ASTERISK-23792 https://issues.asterisk.org/jira/browse/ASTERISK-23792 Repository: Asterisk Description --- There is a conditional exit from a mutexed area of code which does not unlock before the return. Diffs - Diff: https://reviewboard.asterisk.org/r/3567/diff/ Testing --- Inspection and build Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 28, 2014, 10:32 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Bugs: ASTERISK-23592 https://issues.asterisk.org/jira/browse/ASTERISK-23592 Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs - /trunk/configs/unistim.conf.sample 412191 /trunk/channels/chan_unistim.c 412191 /trunk/CHANGES 412191 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 21, 2014, 7:46 a.m.) Review request for Asterisk Developers. Changes --- Added issue to review Bugs: ASTERISK-23592 https://issues.asterisk.org/jira/browse/ASTERISK-23592 Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs - /trunk/configs/unistim.conf.sample 412191 /trunk/channels/chan_unistim.c 412191 /trunk/CHANGES 412191 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 16, 2014, 11:07 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs (updated) - /trunk/configs/unistim.conf.sample 412191 /trunk/channels/chan_unistim.c 412191 /trunk/CHANGES 412191 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 11, 2014, 10:51 a.m.) Review request for Asterisk Developers. Changes --- Updated following Matt Jordan's comments. Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs (updated) - /trunk/configs/unistim.conf.sample 412191 /trunk/channels/chan_unistim.c 412191 /trunk/CHANGES 412191 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 9, 2014, 3:25 p.m.) Review request for Asterisk Developers. Summary (updated) - [channels/chan_unistim.c]: Improvements and bugfixes to chan_unistim.c Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs - /trunk/configs/unistim.conf.sample 411700 /trunk/channels/chan_unistim.c 411700 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3430: [channels/chan_unistim.c] Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- (Updated April 9, 2014, 3:23 p.m.) Review request for Asterisk Developers. Summary (updated) - [channels/chan_unistim.c] Improvements and bugfixes to chan_unistim.c Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs - /trunk/configs/unistim.conf.sample 411700 /trunk/channels/chan_unistim.c 411700 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3430: Improvements and bugfixes to chan_unistim.c
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/ --- Review request for Asterisk Developers. Repository: Asterisk Description --- I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with 1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display Diffs - /trunk/configs/unistim.conf.sample 411700 /trunk/channels/chan_unistim.c 411700 Diff: https://reviewboard.asterisk.org/r/3430/diff/ Testing --- In use here Thanks, Peter Whisker -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
