Re: [asterisk-dev] dahdi 2.11.1 build fails with kernel 4.11.3

2017-06-01 Thread Shaun Ruffell
On Thu, Jun 01, 2017 at 11:39:51AM -0500, Shaun Ruffell wrote:
> I have been away from DAHDI for awhile now, but I'll post a patch
> to https://issues.asterisk.org for you here in a few minutes.

Two patches posted to DAHLIN-354 [1]. I only compile tested them
against a vanilla 4.11 kernel, so hopefully there aren't other
patches are your distro kernel that conflicts.

[1] https://issues.asterisk.org/jira/browse/DAHLIN-354

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


Re: [asterisk-dev] dahdi 2.11.1 build fails with kernel 4.11.3

2017-06-01 Thread Shaun Ruffell
Sean, 

On Thu, Jun 01, 2017 at 12:07:52PM -0400, sean darcy wrote:
> Building dahdi-2.11.1 using gcc-6.3.1 for kernel-4.11.3:
> 
> ..
> make[1]: Entering directory '/usr/src/kernels/4.11.3-200.fc25.x86_64'
>   CC [M] 
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi-base.o
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi-base.c:
> In function 'dahdi_ioctl_iomux':
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi-base.c:5954:7:
> error: implicit declaration of function 'signal_pending'
> [-Werror=implicit-function-declaration]
>if (signal_pending(current))
> 
> For whatever reason signal_pending has been moved in 4.13.
> dahdi-base.o needs:
> 
> #include 
> 
> But then:
> 
> 
>   CC [M] 
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi_dynamic.o
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi_dynamic.c:
> In function '_destroy_dynamic':
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi_dynamic.c:470:18:
> error: passing argument 1 of 'atomic_read' from incompatible pointer
> type [-Werror=incompatible-pointer-types]
>   if (atomic_read(&d->kref.refcount) > 2) {
>   ^
> In file included from ./arch/x86/include/asm/msr.h:66:0,
>  from ./arch/x86/include/asm/processor.h:20,
>  from ./arch/x86/include/asm/cpufeature.h:4,
>  from ./arch/x86/include/asm/thread_info.h:52,
>  from ./include/linux/thread_info.h:25,
>  from ./arch/x86/include/asm/preempt.h:6,
>  from ./include/linux/preempt.h:80,
>  from ./include/linux/spinlock.h:50,
>  from ./include/linux/seqlock.h:35,
>  from ./include/linux/time.h:5,
>  from ./include/linux/stat.h:18,
>  from ./include/linux/module.h:10,
>  from 
> /home/asterisk/rpmbuild/BUILD/dahdi-linux-2.11.1/drivers/dahdi/dahdi_dynamic.c:27:
> ./arch/x86/include/asm/atomic.h:24:28: note: expected 'const
> atomic_t * {aka const struct  *}' but argument is of type
> 'refcount_t * {aka struct refcount_struct *}'
>  static __always_inline int atomic_read(const atomic_t *v)
> 
> About which I have no clue.

I have been away from DAHDI for awhile now, but I'll post a patch
to https://issues.asterisk.org for you here in a few minutes.

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


Re: [asterisk-dev] [Code Review] 4105: codec_dahdi: Fix segfault on load.

2014-10-22 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4105/
---

(Updated Oct. 22, 2014, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 426097


Bugs: ASTERISK-24435
https://issues.asterisk.org/jira/browse/ASTERISK-24435


Repository: Asterisk


Description
---

This is another version of https://reviewboard.asterisk.org/r/4100/ that 
doesn't change anything in the core of Asterisk.  

The commit message from original git-patch:

codec_dahdi: Cannot use struct ast_translator.core_{src,src}_codec. 
   

   
This fixes a Segmentation fault introduced in r419044 "media formats: 
re-architect
 
handling of media for performance improvements".
   

   
The problem is that codec_dahdi was using using core_src_codec and 
core_dst_codec in the   

ast_translator structure when these fields were never set. Now instead of 
trying to map   
 
the new core codec descriptions to the way DAHDI defines different codecs, 
we will store   
the DAHDI specific formats in 'struct translator' directly so we can refer 
to them without 
mapping.
   

   
This also allows us to remove the "global_format_map" structure, since we 
can now query   
 
the list of translators directly to make sure we do not ever register a 
DAHDI based 
   
translator for a specific path more than once and eliminate the need to 
keep the list and   
   
the map in sync. 


Diffs
-

  branches/13/codecs/codec_dahdi.c 426095 

Diff: https://reviewboard.asterisk.org/r/4105/diff/


Testing
---

Called between two phones with g729 on one side and g722 on the other and made 
sure transcoder show indicated the transcoder was in use and I could hear 
myself.


Thanks,

Shaun Ruffell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4105: codec_dahdi: Fix segfault on load.

2014-10-22 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4105/
---

(Updated Oct. 22, 2014, 7:13 p.m.)


Review request for Asterisk Developers.


Changes
---

Added commit message to Description.


Bugs: ASTERISK-24435
https://issues.asterisk.org/jira/browse/ASTERISK-24435


Repository: Asterisk


Description (updated)
---

This is another version of https://reviewboard.asterisk.org/r/4100/ that 
doesn't change anything in the core of Asterisk.  

The commit message from original git-patch:

codec_dahdi: Cannot use struct ast_translator.core_{src,src}_codec. 
   

   
This fixes a Segmentation fault introduced in r419044 "media formats: 
re-architect
 
handling of media for performance improvements".
   

   
The problem is that codec_dahdi was using using core_src_codec and 
core_dst_codec in the   

ast_translator structure when these fields were never set. Now instead of 
trying to map   
 
the new core codec descriptions to the way DAHDI defines different codecs, 
we will store   
the DAHDI specific formats in 'struct translator' directly so we can refer 
to them without 
mapping.
   

   
This also allows us to remove the "global_format_map" structure, since we 
can now query   
 
the list of translators directly to make sure we do not ever register a 
DAHDI based 
   
translator for a specific path more than once and eliminate the need to 
keep the list and   
   
the map in sync. 


Diffs
-

  branches/13/codecs/codec_dahdi.c 426095 

Diff: https://reviewboard.asterisk.org/r/4105/diff/


Testing
---

Called between two phones with g729 on one side and g722 on the other and made 
sure transcoder show indicated the transcoder was in use and I could hear 
myself.


Thanks,

Shaun Ruffell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4105: codec_dahdi: Fix segfault on load.

2014-10-22 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4105/#review13586
---


This patch contains formatting changes suggested by rmudgett already.

- Shaun Ruffell


On Oct. 22, 2014, 6:17 p.m., Shaun Ruffell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4105/
> ---
> 
> (Updated Oct. 22, 2014, 6:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24435
> https://issues.asterisk.org/jira/browse/ASTERISK-24435
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This is another version of https://reviewboard.asterisk.org/r/4100/ that 
> doesn't change anything in the core of Asterisk.  
> 
> 
> Diffs
> -
> 
>   branches/13/codecs/codec_dahdi.c 426095 
> 
> Diff: https://reviewboard.asterisk.org/r/4105/diff/
> 
> 
> Testing
> ---
> 
> Called between two phones with g729 on one side and g722 on the other and 
> made sure transcoder show indicated the transcoder was in use and I could 
> hear myself.
> 
> 
> Thanks,
> 
> Shaun Ruffell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4105: codec_dahdi: Fix segfault on load.

2014-10-22 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4105/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-24435
https://issues.asterisk.org/jira/browse/ASTERISK-24435


Repository: Asterisk


Description
---

This is another version of https://reviewboard.asterisk.org/r/4100/ that 
doesn't change anything in the core of Asterisk.  


Diffs
-

  branches/13/codecs/codec_dahdi.c 426095 

Diff: https://reviewboard.asterisk.org/r/4105/diff/


Testing
---

Called between two phones with g729 on one side and g722 on the other and made 
sure transcoder show indicated the transcoder was in use and I could hear 
myself.


Thanks,

Shaun Ruffell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4100: codec_dahdi: Fix crash on load of codec_dahdi.

2014-10-22 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4100/#review13585
---


I'm not sure this should go in as it is. I think it is better to remove the 
dependency on core_src_codec and core_dst_codec in codec_dahdi. I have another 
patch I've worked up, just finding the best place to post it.


- Shaun Ruffell


On Oct. 21, 2014, 4:11 p.m., rmudgett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4100/
> ---
> 
> (Updated Oct. 21, 2014, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24435
> https://issues.asterisk.org/jira/browse/ASTERISK-24435
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Codec_dahdi is the only translator that uses the struct 
> ast_translator->core_src_codec and struct ast_translator->core_dst_codec 
> pointers.  Unfortunately, nothing ever initialized the pointers.
> 
> 
> Diffs
> -
> 
>   /branches/13/main/translate.c 426078 
>   /branches/13/include/asterisk/translate.h 426078 
>   /branches/13/codecs/codec_dahdi.c 426078 
> 
> Diff: https://reviewboard.asterisk.org/r/4100/diff/
> 
> 
> Testing
> ---
> 
> Made some calls that perform translation.  No crashes happened.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Git Migration

2014-09-17 Thread Shaun Ruffell
On Tue, Sep 16, 2014 at 09:02:24PM -0500, Matthew Jordan wrote:
> On Tue, Sep 16, 2014 at 4:31 PM, George Joseph 
> wrote:
> 
> > On Tue, Sep 16, 2014 at 1:48 PM, Matthew Jordan 
> > wrote:
> >
> >> "And there was much rejoicing"
> >>
> >> To summarize:
> >>  * A comparison of management platforms has been done. Barring a giant
> >> catastrophe or some insane limitation, we're going to go simple here and
> >> stick with gitolite. Reasoning is on the wiki page.
> >>
> >
> > The only thing I'd suggest is to use CGit instead of gitweb for the web
> > interface.   It's got richer capabilities and works great with gitolite.
> > Once it's initially configured you don't ever have to touch it.
> >
> >
> 
> CGit does look a lot better. Wiki page updated!

Adding my +1 for cgit.

http://git.kernel.org switched to it awhile ago and it's right up
there on my list of easy-to-read C source too. That's got to count
for something. :)

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Shaun Ruffell


> On Sept. 4, 2014, 10:49 a.m., Tzafrir Cohen wrote:
> > Short version: not needed, IMO.
> > 
> > The path was hard-coded in the first place because the DAHDI udev hooks 
> > directory is explicitly hard-coded. Placing it elsewhere does nothing. If 
> > the prefix is anything other than '/usr'. this hook script is thus simply 
> > not copied.
> > 
> > See also Oron Peled's comment on the list: 
> > http://lists.digium.com/pipermail/asterisk-dev/2014-September/070114.html

+1


- Shaun


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3972/#review13229
---


On Sept. 3, 2014, 1:57 p.m., David Lee wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3972/
> ---
> 
> (Updated Sept. 3, 2014, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> I'm a bit wierd, and I configure asterisk with --prefix=/opt/asterisk,
> so that I can install it without running as root. The install script
> for the DAHDI hook scripts were hard coded to install into /usr/share,
> which foils my weirdness.
> 
> This patch changes the install location for the DAHDI hook scripts to
> honor --prefix. It also moves the variable in the Makefile so that it
> doesn't get between the _MAKEOPTS variables and the comment describing
> them.
> 
> 
> Diffs
> -
> 
>   /branches/13/Makefile 422556 
> 
> Diff: https://reviewboard.asterisk.org/r/3972/diff/
> 
> 
> Testing
> ---
> 
> Ran ./configure && make all install to verify that the hook script
> installed into /usr/share/dahdi/span_config.d.
> 
> Ran ./configure --prefix=/opt/asterisk && make all install to verify
> that the hook script installed into
> /opt/Asterisk/share/dahdi/span_config.d
> 
> 
> Thanks,
> 
> David Lee
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3773: Add menuselect to Asterisk, remove mxml

2014-07-14 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3773/#review12637
---


a) awesome.  b) If at all possible I believe moving the code and modifying it 
should be two separate steps. This will make it easier, when generating an 
"official" git repo, to graft the menuselect history onto the git repository, 
in addition to highlighting the changes from what is currently sitting in 
menuselect/mxml.

- Shaun Ruffell


On July 14, 2014, 9:21 p.m., Matt Jordan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3773/
> ---
> 
> (Updated July 14, 2014, 9:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20703
> https://issues.asterisk.org/jira/browse/ASTERISK-20703
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This patch removes menuselect as a subversion external repo and adds it 
> directly to the Asterisk source. This makes Asterisk substantially more git 
> friendly.
> 
> Asterisk is (I think) the only thing that uses menuselect still, as such, 
> keeping menuselect in a separate repository isn't strictly necessary any 
> longer. This patch also goes ahead and makes mxml a required library, 
> removing the need for the mxml repo.
> 
> Changes to menuselect were kept at a minimum - however, I opted to copy and 
> add the source files directly rather than attempting any particular svn 
> operation. That does mean we would lose the menuselect history for trunk (13) 
> onwards. I'm not sure how big of a loss that is, given the relative 
> infrequency with which changes are made (and the menuselect history isn't 
> gone, just disconnected...)
> 
> The only functional change with this patch: the menuselect UI is no longer 
> run automatically the first time around. I'm not sure how needed (or desired) 
> that is, since make menuselect is always available to configure settings.
> 
> Note that menuselect/mxml will continue to exist as separate repos for 
> existing Asterisk branches. We can always choose to backport this patch at 
> some future time to other branches, if the need arises.
> 
> 
> Diffs
> -
> 
>   /trunk/menuselect/test/menuselect-tree PRE-CREATION 
>   /trunk/menuselect/test/build_tools/menuselect-deps PRE-CREATION 
>   /trunk/menuselect/strcompat.c PRE-CREATION 
>   /trunk/menuselect/missing PRE-CREATION 
>   /trunk/menuselect/menuselect_stub.c PRE-CREATION 
>   /trunk/menuselect/menuselect_newt.c PRE-CREATION 
>   /trunk/menuselect/menuselect_gtk.c PRE-CREATION 
>   /trunk/menuselect/menuselect_curses.c PRE-CREATION 
>   /trunk/menuselect/menuselect.c PRE-CREATION 
>   /trunk/menuselect/menuselect.h PRE-CREATION 
>   /trunk/menuselect/makeopts.in PRE-CREATION 
>   /trunk/menuselect/makeopts PRE-CREATION 
>   /trunk/menuselect/make_version PRE-CREATION 
>   /trunk/menuselect/linkedlists.h PRE-CREATION 
>   /trunk/menuselect/install-sh PRE-CREATION 
>   /trunk/menuselect/example_menuselect-tree PRE-CREATION 
>   /trunk/menuselect/contrib/menuselect-dummy PRE-CREATION 
>   /trunk/menuselect/contrib/Makefile-dummy PRE-CREATION 
>   /trunk/menuselect/configure.ac PRE-CREATION 
>   /trunk/menuselect/configure PRE-CREATION 
>   /trunk/menuselect/config.sub PRE-CREATION 
>   /trunk/menuselect/config.log PRE-CREATION 
>   /trunk/menuselect/config.guess PRE-CREATION 
>   /trunk/menuselect/bootstrap.sh PRE-CREATION 
>   /trunk/menuselect/autoconfig.h.in PRE-CREATION 
>   /trunk/menuselect/autoconfig.h PRE-CREATION 
>   /trunk/menuselect/aclocal.m4 PRE-CREATION 
>   /trunk/menuselect/acinclude.m4 PRE-CREATION 
>   /trunk/menuselect/README PRE-CREATION 
>   /trunk/menuselect/Makefile PRE-CREATION 
>   /trunk/include/asterisk/autoconfig.h.in 418565 
>   /trunk/configure.ac 418565 
>   /trunk/configure UNKNOWN 
> 
> Diff: https://reviewboard.asterisk.org/r/3773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Has digits.h been removed from dahdi?

2014-07-03 Thread Shaun Ruffell
On Thu, Jul 03, 2014 at 03:47:14PM +0800, toaster...@gmail.com wrote:
> Hello:
> after dahdi-2.4, the digits.h looks not under the driver/dahdi package. Does 
> the file remove to
> some files or merge to some file? I need to modify the code in digits.h. Does 
> Anyone know these values
> defined in dahdi-2.6 or above version? 
> -
> #define DEFAULT_DTMF_LENGTH 100 * DAHDI_DEFAULT_CHUNKSIZE
> #define DEFAULT_MFR1_LENGTH 68 * DAHDI_DEFAULT_CHUNKSIZE
> #define DEFAULT_MFR2_LENGTH 100 * DAHDI_DEFAULT_CHUNKSIZE
> #define PAUSE_LENGTH 500 * DAHDI_DEFAULT_CHUNKSIZE
> ---
> thanks!
> 
> 
> Cheers!

Hi, these are defined in include/dahdi/dahdi_config.h now.  They are
now expressed in milliseconds and not multiples of the default chunk
size.

http://git.asterisk.org/gitweb/?p=dahdi/linux.git;a=commit;h=a45f8533955

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


Re: [asterisk-dev] [Code Review] 3157: dahdi_span_config_hook: script to automatically register new dahdi channels

2014-07-02 Thread Shaun Ruffell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3157/#review12434
---

Ship it!


Ship It!

- Shaun Ruffell


On Jan. 26, 2014, 3:14 p.m., Tzafrir Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3157/
> ---
> 
> (Updated Jan. 26, 2014, 3:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Recent versions of DAHDI allow making the initialization of DAHDI devices 
> more asynchronous[1]. This should allow, among other things, starting 
> Asterisk independently of DAHDI. If DAHDI starts after Asterisk, Asterisk 
> needs to be notified of new DAHDI channels. If those channels are already 
> configured in chan_dahdi.conf, this can be done by running "asterisk -rx 
> 'dahdi create channels  '".
> 
> (For more information, see [2])
> 
> As of DAHDI 2.8.0, DAHDI has udev hook hooks that eventually run this command 
> after the span was configured. DAHDI 2.9.0 makes that script modular: it runs 
> all the scripts in the directory /usr/share/dahdi/span_config.d in order. 
> DAHDI currently installs /usr/share/dahdi/span_config.d/50-asterisk that runs 
> that command, but this is really not the job of DAHDI: DAHDI can't really 
> tell that Asterisk is installed on the system. If Asterisk wants to get the 
> new spans, Asterisk should install this hook script.
> 
> Note that it should be harmless to install this even if DAHDI isn't installed 
> on the system: you just added a useless script file. Though installing it 
> probably does not make sense if you don't have DAHDI installed. If you have 
> DAHDI installed and caling this script but don't have chan_dahdi.so or don't 
> have those channels configured in chan_dahdi.conf than this will run but only 
> cause some extra error messages. So it takes quite some bad luck to get it to 
> cause damage. which is why I think it is safe to install it by default. In 
> this patch I opted for simplicity and just installed it anyway to the same 
> path. Let me know if you have any better ideas.
> 
> [1] This is still not the default in 2.9.0, but should eventually become the 
> default in a future version. The code is all there.
> [2] http://lists.digium.com/pipermail/asterisk-dev/2014-January/064713.html
> 
> 
> Diffs
> -
> 
>   /trunk/contrib/scripts/dahdi_span_config_hook PRE-CREATION 
>   /trunk/Makefile 406502 
> 
> Diff: https://reviewboard.asterisk.org/r/3157/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] magic number 128- for concurrent meetme monitoring calls.

2014-03-14 Thread Shaun Ruffell
On Fri, Mar 14, 2014 at 02:40:22PM +0100, Olle E. Johansson wrote:
> 
> On 14 Mar 2014, at 14:13, Paul Belanger  wrote:
> 
> > On Fri, Mar 14, 2014 at 3:02 AM, Olle E. Johansson  wrote:
> >> 
> >> Don't forget that if you are using DAHDI there are dahdi file
> >> handles that will expire at some point and give you strange
> >> problems. We had a discussion about that a year or two ago on
> >> the list.
> >> 
> > Interesting, I missed that discussion, can you sum it up to a
> > few lines while I look for the thread?
> 
> Did not find it either. We had big issues when running hundreds of meetme's.
> Someone on the Dahdi teem confirmed and had no solution, so we had to move
> to app_konference, which is not a fun place either.

I think this is the thread:

http://thread.gmane.org/gmane.comp.telephony.pbx.asterisk.devel/51750

But basically, there is still a fixed number of conferences DAHDI
can support since that is still stored as an array in the code and
not a dynamic list.  The current limit is 1024 [1].

[1] 
https://github.com/asterisk/dahdi-linux/blob/master/include/dahdi/user.h#L294

FYI, that DAHDI_MAX_SPANS and DAHDI_MAX_CHANNELS in
include/dahdi/user.h are only for legacy userspace. As far as the
kernel is concerned, there is no longer a fixed upper bound on the
number of spans or channels. This work for channels was done as part
of the dahdi channel hotplug work.

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev