Re: [asterisk-dev] [Code Review] 3858: Tests for verifying StopMixMonitor/MuteMixMonitor AMI action
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3858/ --- (Updated Aug. 29, 2014, 2:24 p.m.) Status -- This change has been discarded. Review request for Asterisk Developers. Bugs: ASTERISK-24028 https://issues.asterisk.org/jira/browse/ASTERISK-24028 Repository: testsuite Description --- This is a directory of two tests that verify the StopMixMonitor and MuteMixMonitor actions. The StopMixMonitor Test creates a Local channel that starts a playback of tt-monkeys. When the playback begins, MixMonitor is triggered to begin recording through a headermatch. The same headermatch is used to trigger the StopMixMonitor, but the action is delayed for 4 seconds before sending the stop message to ensure that the file actually began recording to begin with and therefore StopMixMonitor actually had something to stop. When the playback is finished and the channel playing the audio hangs up, the hangup event is used to trigger the SoundChecker pluggable module to check and ensure the file has the correct size and energy. The MuteMixMonitor Test also creates a Local channel that starts a playback of tt-monkyes. When the event for answering of the channel to play tt-monkeys occurs, a headermatch triggers both a message for MixMonitor and MuteMixMonitor to occur. This will mute the audio stream but continue the recording. When the Local channel is hung up, then a headermatch will trigger the SoundChecker pluggable module to check the file and ensure that the file has the correct size but does not have energy. This will show that the mute feature worked properly. The SoundChecker module is included in the diff file because it has not been committed yet and I want to clarify how the pluggable module interacts with the test. Diffs - /asterisk/trunk/tests/apps/mixmonitor_interrupt/tests.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/stop_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/mix_mute.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 Diff: https://reviewboard.asterisk.org/r/3858/diff/ Testing --- Both tests show the correct AMI messages being sent and the actions registering. I also manually went to check where the sound files would be and each file contained the correct amount of sound and energy as specified in the Test. There may be a better way to shorten the recording for the MuteMixMonitor test rather than use StopMixMonitor, but I needed the test to complete before 30 seconds so that I would not get a reactor timeout. The recording is still 10 seconds long, which I figured would be ample time to ensure that MuteMixMonitor had properly muted the recording. The test finishes in 28 seconds. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated Aug. 14, 2014, 3:08 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 5441 Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs - /asterisk/trunk/tests/apps/tests.yaml 5315 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3693: A test of the Authenticate application to ensure that it fails properly.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3693/
---
(Updated Aug. 14, 2014, 4:12 p.m.)
Status
--
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
---
Committed in revision 5449
Bugs: Asterisk-23953
https://issues.asterisk.org/jira/browse/Asterisk-23953
Repository: testsuite
Description
---
This test uses the dialplan to enter the Authenticate application, which has
been given a hard coded password, and sends the wrong dtmf password three
times. The Authenticate application should respond twice with the sound file
auth-incorrect, and then after a third incorrect try, play vm-goodbye and
end the session. This test checks, using a header match, to ensure that
auth-incorrect is played twice, followed by vm-goodbye. To make the test
give off an event for the playing of vm-goodbye, the line of code that was in
charge of raising the event in app.c had to be moved to file.c. I will post the
diff in this description for clarification. The AppTest module also had to be
modified to allow for an action to be executed each time that the event is
matched instead of just executing once, regardless of the number of times the
header match was told to match the event.
app.c and file.c diff file:
Index: app.c
===
--- app.c (revision 415357)
+++ app.c (working copy)
@@ -256,7 +256,6 @@
filename = ast_strdupa(prompt);
while ((front = strsep(filename, ))) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, front, ast_channel_name(c));
if (!ast_strlen_zero(front)) {
res = ast_streamfile(c, front, ast_channel_language(c));
if (res)
Index: file.c
===
--- file.c (revision 415357)
+++ file.c (working copy)
@@ -1105,6 +1105,7 @@
return -1;
if (vfs ast_applystream(chan, vfs))
return -1;
+ ast_test_suite_event_notify(PLAYBACK, Message: %s\r\nChannel: %s,
filename, ast_channel_name(chan));
res = ast_playstream(fs);
if (!res vfs)
res = ast_playstream(vfs);
@@ -1611,7 +1612,6 @@
{
int res = 0;
if (!ast_strlen_zero(file)) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, file, ast_channel_name(chan));
res = ast_streamfile(chan, file, ast_channel_language(chan));
if (!res) {
res = ast_waitstream(chan, digits);
Diffs
-
/asterisk/trunk/tests/apps/tests.yaml 5202
/asterisk/trunk/tests/apps/authenticate/tests.yaml PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/apptest.py 5202
Diff: https://reviewboard.asterisk.org/r/3693/diff/
Testing
---
The test passes, and the logs show a call is made, the incorrect DTMF password
is sent three times, the correct sound files are played as according to the
header matches, and the session terminates upon hearing vm-goodbye.
Thanks,
Tyler Austin Cambron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 25, 2014, 2:50 p.m.) Review request for Asterisk Developers. Changes --- Updated test-config to work with updated pluggable module. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs (updated) - /asterisk/trunk/tests/apps/tests.yaml 5315 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 25, 2014, 2:51 p.m.) Review request for Asterisk Developers. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs - /asterisk/trunk/tests/apps/tests.yaml 5315 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3858: Tests for verifying StopMixMonitor/MuteMixMonitor AMI action
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3858/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24028 https://issues.asterisk.org/jira/browse/ASTERISK-24028 Repository: testsuite Description --- This is a directory of two tests that verify the StopMixMonitor and MuteMixMonitor actions. The StopMixMonitor Test creates a Local channel that starts a playback of tt-monkeys. When the playback begins, MixMonitor is triggered to begin recording through a headermatch. The same headermatch is used to trigger the StopMixMonitor, but the action is delayed for 4 seconds before sending the stop message to ensure that the file actually began recording to begin with and therefore StopMixMonitor actually had something to stop. When the playback is finished and the channel playing the audio hangs up, the hangup event is used to trigger the SoundChecker pluggable module to check and ensure the file has the correct size and energy. The MuteMixMonitor Test also creates a Local channel that starts a playback of tt-monkyes. When the event for answering of the channel to play tt-monkeys occurs, a headermatch triggers both a message for MixMonitor and MuteMixMonitor to occur. This will mute the audio stream but continue the recording. When the Local channel is hung up, then a headermatch will trigger the SoundChecker pluggable module to check the file and ensure that the file has the correct size but does not have energy. This will show that the mute feature worked properly. The SoundChecker module is included in the diff file because it has not been committed yet and I want to clarify how the pluggable module interacts with the test. Diffs - /asterisk/trunk/tests/apps/mixmonitor_interrupt/tests.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/stop_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_stop/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/mix_mute.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_interrupt/mixmonitor_mute/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 Diff: https://reviewboard.asterisk.org/r/3858/diff/ Testing --- Both tests show the correct AMI messages being sent and the actions registering. I also manually went to check where the sound files would be and each file contained the correct amount of sound and energy as specified in the Test. There may be a better way to shorten the recording for the MuteMixMonitor test rather than use StopMixMonitor, but I needed the test to complete before 30 seconds so that I would not get a reactor timeout. The recording is still 10 seconds long, which I figured would be ample time to ensure that MuteMixMonitor had properly muted the recording. The test finishes in 28 seconds. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 24, 2014, 9:46 a.m.) Review request for Asterisk Developers. Changes --- Added a pre-amble and a pydoc comment for my python method, updated my description in the test-config, removed an unnecessary headermatch, and added the app dependency for mixmonitor. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs (updated) - /asterisk/trunk/tests/apps/tests.yaml 5305 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5305 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 22, 2014, 3:01 p.m.) Review request for Asterisk Developers. Changes --- Corrected test to use the MixMonitor AMI command rather than call MixMonitor through the dialplan by adding a small bit of python code. The test-config.yaml has been updated to work with updates to the SoundChecker pluggable module. Also updated the size to check for in the test-config to be slightly more accurate. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs (updated) - /asterisk/trunk/tests/apps/tests.yaml 5297 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 22, 2014, 3:02 p.m.) Review request for Asterisk Developers. Changes --- Updated the Depends On section to refer to the pluggable module that is currently in review. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs - /asterisk/trunk/tests/apps/tests.yaml 5297 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- Review request for Asterisk Developers. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs - /asterisk/trunk/tests/apps/tests.yaml 5242 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5242 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/ --- (Updated July 15, 2014, 1:27 p.m.) Review request for Asterisk Developers. Changes --- Updated minversion. Bugs: Asterisk-24028 https://issues.asterisk.org/jira/browse/Asterisk-24028 Repository: testsuite Description --- This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe. Diffs (updated) - /asterisk/trunk/tests/apps/tests.yaml 5242 /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5242 Diff: https://reviewboard.asterisk.org/r/3795/diff/ Testing --- The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys. Thanks, Tyler Austin Cambron -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3693: A test of the Authenticate application to ensure that it fails properly.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3693/
---
(Updated July 2, 2014, 9:50 a.m.)
Review request for Asterisk Developers.
Changes
---
Corrected the title for the 'Bugs' section.
Added a hangup after Authenticate in the dialplan.
Corrected min-version.
Corrected app requirements.
Bugs: Asterisk-23953
https://issues.asterisk.org/jira/browse/Asterisk-23953
Repository: testsuite
Description
---
This test uses the dialplan to enter the Authenticate application, which has
been given a hard coded password, and sends the wrong dtmf password three
times. The Authenticate application should respond twice with the sound file
auth-incorrect, and then after a third incorrect try, play vm-goodbye and
end the session. This test checks, using a header match, to ensure that
auth-incorrect is played twice, followed by vm-goodbye. To make the test
give off an event for the playing of vm-goodbye, the line of code that was in
charge of raising the event in app.c had to be moved to file.c. I will post the
diff in this description for clarification. The AppTest module also had to be
modified to allow for an action to be executed each time that the event is
matched instead of just executing once, regardless of the number of times the
header match was told to match the event.
app.c and file.c diff file:
Index: app.c
===
--- app.c (revision 415357)
+++ app.c (working copy)
@@ -256,7 +256,6 @@
filename = ast_strdupa(prompt);
while ((front = strsep(filename, ))) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, front, ast_channel_name(c));
if (!ast_strlen_zero(front)) {
res = ast_streamfile(c, front, ast_channel_language(c));
if (res)
Index: file.c
===
--- file.c (revision 415357)
+++ file.c (working copy)
@@ -1105,6 +1105,7 @@
return -1;
if (vfs ast_applystream(chan, vfs))
return -1;
+ ast_test_suite_event_notify(PLAYBACK, Message: %s\r\nChannel: %s,
filename, ast_channel_name(chan));
res = ast_playstream(fs);
if (!res vfs)
res = ast_playstream(vfs);
@@ -1611,7 +1612,6 @@
{
int res = 0;
if (!ast_strlen_zero(file)) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, file, ast_channel_name(chan));
res = ast_streamfile(chan, file, ast_channel_language(chan));
if (!res) {
res = ast_waitstream(chan, digits);
Diffs (updated)
-
/asterisk/trunk/tests/apps/tests.yaml 5202
/asterisk/trunk/tests/apps/authenticate/tests.yaml PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/apptest.py 5202
Diff: https://reviewboard.asterisk.org/r/3693/diff/
Testing
---
The test passes, and the logs show a call is made, the incorrect DTMF password
is sent three times, the correct sound files are played as according to the
header matches, and the session terminates upon hearing vm-goodbye.
Thanks,
Tyler Austin Cambron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3693: A test of the Authenticate application to ensure that it fails properly.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3693/
---
Review request for Asterisk Developers.
Bugs: SWP-7080
https://issues.asterisk.org/jira/browse/SWP-7080
Repository: testsuite
Description
---
This test uses the dialplan to enter the Authenticate application, which has
been given a hard coded password, and sends the wrong dtmf password three
times. The Authenticate application should respond twice with the sound file
auth-incorrect, and then after a third incorrect try, play vm-goodbye and
end the session. This test checks, using a header match, to ensure that
auth-incorrect is played twice, followed by vm-goodbye. To make the test
give off an event for the playing of vm-goodbye, the line of code that was in
charge of raising the event in app.c had to be moved to file.c. I will post the
diff in this description for clarification. The AppTest module also had to be
modified to allow for an action to be executed each time that the event is
matched instead of just executing once, regardless of the number of times the
header match was told to match the event.
app.c and file.c diff file:
Index: app.c
===
--- app.c (revision 415357)
+++ app.c (working copy)
@@ -256,7 +256,6 @@
filename = ast_strdupa(prompt);
while ((front = strsep(filename, ))) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, front, ast_channel_name(c));
if (!ast_strlen_zero(front)) {
res = ast_streamfile(c, front, ast_channel_language(c));
if (res)
Index: file.c
===
--- file.c (revision 415357)
+++ file.c (working copy)
@@ -1105,6 +1105,7 @@
return -1;
if (vfs ast_applystream(chan, vfs))
return -1;
+ ast_test_suite_event_notify(PLAYBACK, Message: %s\r\nChannel: %s,
filename, ast_channel_name(chan));
res = ast_playstream(fs);
if (!res vfs)
res = ast_playstream(vfs);
@@ -1611,7 +1612,6 @@
{
int res = 0;
if (!ast_strlen_zero(file)) {
- ast_test_suite_event_notify(PLAYBACK, Message:
%s\r\nChannel: %s, file, ast_channel_name(chan));
res = ast_streamfile(chan, file, ast_channel_language(chan));
if (!res) {
res = ast_waitstream(chan, digits);
Diffs
-
/asterisk/trunk/tests/apps/tests.yaml 5202
/asterisk/trunk/tests/apps/authenticate/tests.yaml PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/apps/authenticate/off_nominal/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/apptest.py 5202
Diff: https://reviewboard.asterisk.org/r/3693/diff/
Testing
---
The test passes, and the logs show a call is made, the incorrect DTMF password
is sent three times, the correct sound files are played as according to the
header matches, and the session terminates upon hearing vm-goodbye.
Thanks,
Tyler Austin Cambron
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
