Re: [asterisk-dev] [Code Review] 3062: a systemd service
On Jan. 1, 2014, 4:43 p.m., George Joseph wrote: /trunk/contrib/asterisk.service, line 20 https://reviewboard.asterisk.org/r/3062/diff/2/?file=49947#file49947line20 I use the following which mimic some of the safe_asterisk settings... Nice=0 UMask=0002 LimitCORE=infinity LimitNOFILE=4096 Restart=always RestartSec=4 I don't think that these are appropriate for the default service file. If you look at the Fedora service file, they are included as comments and can be enabled as needed by the administrator. - jcollie --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/#review10503 --- On Dec. 24, 2013, 4:49 p.m., Tzafrir Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/ --- (Updated Dec. 24, 2013, 4:49 p.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- Installs a systemd service file for Asterisk. Systeemd is the new one daemon to rule them all for Linux: http://www.freedesktop.org/wiki/Software/systemd/ On systems without systemd this should be just a harmless (though maybe annoying) text file. This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command. Diffs - /trunk/contrib/asterisk.service PRE-CREATION /trunk/Makefile 404563 Diff: https://reviewboard.asterisk.org/r/3062/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3062: a systemd service
On Jan. 2, 2014, 2:42 p.m., Russell Bryant wrote: I'm not sure this belongs in Asterisk itself, personally. In any case, Fedora has had a systemd unit for Asterisk for quite some time. For reference, you can view it here: http://pkgs.fedoraproject.org/cgit/asterisk.git/tree/asterisk.service Actually, having the service file upstream makes a lot of sense so that all the distributions that use systemd can benefit, as long as we don't end up with a separate service file for each distribution in the upstream sources. - jcollie --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/#review10506 --- On Dec. 24, 2013, 4:49 p.m., Tzafrir Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/ --- (Updated Dec. 24, 2013, 4:49 p.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- Installs a systemd service file for Asterisk. Systeemd is the new one daemon to rule them all for Linux: http://www.freedesktop.org/wiki/Software/systemd/ On systems without systemd this should be just a harmless (though maybe annoying) text file. This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command. Diffs - /trunk/contrib/asterisk.service PRE-CREATION /trunk/Makefile 404563 Diff: https://reviewboard.asterisk.org/r/3062/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev