Re: [Asterisk-Dev] Voicemail to email volume change patch
Because the volume of the recording is great when listening on the phone, if we increase the gain on the original message, it blasts the phone but sounds ok on the computer. We need to modify the volume only on the outgoing mail and not the original message. Aaron Steven Critchfield wrote: On Fri, 2006-01-13 at 11:45 -0600, Aaron Daniel wrote: Well, I think we're calling it normalize cause that name sorta stuck. We are in fact just changing the volume of it, and using sox, cause as you say, it supports more formats. Normalize just didn't do what we wanted it to, and didn't support the format we were using, so sox seemed like a much better idea for the time being. Since you are just changing the volume level, is there a reason you aren't using the record_gain option that I see in the code I just checked out from trunk? It would save you from spawning a process out of asterisk for the recorded files. ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] Voicemail to email volume change patch
On Fri, 2006-01-13 at 11:45 -0600, Aaron Daniel wrote: > Well, I think we're calling it normalize cause that name sorta stuck. > We are in fact just changing the volume of it, and using sox, cause as > you say, it supports more formats. Normalize just didn't do what we > wanted it to, and didn't support the format we were using, so sox seemed > like a much better idea for the time being. Since you are just changing the volume level, is there a reason you aren't using the record_gain option that I see in the code I just checked out from trunk? It would save you from spawning a process out of asterisk for the recorded files. -- Steven Critchfield <[EMAIL PROTECTED]> ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] Voicemail to email volume change patch
Well, I think we're calling it normalize cause that name sorta stuck. We are in fact just changing the volume of it, and using sox, cause as you say, it supports more formats. Normalize just didn't do what we wanted it to, and didn't support the format we were using, so sox seemed like a much better idea for the time being. Aaron Steven Critchfield wrote: On Fri, 2006-01-13 at 11:15 -0600, Aaron Daniel wrote: My boss and I have been working on a patch to the voicemail code, and I'd like to see what everyone thinks of it. I'd like suggestions and stuff on anything that needs to be changed, as this is the first time we've patched the code, and would like to submit it for use later on in the code. It basically sends the voicemail attachment through sox to increase (or decrease) the volume of the message as need be, and then sends the normalized file to the user. You aren't normalizing the audio, you are just adjusting the volume. If you are going to go to the work of using an external app, why not use normalize so it truly is normalized and doesn't introduce problems when audio comes from different sources and therefore needs different audio adjustments. Now the trouble with normalize is that it doesn't support very many formats. I think it supports PCM wav and mp3 only. At least sox does have better format support. ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] Voicemail to email volume change patch
On Fri, 2006-01-13 at 11:15 -0600, Aaron Daniel wrote: > My boss and I have been working on a patch to the voicemail code, and > I'd like to see what everyone thinks of it. I'd like suggestions and > stuff on anything that needs to be changed, as this is the first time > we've patched the code, and would like to submit it for use later on in > the code. > > It basically sends the voicemail attachment through sox to increase (or > decrease) the volume of the message as need be, and then sends the > normalized file to the user. You aren't normalizing the audio, you are just adjusting the volume. If you are going to go to the work of using an external app, why not use normalize so it truly is normalized and doesn't introduce problems when audio comes from different sources and therefore needs different audio adjustments. Now the trouble with normalize is that it doesn't support very many formats. I think it supports PCM wav and mp3 only. At least sox does have better format support. -- Steven Critchfield <[EMAIL PROTECTED]> ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [Asterisk-Dev] Voicemail to email volume change patch
On Fri, 2006-01-13 at 11:15 -0600, Aaron Daniel wrote: > My boss and I have been working on a patch to the voicemail code, and > I'd like to see what everyone thinks of it. I'd like suggestions and > stuff on anything that needs to be changed, as this is the first time > we've patched the code, and would like to submit it for use later on in > the code. Thanks for helping out! Please post your patch to the bug tracker at http://bugs.digium.com/, and make sure you have a signed disclaimer on file. This way, it will be reviewed by the bug marshals, and we can keep track of it. (If you'd like to post the bug number back here, then it'll probably get a little more attention.) -Jared ___ --Bandwidth and Colocation provided by Easynews.com -- Asterisk-Dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
