Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-30 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

(Updated Jan. 30, 2014, 2:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4541 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-29 Thread Matt Jordan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/#review10714
---

Ship it!


Ship It!

- Matt Jordan


On Jan. 21, 2014, 11:21 a.m., opticron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3051/
> ---
> 
> (Updated Jan. 21, 2014, 11:21 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21084
> https://issues.asterisk.org/jira/browse/ASTERISK-21084
> 
> 
> Repository: testsuite
> 
> 
> Description
> ---
> 
> This adds a test which covers path support for outbound registrations, 
> inbound registrations, and outbound requests following an inbound 
> registration.
> 
> 
> Diffs
> -
> 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
> 4541 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
>  PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3051/diff/
> 
> 
> Testing
> ---
> 
> Ensured the tests behaved as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-21 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

(Updated Jan. 21, 2014, 11:21 a.m.)


Review request for Asterisk Developers.


Changes
---

Update the test for Walter's comments.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs (updated)
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4541 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-21 Thread opticron 


> On Jan. 17, 2014, 8:44 a.m., wdoekes wrote:
> > asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml,
> >  lines 92-93
> > 
> >
> > I think you can do:
> > 
> > From: [last_To]
> > To: [last_From]
> > 
> > But don't take my word for it.

This does not work properly which is why it is often worked around in the 
manner used here. chan_pjsip is unable to identify the call and responds with a 
481 to that effect.


- opticron


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/#review10619
---


On Jan. 6, 2014, 3:53 p.m., opticron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3051/
> ---
> 
> (Updated Jan. 6, 2014, 3:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21084
> https://issues.asterisk.org/jira/browse/ASTERISK-21084
> 
> 
> Repository: testsuite
> 
> 
> Description
> ---
> 
> This adds a test which covers path support for outbound registrations, 
> inbound registrations, and outbound requests following an inbound 
> registration.
> 
> 
> Diffs
> -
> 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
> 4485 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
>  PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3051/diff/
> 
> 
> Testing
> ---
> 
> Ensured the tests behaved as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-17 Thread wdoekes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/#review10619
---


Without going into the functionality of the patch, a few notes:


asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml


You're referencing more than the ";tag" bit, below:

To: [$remote_tag]



asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml


I think you can do:

From: [last_To]
To: [last_From]

But don't take my word for it.



asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml


A bit inconsitent with contacts with and without angle brackets. Not that 
it matters.


- wdoekes


On Jan. 6, 2014, 9:53 p.m., opticron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3051/
> ---
> 
> (Updated Jan. 6, 2014, 9:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21084
> https://issues.asterisk.org/jira/browse/ASTERISK-21084
> 
> 
> Repository: testsuite
> 
> 
> Description
> ---
> 
> This adds a test which covers path support for outbound registrations, 
> inbound registrations, and outbound requests following an inbound 
> registration.
> 
> 
> Diffs
> -
> 
>   asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
> 4485 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
>  PRE-CREATION 
>   
> asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
>  PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3051/diff/
> 
> 
> Testing
> ---
> 
> Ensured the tests behaved as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2014-01-06 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

(Updated Jan. 6, 2014, 3:53 p.m.)


Review request for Asterisk Developers.


Changes
---

Tweak the SIPp scenario to fail more consistently under off-nominal conditions.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs (updated)
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4485 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-09 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

(Updated Dec. 9, 2013, 8:52 a.m.)


Review request for Asterisk Developers.


Changes
---

Add review dependency.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4355 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-09 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

(Updated Dec. 9, 2013, 8:49 a.m.)


Review request for Asterisk Developers.


Changes
---

Fix tags, description, and min version and add dependencies.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs (updated)
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4355 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-05 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-21084
https://issues.asterisk.org/jira/browse/ASTERISK-21084


Repository: testsuite


Description
---

This adds a test which covers path support for outbound registrations, inbound 
registrations, and outbound requests following an inbound registration.


Diffs
-

  asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml 
4355 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/test-config.yaml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_register.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/ua1_invite_recv.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/sipp/registrar.xml
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/pjsip.conf
 PRE-CREATION 
  
asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/path/configs/ast1/extensions.conf
 PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3051/diff/


Testing
---

Ensured the tests behaved as expected.


Thanks,

opticron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev