[asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/ --- Review request for Asterisk Developers. Bugs: ASTERISK-19454 https://issues.asterisk.org/jira/browse/ASTERISK-19454 Repository: Asterisk Description --- If you set a peer's outboundproxy and then removed it from the config, this would not get picked up in a config reload. This patch fixes that by resetting it in set_peer_defaults(). Note that the fix is the same for 1.8, 11, 12, and trunk branches. Diffs - /branches/1.8/channels/chan_sip.c 403633 Diff: https://reviewboard.asterisk.org/r/3065/diff/ Testing --- 1) Created a peer with outboundproxy set, observed with 'sip show peer foo' 2) removed outboundproxy from the config 3) executed *CLI sip reload 4) Repeat step 1, observe outboundproxy no longer set when the patch is applied I also verified that step 4 fails without the patch Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/#review10384 --- Ship it! Ship It! - Matt Jordan On Dec. 11, 2013, 12:16 p.m., Russell Bryant wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/ --- (Updated Dec. 11, 2013, 12:16 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-19454 https://issues.asterisk.org/jira/browse/ASTERISK-19454 Repository: Asterisk Description --- If you set a peer's outboundproxy and then removed it from the config, this would not get picked up in a config reload. This patch fixes that by resetting it in set_peer_defaults(). Note that the fix is the same for 1.8, 11, 12, and trunk branches. Diffs - /branches/1.8/channels/chan_sip.c 403633 Diff: https://reviewboard.asterisk.org/r/3065/diff/ Testing --- 1) Created a peer with outboundproxy set, observed with 'sip show peer foo' 2) removed outboundproxy from the config 3) executed *CLI sip reload 4) Repeat step 1, observe outboundproxy no longer set when the patch is applied I also verified that step 4 fails without the patch Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/ --- (Updated Dec. 11, 2013, 7:19 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Bugs: ASTERISK-19454 https://issues.asterisk.org/jira/browse/ASTERISK-19454 Repository: Asterisk Description --- If you set a peer's outboundproxy and then removed it from the config, this would not get picked up in a config reload. This patch fixes that by resetting it in set_peer_defaults(). Note that the fix is the same for 1.8, 11, 12, and trunk branches. Diffs - /branches/1.8/channels/chan_sip.c 403633 Diff: https://reviewboard.asterisk.org/r/3065/diff/ Testing --- 1) Created a peer with outboundproxy set, observed with 'sip show peer foo' 2) removed outboundproxy from the config 3) executed *CLI sip reload 4) Repeat step 1, observe outboundproxy no longer set when the patch is applied I also verified that step 4 fails without the patch Thanks, Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
