Re: [asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-10 Thread Joshua Colp

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3429/#review11543
---

Ship it!


Ship It!

- Joshua Colp


On April 9, 2014, 12:46 a.m., Russell Bryant wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3429/
 ---
 
 (Updated April 9, 2014, 12:46 a.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Repository: Asterisk
 
 
 Description
 ---
 
 This app is pretty ancient, so it was never converted to use the
 option parsing helper code.  I'd like to add an option to this app
 that takes an argument, and that's a pain to do when not using this
 helper, so start by doing this conversion.
 
 
 Diffs
 -
 
   /trunk/res/res_monitor.c 412023 
 
 Diff: https://reviewboard.asterisk.org/r/3429/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Russell Bryant
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-10 Thread Russell Bryant

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3429/
---

(Updated April 10, 2014, 8:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 412102


Repository: Asterisk


Description
---

This app is pretty ancient, so it was never converted to use the
option parsing helper code.  I'd like to add an option to this app
that takes an argument, and that's a pain to do when not using this
helper, so start by doing this conversion.


Diffs
-

  /trunk/res/res_monitor.c 412023 

Diff: https://reviewboard.asterisk.org/r/3429/diff/


Testing
---


Thanks,

Russell Bryant

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-08 Thread Russell Bryant

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3429/
---

Review request for Asterisk Developers.


Repository: Asterisk


Description
---

This app is pretty ancient, so it was never converted to use the
option parsing helper code.  I'd like to add an option to this app
that takes an argument, and that's a pain to do when not using this
helper, so start by doing this conversion.


Diffs
-

  /trunk/res/res_monitor.c 412023 

Diff: https://reviewboard.asterisk.org/r/3429/diff/


Testing
---


Thanks,

Russell Bryant

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev