Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Olle E Johansson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/
---

(Updated Oct. 29, 2014, 8:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 426599


Repository: Asterisk


Description
---

Adding improved support for 400, 414 and 493 response codes.

I would like to add this as a bug fix to 1.8 and up.


Diffs
-

  /trunk/channels/chan_sip.c 414046 

Diff: https://reviewboard.asterisk.org/r/3437/diff/


Testing
---

A lot during interoperability tests.


Thanks,

Olle E Johansson

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Matt Jordan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/#review11938
---

Ship it!


Hooray for handling badness!


/trunk/channels/chan_sip.c


Clean up the blob on commit :-)


- Matt Jordan


On May 16, 2014, 7:55 a.m., Olle E Johansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3437/
> ---
> 
> (Updated May 16, 2014, 7:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Adding improved support for 400, 414 and 493 response codes.
> 
> I would like to add this as a bug fix to 1.8 and up.
> 
> 
> Diffs
> -
> 
>   /trunk/channels/chan_sip.c 414046 
> 
> Diff: https://reviewboard.asterisk.org/r/3437/diff/
> 
> 
> Testing
> ---
> 
> A lot during interoperability tests.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Olle E Johansson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/
---

(Updated May 16, 2014, 2:55 p.m.)


Review request for Asterisk Developers.


Changes
---

Update according to review


Repository: Asterisk


Description
---

Adding improved support for 400, 414 and 493 response codes.

I would like to add this as a bug fix to 1.8 and up.


Diffs (updated)
-

  /trunk/channels/chan_sip.c 414046 

Diff: https://reviewboard.asterisk.org/r/3437/diff/


Testing
---

A lot during interoperability tests.


Thanks,

Olle E Johansson

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Olle E Johansson]

> On April 14, 2014, 2:24 p.m., Matt Jordan wrote:
> > /trunk/channels/chan_sip.c, lines 24306-24307
> > 
> >
> > The 400/414 responses could occur for any request we send. How about 
> > moving them up to the 404 handling (line 24214)?
> > 
> > That would mean some additional handling would be needed in 
> > handle_response_register and handle_response_subscribe, but it shouldn't be 
> > too much.

Hmmm. Maybe. < sipping a cup of tea while pondering this >


- Olle E


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/#review11598
---


On April 11, 2014, 9:29 a.m., Olle E Johansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3437/
> ---
> 
> (Updated April 11, 2014, 9:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Adding improved support for 400, 414 and 493 response codes.
> 
> I would like to add this as a bug fix to 1.8 and up.
> 
> 
> Diffs
> -
> 
>   /trunk/channels/chan_sip.c 412166 
> 
> Diff: https://reviewboard.asterisk.org/r/3437/diff/
> 
> 
> Testing
> ---
> 
> A lot during interoperability tests.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Matt Jordan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/#review11598
---



/trunk/channels/chan_sip.c


The 400/414 responses could occur for any request we send. How about moving 
them up to the 404 handling (line 24214)?

That would mean some additional handling would be needed in 
handle_response_register and handle_response_subscribe, but it shouldn't be too 
much.



/trunk/channels/chan_sip.c


Since a 493 occurs when an encrypted MIME body could not be unencrypted by 
the UAS, this should probably be handled by both the INVITE response handling 
as well as the SUBSCRIBE response handling.


I agree that this should go into 1.8+. We should handle valid response codes.

- Matt Jordan


On April 11, 2014, 2:29 a.m., Olle E Johansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3437/
> ---
> 
> (Updated April 11, 2014, 2:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Adding improved support for 400, 414 and 493 response codes.
> 
> I would like to add this as a bug fix to 1.8 and up.
> 
> 
> Diffs
> -
> 
>   /trunk/channels/chan_sip.c 412166 
> 
> Diff: https://reviewboard.asterisk.org/r/3437/diff/
> 
> 
> Testing
> ---
> 
> A lot during interoperability tests.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3437: chan_sip: Add support for a few more 4xx error responses

[Olle E Johansson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3437/
---

Review request for Asterisk Developers.


Repository: Asterisk


Description
---

Adding improved support for 400, 414 and 493 response codes.

I would like to add this as a bug fix to 1.8 and up.


Diffs
-

  /trunk/channels/chan_sip.c 412166 

Diff: https://reviewboard.asterisk.org/r/3437/diff/


Testing
---

A lot during interoperability tests.


Thanks,

Olle E Johansson

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev