Re: [asterisk-dev] [Code Review] 3440: ARI: Get rid of \brief on ARI resource mustache struct documentation comments

2014-04-18 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3440/
---

(Updated April 18, 2014, 3:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers, David Lee and Matt Jordan.


Changes
---

Committed in revision 412653


Repository: Asterisk


Description
---

This was pointed out on https://reviewboard.asterisk.org/r/3379/ -- the real 
change here was a very minor adjustment to the ARI resource mustache 
template... the rest is all autogenerated.


Diffs
-

  /branches/12/rest-api-templates/ari_resource.h.mustache 412208 
  /branches/12/res/ari/resource_sounds.h 412208 
  /branches/12/res/ari/resource_recordings.h 412208 
  /branches/12/res/ari/resource_playbacks.h 412208 
  /branches/12/res/ari/resource_mailboxes.h 412208 
  /branches/12/res/ari/resource_events.h 412208 
  /branches/12/res/ari/resource_endpoints.h 412208 
  /branches/12/res/ari/resource_device_states.h 412208 
  /branches/12/res/ari/resource_channels.h 412208 
  /branches/12/res/ari/resource_bridges.h 412208 
  /branches/12/res/ari/resource_asterisk.h 412208 
  /branches/12/res/ari/resource_applications.h 412208 

Diff: https://reviewboard.asterisk.org/r/3440/diff/


Testing
---

Made sure the struct fields lost their \briefs, checked to make sure nothing 
else did in the file I was looking at at least.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3440: ARI: Get rid of \brief on ARI resource mustache struct documentation comments

2014-04-15 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3440/#review11610
---

Ship it!


Ship It!

- rmudgett


On April 15, 2014, 11:57 a.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3440/
> ---
> 
> (Updated April 15, 2014, 11:57 a.m.)
> 
> 
> Review request for Asterisk Developers, David Lee and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This was pointed out on https://reviewboard.asterisk.org/r/3379/ -- the real 
> change here was a very minor adjustment to the ARI resource mustache 
> template... the rest is all autogenerated.
> 
> 
> Diffs
> -
> 
>   /branches/12/rest-api-templates/ari_resource.h.mustache 412208 
>   /branches/12/res/ari/resource_sounds.h 412208 
>   /branches/12/res/ari/resource_recordings.h 412208 
>   /branches/12/res/ari/resource_playbacks.h 412208 
>   /branches/12/res/ari/resource_mailboxes.h 412208 
>   /branches/12/res/ari/resource_events.h 412208 
>   /branches/12/res/ari/resource_endpoints.h 412208 
>   /branches/12/res/ari/resource_device_states.h 412208 
>   /branches/12/res/ari/resource_channels.h 412208 
>   /branches/12/res/ari/resource_bridges.h 412208 
>   /branches/12/res/ari/resource_asterisk.h 412208 
>   /branches/12/res/ari/resource_applications.h 412208 
> 
> Diff: https://reviewboard.asterisk.org/r/3440/diff/
> 
> 
> Testing
> ---
> 
> Made sure the struct fields lost their \briefs, checked to make sure nothing 
> else did in the file I was looking at at least.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3440: ARI: Get rid of \brief on ARI resource mustache struct documentation comments

2014-04-15 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3440/
---

(Updated April 15, 2014, 11:57 a.m.)


Review request for Asterisk Developers, David Lee and Matt Jordan.


Changes
---

Address Richard's comment


Repository: Asterisk


Description
---

This was pointed out on https://reviewboard.asterisk.org/r/3379/ -- the real 
change here was a very minor adjustment to the ARI resource mustache 
template... the rest is all autogenerated.


Diffs (updated)
-

  /branches/12/rest-api-templates/ari_resource.h.mustache 412208 
  /branches/12/res/ari/resource_sounds.h 412208 
  /branches/12/res/ari/resource_recordings.h 412208 
  /branches/12/res/ari/resource_playbacks.h 412208 
  /branches/12/res/ari/resource_mailboxes.h 412208 
  /branches/12/res/ari/resource_events.h 412208 
  /branches/12/res/ari/resource_endpoints.h 412208 
  /branches/12/res/ari/resource_device_states.h 412208 
  /branches/12/res/ari/resource_channels.h 412208 
  /branches/12/res/ari/resource_bridges.h 412208 
  /branches/12/res/ari/resource_asterisk.h 412208 
  /branches/12/res/ari/resource_applications.h 412208 

Diff: https://reviewboard.asterisk.org/r/3440/diff/


Testing
---

Made sure the struct fields lost their \briefs, checked to make sure nothing 
else did in the file I was looking at at least.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3440: ARI: Get rid of \brief on ARI resource mustache struct documentation comments

2014-04-11 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3440/#review11581
---



/branches/12/rest-api-templates/ari_resource.h.mustache


I think you should remove \brief from all of these lines for the same 
reason.


- rmudgett


On April 11, 2014, 11:33 a.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3440/
> ---
> 
> (Updated April 11, 2014, 11:33 a.m.)
> 
> 
> Review request for Asterisk Developers, David Lee and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This was pointed out on https://reviewboard.asterisk.org/r/3379/ -- the real 
> change here was a very minor adjustment to the ARI resource mustache 
> template... the rest is all autogenerated.
> 
> 
> Diffs
> -
> 
>   /branches/12/rest-api-templates/ari_resource.h.mustache 412208 
>   /branches/12/res/ari/resource_sounds.h 412208 
>   /branches/12/res/ari/resource_recordings.h 412208 
>   /branches/12/res/ari/resource_playbacks.h 412208 
>   /branches/12/res/ari/resource_mailboxes.h 412208 
>   /branches/12/res/ari/resource_endpoints.h 412208 
>   /branches/12/res/ari/resource_device_states.h 412208 
>   /branches/12/res/ari/resource_channels.h 412208 
>   /branches/12/res/ari/resource_bridges.h 412208 
>   /branches/12/res/ari/resource_asterisk.h 412208 
>   /branches/12/res/ari/resource_applications.h 412208 
> 
> Diff: https://reviewboard.asterisk.org/r/3440/diff/
> 
> 
> Testing
> ---
> 
> Made sure the struct fields lost their \briefs, checked to make sure nothing 
> else did in the file I was looking at at least.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3440: ARI: Get rid of \brief on ARI resource mustache struct documentation comments

2014-04-11 Thread Jonathan Rose 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3440/
---

Review request for Asterisk Developers, David Lee and Matt Jordan.


Repository: Asterisk


Description
---

This was pointed out on https://reviewboard.asterisk.org/r/3379/ -- the real 
change here was a very minor adjustment to the ARI resource mustache 
template... the rest is all autogenerated.


Diffs
-

  /branches/12/rest-api-templates/ari_resource.h.mustache 412208 
  /branches/12/res/ari/resource_sounds.h 412208 
  /branches/12/res/ari/resource_recordings.h 412208 
  /branches/12/res/ari/resource_playbacks.h 412208 
  /branches/12/res/ari/resource_mailboxes.h 412208 
  /branches/12/res/ari/resource_endpoints.h 412208 
  /branches/12/res/ari/resource_device_states.h 412208 
  /branches/12/res/ari/resource_channels.h 412208 
  /branches/12/res/ari/resource_bridges.h 412208 
  /branches/12/res/ari/resource_asterisk.h 412208 
  /branches/12/res/ari/resource_applications.h 412208 

Diff: https://reviewboard.asterisk.org/r/3440/diff/


Testing
---

Made sure the struct fields lost their \briefs, checked to make sure nothing 
else did in the file I was looking at at least.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev