Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---

(Updated July 21, 2014, 3:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 419060


Bugs: ASTERISK-24066
https://issues.asterisk.org/jira/browse/ASTERISK-24066


Repository: Asterisk


Description
---

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using 
ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining 
users are netsock.c (deprecated) and chan_sip (to be updated in a separate 
review).


Diffs
-

  /trunk/res/res_smdi.c 418788 
  /trunk/include/asterisk/smdi.h 418788 
  /trunk/channels/sig_analog.c 418788 
  /trunk/channels/chan_motif.c 418788 
  /trunk/channels/chan_dahdi.c 418788 
  /trunk/apps/app_voicemail.c 418788 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
---

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---

(Updated July 21, 2014, 4:40 a.m.)


Review request for Asterisk Developers.


Changes
---

Add JIRA ticket


Bugs: ASTERISK-24066
https://issues.asterisk.org/jira/browse/ASTERISK-24066


Repository: Asterisk


Description
---

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using 
ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining 
users are netsock.c (deprecated) and chan_sip (to be updated in a separate 
review).


Diffs
-

  /trunk/res/res_smdi.c 418788 
  /trunk/include/asterisk/smdi.h 418788 
  /trunk/channels/sig_analog.c 418788 
  /trunk/channels/chan_motif.c 418788 
  /trunk/channels/chan_dahdi.c 418788 
  /trunk/apps/app_voicemail.c 418788 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
---

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12763
---

Ship it!


Ship It!

- rmudgett


On July 16, 2014, 8:29 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 16, 2014, 8:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418788 
>   /trunk/include/asterisk/smdi.h 418788 
>   /trunk/channels/sig_analog.c 418788 
>   /trunk/channels/chan_motif.c 418788 
>   /trunk/channels/chan_dahdi.c 418788 
>   /trunk/apps/app_voicemail.c 418788 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12760
---

Ship it!


Ship It!

- opticron


On July 16, 2014, 8:29 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 16, 2014, 8:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418788 
>   /trunk/include/asterisk/smdi.h 418788 
>   /trunk/channels/sig_analog.c 418788 
>   /trunk/channels/chan_motif.c 418788 
>   /trunk/channels/chan_dahdi.c 418788 
>   /trunk/apps/app_voicemail.c 418788 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell 


> On July 16, 2014, 9:19 p.m., rmudgett wrote:
> > /trunk/res/res_smdi.c, line 1207
> > 
> >
> > Yuck a shadowed variable.

Technically no the other 'iface' variable was in a different sub-scope (to 
allow use with RAII_VAR).  I've renamed this variable to mailbox_iface and 
moved the declaration to the top of the function.


- Corey


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12704
---


On July 16, 2014, 9:29 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 16, 2014, 9:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418788 
>   /trunk/include/asterisk/smdi.h 418788 
>   /trunk/channels/sig_analog.c 418788 
>   /trunk/channels/chan_motif.c 418788 
>   /trunk/channels/chan_dahdi.c 418788 
>   /trunk/apps/app_voicemail.c 418788 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---

(Updated July 16, 2014, 9:29 p.m.)


Review request for Asterisk Developers.


Changes
---

Address Richards findings.


Repository: Asterisk


Description
---

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using 
ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining 
users are netsock.c (deprecated) and chan_sip (to be updated in a separate 
review).


Diffs (updated)
-

  /trunk/res/res_smdi.c 418788 
  /trunk/include/asterisk/smdi.h 418788 
  /trunk/channels/sig_analog.c 418788 
  /trunk/channels/chan_motif.c 418788 
  /trunk/channels/chan_dahdi.c 418788 
  /trunk/apps/app_voicemail.c 418788 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
---

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12704
---



/trunk/res/res_smdi.c


The old code doesn't seem to remove the object from the container.



/trunk/res/res_smdi.c


The old code doesn't seem to remove the object from the container.



/trunk/res/res_smdi.c


Excess indention.



/trunk/res/res_smdi.c


Yuck a shadowed variable.


- rmudgett


On July 16, 2014, 6:32 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 16, 2014, 6:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418788 
>   /trunk/include/asterisk/smdi.h 418788 
>   /trunk/channels/sig_analog.c 418788 
>   /trunk/channels/chan_motif.c 418788 
>   /trunk/channels/chan_dahdi.c 418788 
>   /trunk/apps/app_voicemail.c 418788 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---

(Updated July 16, 2014, 7:32 p.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
---

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using 
ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining 
users are netsock.c (deprecated) and chan_sip (to be updated in a separate 
review).


Diffs (updated)
-

  /trunk/res/res_smdi.c 418788 
  /trunk/include/asterisk/smdi.h 418788 
  /trunk/channels/sig_analog.c 418788 
  /trunk/channels/chan_motif.c 418788 
  /trunk/channels/chan_dahdi.c 418788 
  /trunk/apps/app_voicemail.c 418788 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
---

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread rmudgett 


> On July 13, 2014, 1:59 p.m., opticron wrote:
> > /trunk/res/res_smdi.c, line 394
> > 
> >
> > This can be accomplished with:
> > ao2_callback(iface->mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL);
> 
> Corey Farrell wrote:
> Seems like I shouldn't use OBJ_NODATA since I'm returning the object?

Correct.  Remove the OBJ_NODATA and you'll delete and get the first object out 
of the container.  Keep the OBJ_NODATA and you'll just delete the first object 
in the container.  A NULL compare function means use the match anything default 
compare function.

You are using the iterator in an unusual way here and other places.


- rmudgett


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12606
---


On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 12, 2014, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418436 
>   /trunk/include/asterisk/smdi.h 418436 
>   /trunk/channels/sig_analog.c 418436 
>   /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
>   /trunk/channels/chan_motif.c 418436 
>   /trunk/channels/chan_dahdi.c 418436 
>   /trunk/apps/app_voicemail.c 418436 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell 


> On July 13, 2014, 2:59 p.m., opticron wrote:
> > /trunk/res/res_smdi.c, line 394
> > 
> >
> > This can be accomplished with:
> > ao2_callback(iface->mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL);

Seems like I shouldn't use OBJ_NODATA since I'm returning the object?


- Corey


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12606
---


On July 12, 2014, 7:38 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 12, 2014, 7:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418436 
>   /trunk/include/asterisk/smdi.h 418436 
>   /trunk/channels/sig_analog.c 418436 
>   /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
>   /trunk/channels/chan_motif.c 418436 
>   /trunk/channels/chan_dahdi.c 418436 
>   /trunk/apps/app_voicemail.c 418436 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-13 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12612
---



/trunk/channels/dahdi/bridge_native_dahdi.c


This should be removed in v12 also as the include is not needed there 
either.  I don't know why it is including it.

Maybe I intended to explicitly include astobj2.h instead of astobj.h there. 
 Unfortunately, that memory has been overwritten in my brain. :)



/trunk/include/asterisk/smdi.h


There should be a define for the 80.



/trunk/include/asterisk/smdi.h


There should be a define for the 80.



/trunk/res/res_smdi.c


Use the template functions from the Asterisk wiki.  The OBJ_SEARCH_KEY and 
OBJ_SEARCH_OBJECT are enum values for a multi bit field in the flags parameter.



/trunk/res/res_smdi.c


Use ao2_container_alloc_list() instead of expressing it as a degenerate 
hash container.



/trunk/res/res_smdi.c


Use ao2_container_alloc_list() instead of expressing it as a degenerate 
hash container.


- rmudgett


On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 12, 2014, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418436 
>   /trunk/include/asterisk/smdi.h 418436 
>   /trunk/channels/sig_analog.c 418436 
>   /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
>   /trunk/channels/chan_motif.c 418436 
>   /trunk/channels/chan_dahdi.c 418436 
>   /trunk/apps/app_voicemail.c 418436 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-13 Thread opticron 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12606
---



/trunk/res/res_smdi.c


This can be accomplished with:
ao2_callback(iface->mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL);



/trunk/res/res_smdi.c


Idem.



/trunk/res/res_smdi.c


A similar operation can be performed here.



/trunk/res/res_smdi.c


Idem.


- opticron


On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> ---
> 
> (Updated July 12, 2014, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
> ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
> ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using 
> ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only 
> remaining users are netsock.c (deprecated) and chan_sip (to be updated in a 
> separate review).
> 
> 
> Diffs
> -
> 
>   /trunk/res/res_smdi.c 418436 
>   /trunk/include/asterisk/smdi.h 418436 
>   /trunk/channels/sig_analog.c 418436 
>   /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
>   /trunk/channels/chan_motif.c 418436 
>   /trunk/channels/chan_dahdi.c 418436 
>   /trunk/apps/app_voicemail.c 418436 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> ---
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-12 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
---

Review request for Asterisk Developers.


Repository: Asterisk


Description
---

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, 
ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, 
ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using 
ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining 
users are netsock.c (deprecated) and chan_sip (to be updated in a separate 
review).


Diffs
-

  /trunk/res/res_smdi.c 418436 
  /trunk/include/asterisk/smdi.h 418436 
  /trunk/channels/sig_analog.c 418436 
  /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
  /trunk/channels/chan_motif.c 418436 
  /trunk/channels/chan_dahdi.c 418436 
  /trunk/apps/app_voicemail.c 418436 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
---

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev