Re: [asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

2014-07-22 Thread Corey Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3831/
---

(Updated July 22, 2014, 8:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 419268


Bugs: ASTERISK-24058
https://issues.asterisk.org/jira/browse/ASTERISK-24058


Repository: Asterisk


Description
---

Unregisters manager actions FAXSessions, FAXSession and FAXStats at shutdown.

Additionally make ast_manager_register2 use ao2_t_alloc with the action name 
for the tag, to make it easier to track leaks like this in the future.


Diffs
-

  /trunk/res/res_fax.c 419018 
  /trunk/main/manager.c 419018 

Diff: https://reviewboard.asterisk.org/r/3831/diff/


Testing
---

Verified that tests/manager/originate no longer produces REF_DEBUG leaks.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

2014-07-21 Thread opticron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3831/#review12771
---

Ship it!


Ship It!

- opticron


On July 18, 2014, 7:29 p.m., Corey Farrell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3831/
 ---
 
 (Updated July 18, 2014, 7:29 p.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Bugs: ASTERISK-24058
 https://issues.asterisk.org/jira/browse/ASTERISK-24058
 
 
 Repository: Asterisk
 
 
 Description
 ---
 
 Unregisters manager actions FAXSessions, FAXSession and FAXStats at shutdown.
 
 Additionally make ast_manager_register2 use ao2_t_alloc with the action name 
 for the tag, to make it easier to track leaks like this in the future.
 
 
 Diffs
 -
 
   /trunk/res/res_fax.c 419018 
   /trunk/main/manager.c 419018 
 
 Diff: https://reviewboard.asterisk.org/r/3831/diff/
 
 
 Testing
 ---
 
 Verified that tests/manager/originate no longer produces REF_DEBUG leaks.
 
 
 Thanks,
 
 Corey Farrell
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

2014-07-18 Thread Corey Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3831/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-24058
https://issues.asterisk.org/jira/browse/ASTERISK-24058


Repository: Asterisk


Description
---

Unregisters manager actions FAXSessions, FAXSession and FAXStats at shutdown.

Additionally make ast_manager_register2 use ao2_t_alloc with the action name 
for the tag, to make it easier to track leaks like this in the future.


Diffs
-

  /trunk/res/res_fax.c 419018 
  /trunk/main/manager.c 419018 

Diff: https://reviewboard.asterisk.org/r/3831/diff/


Testing
---

Verified that tests/manager/originate no longer produces REF_DEBUG leaks.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev