Re: [asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3910/ --- (Updated Aug. 15, 2014, 11:56 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers, Matt Jordan and rmudgett. Changes --- Committed in revision 421186 Bugs: ASTERISK-24027 https://issues.asterisk.org/jira/browse/ASTERISK-24027 Repository: Asterisk Description --- r420934 changed ast_channel_is_leaving bridge to not care about the unbridge flag (which is no longer a softhangup flag due to that causing the behavior noted in ASTERISK-24027). This patch makes it so that the unbridge flag is evaluated again since that caused an unexpected change in how media would be re-established when a bridge starts to get torn down on hangup. Diffs - /branches/12/main/channel.c 420934 Diff: https://reviewboard.asterisk.org/r/3910/diff/ Testing --- Ran the failing tests from https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-C632TE-336. I couldn't get all of them to pass prior to r420934, but the ones that I could run successfully were confirmed broken by r420934 and fixed by this patch. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3910/#review13087 --- Ship it! Ship It! - Matt Jordan On Aug. 14, 2014, 1:28 p.m., Jonathan Rose wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3910/ > --- > > (Updated Aug. 14, 2014, 1:28 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and rmudgett. > > > Bugs: ASTERISK-24027 > https://issues.asterisk.org/jira/browse/ASTERISK-24027 > > > Repository: Asterisk > > > Description > --- > > r420934 changed ast_channel_is_leaving bridge to not care about the unbridge > flag (which is no longer a softhangup flag due to that causing the behavior > noted in ASTERISK-24027). This patch makes it so that the unbridge flag is > evaluated again since that caused an unexpected change in how media would be > re-established when a bridge starts to get torn down on hangup. > > > Diffs > - > > /branches/12/main/channel.c 420934 > > Diff: https://reviewboard.asterisk.org/r/3910/diff/ > > > Testing > --- > > Ran the failing tests from > https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-C632TE-336. I couldn't > get all of them to pass prior to r420934, but the ones that I could run > successfully were confirmed broken by r420934 and fixed by this patch. > > > Thanks, > > Jonathan Rose > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3910/#review13086 --- Ship it! Ship It! - rmudgett On Aug. 14, 2014, 1:28 p.m., Jonathan Rose wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3910/ > --- > > (Updated Aug. 14, 2014, 1:28 p.m.) > > > Review request for Asterisk Developers, Matt Jordan and rmudgett. > > > Bugs: ASTERISK-24027 > https://issues.asterisk.org/jira/browse/ASTERISK-24027 > > > Repository: Asterisk > > > Description > --- > > r420934 changed ast_channel_is_leaving bridge to not care about the unbridge > flag (which is no longer a softhangup flag due to that causing the behavior > noted in ASTERISK-24027). This patch makes it so that the unbridge flag is > evaluated again since that caused an unexpected change in how media would be > re-established when a bridge starts to get torn down on hangup. > > > Diffs > - > > /branches/12/main/channel.c 420934 > > Diff: https://reviewboard.asterisk.org/r/3910/diff/ > > > Testing > --- > > Ran the failing tests from > https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-C632TE-336. I couldn't > get all of them to pass prior to r420934, but the ones that I could run > successfully were confirmed broken by r420934 and fixed by this patch. > > > Thanks, > > Jonathan Rose > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3910/ --- (Updated Aug. 14, 2014, 1:28 p.m.) Review request for Asterisk Developers, Matt Jordan and rmudgett. Changes --- Oops, copied the wrong link. Bugs: ASTERISK-24027 https://issues.asterisk.org/jira/browse/ASTERISK-24027 Repository: Asterisk Description --- r420934 changed ast_channel_is_leaving bridge to not care about the unbridge flag (which is no longer a softhangup flag due to that causing the behavior noted in ASTERISK-24027). This patch makes it so that the unbridge flag is evaluated again since that caused an unexpected change in how media would be re-established when a bridge starts to get torn down on hangup. Diffs - /branches/12/main/channel.c 420934 Diff: https://reviewboard.asterisk.org/r/3910/diff/ Testing (updated) --- Ran the failing tests from https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-C632TE-336. I couldn't get all of them to pass prior to r420934, but the ones that I could run successfully were confirmed broken by r420934 and fixed by this patch. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3910: Fix test failures introduced by 420934
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3910/ --- Review request for Asterisk Developers, Matt Jordan and rmudgett. Bugs: ASTERISK-24027 https://issues.asterisk.org/jira/browse/ASTERISK-24027 Repository: Asterisk Description --- r420934 changed ast_channel_is_leaving bridge to not care about the unbridge flag (which is no longer a softhangup flag due to that causing the behavior noted in ASTERISK-24027). This patch makes it so that the unbridge flag is evaluated again since that caused an unexpected change in how media would be re-established when a bridge starts to get torn down on hangup. Diffs - /branches/12/main/channel.c 420934 Diff: https://reviewboard.asterisk.org/r/3910/diff/ Testing --- Ran the failing tests from https://issues.asterisk.org/jira/browse/AFS-137. I couldn't get all of them to pass prior to r420934, but the ones that I could run successfully were confirmed broken by r420934 and fixed by this patch. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
