Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-28 Thread Corey Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4111/
---

(Updated Oct. 28, 2014, 6:17 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 426255


Bugs: ASTERISK-24454
https://issues.asterisk.org/jira/browse/ASTERISK-24454


Repository: Asterisk


Description
---

update_realtime_members doesn't release the iterator for q->members, causing a 
reference leak.


Diffs
-

  /branches/11/apps/app_queue.c 426232 

Diff: https://reviewboard.asterisk.org/r/4111/diff/


Testing
---

Testsuite against 13, compile test/visual inspection for 11.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-27 Thread rmudgett

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4111/#review13598
---

Ship it!


Ship It!

- rmudgett


On Oct. 27, 2014, 12:53 a.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4111/
> ---
> 
> (Updated Oct. 27, 2014, 12:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24454
> https://issues.asterisk.org/jira/browse/ASTERISK-24454
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> update_realtime_members doesn't release the iterator for q->members, causing 
> a reference leak.
> 
> 
> Diffs
> -
> 
>   /branches/11/apps/app_queue.c 426232 
> 
> Diff: https://reviewboard.asterisk.org/r/4111/diff/
> 
> 
> Testing
> ---
> 
> Testsuite against 13, compile test/visual inspection for 11.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-27 Thread wdoekes

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4111/#review13594
---

Ship it!


Ship It!

- wdoekes


On Oct. 27, 2014, 5:53 a.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4111/
> ---
> 
> (Updated Oct. 27, 2014, 5:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24454
> https://issues.asterisk.org/jira/browse/ASTERISK-24454
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> update_realtime_members doesn't release the iterator for q->members, causing 
> a reference leak.
> 
> 
> Diffs
> -
> 
>   /branches/11/apps/app_queue.c 426232 
> 
> Diff: https://reviewboard.asterisk.org/r/4111/diff/
> 
> 
> Testing
> ---
> 
> Testsuite against 13, compile test/visual inspection for 11.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-26 Thread Corey Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4111/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-24454
https://issues.asterisk.org/jira/browse/ASTERISK-24454


Repository: Asterisk


Description
---

update_realtime_members doesn't release the iterator for q->members, causing a 
reference leak.


Diffs
-

  /branches/11/apps/app_queue.c 426232 

Diff: https://reviewboard.asterisk.org/r/4111/diff/


Testing
---

Testsuite against 13, compile test/visual inspection for 11.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev