Re: [asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/ --- (Updated Oct. 28, 2014, 6:11 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 426252 Bugs: ASTERISK-24455 https://issues.asterisk.org/jira/browse/ASTERISK-24455 Repository: Asterisk Description --- cdr_prop_write allocates payload twice, causing a leak for every call. I've removed the allocation with the declaration of payload, leaving it to be allocated at line 563. Diffs - /branches/13/funcs/func_cdr.c 426139 Diff: https://reviewboard.asterisk.org/r/4113/diff/ Testing --- Visual inspection only - my system is busy running other tests and this fix is very clear. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/#review13593 --- Ship it! Ship It! - wdoekes On Oct. 27, 2014, 8:03 a.m., Corey Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4113/ > --- > > (Updated Oct. 27, 2014, 8:03 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24455 > https://issues.asterisk.org/jira/browse/ASTERISK-24455 > > > Repository: Asterisk > > > Description > --- > > cdr_prop_write allocates payload twice, causing a leak for every call. I've > removed the allocation with the declaration of payload, leaving it to be > allocated at line 563. > > > Diffs > - > > /branches/13/funcs/func_cdr.c 426139 > > Diff: https://reviewboard.asterisk.org/r/4113/diff/ > > > Testing > --- > > Visual inspection only - my system is busy running other tests and this fix > is very clear. > > > Thanks, > > Corey Farrell > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24455 https://issues.asterisk.org/jira/browse/ASTERISK-24455 Repository: Asterisk Description --- cdr_prop_write allocates payload twice, causing a leak for every call. I've removed the allocation with the declaration of payload, leaving it to be allocated at line 563. Diffs - /branches/13/funcs/func_cdr.c 426139 Diff: https://reviewboard.asterisk.org/r/4113/diff/ Testing --- Visual inspection only - my system is busy running other tests and this fix is very clear. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
