Re: [asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/ --- (Updated Oct. 30, 2014, 12:16 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 426755 Bugs: ASTERISK-24462 https://issues.asterisk.org/jira/browse/ASTERISK-24462 Repository: Asterisk Description --- When removing the qualify_frequency from an AoR or a contact the statistics shown when issuing "pjsip show aors" from the CLI are incorrect. This patch deletes the contact's status object from sorcery, disassociating it from the contact, if the qualify_freqency is removed from configuration. Diffs - branches/12/res/res_pjsip/pjsip_options.c 426251 Diff: https://reviewboard.asterisk.org/r/4116/diff/ Testing --- Using static and dynamic contacts and various combinations of adding, removing, and reloading the configuration for both AoR and contact level qualify_freqency options noted that the qualify statistics are now correctly reflected. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/#review13625 --- Ship it! Ship It! - opticron On Oct. 27, 2014, 4:43 p.m., Kevin Harwell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4116/ > --- > > (Updated Oct. 27, 2014, 4:43 p.m.) > > > Review request for Asterisk Developers and Mark Michelson. > > > Bugs: ASTERISK-24462 > https://issues.asterisk.org/jira/browse/ASTERISK-24462 > > > Repository: Asterisk > > > Description > --- > > When removing the qualify_frequency from an AoR or a contact the statistics > shown when issuing "pjsip show aors" from the CLI are incorrect. This patch > deletes the contact's status object from sorcery, disassociating it from the > contact, if the qualify_freqency is removed from configuration. > > > Diffs > - > > branches/12/res/res_pjsip/pjsip_options.c 426251 > > Diff: https://reviewboard.asterisk.org/r/4116/diff/ > > > Testing > --- > > Using static and dynamic contacts and various combinations of adding, > removing, and reloading the configuration for both AoR and contact level > qualify_freqency options noted that the qualify statistics are now correctly > reflected. > > > Thanks, > > Kevin Harwell > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24462 https://issues.asterisk.org/jira/browse/ASTERISK-24462 Repository: Asterisk Description --- When removing the qualify_frequency from an AoR or a contact the statistics shown when issuing "pjsip show aors" from the CLI are incorrect. This patch deletes the contact's status object from sorcery, disassociating it from the contact, if the qualify_freqency is removed from configuration. Diffs - branches/12/res/res_pjsip/pjsip_options.c 426251 Diff: https://reviewboard.asterisk.org/r/4116/diff/ Testing --- Using static and dynamic contacts and various combinations of adding, removing, and reloading the configuration for both AoR and contact level qualify_freqency options noted that the qualify statistics are now correctly reflected. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
