Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/ --- (Updated Nov. 20, 2014, 9:46 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 428333 Repository: Asterisk Description --- In the attempt to skip past the 'contact' part of the variable name before passing it into the acl handler, we have a momentary lapse of sanity and forget that '_allow' isn't 'allow' and ast_append_acl interprets it as another deny. Diffs - /branches/12/res/res_pjsip_acl.c 426232 Diff: https://reviewboard.asterisk.org/r/4120/diff/ Testing --- deny=0.0.0.0/24 allow= Note that I have to reload pjsip after startup in order for the ACL to work... that seems like a bug surely. In any event, with the patch the device successfully registers. Without the patch, the registration is blocked by the ACL. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/#review13627 --- As an addendum to opticron's Ship It: This needs a test. - Matt Jordan On Oct. 28, 2014, 2:45 p.m., Jonathan Rose wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4120/ > --- > > (Updated Oct. 28, 2014, 2:45 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > --- > > In the attempt to skip past the 'contact' part of the variable name before > passing it into the acl handler, we have a momentary lapse of sanity and > forget that '_allow' isn't 'allow' and ast_append_acl interprets it as > another deny. > > > Diffs > - > > /branches/12/res/res_pjsip_acl.c 426232 > > Diff: https://reviewboard.asterisk.org/r/4120/diff/ > > > Testing > --- > > deny=0.0.0.0/24 > allow= > > Note that I have to reload pjsip after startup in order for the ACL to > work... that seems like a bug surely. In any event, with the patch the > device successfully registers. Without the patch, the registration is > blocked by the ACL. > > > Thanks, > > Jonathan Rose > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/#review13626 --- Ship it! Ship It! - opticron On Oct. 28, 2014, 2:45 p.m., Jonathan Rose wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4120/ > --- > > (Updated Oct. 28, 2014, 2:45 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > --- > > In the attempt to skip past the 'contact' part of the variable name before > passing it into the acl handler, we have a momentary lapse of sanity and > forget that '_allow' isn't 'allow' and ast_append_acl interprets it as > another deny. > > > Diffs > - > > /branches/12/res/res_pjsip_acl.c 426232 > > Diff: https://reviewboard.asterisk.org/r/4120/diff/ > > > Testing > --- > > deny=0.0.0.0/24 > allow= > > Note that I have to reload pjsip after startup in order for the ACL to > work... that seems like a bug surely. In any event, with the patch the > device successfully registers. Without the patch, the registration is > blocked by the ACL. > > > Thanks, > > Jonathan Rose > > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4120: res_pjsip_acl: contact ACL permits are being interpreted incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4120/ --- Review request for Asterisk Developers. Repository: Asterisk Description --- In the attempt to skip past the 'contact' part of the variable name before passing it into the acl handler, we have a momentary lapse of sanity and forget that '_allow' isn't 'allow' and ast_append_acl interprets it as another deny. Diffs - /branches/12/res/res_pjsip_acl.c 426232 Diff: https://reviewboard.asterisk.org/r/4120/diff/ Testing --- deny=0.0.0.0/24 allow= Note that I have to reload pjsip after startup in order for the ACL to work... that seems like a bug surely. In any event, with the patch the device successfully registers. Without the patch, the registration is blocked by the ACL. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
