[asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-13 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---

Review request for Asterisk Developers.


Repository: Asterisk


Description
---

This does have a minor change to sip_ref_peer and dialog_ref - the error 
messages about trying to reference a NULL is removed.  This message provided 
nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct 
ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the 
parameter logger_callid of sip_alloc.


Diffs
-

  /branches/13/channels/sip/include/sip.h 432806 
  /branches/13/channels/sip/include/dialog.h 432806 
  /branches/13/channels/chan_sip.c 432806 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
---

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
of sip_alloc.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-15 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---

(Updated March 15, 2015, 11 p.m.)


Review request for Asterisk Developers.


Changes
---

Add ticket.


Bugs: ASTERISK-24882
https://issues.asterisk.org/jira/browse/ASTERISK-24882


Repository: Asterisk


Description
---

This does have a minor change to sip_ref_peer and dialog_ref - the error 
messages about trying to reference a NULL is removed.  This message provided 
nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct 
ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the 
parameter logger_callid of sip_alloc.


Diffs
-

  /branches/13/channels/sip/include/sip.h 432806 
  /branches/13/channels/sip/include/dialog.h 432806 
  /branches/13/channels/chan_sip.c 432806 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
---

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
of sip_alloc.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-16 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14712
---



/branches/13/channels/chan_sip.c


Is there a reason why char *file cannot be const?



/branches/13/channels/chan_sip.c


Is there a reason why char *file cannot be const?



/branches/13/channels/chan_sip.c


Take the assignment out of the if test.  The long assignment line has 
better line breaks outside of the if test.


- rmudgett


On March 15, 2015, 10 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4189/
> ---
> 
> (Updated March 15, 2015, 10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24882
> https://issues.asterisk.org/jira/browse/ASTERISK-24882
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This does have a minor change to sip_ref_peer and dialog_ref - the error 
> messages about trying to reference a NULL is removed.  This message provided 
> nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
> REF_DEBUG logs for leaked dialogs.
> 
> Note: I've posted the version of this patch for 13.  In trunk the 'struct 
> ast_callid *' type has been replaced with a typedef 'ast_callid', effecting 
> the parameter logger_callid of sip_alloc.
> 
> 
> Diffs
> -
> 
>   /branches/13/channels/sip/include/sip.h 432806 
>   /branches/13/channels/sip/include/dialog.h 432806 
>   /branches/13/channels/chan_sip.c 432806 
> 
> Diff: https://reviewboard.asterisk.org/r/4189/diff/
> 
> 
> Testing
> ---
> 
> Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
> of sip_alloc.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-16 Thread Corey Farrell 


> On March 16, 2015, 6:47 p.m., rmudgett wrote:
> > /branches/13/channels/chan_sip.c, lines 1183-1184
> > 
> >
> > Is there a reason why char *file cannot be const?

Looks like I copy/pasted the new parameters from dialog_ref_debug.


- Corey


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14712
---


On March 15, 2015, 11 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4189/
> ---
> 
> (Updated March 15, 2015, 11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24882
> https://issues.asterisk.org/jira/browse/ASTERISK-24882
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This does have a minor change to sip_ref_peer and dialog_ref - the error 
> messages about trying to reference a NULL is removed.  This message provided 
> nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
> REF_DEBUG logs for leaked dialogs.
> 
> Note: I've posted the version of this patch for 13.  In trunk the 'struct 
> ast_callid *' type has been replaced with a typedef 'ast_callid', effecting 
> the parameter logger_callid of sip_alloc.
> 
> 
> Diffs
> -
> 
>   /branches/13/channels/sip/include/sip.h 432806 
>   /branches/13/channels/sip/include/dialog.h 432806 
>   /branches/13/channels/chan_sip.c 432806 
> 
> Diff: https://reviewboard.asterisk.org/r/4189/diff/
> 
> 
> Testing
> ---
> 
> Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
> of sip_alloc.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-16 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---

(Updated March 16, 2015, 7:37 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24882
https://issues.asterisk.org/jira/browse/ASTERISK-24882


Repository: Asterisk


Description
---

This does have a minor change to sip_ref_peer and dialog_ref - the error 
messages about trying to reference a NULL is removed.  This message provided 
nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct 
ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the 
parameter logger_callid of sip_alloc.


Diffs (updated)
-

  /branches/13/channels/sip/include/sip.h 433002 
  /branches/13/channels/sip/include/dialog.h 433002 
  /branches/13/channels/chan_sip.c 433002 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
---

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
of sip_alloc.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-16 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---

(Updated March 16, 2015, 7:42 p.m.)


Review request for Asterisk Developers.


Changes
---

Last update missed the __find_call file parameter fix.


Bugs: ASTERISK-24882
https://issues.asterisk.org/jira/browse/ASTERISK-24882


Repository: Asterisk


Description
---

This does have a minor change to sip_ref_peer and dialog_ref - the error 
messages about trying to reference a NULL is removed.  This message provided 
nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct 
ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the 
parameter logger_callid of sip_alloc.


Diffs (updated)
-

  /branches/13/channels/sip/include/sip.h 433002 
  /branches/13/channels/sip/include/dialog.h 433002 
  /branches/13/channels/chan_sip.c 433002 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
---

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
of sip_alloc.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-17 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14718
---

Ship it!


Ship It!

- rmudgett


On March 16, 2015, 6:42 p.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4189/
> ---
> 
> (Updated March 16, 2015, 6:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24882
> https://issues.asterisk.org/jira/browse/ASTERISK-24882
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> This does have a minor change to sip_ref_peer and dialog_ref - the error 
> messages about trying to reference a NULL is removed.  This message provided 
> nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
> REF_DEBUG logs for leaked dialogs.
> 
> Note: I've posted the version of this patch for 13.  In trunk the 'struct 
> ast_callid *' type has been replaced with a typedef 'ast_callid', effecting 
> the parameter logger_callid of sip_alloc.
> 
> 
> Diffs
> -
> 
>   /branches/13/channels/sip/include/sip.h 433002 
>   /branches/13/channels/sip/include/dialog.h 433002 
>   /branches/13/channels/chan_sip.c 433002 
> 
> Diff: https://reviewboard.asterisk.org/r/4189/diff/
> 
> 
> Testing
> ---
> 
> Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
> of sip_alloc.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

2015-03-19 Thread Corey Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/
---

(Updated March 19, 2015, 4:53 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 433115


Bugs: ASTERISK-24882
https://issues.asterisk.org/jira/browse/ASTERISK-24882


Repository: Asterisk


Description
---

This does have a minor change to sip_ref_peer and dialog_ref - the error 
messages about trying to reference a NULL is removed.  This message provided 
nothing useful.  The changes to sip_alloc / find_call make it easier to trace 
REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct 
ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the 
parameter logger_callid of sip_alloc.


Diffs
-

  /branches/13/channels/sip/include/sip.h 433002 
  /branches/13/channels/sip/include/dialog.h 433002 
  /branches/13/channels/chan_sip.c 433002 

Diff: https://reviewboard.asterisk.org/r/4189/diff/


Testing
---

Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller 
of sip_alloc.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev