Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[Jonathan Rose]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/
---

(Updated March 27, 2015, 5:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 433658


Repository: Asterisk


Description
---

As described on the wiki at: 

> The Sales Queue may be reached externally by dialing 256-555-1200, or 
> internally by dialing 1200.
> The Customer Experience Queue may be reached externally by dialing 
> 256-555-1250, or internally by dialing 1250.

> Sales Queue
> Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> fashion
> If no one answers a call to the Sales Queue after 5 minutes, the caller 
> should be directed
> to the Operator so that the Operator can take a message and have a Sales 
> person contact the
> caller at a later time.

> Customer Advocate Queue
> Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> ring-all
> fashion. If no one answers a call to the Customer Advocate queue after 20 
> minutes, the
> caller should be directed to the Operator so that the Operator can take a 
> message and
> have a Customer Advocate contact the caller at a later time.

NOTE: This review is accidentally against trunk, but the patch is perfectly 
portable, so that shouldn't be a problem.

NOTE 2: External extensions for the queues still need to be added since the 
outside connectivity patch hasn't been merged yet
https://reviewboard.asterisk.org/r/4488/diff/#index_header


Diffs
-

  /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
  /trunk/configs/basic-pbx/modules.conf 432443 
  /trunk/configs/basic-pbx/extensions.conf 432443 

Diff: https://reviewboard.asterisk.org/r/4503/diff/


Testing
---

Had some phones register as agents in the queues as well as the operator, made 
sure the queue members were dialed in ring-all fashion and that the timeouts 
occurred and the operator was dialed as expected.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

> On March 24, 2015, 10:41 p.m., rnewton wrote:
> > Tested with 4488, only a few modifications made. Emailed you a diff with 
> > the changes and external extensions.

When testing this patch with 4488 I ran through the following tests:
*patch1 - internal stuff*
internal user to internal user (audio):  PASS
internal user to internal user (voicemail-unavail): PASS
internal user to internal user (voicemail-busy): PASS
internal user can check voicemail: PASS
deskphone displays MWI indication: PASS

*patch2 - outside connectivity*
registration to ITSP(DCS) comes up: PASS
internal user dials out ITSP with 7 digit number: PASS
internal user dials out ITSP with 10 digit number: PASS
internal user dials out ITSP with 10+1 digit number: PASS
internal user dials main IVR internally: PASS
restricted number patterns work successfully: PASS
inbound calls reach the main IVR: PASS
external user can reach external voicemail feature via DID: PASS
external users can dial internal users directly via DID match: PASS

*patch3 - queues with external and internal access*
sales queue reached internally: PASS
externally: PASS
sales queue rings Terry, Garnet and Franny in ring-all: PASS
customer advocate queue reached internally: PASS
externally: PASS
customer advocate Queue rings Maria, Dusty and Tommie in ring-all: PASS

*patch4 - conferences*
employee conference can be dialed by internal users: PASS
at least two parties in employee conference with audio: PASS
customer conference can be dialed into by internal user and transfer in 
external users: PASS
at least two parties, including an external party in customer conference with 
audio: PASS

*ALL PATCHES COMBINED*
All IVR options go to the correct feature/extension: PASS
CDR Master.csv does not record any intra-office calls: PASS
CDR Master.csv records calls to/from the ITSP account: PASS


- rnewton


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14825
---


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14825
---


Tested with 4488, only a few modifications made. Emailed you a diff with the 
changes and external extensions.

- rnewton


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

> On March 24, 2015, 10:39 p.m., rnewton wrote:
> > /trunk/configs/basic-pbx/extensions.conf, lines 16-30
> > 
> >
> > These should move to the External-Features context and get their 
> > extensions changed to the full DID.
> > 
> > The Features context will have the internal "goto" calls to send 
> > internal callers to the extensions in External-Features.
> > 
> > You'll note this in the diff I just E-mailed over to you.

The diff should also show modified comments for all of those extensions I 
believe.


- rnewton


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14823
---


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14823
---



/trunk/configs/basic-pbx/extensions.conf


These should move to the External-Features context and get their extensions 
changed to the full DID.

The Features context will have the internal "goto" calls to send internal 
callers to the extensions in External-Features.

You'll note this in the diff I just E-mailed over to you.


- rnewton


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14752
---


As an update - when testing with my external connectivity patch I've run into 
some one-way audio and issues where in certain calling scenarios MOH does not 
play. I'm investigating that further tomorrow.

- rnewton


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[rnewton]

> On March 17, 2015, 9:44 p.m., Mark Michelson wrote:
> > Everything looks good here. Should this review stay open for the external 
> > extensions to be added, or will that be a separate review?
> 
> Jonathan Rose wrote:
> I'll leave both reviews open for now.

I'm finally testing with these with outside connectivity this morning, so we'll 
see if anything needs to change.


- rnewton


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14730
---


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[Jonathan Rose]

> On March 17, 2015, 4:44 p.m., Mark Michelson wrote:
> > Everything looks good here. Should this review stay open for the external 
> > extensions to be added, or will that be a separate review?

I'll leave both reviews open for now.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14730
---


On March 16, 2015, 10:37 a.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 10:37 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[Mark Michelson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/#review14730
---

Ship it!


Everything looks good here. Should this review stay open for the external 
extensions to be added, or will that be a separate review?

- Mark Michelson


On March 16, 2015, 3:37 p.m., Jonathan Rose wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4503/
> ---
> 
> (Updated March 16, 2015, 3:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> As described on the wiki at: 
> 
> > The Sales Queue may be reached externally by dialing 256-555-1200, or 
> > internally by dialing 1200.
> > The Customer Experience Queue may be reached externally by dialing 
> > 256-555-1250, or internally by dialing 1250.
> 
> > Sales Queue
> > Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> > fashion
> > If no one answers a call to the Sales Queue after 5 minutes, the caller 
> > should be directed
> > to the Operator so that the Operator can take a message and have a Sales 
> > person contact the
> > caller at a later time.
> 
> > Customer Advocate Queue
> > Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> > ring-all
> > fashion. If no one answers a call to the Customer Advocate queue after 20 
> > minutes, the
> > caller should be directed to the Operator so that the Operator can take a 
> > message and
> > have a Customer Advocate contact the caller at a later time.
> 
> NOTE: This review is accidentally against trunk, but the patch is perfectly 
> portable, so that shouldn't be a problem.
> 
> NOTE 2: External extensions for the queues still need to be added since the 
> outside connectivity patch hasn't been merged yet
> https://reviewboard.asterisk.org/r/4488/diff/#index_header
> 
> 
> Diffs
> -
> 
>   /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
>   /trunk/configs/basic-pbx/modules.conf 432443 
>   /trunk/configs/basic-pbx/extensions.conf 432443 
> 
> Diff: https://reviewboard.asterisk.org/r/4503/diff/
> 
> 
> Testing
> ---
> 
> Had some phones register as agents in the queues as well as the operator, 
> made sure the queue members were dialed in ring-all fashion and that the 
> timeouts occurred and the operator was dialed as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4503: SAC: Configure customer advocate/sales queues

[Jonathan Rose]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/
---

Review request for Asterisk Developers.


Repository: Asterisk


Description
---

As described on the wiki at: 

> The Sales Queue may be reached externally by dialing 256-555-1200, or 
> internally by dialing 1200.
> The Customer Experience Queue may be reached externally by dialing 
> 256-555-1250, or internally by dialing 1250.

> Sales Queue
> Calls to the Sales Queue should ring Terry, Garnet and Franny in ring-all 
> fashion
> If no one answers a call to the Sales Queue after 5 minutes, the caller 
> should be directed
> to the Operator so that the Operator can take a message and have a Sales 
> person contact the
> caller at a later time.

> Customer Advocate Queue
> Calls to the Customer Advocate Queue should ring Maria, Dusty and Tommie in 
> ring-all
> fashion. If no one answers a call to the Customer Advocate queue after 20 
> minutes, the
> caller should be directed to the Operator so that the Operator can take a 
> message and
> have a Customer Advocate contact the caller at a later time.

NOTE: This review is accidentally against trunk, but the patch is perfectly 
portable, so that shouldn't be a problem.

NOTE 2: External extensions for the queues still need to be added since the 
outside connectivity patch hasn't been merged yet
https://reviewboard.asterisk.org/r/4488/diff/#index_header


Diffs
-

  /trunk/configs/basic-pbx/queues.conf PRE-CREATION 
  /trunk/configs/basic-pbx/modules.conf 432443 
  /trunk/configs/basic-pbx/extensions.conf 432443 

Diff: https://reviewboard.asterisk.org/r/4503/diff/


Testing
---

Had some phones register as agents in the queues as well as the operator, made 
sure the queue members were dialed in ring-all fashion and that the timeouts 
occurred and the operator was dialed as expected.


Thanks,

Jonathan Rose

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev