[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---

Review request for Asterisk Developers.


Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description
---

clang's static analyzer will throw quite a number warnings / errors during 
compilation, some of which can be very helpfull in finding corner-case bugs. 
clang compiler warning:-Wself-assign


Diffs
-

  /branches/13/formats/format_wav_gsm.c 433444 
  /branches/13/formats/format_wav.c 433444 

Diff: https://reviewboard.asterisk.org/r/4544/diff/


Testing
---


Thanks,

Diederik de Groot

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Jared Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14907
---



/branches/13/formats/format_wav.c


Red blob...



/branches/13/formats/format_wav.c


Red blob here...



/branches/13/formats/format_wav_gsm.c


And here as well...


While most of my comments are about the coding standards, the meat of this 
patch is very straightforward, and shouldn't cause any problems.

- Jared Smith


On March 27, 2015, 12:02 p.m., Diederik de Groot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> ---
> 
> (Updated March 27, 2015, 12:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> clang's static analyzer will throw quite a number warnings / errors during 
> compilation, some of which can be very helpfull in finding corner-case bugs. 
> clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot 


> On March 27, 2015, 5:20 p.m., Jared Smith wrote:
> > /branches/13/formats/format_wav.c, line 67
> > 
> >
> > Red blob...

I like to line up the slashes when using macro's. But ok


- Diederik


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14907
---


On March 27, 2015, 5:38 p.m., Diederik de Groot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> ---
> 
> (Updated March 27, 2015, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> clang's static analyzer will throw quite a number warnings / errors during 
> compilation, some of which can be very helpfull in finding corner-case bugs. 
> clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---

(Updated March 27, 2015, 5:38 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description
---

clang's static analyzer will throw quite a number warnings / errors during 
compilation, some of which can be very helpfull in finding corner-case bugs. 
clang compiler warning:-Wself-assign


Diffs (updated)
-

  /branches/13/formats/format_wav_gsm.c 433444 
  /branches/13/formats/format_wav.c 433444 

Diff: https://reviewboard.asterisk.org/r/4544/diff/


Testing
---


Thanks,

Diederik de Groot

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread rmudgett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14917
---


I'm wondering if -Wself-assign should not be enabled.  It appears to be just a 
nuisance warning.


/branches/13/formats/format_wav.c


Revert this per guidelines


- rmudgett


On March 27, 2015, 11:38 a.m., Diederik de Groot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> ---
> 
> (Updated March 27, 2015, 11:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> clang's static analyzer will throw quite a number warnings / errors during 
> compilation, some of which can be very helpfull in finding corner-case bugs. 
> clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---

(Updated March 27, 2015, 6:20 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description
---

clang's static analyzer will throw quite a number warnings / errors during 
compilation, some of which can be very helpfull in finding corner-case bugs. 
clang compiler warning:-Wself-assign


Diffs (updated)
-

  /branches/13/formats/format_wav_gsm.c 433444 
  /branches/13/formats/format_wav.c 433444 

Diff: https://reviewboard.asterisk.org/r/4544/diff/


Testing
---


Thanks,

Diederik de Groot

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot 


> On March 27, 2015, 6:14 p.m., rmudgett wrote:
> > I'm wondering if -Wself-assign should not be enabled.  It appears to be 
> > just a nuisance warning.

I do agree, some of the clang warnings can be a little bit petty to be honest. 
Some of them have proven to be quite usefull though. I will leave this up to 
you guys to decide. I already had to suppress the 
"-Wunused-command-line-argument" which was annoying me quite a bit, when 
compiling with --dev-mode :-)


> On March 27, 2015, 6:14 p.m., rmudgett wrote:
> > /branches/13/formats/format_wav.c, lines 114-115
> > 
> >
> > Revert this per guidelines

Will do.


- Diederik


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14917
---


On March 27, 2015, 5:38 p.m., Diederik de Groot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> ---
> 
> (Updated March 27, 2015, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> clang's static analyzer will throw quite a number warnings / errors during 
> compilation, some of which can be very helpfull in finding corner-case bugs. 
> clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Matt Jordan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14925
---

Ship it!


Ship It!

- Matt Jordan


On March 27, 2015, 12:20 p.m., Diederik de Groot wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> ---
> 
> (Updated March 27, 2015, 12:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> clang's static analyzer will throw quite a number warnings / errors during 
> compilation, some of which can be very helpfull in finding corner-case bugs. 
> clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-28 Thread Diederik de Groot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---

(Updated March 28, 2015, 7:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 433691


Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917


Repository: Asterisk


Description
---

clang's static analyzer will throw quite a number warnings / errors during 
compilation, some of which can be very helpfull in finding corner-case bugs. 
clang compiler warning:-Wself-assign


Diffs
-

  /branches/13/formats/format_wav_gsm.c 433444 
  /branches/13/formats/format_wav.c 433444 

Diff: https://reviewboard.asterisk.org/r/4544/diff/


Testing
---


Thanks,

Diederik de Groot

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev