Re: [asterisk-dev] [Code Review] 4586: AMI: Fix improper handling of lines that are exactly 1025 bytes long.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4586/ --- (Updated April 13, 2015, 7:59 a.m.) Status -- This change has been discarded. Review request for Asterisk Developers. Bugs: ASTERISK-20524 https://issues.asterisk.org/jira/browse/ASTERISK-20524 Repository: Asterisk Description --- When AMI receives a line that is 1025 bytes long, it sends two error messages. Copy the last byte in the buffer to the first postiion, set the length to 1. Diffs - /branches/11/main/manager.c 433967 Diff: https://reviewboard.asterisk.org/r/4586/diff/ Testing --- Testsuite - tests/manager against Asterisk 13. All passed. Manually tested against 11 using David's script posted to JIRA. Verified a single error is received for lines 1025 or more, lines 1024 or less succeed. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4586: AMI: Fix improper handling of lines that are exactly 1025 bytes long.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4586/ --- Review request for Asterisk Developers. Bugs: ASTERISK-20524 https://issues.asterisk.org/jira/browse/ASTERISK-20524 Repository: Asterisk Description --- When AMI receives a line that is 1025 bytes long, it sends two error messages. Copy the last byte in the buffer to the first postiion, set the length to 1. Diffs - /branches/11/main/manager.c 433967 Diff: https://reviewboard.asterisk.org/r/4586/diff/ Testing --- Testsuite - tests/manager against Asterisk 13. All passed. Manually tested against 11 using David's script posted to JIRA. Verified a single error is received for lines 1025 or more, lines 1024 or less succeed. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
