Re: [asterisk-dev] [asterisk-commits] file: trunk r89637 - /trunk/main/utils.c

2007-11-27 Thread Simon Perreault 
On Tuesday 27 November 2007 12:01:19 SVN commits to the Asterisk project 
wrote:
> + long int rm = RAND_MAX;
>   res = res < 0 ? ~res : res;
> - return res;
> + rm++;
> + return res % rm;

Hum... Won't rm be zero on 32-bit platforms? Modulo zero isn't defined in C...

___
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [asterisk-commits] file: trunk r89637 - /trunk/main/utils.c

2007-11-27 Thread Joshua Colp 
- Original Message -
From: Simon Perreault
[mailto:[EMAIL PROTECTED]
To: asterisk-dev@lists.digium.com
Sent:
Tue, 27 Nov 2007 13:06:36 -0400
Subject: Re: [asterisk-dev]
[asterisk-commits] file: trunk r89637 - /trunk/main/utils.c


> On Tuesday 27 November 2007 12:01:19 SVN commits to the Asterisk project 
> wrote:
> > +   long int rm = RAND_MAX;
> > res = res < 0 ? ~res : res;
> > -   return res;
> > +   rm++;
> > +   return res % rm;
> 
> Hum... Won't rm be zero on 32-bit platforms? Modulo zero isn't defined in
> C...

I tested both platforms before putting the change in and it worked fine on 
both, but it could be undefined. More exploring is required I suppose.

Joshua Colp
Software Developer
Digium, Inc.

___
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev