[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review.

  https://gerrit.asterisk.org/42

Change subject: Add .gitignore and .gitreview files
..

Add .gitignore and .gitreview files

Add the .gitignore and .gitreview files to the asterisk repo.

NB:  You can add local ignores to the .git/info/exclude file
without having to do a commit.

Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Tested-by: George Joseph
---
A .gitignore
A .gitreview
2 files changed, 71 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/42/42/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..db9aaed
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,67 @@
+# git ls-files --others --exclude-from=.git/info/exclude
+# Lines that start with '#' are comments.
+# For a project mostly in C, the following would be a good set of
+# exclude patterns (uncomment them if you want to use them):
+# *.[oa]
+# *~
+
+**.[oadi]
+**.exports
+**.so
+**.moduleinfo
+**.makeopts
+**.makedeps
+**/makeopts
+
+.lastclean
+addons/mp3
+agi/eagi-sphinx-test
+agi/eagi-test
+agi/strcompat.c
+build_tools/menuselect-deps
+config.log
+config.status
+defaults.h
+doc/core-en_US.xml
+include/asterisk/autoconfig.h
+include/asterisk/build.h
+include/asterisk/buildopts.h
+main/ast_expr2.h
+main/asterisk
+main/libasteriskssl.so.1
+main/version.c
+makeopts.embed_rules
+menuselect-tree
+menuselect/autoconfig.h
+menuselect/cmenuselect
+menuselect/config.log
+menuselect/config.status
+menuselect/menuselect
+res/ael/ael.output
+res/ael/ael.tab.c
+res/ael/ael.tab.h
+utils/aelbison.c
+utils/aelparse
+utils/aelparse.c
+utils/ast_expr2.c
+utils/ast_expr2f.c
+utils/astman
+utils/astcanary
+utils/astdb2bdb
+utils/astdb2sqlite3
+utils/check_expr
+utils/check_expr2
+utils/conf2ael
+utils/db1-ast/libdb1.a
+utils/hashtab.c
+utils/lock.c
+utils/md5.c
+utils/muted
+utils/pbx_ael.c
+utils/pval.c
+utils/smsq
+utils/stereorize
+utils/strcompat.c
+utils/streamplayer
+utils/threadstorage.c
+
diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..f9ef050
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,4 @@
+[gerrit]
+host=gerrit.asterisk.org
+port=29418
+project=asterisk.git

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-HasComments: No

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 1:

(2 comments)

Couple minor things then this is good to go.

https://gerrit.asterisk.org/#/c/42/1/.gitignore
File .gitignore:

Line 6: # *~
I suspect we do want to ignore *~


Line 10: **.so
Please add *.eo for embedded objects.  Also *.ii, *.oo for C++ modules.

Honestly I'm not sure the purpose of the two stars in **.so or others like 
this.  Why not just use *.so?  That would apply to all dirs.


-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-HasComments: Yes

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/42/2/.gitignore
File .gitignore:

Line 21: addons/mp3
I personally think it's nicer to use .gitignore files in subdirectories.  Some 
concrete reasons it helps: if you rename or move directories, the ignore rules 
follow automatically and you end up with less conflicts with patches updating 
the same file.


-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: Yes

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/42/2//COMMIT_MSG
Commit Message:

Line 15: Tested-by: George Joseph
I think it would be good to move to using the same format for other git headers 
(include the full name and email address)


-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: Yes

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 2:

 (1 comment)

My only issue with this is that it makes it harder to troubleshoot or get an 
overview of ignores especially if you have a cascading situation.  I'm ok with 
it though so if Matt's ok with it, i'll separate them.

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: No

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged.

Change subject: Add .gitignore and .gitreview files
..


Add .gitignore and .gitreview files

Add the .gitignore and .gitreview files to the asterisk repo.

NB:  You can add local ignores to the .git/info/exclude file
without having to do a commit.

Common ignore patterns are in the top-level .gitignore file.
Subdirectory-specific ignore patterns are in their own .gitignore
files.

Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Tested-by: George Joseph
---
A .gitignore
A .gitreview
A addons/.gitignore
A agi/.gitignore
A build_tools/.gitignore
A doc/.gitignore
A include/asterisk/.gitignore
A main/.gitignore
A menuselect/.gitignore
A res/ael/.gitignore
A utils/.gitignore
11 files changed, 72 insertions(+), 0 deletions(-)

Approvals:
  Matt Jordan: Looks good to me, approved; Verified
  Russell Bryant: Looks good to me, but someone else must approve



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..cf46873
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,26 @@
+# git ls-files --others --exclude-from=.git/info/exclude
+# Lines that start with '#' are comments.
+# For a project mostly in C, the following would be a good set of
+# exclude patterns (uncomment them if you want to use them):
+# *.[oa]
+# *~
+
+# See .gitignore in subdirectories for more ignored files
+
+*~
+*.[oadi]
+*.ii
+*.oo
+*.eo
+*.so
+*.exports
+*.moduleinfo
+*.makeopts
+*.makedeps
+makeopts
+.lastclean
+config.log
+config.status
+defaults.h
+makeopts.embed_rules
+menuselect-tree
diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..f9ef050
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,4 @@
+[gerrit]
+host=gerrit.asterisk.org
+port=29418
+project=asterisk.git
diff --git a/addons/.gitignore b/addons/.gitignore
new file mode 100644
index 000..663e668
--- /dev/null
+++ b/addons/.gitignore
@@ -0,0 +1 @@
+mp3
diff --git a/agi/.gitignore b/agi/.gitignore
new file mode 100644
index 000..9b2a4e2
--- /dev/null
+++ b/agi/.gitignore
@@ -0,0 +1,3 @@
+eagi-sphinx-test
+eagi-test
+strcompat.c
diff --git a/build_tools/.gitignore b/build_tools/.gitignore
new file mode 100644
index 000..c60a0df
--- /dev/null
+++ b/build_tools/.gitignore
@@ -0,0 +1 @@
+menuselect-deps
diff --git a/doc/.gitignore b/doc/.gitignore
new file mode 100644
index 000..27acdb3
--- /dev/null
+++ b/doc/.gitignore
@@ -0,0 +1 @@
+core-en_US.xml
diff --git a/include/asterisk/.gitignore b/include/asterisk/.gitignore
new file mode 100644
index 000..ae33b3c
--- /dev/null
+++ b/include/asterisk/.gitignore
@@ -0,0 +1,3 @@
+autoconfig.h
+build.h
+buildopts.h
diff --git a/main/.gitignore b/main/.gitignore
new file mode 100644
index 000..23f5c58
--- /dev/null
+++ b/main/.gitignore
@@ -0,0 +1,3 @@
+asterisk
+libasteriskssl.so.1
+version.c
diff --git a/menuselect/.gitignore b/menuselect/.gitignore
new file mode 100644
index 000..38ea2d3
--- /dev/null
+++ b/menuselect/.gitignore
@@ -0,0 +1,5 @@
+autoconfig.h
+cmenuselect
+config.log
+config.status
+menuselect
diff --git a/res/ael/.gitignore b/res/ael/.gitignore
new file mode 100644
index 000..f39b612
--- /dev/null
+++ b/res/ael/.gitignore
@@ -0,0 +1 @@
+ael.output
diff --git a/utils/.gitignore b/utils/.gitignore
new file mode 100644
index 000..ed37a06
--- /dev/null
+++ b/utils/.gitignore
@@ -0,0 +1,24 @@
+aelbison.c
+aelparse
+aelparse.c
+ast_expr2.c
+ast_expr2f.c
+astman
+astcanary
+astdb2bdb
+astdb2sqlite3
+check_expr
+check_expr2
+conf2ael
+db1-ast/libdb1.a
+hashtab.c
+lock.c
+md5.c
+muted
+pbx_ael.c
+pval.c
+smsq
+stereorize
+strcompat.c
+streamplayer
+threadstorage.c

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 3: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: No

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/42/2/.gitignore
File .gitignore:

Line 21: addons/mp3
 I personally think it's nicer to use .gitignore files in subdirectories.  S
To address George's comment: I'm good either way.


https://gerrit.asterisk.org/#/c/42/2//COMMIT_MSG
Commit Message:

Line 15: Tested-by: George Joseph
 I think it would be good to move to using the same format for other git hea
I'd be fine with that, but we'll need to update the wiki/commit message script 
as well. We should be able to extract that quite easily from JIRA - in fact, 
it'd probably be helpful to just have a script that returns that and the CLA 
License numbers as appropriate.

/me makes a note to do that.


-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: Yes

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
Hello Corey Farrell,

I'd like you to reexamine a change.  Please visit

https://gerrit.asterisk.org/42

to look at the new patch set (#3).

Change subject: Add .gitignore and .gitreview files
..

Add .gitignore and .gitreview files

Add the .gitignore and .gitreview files to the asterisk repo.

NB:  You can add local ignores to the .git/info/exclude file
without having to do a commit.

Common ignore patterns are in the top-level .gitignore file.
Subdirectory-specific ignore patterns are in their own .gitignore
files.

Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Tested-by: George Joseph
---
A .gitignore
A .gitreview
A addons/.gitignore
A agi/.gitignore
A build_tools/.gitignore
A doc/.gitignore
A include/asterisk/.gitignore
A main/.gitignore
A menuselect/.gitignore
A res/ael/.gitignore
A utils/.gitignore
11 files changed, 72 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/42/42/3
-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev


[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change.

Change subject: Add .gitignore and .gitreview files
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.asterisk.org/42
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: George Joseph george.jos...@fairview5.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Russell Bryant russ...@russellbryant.net
Gerrit-HasComments: No

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev