Re: [asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

[Alexander Traud]

> Asterisk never had a commit that actually used the function so
> it does not matter.





-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

[Richard Mudgett]

On Mon, Nov 6, 2017 at 6:00 AM, Alexander Traud 
wrote:

> > An earlier approach was to add support for setting pjproject's timer
> > (via a pjproject patch) and while that patch is still included here,
> > we don't use that call at the moment."
>
> OK, and what do we do with this code now?
> I am not used to leverage a version-controlled source code as pastebin or
> to keep dead code. Remove it? If not, it should at least work – configure
> is not able to find/match that feature at the moment. Remove or repair?
>

That patch was submitted upstream and committed to the pjproject.  However,
the function
name got changed slightly from pjsip_evsub_set_uas_timeout() to
pjsip_evsub_uas_set_timeout() when Teluu merged it into pjproject.
Asterisk never had a
commit that actually used the function so it does not matter.  Asterisk's
bundled pjproject
is currently 2.7.1 on the released branches and does not include the broken
patch anymore.

Richard
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

[Alexander Traud]

> An earlier approach was to add support for setting pjproject's timer
> (via a pjproject patch) and while that patch is still included here,
> we don't use that call at the moment."

OK, and what do we do with this code now?
I am not used to leverage a version-controlled source code as pastebin or to 
keep dead code. Remove it? If not, it should at least work – configure is not 
able to find/match that feature at the moment. Remove or repair?



-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

[Michael L. Young]

- Original Message -
> From: "Alexander Traud" <pabstr...@compuserve.com>
> To: "Asterisk Developers Mailing List" <asterisk-dev@lists.digium.com>
> Sent: Wednesday, October 18, 2017 5:02:47 AM
> Subject: [asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

> Because I use not the bundled PJProject, I have to examine whether Configure
> finds all symbols with my external PJProject 2.7. For
> "pjsip_evsub_set_uas_timeout" it is not able to do so. Before I investigate
> why, I would like to know where this is used in Asterisk at all. I found
> neither that symbol nor its guard (#if HAVE_xyz).
> 
> References
> <http://gerrit.asterisk.org/4916>
> <http://trac.pjsip.org/repos/changeset/5558>

According to the commit message, I don't believe it is used.

"An earlier approach was to add support for setting pjproject's timer (via a 
pjproject patch) and while that patch is still included here, we don't use that 
call at the moment."

--
Michael L. Young

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] Where is pjsip_evsub_set_uas_timeout?

[Alexander Traud]

Because I use not the bundled PJProject, I have to examine whether Configure 
finds all symbols with my external PJProject 2.7. For 
"pjsip_evsub_set_uas_timeout" it is not able to do so. Before I investigate 
why, I would like to know where this is used in Asterisk at all. I found 
neither that symbol nor its guard (#if HAVE_xyz).

References





-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev