Re: [asterisk-dev] asterisk-testsuite: linux-only
Does this also mean there are official debian packages for all of the testsuite dependencies? If so, that would go along way to getting people to start using it :-) Torrey On 13 October 2014 18:28, George Joseph wrote: > On Mon, Oct 13, 2014 at 10:15 AM, Matthew Jordan > wrote: > >> On Mon, Oct 13, 2014 at 12:58 AM, Tzafrir Cohen >> wrote: >> > Hi >> > >> > I finally got the asterisk-testsuite accpted into Debian (I know, I need >> > to get it updated). >> > >> > And just as it entered Unstable, it already got 3 bug reports on build >> > failures: http://bugs.debian.org/src:asterisk-testsuite >> > >> > Notable of them is: https://bugs.debian.org/764906 >> > >> > Basically asttest fails to build on non-linux platforms due to the use >> > of (for using e.g. PATH_MAX. >> > >> > What should I do on other platforms? >> > >> > * Try to rewrite the code to avoid using PATH_MAX (for instance, HURD >> > does not have this limit), or: >> > >> > * If the platform is not Linux, don't build asttest and don't run Lua >> > tests (is it used for Python ones as well?) >> > >> >> While I'm okay with either option, I think it is important to note >> that we (a) almost never write tests in Lua any more (in fact, I'd say >> we actively discourage it), and (b) have been migrating the tests from >> Lua to Python for some time. >> >> I don't think you lose much coverage by going with your second option. >> >> > Just FYI... asttest is still used by the following tests: > > tests/channels/SIP/rfc2833_dtmf_detect > tests/channels/SIP/handle_response_refer > tests/channels/SIP/tcpauthtimeout > tests/channels/SIP/sip_channel_params > tests/channels/SIP/tcpauthlimit > tests/apps/queues/macro_gosub_test > tests/apps/queues/ringinuse_and_pause > tests/apps/queues/ringinuse_and_pause > tests/apps/queues/queue_baseline > tests/apps/queues/position_priority_maxlen > tests/apps/queues/wrapup_time > tests/apps/queues/wrapup_time > tests/fax/sip/local_channel_t38_queryoption > tests/cdr/app_queue > tests/cdr/app_dial_G_flag > tests/manager/response-time > tests/manager/authlimit > tests/manager/authtimeout > tests/manager/action-events-response > tests/span-alarms > > You're also going to have to do some work on it to get it to even compile > on Lua 5.2. > > > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: >http://lists.digium.com/mailman/listinfo/asterisk-dev > -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] asterisk-testsuite: linux-only
On Mon, Oct 13, 2014 at 10:15 AM, Matthew Jordan wrote: > On Mon, Oct 13, 2014 at 12:58 AM, Tzafrir Cohen > wrote: > > Hi > > > > I finally got the asterisk-testsuite accpted into Debian (I know, I need > > to get it updated). > > > > And just as it entered Unstable, it already got 3 bug reports on build > > failures: http://bugs.debian.org/src:asterisk-testsuite > > > > Notable of them is: https://bugs.debian.org/764906 > > > > Basically asttest fails to build on non-linux platforms due to the use > > of (for using e.g. PATH_MAX. > > > > What should I do on other platforms? > > > > * Try to rewrite the code to avoid using PATH_MAX (for instance, HURD > > does not have this limit), or: > > > > * If the platform is not Linux, don't build asttest and don't run Lua > > tests (is it used for Python ones as well?) > > > > While I'm okay with either option, I think it is important to note > that we (a) almost never write tests in Lua any more (in fact, I'd say > we actively discourage it), and (b) have been migrating the tests from > Lua to Python for some time. > > I don't think you lose much coverage by going with your second option. > > Just FYI... asttest is still used by the following tests: tests/channels/SIP/rfc2833_dtmf_detect tests/channels/SIP/handle_response_refer tests/channels/SIP/tcpauthtimeout tests/channels/SIP/sip_channel_params tests/channels/SIP/tcpauthlimit tests/apps/queues/macro_gosub_test tests/apps/queues/ringinuse_and_pause tests/apps/queues/ringinuse_and_pause tests/apps/queues/queue_baseline tests/apps/queues/position_priority_maxlen tests/apps/queues/wrapup_time tests/apps/queues/wrapup_time tests/fax/sip/local_channel_t38_queryoption tests/cdr/app_queue tests/cdr/app_dial_G_flag tests/manager/response-time tests/manager/authlimit tests/manager/authtimeout tests/manager/action-events-response tests/span-alarms You're also going to have to do some work on it to get it to even compile on Lua 5.2. -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] asterisk-testsuite: linux-only
On Mon, Oct 13, 2014 at 12:58 AM, Tzafrir Cohen wrote: > Hi > > I finally got the asterisk-testsuite accpted into Debian (I know, I need > to get it updated). > > And just as it entered Unstable, it already got 3 bug reports on build > failures: http://bugs.debian.org/src:asterisk-testsuite > > Notable of them is: https://bugs.debian.org/764906 > > Basically asttest fails to build on non-linux platforms due to the use > of (for using e.g. PATH_MAX. > > What should I do on other platforms? > > * Try to rewrite the code to avoid using PATH_MAX (for instance, HURD > does not have this limit), or: > > * If the platform is not Linux, don't build asttest and don't run Lua > tests (is it used for Python ones as well?) > While I'm okay with either option, I think it is important to note that we (a) almost never write tests in Lua any more (in fact, I'd say we actively discourage it), and (b) have been migrating the tests from Lua to Python for some time. I don't think you lose much coverage by going with your second option. -- Matthew Jordan Digium, Inc. | Engineering Manager 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: http://digium.com & http://asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] asterisk-testsuite: linux-only
On Mon, Oct 13, 2014 at 9:44 AM, Tzafrir Cohen wrote: > On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: > > On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen > > > wrote: > > > > > Hi > > > > > > I finally got the asterisk-testsuite accpted into Debian (I know, I > need > > > to get it updated). > > > > > > > A related question ... what's the value of having it packaged at all? > > For the asterisk package to have tests that could be run by the Debian > testing infrastructure. Ah, OK. That makes sense. Thanks. :-) -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] asterisk-testsuite: linux-only
On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: > On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen > wrote: > > > Hi > > > > I finally got the asterisk-testsuite accpted into Debian (I know, I need > > to get it updated). > > > > A related question ... what's the value of having it packaged at all? For the asterisk package to have tests that could be run by the Debian testing infrastructure. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] asterisk-testsuite: linux-only
On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen wrote: > Hi > > I finally got the asterisk-testsuite accpted into Debian (I know, I need > to get it updated). > A related question ... what's the value of having it packaged at all? I could see the value if the test suite was designed in such a way that people could run it against their own deployment to do some validation, but quite far from how it actually works. So, what use cases are you aiming to allow exactly? -- Russell Bryant -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] asterisk-testsuite: linux-only
Hi I finally got the asterisk-testsuite accpted into Debian (I know, I need to get it updated). And just as it entered Unstable, it already got 3 bug reports on build failures: http://bugs.debian.org/src:asterisk-testsuite Notable of them is: https://bugs.debian.org/764906 Basically asttest fails to build on non-linux platforms due to the use of (for using e.g. PATH_MAX. What should I do on other platforms? * Try to rewrite the code to avoid using PATH_MAX (for instance, HURD does not have this limit), or: * If the platform is not Linux, don't build asttest and don't run Lua tests (is it used for Python ones as well?) -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
