Re: [asterisk-dev] tcptls.c
On 11 Apr 2014, at 16:53, Matthew Jordan wrote: > > > > On Fri, Apr 11, 2014 at 1:38 AM, Olle E. Johansson wrote: > Looking at tcptls.c we have a lot of error messages sent to LOG_WARNING and > some stuff sent to the verbose channel that should not be there. Do I need to > go through reviewboard to just change these to LOG_ERROR or can I just fix > this straight into the subversion repo? > > > If you're just cleaning up WARNING/VERBOSE messages (and making certain ones > ERRORs that weren't before, such as some of those ast_verb(0, ...) messages), > I don't think that has to go up to Review Board. > > If there's something about the commit that someone doesn't like, we can > always discuss it on the -dev list :-) No, nothing else. Just changing the default cipher to the null cipher... ;-) Thanks, Matt. /O-- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] tcptls.c
On Fri, Apr 11, 2014 at 1:38 AM, Olle E. Johansson wrote: > Looking at tcptls.c we have a lot of error messages sent to LOG_WARNING > and some stuff sent to the verbose channel that should not be there. Do I > need to go through reviewboard to just change these to LOG_ERROR or can I > just fix this straight into the subversion repo? > > If you're just cleaning up WARNING/VERBOSE messages (and making certain ones ERRORs that weren't before, such as some of those ast_verb(0, ...) messages), I don't think that has to go up to Review Board. If there's something about the commit that someone doesn't like, we can always discuss it on the -dev list :-) -- Matthew Jordan Digium, Inc. | Engineering Manager 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: http://digium.com & http://asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] tcptls.c
Looking at tcptls.c we have a lot of error messages sent to LOG_WARNING and some stuff sent to the verbose channel that should not be there. Do I need to go through reviewboard to just change these to LOG_ERROR or can I just fix this straight into the subversion repo? /O -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
