Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-23 Thread Kevin Harwell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/
---

(Updated Nov. 23, 2013, 11:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 403131


Bugs: ASTERISK-22609
https://issues.asterisk.org/jira/browse/ASTERISK-22609


Repository: Asterisk


Description
---

Created the following AMI commands and corresponding events for res_pjsip:

PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select 
attributes on each.
  Events:
EndpointList - for each endpoint a few attributes
EndpointlistComplete - after all endpoints have been listed

PJSIPShowEndpoint - Provides a detail list of attributes for a specified 
endpoint
  Events:
EndpointDetail - attributes on an endpoint
AorDetail - raised for each AOR on an endpoint
AuthDetail - raised for each associated inbound and outbound auth
TransportDetail - transport attributes
IdentifyDetail - attributes for the identify object associated with the 
endpoint
EndpointDetailComplete - last event raised after all detail events

PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound 
registrations
  Events:
InboundRegistrationDetail - inbound registration attributes for each 
registration
InboundRegistrationDetailComplete - raised after all detail records have 
been listed

PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound 
registrations
  Events:
OutboundRegistrationDetail - outbound registration attributes for each 
registration
OutboundRegistrationDetailComplete - raised after all detail records have 
been listed

PJSIPShowSubscriptions - A detail listing of all subscriptions and their 
attributes
  Events:
SubscriptionDetail - on each subscription detailed attributes
SubscriptionDetailComplete - raised after all detail records have been 
listed


Diffs
-

  branches/12/res/res_pjsip_registrar.c 403083 
  branches/12/res/res_pjsip_pubsub.c 403083 
  branches/12/res/res_pjsip_outbound_registration.c 403083 
  branches/12/res/res_pjsip_mwi.c 403083 
  branches/12/res/res_pjsip_exten_state.c 403083 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 403083 
  branches/12/res/res_pjsip/pjsip_configuration.c 403083 
  branches/12/res/res_pjsip/location.c 403083 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 403083 
  branches/12/res/res_pjsip/config_transport.c 403083 
  branches/12/res/res_pjsip/config_auth.c 403083 
  branches/12/res/res_pjsip.exports.in 403083 
  branches/12/res/res_pjsip.c 403083 
  branches/12/main/utils.c 403083 
  branches/12/main/sorcery.c 403083 
  branches/12/main/acl.c 403083 
  branches/12/include/asterisk/utils.h 403083 
  branches/12/include/asterisk/strings.h 403083 
  branches/12/include/asterisk/sorcery.h 403083 
  branches/12/include/asterisk/res_pjsip_pubsub.h 403083 
  branches/12/include/asterisk/res_pjsip.h 403083 
  branches/12/include/asterisk/acl.h 403083 

Diff: https://reviewboard.asterisk.org/r/2959/diff/


Testing
---

Ran a few manual tests over AMI and observed the output to make sure things 
look correct.  Also wrote some testsuite tests: 
https://reviewboard.asterisk.org/r/2958/


Thanks,

Kevin Harwell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-23 Thread Kevin Harwell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/
---

(Updated Nov. 23, 2013, 10:54 a.m.)


Review request for Asterisk Developers.


Changes
---

Updated based on findings.


Bugs: ASTERISK-22609
https://issues.asterisk.org/jira/browse/ASTERISK-22609


Repository: Asterisk


Description
---

Created the following AMI commands and corresponding events for res_pjsip:

PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select 
attributes on each.
  Events:
EndpointList - for each endpoint a few attributes
EndpointlistComplete - after all endpoints have been listed

PJSIPShowEndpoint - Provides a detail list of attributes for a specified 
endpoint
  Events:
EndpointDetail - attributes on an endpoint
AorDetail - raised for each AOR on an endpoint
AuthDetail - raised for each associated inbound and outbound auth
TransportDetail - transport attributes
IdentifyDetail - attributes for the identify object associated with the 
endpoint
EndpointDetailComplete - last event raised after all detail events

PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound 
registrations
  Events:
InboundRegistrationDetail - inbound registration attributes for each 
registration
InboundRegistrationDetailComplete - raised after all detail records have 
been listed

PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound 
registrations
  Events:
OutboundRegistrationDetail - outbound registration attributes for each 
registration
OutboundRegistrationDetailComplete - raised after all detail records have 
been listed

PJSIPShowSubscriptions - A detail listing of all subscriptions and their 
attributes
  Events:
SubscriptionDetail - on each subscription detailed attributes
SubscriptionDetailComplete - raised after all detail records have been 
listed


Diffs (updated)
-

  branches/12/res/res_pjsip_registrar.c 403083 
  branches/12/res/res_pjsip_pubsub.c 403083 
  branches/12/res/res_pjsip_outbound_registration.c 403083 
  branches/12/res/res_pjsip_mwi.c 403083 
  branches/12/res/res_pjsip_exten_state.c 403083 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 403083 
  branches/12/res/res_pjsip/pjsip_configuration.c 403083 
  branches/12/res/res_pjsip/location.c 403083 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 403083 
  branches/12/res/res_pjsip/config_transport.c 403083 
  branches/12/res/res_pjsip/config_auth.c 403083 
  branches/12/res/res_pjsip.exports.in 403083 
  branches/12/res/res_pjsip.c 403083 
  branches/12/main/utils.c 403083 
  branches/12/main/sorcery.c 403083 
  branches/12/main/acl.c 403083 
  branches/12/include/asterisk/utils.h 403083 
  branches/12/include/asterisk/strings.h 403083 
  branches/12/include/asterisk/sorcery.h 403083 
  branches/12/include/asterisk/res_pjsip_pubsub.h 403083 
  branches/12/include/asterisk/res_pjsip.h 403083 
  branches/12/include/asterisk/acl.h 403083 

Diff: https://reviewboard.asterisk.org/r/2959/diff/


Testing
---

Ran a few manual tests over AMI and observed the output to make sure things 
look correct.  Also wrote some testsuite tests: 
https://reviewboard.asterisk.org/r/2958/


Thanks,

Kevin Harwell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review10267
---


Note that my findings are very minor, and shouldn't hold up shipping this in.

- Matt Jordan


On Nov. 15, 2013, 7:58 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> ---
> 
> (Updated Nov. 15, 2013, 7:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
> https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few 
> select attributes on each.
>   Events:
> EndpointList - for each endpoint a few attributes
> EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified 
> endpoint
>   Events:
> EndpointDetail - attributes on an endpoint
> AorDetail - raised for each AOR on an endpoint
> AuthDetail - raised for each associated inbound and outbound auth
> TransportDetail - transport attributes
> IdentifyDetail - attributes for the identify object associated with the 
> endpoint
> EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound 
> registrations
>   Events:
> InboundRegistrationDetail - inbound registration attributes for each 
> registration
> InboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound 
> registrations
>   Events:
> OutboundRegistrationDetail - outbound registration attributes for each 
> registration
> OutboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their 
> attributes
>   Events:
> SubscriptionDetail - on each subscription detailed attributes
> SubscriptionDetailComplete - raised after all detail records have been 
> listed
> 
> 
> Diffs
> -
> 
>   branches/12/res/res_pjsip_registrar.c 402377 
>   branches/12/res/res_pjsip_pubsub.c 402377 
>   branches/12/res/res_pjsip_outbound_registration.c 402377 
>   branches/12/res/res_pjsip_mwi.c 402377 
>   branches/12/res/res_pjsip_exten_state.c 402377 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 402377 
>   branches/12/res/res_pjsip/pjsip_configuration.c 402377 
>   branches/12/res/res_pjsip/location.c 402377 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 402377 
>   branches/12/res/res_pjsip/config_transport.c 402377 
>   branches/12/res/res_pjsip/config_auth.c 402377 
>   branches/12/res/res_pjsip.exports.in 402377 
>   branches/12/res/res_pjsip.c 402377 
>   branches/12/main/utils.c 402377 
>   branches/12/main/sorcery.c 402377 
>   branches/12/main/acl.c 402377 
>   branches/12/include/asterisk/utils.h 402377 
>   branches/12/include/asterisk/strings.h 402377 
>   branches/12/include/asterisk/sorcery.h 402377 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 402377 
>   branches/12/include/asterisk/res_pjsip.h 402377 
>   branches/12/include/asterisk/acl.h 402377 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> ---
> 
> Ran a few manual tests over AMI and observed the output to make sure things 
> look correct.  Also wrote some testsuite tests: 
> https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review10256
---



branches/12/include/asterisk/strings.h


When you commit this, please commit the whitespace changes in a separate 
commit from the code changes. Otherwise, the subversion history gets wonky.

You may want to disable auto-whitespace stripping from your editor and only 
run it on new files.



branches/12/include/asterisk/strings.h


Put a \since 12.0.0 doxygen tag on here



branches/12/include/asterisk/strings.h


And put the same \since 12 on here as well



branches/12/res/res_pjsip.c


If you felt like it, you could collapse this down to:

if (i->format_ami && ((res = i->format_ami...)))

But that's up to you.



branches/12/res/res_pjsip.exports.in


Is there any reason why we aren't exporting all ast_sip* symbols?



branches/12/res/res_pjsip_pubsub.c


Blobs


- Matt Jordan


On Nov. 15, 2013, 7:58 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> ---
> 
> (Updated Nov. 15, 2013, 7:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
> https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few 
> select attributes on each.
>   Events:
> EndpointList - for each endpoint a few attributes
> EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified 
> endpoint
>   Events:
> EndpointDetail - attributes on an endpoint
> AorDetail - raised for each AOR on an endpoint
> AuthDetail - raised for each associated inbound and outbound auth
> TransportDetail - transport attributes
> IdentifyDetail - attributes for the identify object associated with the 
> endpoint
> EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound 
> registrations
>   Events:
> InboundRegistrationDetail - inbound registration attributes for each 
> registration
> InboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound 
> registrations
>   Events:
> OutboundRegistrationDetail - outbound registration attributes for each 
> registration
> OutboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their 
> attributes
>   Events:
> SubscriptionDetail - on each subscription detailed attributes
> SubscriptionDetailComplete - raised after all detail records have been 
> listed
> 
> 
> Diffs
> -
> 
>   branches/12/res/res_pjsip_registrar.c 402377 
>   branches/12/res/res_pjsip_pubsub.c 402377 
>   branches/12/res/res_pjsip_outbound_registration.c 402377 
>   branches/12/res/res_pjsip_mwi.c 402377 
>   branches/12/res/res_pjsip_exten_state.c 402377 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 402377 
>   branches/12/res/res_pjsip/pjsip_configuration.c 402377 
>   branches/12/res/res_pjsip/location.c 402377 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 402377 
>   branches/12/res/res_pjsip/config_transport.c 402377 
>   branches/12/res/res_pjsip/config_auth.c 402377 
>   branches/12/res/res_pjsip.exports.in 402377 
>   branches/12/res/res_pjsip.c 402377 
>   branches/12/main/utils.c 402377 
>   branches/12/main/sorcery.c 402377 
>   branches/12/main/acl.c 402377 
>   branches/12/include/asterisk/utils.h 402377 
>   branches/12/include/asterisk/strings.h 402377 
>   branches/12/include/asterisk/sorcery.h 402377 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 402377 
>   branches/12/include/asterisk/res_pjsip.h 402377 
>   branches/12/include/asterisk/acl.h 402377 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> ---
> 
> Ran a few manual tests over AMI and observed the output to make sure things 
> look correct.  Also wrote some testsuite tests: 
> https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
>

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread Mark Michelson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review10237
---

Ship it!



branches/12/res/res_pjsip_pubsub.c


Introduced a couple of red blobs here.


- Mark Michelson


On Nov. 15, 2013, 7:58 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> ---
> 
> (Updated Nov. 15, 2013, 7:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
> https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few 
> select attributes on each.
>   Events:
> EndpointList - for each endpoint a few attributes
> EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified 
> endpoint
>   Events:
> EndpointDetail - attributes on an endpoint
> AorDetail - raised for each AOR on an endpoint
> AuthDetail - raised for each associated inbound and outbound auth
> TransportDetail - transport attributes
> IdentifyDetail - attributes for the identify object associated with the 
> endpoint
> EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound 
> registrations
>   Events:
> InboundRegistrationDetail - inbound registration attributes for each 
> registration
> InboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound 
> registrations
>   Events:
> OutboundRegistrationDetail - outbound registration attributes for each 
> registration
> OutboundRegistrationDetailComplete - raised after all detail records have 
> been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their 
> attributes
>   Events:
> SubscriptionDetail - on each subscription detailed attributes
> SubscriptionDetailComplete - raised after all detail records have been 
> listed
> 
> 
> Diffs
> -
> 
>   branches/12/res/res_pjsip_registrar.c 402377 
>   branches/12/res/res_pjsip_pubsub.c 402377 
>   branches/12/res/res_pjsip_outbound_registration.c 402377 
>   branches/12/res/res_pjsip_mwi.c 402377 
>   branches/12/res/res_pjsip_exten_state.c 402377 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 402377 
>   branches/12/res/res_pjsip/pjsip_configuration.c 402377 
>   branches/12/res/res_pjsip/location.c 402377 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 402377 
>   branches/12/res/res_pjsip/config_transport.c 402377 
>   branches/12/res/res_pjsip/config_auth.c 402377 
>   branches/12/res/res_pjsip.exports.in 402377 
>   branches/12/res/res_pjsip.c 402377 
>   branches/12/main/utils.c 402377 
>   branches/12/main/sorcery.c 402377 
>   branches/12/main/acl.c 402377 
>   branches/12/include/asterisk/utils.h 402377 
>   branches/12/include/asterisk/strings.h 402377 
>   branches/12/include/asterisk/sorcery.h 402377 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 402377 
>   branches/12/include/asterisk/res_pjsip.h 402377 
>   branches/12/include/asterisk/acl.h 402377 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> ---
> 
> Ran a few manual tests over AMI and observed the output to make sure things 
> look correct.  Also wrote some testsuite tests: 
> https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread George Joseph 
On Thu, Nov 21, 2013 at 7:25 AM, Joshua Colp  wrote:

> George Joseph wrote:
>
>> Just FYI...   I've got a whole bunch of pjsip cli stuff waiting on this
>> patch to be committed.   Any chance of this happening this week?
>>
>
> It'll get reviewed today and pending any other findings arising it'll go
> in shortly.
>
> If possible you could just throw your stuff up for review too and mark it
> as dependent on the AMI commands/events review (you can do that in
> Reviewboard now! yay!).
>
> Cheers,
>
> Yeah, I can attempt that this afternoon.  There's no way it would compile
even with 2959 applied first because of some workarounds I had to do.  It
would be a start though.
-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread Joshua Colp 

George Joseph wrote:

Just FYI...   I've got a whole bunch of pjsip cli stuff waiting on this
patch to be committed.   Any chance of this happening this week?


It'll get reviewed today and pending any other findings arising it'll go 
in shortly.


If possible you could just throw your stuff up for review too and mark 
it as dependent on the AMI commands/events review (you can do that in 
Reviewboard now! yay!).


Cheers,

--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at:  www.digium.com  & www.asterisk.org

--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
  http://lists.digium.com/mailman/listinfo/asterisk-dev