Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- (Updated Jan. 16, 2014, 2:14 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Bugs: ASTERISK-23062 https://issues.asterisk.org/jira/browse/ASTERISK-23062 Repository: Asterisk Description --- If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set. This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup. Modified the code to check and schedule all registered contacts at startup. Diffs - branches/12/res/res_pjsip/pjsip_options.c 405361 Diff: https://reviewboard.asterisk.org/r/3124/diff/ Testing --- Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/#review10577 --- Ship it! Besides my wish to kill excessive RAII_VAR usage this looks good. branches/12/res/res_pjsip/pjsip_options.c https://reviewboard.asterisk.org/r/3124/#comment20039 Let's kill this usage of RAII_VAR whilst you are here. branches/12/res/res_pjsip/pjsip_options.c https://reviewboard.asterisk.org/r/3124/#comment20040 Same here, let's kill it. - Joshua Colp On Jan. 13, 2014, 6:33 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- (Updated Jan. 13, 2014, 6:33 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23062 https://issues.asterisk.org/jira/browse/ASTERISK-23062 Repository: Asterisk Description --- If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set. This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup. Modified the code to check and schedule all registered contacts at startup. Diffs - branches/12/res/res_pjsip/pjsip_options.c 405361 Diff: https://reviewboard.asterisk.org/r/3124/diff/ Testing --- Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- (Updated Jan. 13, 2014, 2:48 p.m.) Review request for Asterisk Developers. Changes --- Changed a couple of variables to not use RAII_VAR. Also fixed a bug on reload where qualifies were being added, but not being removed from the scheduler. This resulted the existance of multiple scheduled qualifies for a contact. Bugs: ASTERISK-23062 https://issues.asterisk.org/jira/browse/ASTERISK-23062 Repository: Asterisk Description --- If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set. This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup. Modified the code to check and schedule all registered contacts at startup. Diffs (updated) - branches/12/res/res_pjsip/pjsip_options.c 405361 Diff: https://reviewboard.asterisk.org/r/3124/diff/ Testing --- Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3124: res_pjsip: AOR option qualify_frequency not respected on startup
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/#review10579 --- Ship it! Ship It! - Joshua Colp On Jan. 13, 2014, 8:48 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3124/ --- (Updated Jan. 13, 2014, 8:48 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23062 https://issues.asterisk.org/jira/browse/ASTERISK-23062 Repository: Asterisk Description --- If an endpoint had previously dynamically registered a contact and the contact information was successfully stored in astdb then upon restart the qualify notifications would not be sent out if the qualify_frequency was set. This was due to the fact that only permanent contacts were being checked and scheduled for qualifies on startup. Modified the code to check and schedule all registered contacts at startup. Diffs - branches/12/res/res_pjsip/pjsip_options.c 405361 Diff: https://reviewboard.asterisk.org/r/3124/diff/ Testing --- Using cli commands noted that qualifies are now being sent out for dynamically registered contacts that had been stored in the astdb and loaded at system start. Thanks, Kevin Harwell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
