Re: [asterisk-dev] [Code Review] 3391: ARI: Don't complain about missing ARI users when we aren't enabled

2014-03-25 Thread Joshua Colp

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3391/#review11368
---

Ship it!


Ship It!

- Joshua Colp


On March 25, 2014, 11:33 a.m., Sean Bright wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3391/
 ---
 
 (Updated March 25, 2014, 11:33 a.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Repository: Asterisk
 
 
 Description
 ---
 
 Currently, if ARI is not enabled it will still complain that there are no 
 configured users.  This patch checks to see if ARI is enabled before logging 
 and error or iterating the container to validate the users.
 
 
 Diffs
 -
 
   /branches/12/res/ari/config.c 411084 
 
 Diff: https://reviewboard.asterisk.org/r/3391/diff/
 
 
 Testing
 ---
 
 Basic runtime tests with ARI enabled and disabled.
 
 
 Thanks,
 
 Sean Bright
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3391: ARI: Don't complain about missing ARI users when we aren't enabled

2014-03-25 Thread Sean Bright

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3391/
---

(Updated March 25, 2014, 1:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 411173


Repository: Asterisk


Description
---

Currently, if ARI is not enabled it will still complain that there are no 
configured users.  This patch checks to see if ARI is enabled before logging 
and error or iterating the container to validate the users.


Diffs
-

  /branches/12/res/ari/config.c 411084 

Diff: https://reviewboard.asterisk.org/r/3391/diff/


Testing
---

Basic runtime tests with ARI enabled and disabled.


Thanks,

Sean Bright

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev