Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-08-14 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated Aug. 14, 2014, 3:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 5441


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs
-

  /asterisk/trunk/tests/apps/tests.yaml 5315 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-08-12 Thread Matt Jordan

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/#review13083
---



/asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml
https://reviewboard.asterisk.org/r/3795/#comment23526

This won't work on Asterisk 11, as that version doesn't have a DialEnd 
event.

I'll clean this up on commit.


- Matt Jordan


On July 25, 2014, 2:51 p.m., Tyler Austin Cambron wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3795/
 ---
 
 (Updated July 25, 2014, 2:51 p.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Bugs: Asterisk-24028
 https://issues.asterisk.org/jira/browse/Asterisk-24028
 
 
 Repository: testsuite
 
 
 Description
 ---
 
 This is a test that verifies that the recording feature of MixMonitor is 
 functioning properly. The test uses the SoundChecker pluggable module, which 
 is currently still up for review, so the test could change depending on 
 changes with the pluggable module. Assuming the pluggable module is working 
 correctly, this test uses the pluggable module to verify that audio has been 
 recorded from a local channel call and that the recording has correctly 
 created a sound file that contains the full recording. The pluggable module 
 will appear in the diff, specifically to show how the test uses the pluggable 
 module. Please do not review the module on this thread, as it is being 
 reviewed in another thread posted by cwolfe.
 
 
 Diffs
 -
 
   /asterisk/trunk/tests/apps/tests.yaml 5315 
   /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
 PRE-CREATION 
   /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 
 
 Diff: https://reviewboard.asterisk.org/r/3795/diff/
 
 
 Testing
 ---
 
 The test begins by executing dialplan, where MixMonitor is started and a 
 playback of tt-monkeys begins. MixMonitor records this audio and stores it 
 into a file called theRecording.wav. When the recording is finished, the 
 dialplan executes a hangup, which triggers (through the yaml file) a size 
 check and energy check on the newly created file, which is done using the 
 SoundChecker pluggable module. The test logs confirm that a call is made, the 
 audio starts and is recorded, the file is saved, and then the pluggable 
 module verifies that the file has the correct size and energy, showing that 
 there is actual audio in the file. I also went and found the file manually, 
 and the recording fully played back tt-monkeys.
 
 
 Thanks,
 
 Tyler Austin Cambron
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-08-01 Thread opticron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/#review12957
---

Ship it!


Ship It!

- opticron


On July 25, 2014, 2:51 p.m., Tyler Austin Cambron wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3795/
 ---
 
 (Updated July 25, 2014, 2:51 p.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Bugs: Asterisk-24028
 https://issues.asterisk.org/jira/browse/Asterisk-24028
 
 
 Repository: testsuite
 
 
 Description
 ---
 
 This is a test that verifies that the recording feature of MixMonitor is 
 functioning properly. The test uses the SoundChecker pluggable module, which 
 is currently still up for review, so the test could change depending on 
 changes with the pluggable module. Assuming the pluggable module is working 
 correctly, this test uses the pluggable module to verify that audio has been 
 recorded from a local channel call and that the recording has correctly 
 created a sound file that contains the full recording. The pluggable module 
 will appear in the diff, specifically to show how the test uses the pluggable 
 module. Please do not review the module on this thread, as it is being 
 reviewed in another thread posted by cwolfe.
 
 
 Diffs
 -
 
   /asterisk/trunk/tests/apps/tests.yaml 5315 
   /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
 PRE-CREATION 
   /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 
 
 Diff: https://reviewboard.asterisk.org/r/3795/diff/
 
 
 Testing
 ---
 
 The test begins by executing dialplan, where MixMonitor is started and a 
 playback of tt-monkeys begins. MixMonitor records this audio and stores it 
 into a file called theRecording.wav. When the recording is finished, the 
 dialplan executes a hangup, which triggers (through the yaml file) a size 
 check and energy check on the newly created file, which is done using the 
 SoundChecker pluggable module. The test logs confirm that a call is made, the 
 audio starts and is recorded, the file is saved, and then the pluggable 
 module verifies that the file has the correct size and energy, showing that 
 there is actual audio in the file. I also went and found the file manually, 
 and the recording fully played back tt-monkeys.
 
 
 Thanks,
 
 Tyler Austin Cambron
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-25 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 25, 2014, 2:50 p.m.)


Review request for Asterisk Developers.


Changes
---

Updated test-config to work with updated pluggable module.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs (updated)
-

  /asterisk/trunk/tests/apps/tests.yaml 5315 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-25 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 25, 2014, 2:51 p.m.)


Review request for Asterisk Developers.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs
-

  /asterisk/trunk/tests/apps/tests.yaml 5315 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5315 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-24 Thread Matt Jordan

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/#review12849
---



/asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py
https://reviewboard.asterisk.org/r/3795/#comment23189

Add a pre-amble to this file that includes the copyright notice and your 
name as the author:


Copyright (C) 2014, Digium, Inc.
Your name e-mail address

This program is free software, distributed under the terms of
the GNU General Public License Version 2.




/asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py
https://reviewboard.asterisk.org/r/3795/#comment23190

Add a pydoc comment documenting what this function does



/asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml
https://reviewboard.asterisk.org/r/3795/#comment23191

For your description, provide a bit more detail on how the test works. For 
example, how does the MixMonitor get triggered? What constitutes a successful 
test versus a failed test?



/asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml
https://reviewboard.asterisk.org/r/3795/#comment23192

Remove this. You already are checking for DialEnd to trigger your 
start_mix/record operation.



/asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml
https://reviewboard.asterisk.org/r/3795/#comment23193

Add a dependency on app_mixmonitor:

asterisk: app_mixmonitor


- Matt Jordan


On July 22, 2014, 3:02 p.m., Tyler Austin Cambron wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviewboard.asterisk.org/r/3795/
 ---
 
 (Updated July 22, 2014, 3:02 p.m.)
 
 
 Review request for Asterisk Developers.
 
 
 Bugs: Asterisk-24028
 https://issues.asterisk.org/jira/browse/Asterisk-24028
 
 
 Repository: testsuite
 
 
 Description
 ---
 
 This is a test that verifies that the recording feature of MixMonitor is 
 functioning properly. The test uses the SoundChecker pluggable module, which 
 is currently still up for review, so the test could change depending on 
 changes with the pluggable module. Assuming the pluggable module is working 
 correctly, this test uses the pluggable module to verify that audio has been 
 recorded from a local channel call and that the recording has correctly 
 created a sound file that contains the full recording. The pluggable module 
 will appear in the diff, specifically to show how the test uses the pluggable 
 module. Please do not review the module on this thread, as it is being 
 reviewed in another thread posted by cwolfe.
 
 
 Diffs
 -
 
   /asterisk/trunk/tests/apps/tests.yaml 5297 
   /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
   /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
 PRE-CREATION 
   /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 
 
 Diff: https://reviewboard.asterisk.org/r/3795/diff/
 
 
 Testing
 ---
 
 The test begins by executing dialplan, where MixMonitor is started and a 
 playback of tt-monkeys begins. MixMonitor records this audio and stores it 
 into a file called theRecording.wav. When the recording is finished, the 
 dialplan executes a hangup, which triggers (through the yaml file) a size 
 check and energy check on the newly created file, which is done using the 
 SoundChecker pluggable module. The test logs confirm that a call is made, the 
 audio starts and is recorded, the file is saved, and then the pluggable 
 module verifies that the file has the correct size and energy, showing that 
 there is actual audio in the file. I also went and found the file manually, 
 and the recording fully played back tt-monkeys.
 
 
 Thanks,
 
 Tyler Austin Cambron
 


-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-24 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 24, 2014, 9:46 a.m.)


Review request for Asterisk Developers.


Changes
---

Added a pre-amble and a pydoc comment for my python method, updated my 
description in the test-config, removed an unnecessary headermatch, and added 
the app dependency for mixmonitor.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs (updated)
-

  /asterisk/trunk/tests/apps/tests.yaml 5305 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5305 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-22 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 22, 2014, 3:01 p.m.)


Review request for Asterisk Developers.


Changes
---

Corrected test to use the MixMonitor AMI command rather than call MixMonitor 
through the dialplan by adding a small bit of python code. The test-config.yaml 
has been updated to work with updates to the SoundChecker pluggable module. 
Also updated the size to check for in the test-config to be slightly more 
accurate.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs (updated)
-

  /asterisk/trunk/tests/apps/tests.yaml 5297 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-22 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 22, 2014, 3:02 p.m.)


Review request for Asterisk Developers.


Changes
---

Updated the Depends On section to refer to the pluggable module that is 
currently in review.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs
-

  /asterisk/trunk/tests/apps/tests.yaml 5297 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-07-15 Thread Tyler Austin Cambron

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
---

(Updated July 15, 2014, 1:27 p.m.)


Review request for Asterisk Developers.


Changes
---

Updated minversion.


Bugs: Asterisk-24028
https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
---

This is a test that verifies that the recording feature of MixMonitor is 
functioning properly. The test uses the SoundChecker pluggable module, which is 
currently still up for review, so the test could change depending on changes 
with the pluggable module. Assuming the pluggable module is working correctly, 
this test uses the pluggable module to verify that audio has been recorded from 
a local channel call and that the recording has correctly created a sound file 
that contains the full recording. The pluggable module will appear in the diff, 
specifically to show how the test uses the pluggable module. Please do not 
review the module on this thread, as it is being reviewed in another thread 
posted by cwolfe.


Diffs (updated)
-

  /asterisk/trunk/tests/apps/tests.yaml 5242 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf 
PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5242 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
---

The test begins by executing dialplan, where MixMonitor is started and a 
playback of tt-monkeys begins. MixMonitor records this audio and stores it into 
a file called theRecording.wav. When the recording is finished, the dialplan 
executes a hangup, which triggers (through the yaml file) a size check and 
energy check on the newly created file, which is done using the SoundChecker 
pluggable module. The test logs confirm that a call is made, the audio starts 
and is recorded, the file is saved, and then the pluggable module verifies that 
the file has the correct size and energy, showing that there is actual audio in 
the file. I also went and found the file manually, and the recording fully 
played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev