Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/ --- (Updated March 26, 2015, 5:16 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 433495 Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881 https://issues.asterisk.org/jira/browse/ASTERISK-24142 https://issues.asterisk.org/jira/browse/ASTERISK-24683 https://issues.asterisk.org/jira/browse/ASTERISK-24805 https://issues.asterisk.org/jira/browse/ASTERISK-24881 Repository: Asterisk Description --- We've had many issues related to core stop now or core restart now causing segmentation faults. The solution to this is to change almost everything to use ast_register_cleanup. Exceptions: CDR: Flush records. res_musiconhold: Kill external applications. AstDB: Close the DB. canary_exit: Kill canary process. Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required. For this reason the change is across the board. Diffs - /branches/11/main/xmldoc.c 432991 /branches/11/main/utils.c 432991 /branches/11/main/udptl.c 432991 /branches/11/main/translate.c 432991 /branches/11/main/timing.c 432991 /branches/11/main/threadstorage.c 432991 /branches/11/main/test.c 432991 /branches/11/main/taskprocessor.c 432991 /branches/11/main/stun.c 432991 /branches/11/main/pbx.c 432991 /branches/11/main/named_acl.c 432991 /branches/11/main/message.c 432991 /branches/11/main/manager.c 432991 /branches/11/main/indications.c 432991 /branches/11/main/image.c 432991 /branches/11/main/http.c 432991 /branches/11/main/format.c 432991 /branches/11/main/file.c 432991 /branches/11/main/features.c 432991 /branches/11/main/event.c 432991 /branches/11/main/dnsmgr.c 432991 /branches/11/main/data.c 432991 /branches/11/main/config.c 432991 /branches/11/main/cli.c 432991 /branches/11/main/channel.c 432991 /branches/11/main/cel.c 432991 /branches/11/main/ccss.c 432991 /branches/11/main/astobj2.c 432991 /branches/11/main/astmm.c 432991 /branches/11/main/astfd.c 432991 /branches/11/main/asterisk.c 432991 /branches/11/main/aoc.c 432991 /branches/11/include/asterisk.h 432991 Diff: https://reviewboard.asterisk.org/r/4500/diff/ Testing --- Compiled, started and ran 'core stop now'. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14757 --- Ship it! Nothing stood out as a problem. Time will tell if there are subtle interactions between modules for the atexit and cleanup versions when doing a stop/restart now. - rmudgett On March 15, 2015, 5:33 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/ --- (Updated March 15, 2015, 5:33 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881 https://issues.asterisk.org/jira/browse/ASTERISK-24142 https://issues.asterisk.org/jira/browse/ASTERISK-24683 https://issues.asterisk.org/jira/browse/ASTERISK-24805 https://issues.asterisk.org/jira/browse/ASTERISK-24881 Repository: Asterisk Description --- We've had many issues related to core stop now or core restart now causing segmentation faults. The solution to this is to change almost everything to use ast_register_cleanup. Exceptions: CDR: Flush records. res_musiconhold: Kill external applications. AstDB: Close the DB. canary_exit: Kill canary process. Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required. For this reason the change is across the board. Diffs - /branches/11/main/xmldoc.c 432991 /branches/11/main/utils.c 432991 /branches/11/main/udptl.c 432991 /branches/11/main/translate.c 432991 /branches/11/main/timing.c 432991 /branches/11/main/threadstorage.c 432991 /branches/11/main/test.c 432991 /branches/11/main/taskprocessor.c 432991 /branches/11/main/stun.c 432991 /branches/11/main/pbx.c 432991 /branches/11/main/named_acl.c 432991 /branches/11/main/message.c 432991 /branches/11/main/manager.c 432991 /branches/11/main/indications.c 432991 /branches/11/main/image.c 432991 /branches/11/main/http.c 432991 /branches/11/main/format.c 432991 /branches/11/main/file.c 432991 /branches/11/main/features.c 432991 /branches/11/main/event.c 432991 /branches/11/main/dnsmgr.c 432991 /branches/11/main/data.c 432991 /branches/11/main/config.c 432991 /branches/11/main/cli.c 432991 /branches/11/main/channel.c 432991 /branches/11/main/cel.c 432991 /branches/11/main/ccss.c 432991 /branches/11/main/astobj2.c 432991 /branches/11/main/astmm.c 432991 /branches/11/main/astfd.c 432991 /branches/11/main/asterisk.c 432991 /branches/11/main/aoc.c 432991 /branches/11/include/asterisk.h 432991 Diff: https://reviewboard.asterisk.org/r/4500/diff/ Testing --- Compiled, started and ran 'core stop now'. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14750 --- Ship it! I'm in the same boat as Matt on this one, but I'll go ahead and tick the Ship it! box. - Mark Michelson On March 15, 2015, 10:33 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/ --- (Updated March 15, 2015, 10:33 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881 https://issues.asterisk.org/jira/browse/ASTERISK-24142 https://issues.asterisk.org/jira/browse/ASTERISK-24683 https://issues.asterisk.org/jira/browse/ASTERISK-24805 https://issues.asterisk.org/jira/browse/ASTERISK-24881 Repository: Asterisk Description --- We've had many issues related to core stop now or core restart now causing segmentation faults. The solution to this is to change almost everything to use ast_register_cleanup. Exceptions: CDR: Flush records. res_musiconhold: Kill external applications. AstDB: Close the DB. canary_exit: Kill canary process. Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required. For this reason the change is across the board. Diffs - /branches/11/main/xmldoc.c 432991 /branches/11/main/utils.c 432991 /branches/11/main/udptl.c 432991 /branches/11/main/translate.c 432991 /branches/11/main/timing.c 432991 /branches/11/main/threadstorage.c 432991 /branches/11/main/test.c 432991 /branches/11/main/taskprocessor.c 432991 /branches/11/main/stun.c 432991 /branches/11/main/pbx.c 432991 /branches/11/main/named_acl.c 432991 /branches/11/main/message.c 432991 /branches/11/main/manager.c 432991 /branches/11/main/indications.c 432991 /branches/11/main/image.c 432991 /branches/11/main/http.c 432991 /branches/11/main/format.c 432991 /branches/11/main/file.c 432991 /branches/11/main/features.c 432991 /branches/11/main/event.c 432991 /branches/11/main/dnsmgr.c 432991 /branches/11/main/data.c 432991 /branches/11/main/config.c 432991 /branches/11/main/cli.c 432991 /branches/11/main/channel.c 432991 /branches/11/main/cel.c 432991 /branches/11/main/ccss.c 432991 /branches/11/main/astobj2.c 432991 /branches/11/main/astmm.c 432991 /branches/11/main/astfd.c 432991 /branches/11/main/asterisk.c 432991 /branches/11/main/aoc.c 432991 /branches/11/include/asterisk.h 432991 Diff: https://reviewboard.asterisk.org/r/4500/diff/ Testing --- Compiled, started and ran 'core stop now'. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14754 --- Thanks for taking a look. I plan to give this review a couple days after 2 ship it's, it will not be rushed. Also this review won't be committed until r4501 (the version 13 patch) has approval. - Corey Farrell On March 15, 2015, 6:33 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/ --- (Updated March 15, 2015, 6:33 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881 https://issues.asterisk.org/jira/browse/ASTERISK-24142 https://issues.asterisk.org/jira/browse/ASTERISK-24683 https://issues.asterisk.org/jira/browse/ASTERISK-24805 https://issues.asterisk.org/jira/browse/ASTERISK-24881 Repository: Asterisk Description --- We've had many issues related to core stop now or core restart now causing segmentation faults. The solution to this is to change almost everything to use ast_register_cleanup. Exceptions: CDR: Flush records. res_musiconhold: Kill external applications. AstDB: Close the DB. canary_exit: Kill canary process. Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required. For this reason the change is across the board. Diffs - /branches/11/main/xmldoc.c 432991 /branches/11/main/utils.c 432991 /branches/11/main/udptl.c 432991 /branches/11/main/translate.c 432991 /branches/11/main/timing.c 432991 /branches/11/main/threadstorage.c 432991 /branches/11/main/test.c 432991 /branches/11/main/taskprocessor.c 432991 /branches/11/main/stun.c 432991 /branches/11/main/pbx.c 432991 /branches/11/main/named_acl.c 432991 /branches/11/main/message.c 432991 /branches/11/main/manager.c 432991 /branches/11/main/indications.c 432991 /branches/11/main/image.c 432991 /branches/11/main/http.c 432991 /branches/11/main/format.c 432991 /branches/11/main/file.c 432991 /branches/11/main/features.c 432991 /branches/11/main/event.c 432991 /branches/11/main/dnsmgr.c 432991 /branches/11/main/data.c 432991 /branches/11/main/config.c 432991 /branches/11/main/cli.c 432991 /branches/11/main/channel.c 432991 /branches/11/main/cel.c 432991 /branches/11/main/ccss.c 432991 /branches/11/main/astobj2.c 432991 /branches/11/main/astmm.c 432991 /branches/11/main/astfd.c 432991 /branches/11/main/asterisk.c 432991 /branches/11/main/aoc.c 432991 /branches/11/include/asterisk.h 432991 Diff: https://reviewboard.asterisk.org/r/4500/diff/ Testing --- Compiled, started and ran 'core stop now'. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4500: ast_register_atexit should only be used when absolutely needed (11 version)
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/#review14747 --- I looked through everything, and it all made sense to me - but I think it might be good to have another pair of eyes on this as well. I'll ping rmudgett and see if he wouldn't mind taking a look at it. - Matt Jordan On March 15, 2015, 5:33 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4500/ --- (Updated March 15, 2015, 5:33 a.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24142, ASTERISK-24683, ASTERISK-24805, and ASTERISK-24881 https://issues.asterisk.org/jira/browse/ASTERISK-24142 https://issues.asterisk.org/jira/browse/ASTERISK-24683 https://issues.asterisk.org/jira/browse/ASTERISK-24805 https://issues.asterisk.org/jira/browse/ASTERISK-24881 Repository: Asterisk Description --- We've had many issues related to core stop now or core restart now causing segmentation faults. The solution to this is to change almost everything to use ast_register_cleanup. Exceptions: CDR: Flush records. res_musiconhold: Kill external applications. AstDB: Close the DB. canary_exit: Kill canary process. Although some changes from ast_register_atexit to ast_register_cleanup are not strictly necessary, the point is for nothing to use ast_register_atexit except where required. For this reason the change is across the board. Diffs - /branches/11/main/xmldoc.c 432991 /branches/11/main/utils.c 432991 /branches/11/main/udptl.c 432991 /branches/11/main/translate.c 432991 /branches/11/main/timing.c 432991 /branches/11/main/threadstorage.c 432991 /branches/11/main/test.c 432991 /branches/11/main/taskprocessor.c 432991 /branches/11/main/stun.c 432991 /branches/11/main/pbx.c 432991 /branches/11/main/named_acl.c 432991 /branches/11/main/message.c 432991 /branches/11/main/manager.c 432991 /branches/11/main/indications.c 432991 /branches/11/main/image.c 432991 /branches/11/main/http.c 432991 /branches/11/main/format.c 432991 /branches/11/main/file.c 432991 /branches/11/main/features.c 432991 /branches/11/main/event.c 432991 /branches/11/main/dnsmgr.c 432991 /branches/11/main/data.c 432991 /branches/11/main/config.c 432991 /branches/11/main/cli.c 432991 /branches/11/main/channel.c 432991 /branches/11/main/cel.c 432991 /branches/11/main/ccss.c 432991 /branches/11/main/astobj2.c 432991 /branches/11/main/astmm.c 432991 /branches/11/main/astfd.c 432991 /branches/11/main/asterisk.c 432991 /branches/11/main/aoc.c 432991 /branches/11/include/asterisk.h 432991 Diff: https://reviewboard.asterisk.org/r/4500/diff/ Testing --- Compiled, started and ran 'core stop now'. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
