Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-08 Thread Joshua Colp 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15130
---

Ship it!



branches/13/CHANGES


That isn't quite what the CLI command does. It shows both the global and 
system configuration settings.


Remember to update your description/testing if you make changes that render 
them, well, inaccurate.

- Joshua Colp


On April 7, 2015, 10:35 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 10:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/include/res_pjsip_private.h 434150 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/res/res_pjsip.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Olle E Johansson 


> On April 7, 2015, 9:55 p.m., Olle E Johansson wrote:
> > "global" is used for global variabels. Other CLI commands have "show 
> > settings" - can't we reuse the same with some extra options for system?
> 
> rmudgett wrote:
> Where are you getting global variables from the command?
> 
> "pjsip show global" gives the settings for the pjsip.conf [global] 
> section.
> 
> The command seems aptly named.
> 
> Olle E Johansson wrote:
> "core show global" has for a long time been used to show global 
> variables. For settings we've used "show settings both in core and in SIP - 
> maybe other modules. 
> 
> If we are going to use "global" for something else, then it will be 
> confusing. We only have a "global" section previously in the dialplan - in 
> other modules it's mostly called "general".
> 
> But if you already broke this, I rest my case. Just wanted to point out 
> that I feel it's strange.
> 
> Kevin Harwell wrote:
> I tend to agree with both opinions, but since consistency is a good thing 
> and doing a quick survey of some other commands most seem to use the "show 
> settings". Also it allowed me to combine the two commands into one: pjsip 
> show settings.

Thank you Kevin. Consistency helps keeping the learning curve down.


- Olle E


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---


On April 8, 2015, 12:35 a.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 8, 2015, 12:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/include/res_pjsip_private.h 434150 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/res/res_pjsip.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---

(Updated April 7, 2015, 5:35 p.m.)


Review request for Asterisk Developers.


Changes
---

Combined the two commands into a single one: 'pjsip show settings'


Bugs: ASTERISK-24918
https://issues.asterisk.org/jira/browse/ASTERISK-24918


Repository: Asterisk


Description
---

Added two new CLI commands for res_pjsip global and system configuration 
settings:

pjsip show global
pjsip show system


Diffs (updated)
-

  branches/13/res/res_pjsip/include/res_pjsip_private.h 434150 
  branches/13/res/res_pjsip/config_system.c 434150 
  branches/13/res/res_pjsip/config_global.c 434150 
  branches/13/res/res_pjsip.c 434150 
  branches/13/CHANGES 434150 

Diff: https://reviewboard.asterisk.org/r/4597/diff/


Testing
---

Ran the commands and checked output. Changed some options and reloaded and made 
sure global settings changed, but system ones did not. Changed some settings 
again and restarted and made sure both global and system changes too effect. 
Also removed the sections completely from the pjsip.conf file and made sure the 
defaults were shown.


Thanks,

Kevin Harwell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell 


> On April 7, 2015, 1:04 p.m., Mark Michelson wrote:
> > branches/13/res/res_pjsip/config_system.c, lines 149-155
> > 
> >
> > This should be impossible to happen since default system configuration 
> > should automatically get set on start-up if no system section was present 
> > in pjsip.conf. If default system configuration setup on startup fails, then 
> > res_pjsip.so should fail to load.
> > 
> > I think an assertion here that cfg is non-NULL would do the trick 
> > instead of trying again to create default configuration settings

If the system settings are not specified in the config file no default object 
exist, but has to be created from the specified system defaults. Each time 
sorcery allocs an object it creates it and sets its fields to the default 
values. At initialization when no system settings exist an object is created 
with defaults and then applied, but then gets deleted. So in order to access 
the default object again it needs to be re-created.

An alternative would be to keep a global defaults object around, but I don't 
see a reason to maintain that pointer just for CLI use.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15095
---


On April 7, 2015, 11:05 a.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell 


> On April 7, 2015, 2:55 p.m., Olle E Johansson wrote:
> > "global" is used for global variabels. Other CLI commands have "show 
> > settings" - can't we reuse the same with some extra options for system?
> 
> rmudgett wrote:
> Where are you getting global variables from the command?
> 
> "pjsip show global" gives the settings for the pjsip.conf [global] 
> section.
> 
> The command seems aptly named.
> 
> Olle E Johansson wrote:
> "core show global" has for a long time been used to show global 
> variables. For settings we've used "show settings both in core and in SIP - 
> maybe other modules. 
> 
> If we are going to use "global" for something else, then it will be 
> confusing. We only have a "global" section previously in the dialplan - in 
> other modules it's mostly called "general".
> 
> But if you already broke this, I rest my case. Just wanted to point out 
> that I feel it's strange.

I tend to agree with both opinions, but since consistency is a good thing and 
doing a quick survey of some other commands most seem to use the "show 
settings". Also it allowed me to combine the two commands into one: pjsip show 
settings.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---


On April 7, 2015, 11:05 a.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Olle E Johansson 


> On April 7, 2015, 9:55 p.m., Olle E Johansson wrote:
> > "global" is used for global variabels. Other CLI commands have "show 
> > settings" - can't we reuse the same with some extra options for system?
> 
> rmudgett wrote:
> Where are you getting global variables from the command?
> 
> "pjsip show global" gives the settings for the pjsip.conf [global] 
> section.
> 
> The command seems aptly named.

"core show global" has for a long time been used to show global variables. For 
settings we've used "show settings both in core and in SIP - maybe other 
modules. 

If we are going to use "global" for something else, then it will be confusing. 
We only have a "global" section previously in the dialplan - in other modules 
it's mostly called "general".

But if you already broke this, I rest my case. Just wanted to point out that I 
feel it's strange.


- Olle E


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---


On April 7, 2015, 6:05 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 6:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread rmudgett 


> On April 7, 2015, 2:55 p.m., Olle E Johansson wrote:
> > "global" is used for global variabels. Other CLI commands have "show 
> > settings" - can't we reuse the same with some extra options for system?

Where are you getting global variables from the command?

"pjsip show global" gives the settings for the pjsip.conf [global] section.

The command seems aptly named.


- rmudgett


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---


On April 7, 2015, 11:05 a.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Olle E Johansson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---


"global" is used for global variabels. Other CLI commands have "show settings" 
- can't we reuse the same with some extra options for system?

- Olle E Johansson


On April 7, 2015, 6:05 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 6:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread rmudgett 


> On April 7, 2015, 1:04 p.m., Mark Michelson wrote:
> > branches/13/res/res_pjsip/config_global.c, lines 234-240
> > 
> >
> > I think for now this is fine, but there actually is the possibility to 
> > misrepresent to the user what is configured here. For instance, if you do 
> > not have any global configuration set, then you will have no user_agent 
> > option set. This means that Asterisk will add no User-Agent header to 
> > outgoing SIP requests at all. However, printing CLI output would show that 
> > the user_agent is set to "Asterisk PBX Version 13.3" (or something similar).
> > 
> > When I evaluate this, to me the issue isn't with what you're showing in 
> > this CLI command, but rather the somewhat odd behavior associated with how 
> > global configuration works. If I have no global configuration at all, then 
> > there is no user_agent set. If I have a global configuration section, but I 
> > have not set a user_agent, then the user_agent gets set to "Asterisk PBX 
> > version 13.3" even though I didn't specify anything.
> > 
> > So rather than raising an issue on this code review, I've opened 
> > https://issues.asterisk.org/jira/browse/ASTERISK-24945 to get this 
> > inconsistency rectified. When that change gets made, then this check for a 
> > NULL cfg can be changed to an assertion instead since it should be 
> > impossible to have a NULL global configuration.

@Mark This is wrong.  The user_agent default if no global section is present 
*is* "Asterisk PBX xxx".  This issue 
https://issues.asterisk.org/jira/browse/ASTERISK-24807 fixed applying the 
defaults if no global section exists because the mandatory Max-Forwards header 
was not present in outgoing request messages.  To get outgoing messages to not 
advertise anything you have to have a global section with user_agent explicitly 
set to nothing.


- rmudgett


---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15095
---


On April 7, 2015, 11:05 a.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 11:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Mark Michelson 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15095
---



branches/13/res/res_pjsip/config_global.c


I think for now this is fine, but there actually is the possibility to 
misrepresent to the user what is configured here. For instance, if you do not 
have any global configuration set, then you will have no user_agent option set. 
This means that Asterisk will add no User-Agent header to outgoing SIP requests 
at all. However, printing CLI output would show that the user_agent is set to 
"Asterisk PBX Version 13.3" (or something similar).

When I evaluate this, to me the issue isn't with what you're showing in 
this CLI command, but rather the somewhat odd behavior associated with how 
global configuration works. If I have no global configuration at all, then 
there is no user_agent set. If I have a global configuration section, but I 
have not set a user_agent, then the user_agent gets set to "Asterisk PBX 
version 13.3" even though I didn't specify anything.

So rather than raising an issue on this code review, I've opened 
https://issues.asterisk.org/jira/browse/ASTERISK-24945 to get this 
inconsistency rectified. When that change gets made, then this check for a NULL 
cfg can be changed to an assertion instead since it should be impossible to 
have a NULL global configuration.



branches/13/res/res_pjsip/config_system.c


This should be impossible to happen since default system configuration 
should automatically get set on start-up if no system section was present in 
pjsip.conf. If default system configuration setup on startup fails, then 
res_pjsip.so should fail to load.

I think an assertion here that cfg is non-NULL would do the trick instead 
of trying again to create default configuration settings


- Mark Michelson


On April 7, 2015, 4:05 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 7, 2015, 4:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
>   branches/13/CHANGES 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---

(Updated April 7, 2015, 11:05 a.m.)


Review request for Asterisk Developers.


Changes
---

Added text to CHANGES file.


Bugs: ASTERISK-24918
https://issues.asterisk.org/jira/browse/ASTERISK-24918


Repository: Asterisk


Description
---

Added two new CLI commands for res_pjsip global and system configuration 
settings:

pjsip show global
pjsip show system


Diffs (updated)
-

  branches/13/res/res_pjsip/config_system.c 434150 
  branches/13/res/res_pjsip/config_global.c 434150 
  branches/13/CHANGES 434150 

Diff: https://reviewboard.asterisk.org/r/4597/diff/


Testing
---

Ran the commands and checked output. Changed some options and reloaded and made 
sure global settings changed, but system ones did not. Changed some settings 
again and restarted and made sure both global and system changes too effect. 
Also removed the sections completely from the pjsip.conf file and made sure the 
defaults were shown.


Thanks,

Kevin Harwell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Matt Jordan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15087
---


Please update the CHANGES file :-)

- Matt Jordan


On April 6, 2015, 5:57 p.m., Kevin Harwell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4597/
> ---
> 
> (Updated April 6, 2015, 5:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24918
> https://issues.asterisk.org/jira/browse/ASTERISK-24918
> 
> 
> Repository: Asterisk
> 
> 
> Description
> ---
> 
> Added two new CLI commands for res_pjsip global and system configuration 
> settings:
> 
> pjsip show global
> pjsip show system
> 
> 
> Diffs
> -
> 
>   branches/13/res/res_pjsip/config_system.c 434150 
>   branches/13/res/res_pjsip/config_global.c 434150 
> 
> Diff: https://reviewboard.asterisk.org/r/4597/diff/
> 
> 
> Testing
> ---
> 
> Ran the commands and checked output. Changed some options and reloaded and 
> made sure global settings changed, but system ones did not. Changed some 
> settings again and restarted and made sure both global and system changes too 
> effect. Also removed the sections completely from the pjsip.conf file and 
> made sure the defaults were shown.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev