Re: [asterisk-users] asterisk 13.16. - sigseg during negotiation

2017-06-18 Thread Michael Maier
On 06/18/2017 at 12:11 PM, Joshua Colp wrote:
> On Sun, Jun 18, 2017, at 06:00 AM, Michael Maier wrote:
>> Hello!
>>
>> unchanged asterisk crashes during udptl / t.38 negotiation with telekom
>> - they do not support t.38 / udptl.
> 
> All Asterisk issues need to go through the issue tracker[1]. In this
> case we'd also need to see the full SIP debug so we can understand the
> complete interaction.
> 
> [1] https://issues.asterisk.org/jira
> 

See https://issues.asterisk.org/jira/browse/ASTERISK-27061

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] asterisk 13.16. - sigseg during negotiation

2017-06-18 Thread Joshua Colp
On Sun, Jun 18, 2017, at 06:00 AM, Michael Maier wrote:
> Hello!
> 
> unchanged asterisk crashes during udptl / t.38 negotiation with telekom
> - they do not support t.38 / udptl.

All Asterisk issues need to go through the issue tracker[1]. In this
case we'd also need to see the full SIP debug so we can understand the
complete interaction.

[1] https://issues.asterisk.org/jira

-- 
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


[asterisk-users] asterisk 13.16. - sigseg during negotiation

2017-06-18 Thread Michael Maier
Hello!

unchanged asterisk crashes during udptl / t.38 negotiation with telekom
- they do not support t.38 / udptl.

In detail:

fax client -> asterisk -> telekom -> easybell -> asterisk -> fax server


Fax server sends t.38 reinvite via asterisk to easybell.

   Session Description Protocol Version (v): 0
   Owner/Creator, Session Id (o): - 2447581897 4 IN IP4 46.17.15.23
   Session Name (s): Asterisk
   Connection Information (c): IN IP4 46.17.15.23
   Time Description, active time (t): 0 0
   Media Description, name and address (m): image 4573 udptl t38
   Media Attribute (a): T38FaxVersion:0
   Media Attribute (a): T38MaxBitRate:14400
   Media Attribute (a): T38FaxRateManagement:transferredTCF
   Media Attribute (a): T38FaxMaxDatagram:397
   Media Attribute (a): T38FaxUdpEC:t38UDPRedundancy


This reinvite is received by asterisk via telekom:

   Session Description Protocol Version (v): 0
   Owner/Creator, Session Id (o): - 1811299599 2925027276 IN IP4 0.0.0.0
   Session Name (s): -
   Time Description, active time (t): 0 0
   Media Description, name and address (m): image 0 udptl t38
   Media Attribute (a): sendrecv
   Media Attribute (a): T38FaxVersion:0
   Media Attribute (a): T38MaxBitRate:14400
   Media Attribute (a): T38FaxRateManagement:transferredTCF
   Media Attribute (a): T38FaxMaxDatagram:397
   Media Attribute (a): T38FaxUdpEC:t38UDPRedundancy


And asterisk gives it to the fax client:

   Session Description Protocol Version (v): 0
   Owner/Creator, Session Id (o): - 1497774025 5 IN IP4 192.168.12.13
   Session Name (s): Asterisk
   Connection Information (c): IN IP4 192.168.12.13
   Time Description, active time (t): 0 0
   Media Description, name and address (m): image 4284 udptl t38
   Media Attribute (a): T38FaxVersion:0
   Media Attribute (a): T38MaxBitRate:14400
   Media Attribute (a): T38FaxRateManagement:transferredTCF
   Media Attribute (a): T38FaxMaxDatagram:393
   Media Attribute (a): T38FaxUdpEC:t38UDPRedundancy

Completely ignoring, that telekom doesn't support it (port and ip
addresses are set to 0).

On completing the negotiation after 200 ok SDP and ACK from fax client,
asterisk crashes. Stack trace is attached!


Regards,
Michael
Program terminated with signal 11, Segmentation fault.

#0  ast_copy_pj_str (dest=0x7fb9f5901100 "x\277\001, src=0x20, size=1025) at res_pjsip.c:4147
#1  0x7fb9f0b02334 in negotiate_incoming_sdp_stream 
(session=0x7fba3c031200, session_media=, sdp=, stream=)
at res_pjsip_t38.c:703
#2  0x7fba0499ccf6 in handle_incoming_sdp (session=0x7fba3c031200, 
sdp=0x7fba3c0adfb8) at res_pjsip_session.c:243
#3  0x7fba0499e650 in session_inv_on_rx_offer (inv=0x7fba3c0504e8, 
offer=0x7fba3c0adfb8) at res_pjsip_session.c:3009
#4  0x7fba44b1b501 in inv_check_sdp_in_incoming_msg (inv=0x7fba3c0504e8, 
tsx=0x7fba08006878, rdata=0x7fba3c0b00a8) at ../src/pjsip-ua/sip_inv.c:2110
#5  0x7fba44b20026 in inv_on_state_confirmed (inv=0x7fba3c0504e8, 
e=0x7fb9f5901880) at ../src/pjsip-ua/sip_inv.c:4869
#6  0x7fba44b18869 in mod_inv_on_tsx_state (tsx=0x7fba08006878, 
e=0x7fb9f5901880) at ../src/pjsip-ua/sip_inv.c:717
#7  0x7fba44b64850 in pjsip_dlg_on_tsx_state (dlg=0x7fba3c028c58, 
tsx=0x7fba08006878, e=0x7fb9f5901880) at ../src/pjsip/sip_dialog.c:2064
#8  0x7fba44b650bf in mod_ua_on_tsx_state (tsx=0x7fba08006878, 
e=0x7fb9f5901880) at ../src/pjsip/sip_ua_layer.c:178
#9  0x7fba44b5d0e4 in tsx_set_state (tsx=0x7fba08006878, 
state=PJSIP_TSX_STATE_TRYING, event_src_type=PJSIP_EVENT_RX_MSG, 
event_src=0x7fba3c0b00a8, flag=0)
at ../src/pjsip/sip_transaction.c:1267
#10 0x7fba44b5f1f7 in tsx_on_state_null (tsx=0x7fba08006878, 
event=0x7fb9f5901950) at ../src/pjsip/sip_transaction.c:2410
#11 0x7fba44b5e07c in pjsip_tsx_recv_msg (tsx=0x7fba08006878, 
rdata=0x7fba3c0b00a8) at ../src/pjsip/sip_transaction.c:1827
#12 0x7fba44b63f62 in pjsip_dlg_on_rx_request (dlg=0x7fba3c028c58, 
rdata=0x7fba3c0b00a8) at ../src/pjsip/sip_dialog.c:1711
#13 0x7fba44b65bde in mod_ua_on_rx_request (rdata=0x7fba3c0b00a8) at 
../src/pjsip/sip_ua_layer.c:704
#14 0x7fba44b42b1e in pjsip_endpt_process_rx_data (endpt=0x36cc2a8, 
rdata=0x7fba3c0b00a8, p=0x7fba05c8d0a0, p_handled=0x7fb9f5901b7c) at 
../src/pjsip/sip_endpoint.c:887
#15 0x7fba05a72c59 in distribute (data=0x7fba3c0b00a8) at 
res_pjsip/pjsip_distributor.c:770
#16 0x005ed6d1 in ast_taskprocessor_execute (tps=0x7fba3c0400a0) at 
taskprocessor.c:965
#17 0x005f7056 in execute_tasks (data=0x7fba3c0400a0) at 
threadpool.c:1322
#18 0x005ed6d1 in ast_taskprocessor_execute (tps=0x36bfab0) at 
taskprocessor.c:965
#19 0x005f53a1 in threadpool_execute (pool=0x36c0040) at 
threadpool.c:351
#20 0x005f69b4 in worker_active (worker=0x7fba38001fb0) at 
threadpool.c:1105
#21 0x005f6760 in worker_start (arg=0x7fba38001fb0) at threadpool.c:1024
#22 0x0060292c in dummy_start (data=0x7fba38000a50) at utils.c:1238
#23 0x7fba43005aa1 in start_thread 

Re: [asterisk-users] asterisk 13.16 / pjsip / t.38: res_pjsip_t38.c:207 t38_automatic_reject: Automatically rejecting T.38 request on channel 'PJSIP/91-00000007'

2017-06-18 Thread Michael Maier
On 06/17/2017 at 02:18 PM, Michael Maier wrote:
> On 06/16/2017 at 04:00 PM, Joshua Colp wrote:
>> On Fri, Jun 16, 2017, at 10:49 AM, Michael Maier wrote:
>>
>> 
>>
>>>
>>> t38modem and asterisk are using
>>>
>>> m=image 35622 udptl t38
>>>^
>>>
>>> Provider uses
>>>
>>> m=image 35622 UDPTL t38
>>>^
>>>
>>> Could this be a problem? If I'm sending internal only, it's always 
>>> lowercase.
>>
>> Looking at the tests we have we only use 'udptl' as the transport.
>> Without diving deep into the SDP negotiator it is possible that it gets
>> upset at that, as we would only produce 'udptl'. If the SDP negotiator
>> in PJSIP is case sensitive then you'd get a declined stream like you
>> see. Looking at the T.38 examples from the ITU doc also shows it in
>> lowercase, so uppercase is probably not commonly used.
> 
> I can proof, that UDPTL vs. udptl is the problem. After "fixing"
> asterisk and opal both using UDPTL, the negotiation works flawlessly.
> See attached patches.

For opal, the sip patch (src/t38/sipt38.cxx) is enough - the other two
patches aren't necessary. It's only a SIP-problem.


Regards,
Michael

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users