Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-09 Thread Godwin Stewart
On Fri, 7 Mar 2008 16:08:31 +0200, Mindaugas Kezys [EMAIL PROTECTED]
wrote:

 Then you can change channel language in front of VoiceMail() app and in
 appropriate place put auth-thankyou file which is recorded/made by you.

Much as I dislike this kludge because of the potential for b0rkage when
Asterisk is updated, for now I've backed up the original auth-thankyou.gsm
and symlinked silence/1.gsm to auth-thankyou.gsm.

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-09 Thread Atis Lezdins
On 3/9/08, Godwin Stewart Horwich IT Services [EMAIL PROTECTED] wrote:
 On Fri, 7 Mar 2008 16:08:31 +0200, Mindaugas Kezys [EMAIL PROTECTED]
  wrote:


   Then you can change channel language in front of VoiceMail() app and in
   appropriate place put auth-thankyou file which is recorded/made by you.


 Much as I dislike this kludge because of the potential for b0rkage when
  Asterisk is updated, for now I've backed up the original auth-thankyou.gsm
  and symlinked silence/1.gsm to auth-thankyou.gsm.


I think that giving 's' argument should silence all prompts including
auth-thankyou. You should report a bug on http://bugs.digium.com ,
fixing this should be trivial.

Regards,
Atis

-- 
Atis Lezdins,
VoIP Project Manager / Developer,
[EMAIL PROTECTED]
Skype: atis.lezdins
Cell Phone: +371 28806004
Cell Phone: +1 800 7300689
Work phone: +1 800 7502835

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-09 Thread Godwin Stewart
On Sun, 9 Mar 2008 16:22:35 +0200, Atis Lezdins [EMAIL PROTECTED] wrote:

 I think that giving 's' argument should silence all prompts including
 auth-thankyou. You should report a bug on http://bugs.digium.com ,
 fixing this should be trivial.

It isn't that trivial.

I've looked at the source and the silent flag is not passed all the way
down the chain to the function that actually does the recording.

In apps/app_voicemail.c, the option is parsed by vm_exec() and passed on to
leave_voicemail().

leave_voicemail(), however, doesn't pass it down to play_record_review().
So by the time the call stack goes through ast_play_and_record_full() and
__ast_play_and_record() in main/app.c, where we see the foillowing code,
the status of the silent option is long lost:

if (outmsg == 2) {
ast_stream_and_wait(chan, auth-thankyou, chan-language,);
}

I will, however, work on a patch to pass the silent option down the chain
to this function, but it's going to mean a major overhaul.

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-09 Thread Atis Lezdins
On 3/9/08, Godwin Stewart Horwich IT Services [EMAIL PROTECTED] wrote:
 On Sun, 9 Mar 2008 16:22:35 +0200, Atis Lezdins [EMAIL PROTECTED] wrote:

   I think that giving 's' argument should silence all prompts including
   auth-thankyou. You should report a bug on http://bugs.digium.com ,
   fixing this should be trivial.


 It isn't that trivial.

  I've looked at the source and the silent flag is not passed all the way
  down the chain to the function that actually does the recording.

  In apps/app_voicemail.c, the option is parsed by vm_exec() and passed on to
  leave_voicemail().

  leave_voicemail(), however, doesn't pass it down to play_record_review().
  So by the time the call stack goes through ast_play_and_record_full() and
  __ast_play_and_record() in main/app.c, where we see the foillowing code,
  the status of the silent option is long lost:

  if (outmsg == 2) {
 ast_stream_and_wait(chan, auth-thankyou, chan-language,);
  }

  I will, however, work on a patch to pass the silent option down the chain
  to this function, but it's going to mean a major overhaul.

Maybe you should ask for best way for this in asterisk-dev. I checked
wat you're saying and it seems to me that more logical would be to
play auth-thankyou in application, not __ast_play_and_record(), but
it may break some concept.

Regards,
Atis
-- 
Atis Lezdins,
VoIP Project Manager / Developer,
[EMAIL PROTECTED]
Skype: atis.lezdins
Cell Phone: +371 28806004
Cell Phone: +1 800 7300689
Work phone: +1 800 7502835

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-09 Thread Godwin Stewart
On Sun, 9 Mar 2008 21:49:34 +0200, Atis Lezdins [EMAIL PROTECTED] wrote:

 Maybe you should ask for best way for this in asterisk-dev.

Good point. I'll probably do that tomorrow.

 I checked wat you're saying and it seems to me that more logical would be
 to play auth-thankyou in application, not __ast_play_and_record(), but
 it may break some concept.

The thing is there are multiple applications that use these functions and
that are liable to want to say thank you afterwards. With that in mind,
it does make more sense to have the message sent out from the common
denominator rather than from each application that uses that common
denominator. However, I also agree with your statement that the 's' option
should silence *everything* with the exception, perhaps, of the beep before
recording starts.

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


[asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-07 Thread Godwin Stewart
Hi there,

Googling through the archives it looks like I'm the ferst person to want
this...

My aim is to set up a voicemail application with a custom greeting before
*AND AFTER* the punter has left the message.

Right now the relevant section of my dialplan is like this:

exten = 2,1,Playback(/media/asterisk/answerphone-en)
exten = 2,n,VoiceMail(2000,s)
exten = 2,n,Playback(/media/asterisk/thankyou-en)
exten = 2,n,Hangup()

The 's' option to VoiceMail() silences the prompt, leaves the beep just
before going into 'record' mode, but also plays back auth-thankyou after
the user hits the # key.

How can I suppress playback of auth-thankyou at the end or get VoiceMail()
to play back a different file?

Thanks in advance,

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-07 Thread Mindaugas Kezys
Hello,

Just find this file in /var/lib/asterisk/sounds and change it to anything
you like.

Regards,
Mindaugas Kezys
http://www.kolmisoft.com
MOR PRO - Advanced Billing for Asterisk PBX



-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Horwich IT
Services (Godwin Stewart)
Sent: Friday, March 07, 2008 10:35 AM
To: asterisk-users@lists.digium.com
Subject: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

Hi there,

Googling through the archives it looks like I'm the ferst person to want
this...

My aim is to set up a voicemail application with a custom greeting before
*AND AFTER* the punter has left the message.

Right now the relevant section of my dialplan is like this:

exten = 2,1,Playback(/media/asterisk/answerphone-en)
exten = 2,n,VoiceMail(2000,s)
exten = 2,n,Playback(/media/asterisk/thankyou-en)
exten = 2,n,Hangup()

The 's' option to VoiceMail() silences the prompt, leaves the beep just
before going into 'record' mode, but also plays back auth-thankyou after
the user hits the # key.

How can I suppress playback of auth-thankyou at the end or get VoiceMail()
to play back a different file?

Thanks in advance,

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-07 Thread Godwin Stewart
On Fri, 7 Mar 2008 12:10:37 +0200, Mindaugas Kezys [EMAIL PROTECTED]
wrote:

 Just find this file in /var/lib/asterisk/sounds and change it to anything
 you like.

But that will break other applications that use the auth-thankyou sound,
Authenticate() for a start (which I use elsewhere in order to remote check
the voicemailbox).

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

2008-03-07 Thread Mindaugas Kezys
Hello,

Then you can change channel language in front of VoiceMail() app and in
appropriate place put auth-thankyou file which is recorded/made by you.

Regards,
Mindaugas Kezys
http://www.kolmisoft.com
MOR PRO - Advanced Billing for Asterisk PBX


-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Horwich IT
Services (Godwin Stewart)
Sent: Friday, March 07, 2008 1:07 PM
To: asterisk-users@lists.digium.com
Subject: Re: [asterisk-users] Silencing VoiceMail() app in * 1.4.10

On Fri, 7 Mar 2008 12:10:37 +0200, Mindaugas Kezys [EMAIL PROTECTED]
wrote:

 Just find this file in /var/lib/asterisk/sounds and change it to anything
 you like.

But that will break other applications that use the auth-thankyou sound,
Authenticate() for a start (which I use elsewhere in order to remote check
the voicemailbox).

-- 
Godwin Stewart - Horwich IT services

___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users


___
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users