Re: [asterisk-users] Oslec issue
Hi Joseph. I spent some time to understand what's missing in the OSLEC patch for dahdi... I can confirm the same problem you reported some days ago and I need OSLEC for home personal use. For what I've understood looking at the code, there is some missing in the dahdi_echocan_oslec.c file you can find in the dahdi-linux/drivers/dahdi. I can list below what I did to have it working. Actually I'm using the trunk revision 5443. 1. In the function "echo_can_create" i've modified the line *ec = (struct echo_can_state *)oslec_create(ecp->tap_length,0); with *ec = (struct echo_can_state *)oslec_create(ecp->tap_length, ECHO_CAN_USE_ADAPTION | ECHO_CAN_USE_NLP | ECHO_CAN_USE_CLIP | ECHO_CAN_USE_TX_HPF | ECHO_CAN_USE_RX_HPF); This instructs OSLEC to have a working modality properly set. 2. I've replaced the function "echo_can_update" with the code below: static void echo_can_update(struct echo_can_state *ec, short *iref, short *isig) { unsigned int SampleNum; for (SampleNum = 0; SampleNum < DAHDI_CHUNKSIZE; SampleNum++, iref++) { short iCleanSample; iCleanSample = (short) oslec_update((struct oslec_state *)ec, *iref, *isig); *isig++ = iCleanSample; } } This lets the OSLEC to work on complete DAHDI_CHUNKSIZE buffer. Please, if you have time, let me know if this solves your problem and, if yes, I'll appreciate to have it public on trunk. I never did a commit on asterisk svn so I need some hints on how to do it. Thank you and best regards. Marco Signorini. Joseph L. Casale wrote: > Yesterday I pulled in the latest svn of Dahdi and added the files > from a recent kernel in the drivers/staging/echo structure and modified > the Kbuild file so it would compile without error. I insmod'ed the module > in, and modified my system.conf has echocanceller=oslec. > > cat /proc/dahdi/1 shows: > Span 1: WCTDM/0 "Wildcard TDM410P Board 1" (MASTER) > IRQ misses: 1 > >1 WCTDM/0/0 FXSKS (In use) (EC: OSLEC) >2 WCTDM/0/1 >3 WCTDM/0/2 >4 WCTDM/0/3 > > With the reco's from http://www.rowetel.com/ucasterisk/oslec.html#install on > configuring the chan_dahdi.conf file, the system behaves exactly as if there > is no ec enabled at all? > > Are there any additional steps needed to enable oslec under dahdi, I am > guessing > I have missed something? > > Thanks, > jlc > > ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Oslec issue
>I spent some time to understand what's missing in the OSLEC patch for >dahdi... I can confirm the same problem you reported some days ago and I >need OSLEC for home personal use. Wow, Appreciate the info! I will need a few days to get this done. Out of curiosity, how do you find this ec's quality compared to the shipped modules and hpec? Thanks! jlc ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [asterisk-users] Oslec issue
Ok Joseph. Don't worry, take your time :-) For what's concerning the quality: I can assume my phone line is an exception because it has a lot of echo. I've spent a LOT of time trying to have an SPA3102 and an HT488 working without any reasonable result. I'm playing for fun with zaptel/dahdi ec's since years and I was never able to have a satisfying result with any ec provided with it. Neither the fxotune process, neither any Tx/Rx gain or echo training parameter tuning, neither Digium people that connected to my server 3 or 4 years ago were able to completely solve any echo issue. Some years ago I had the opportunity to test on my line HPEC with a customer's box equipped with a TDM400P and I was impressed by the quality. I think OSLEC is a very good piece of code. It's working fine with my line and my Grandstream phones and, the must important thing, it's open and free to use. Sometimes I can ear some echo or strange effects at the very beginning of a call, but this is something that I can accept. In the past I tried to modify the zaptel sources in order to prevent them to free the oslec instance at each call. I think that my mods were not working on systems where more than one zap channel was present and I was not able to test it on these type of situations. Thank you and bye Marco Signorini Joseph L. Casale wrote: >> I spent some time to understand what's missing in the OSLEC patch for >> dahdi... I can confirm the same problem you reported some days ago and I >> need OSLEC for home personal use. >> > > Wow, > Appreciate the info! I will need a few days to get this done. Out of > curiosity, > how do you find this ec's quality compared to the shipped modules and hpec? > > Thanks! > jlc > ___ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > ___ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-users mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users