[PATCH v2 12/13] ath10k: Vote for hardware resources for WCN3990

2018-03-22 Thread Govind Singh 
Add clock and regulator votes for WCN3990 WLAN
chipset.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 313 -
 drivers/net/wireless/ath/ath10k/snoc.h |  19 ++
 2 files changed, 331 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 1ef0d3b..2e490ff 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -24,6 +24,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #define  WCN3990_CE_ATTR_FLAGS 0
 #define ATH10K_SNOC_RX_POST_RETRY_MS 50
 #define CE_POLL_PIPE 4
@@ -43,6 +45,17 @@
"WLAN_CE_11",
 };
 
+static struct ath10k_wcn3990_vreg_info vreg_cfg[] = {
+   {NULL, "vdd-0.8-cx-mx", 80, 80, 0, 0, false},
+   {NULL, "vdd-1.8-xo", 180, 180, 0, 0, false},
+   {NULL, "vdd-1.3-rfa", 1304000, 1304000, 0, 0, false},
+   {NULL, "vdd-3.3-ch0", 3312000, 3312000, 0, 0, false},
+};
+
+static struct ath10k_wcn3990_clk_info clk_cfg[] = {
+   {NULL, "cxo_ref_clk_pin", 0, false},
+};
+
 static void ath10k_snoc_htc_tx_cb(struct ath10k_ce_pipe *ce_state);
 static void ath10k_snoc_htt_tx_cb(struct ath10k_ce_pipe *ce_state);
 static void ath10k_snoc_htc_rx_cb(struct ath10k_ce_pipe *ce_state);
@@ -969,6 +982,277 @@ static void ath10k_snoc_release_resource(struct ath10k 
*ar)
ath10k_ce_free_pipe(ar, i);
 }
 
+static int ath10k_get_vreg_info(struct ath10k *ar, struct device *dev,
+   struct ath10k_wcn3990_vreg_info *vreg_info)
+{
+   struct regulator *reg;
+   int ret = 0;
+
+   reg = devm_regulator_get_optional(dev, vreg_info->name);
+
+   if (IS_ERR(reg)) {
+   ret = PTR_ERR(reg);
+
+   if (ret  == -EPROBE_DEFER) {
+   ath10k_err(ar, "EPROBE_DEFER for regulator: %s\n",
+  vreg_info->name);
+   return ret;
+   }
+   if (vreg_info->required) {
+   ath10k_err(ar, "Regulator %s doesn't exist: %d\n",
+  vreg_info->name, ret);
+   return ret;
+   }
+   ath10k_dbg(ar, ATH10K_DBG_SNOC,
+  "Optional regulator %s doesn't exist: %d\n",
+  vreg_info->name, ret);
+   goto done;
+   }
+
+   vreg_info->reg = reg;
+
+done:
+   ath10k_dbg(ar, ATH10K_DBG_SNOC,
+  "snog vreg %s min_v %u max_v %u load_ua %u settle_delay 
%lu\n",
+  vreg_info->name, vreg_info->min_v, vreg_info->max_v,
+  vreg_info->load_ua, vreg_info->settle_delay);
+
+   return 0;
+}
+
+static int ath10k_get_clk_info(struct ath10k *ar, struct device *dev,
+  struct ath10k_wcn3990_clk_info *clk_info)
+{
+   struct clk *handle;
+   int ret = 0;
+
+   handle = devm_clk_get(dev, clk_info->name);
+   if (IS_ERR(handle)) {
+   ret = PTR_ERR(handle);
+   if (clk_info->required) {
+   ath10k_err(ar, "snoc clock %s isn't available: %d\n",
+  clk_info->name, ret);
+   return ret;
+   }
+   ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc ignoring clock %s: %d\n",
+  clk_info->name,
+  ret);
+   return 0;
+   }
+
+   ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc clock %s freq %u\n",
+  clk_info->name, clk_info->freq);
+
+   clk_info->handle = handle;
+
+   return ret;
+}
+
+static int ath10k_wcn3990_vreg_on(struct ath10k *ar)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   struct ath10k_wcn3990_vreg_info *vreg_info;
+   int ret = 0;
+   int i;
+
+   for (i = 0; i < ARRAY_SIZE(vreg_cfg); i++) {
+   vreg_info = &ar_snoc->vreg[i];
+
+   if (!vreg_info->reg)
+   continue;
+
+   ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc regulator %s being 
enabled\n",
+  vreg_info->name);
+
+   ret = regulator_set_voltage(vreg_info->reg, vreg_info->min_v,
+   vreg_info->max_v);
+   if (ret) {
+   ath10k_err(ar,
+  "failed to set regulator %s voltage-min: %d 
voltage-max: %d\n",
+  vreg_info->name, vreg_info->min_v, 
vreg_info->max_v);
+   goto err_reg_config;
+   }
+
+   if (vreg_info->load_ua) {
+   ret = regulator_set_load(vreg_info->reg,
+vreg_info->load_ua);
+   if (ret < 0) {
+   ath10k_err(ar,
+  "faile

[PATCH v2 08/13] ath10k: Add hif rx methods for wcn3990

2018-03-22 Thread Govind Singh 
Add hif rx methods in rx path for wcn3990
target.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 171 +
 1 file changed, 153 insertions(+), 18 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 899f0a3..6d9ccce 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -26,6 +26,7 @@
 #include 
 #define  WCN3990_CE_ATTR_FLAGS 0
 #define ATH10K_SNOC_RX_POST_RETRY_MS 50
+#define CE_POLL_PIPE 4
 
 static char *const ce_name[] = {
"WLAN_CE_0",
@@ -44,6 +45,9 @@
 
 static void ath10k_snoc_htc_tx_cb(struct ath10k_ce_pipe *ce_state);
 static void ath10k_snoc_htt_tx_cb(struct ath10k_ce_pipe *ce_state);
+static void ath10k_snoc_htc_rx_cb(struct ath10k_ce_pipe *ce_state);
+static void ath10k_snoc_htt_rx_cb(struct ath10k_ce_pipe *ce_state);
+static void ath10k_snoc_htt_htc_rx_cb(struct ath10k_ce_pipe *ce_state);
 
 static const struct ath10k_snoc_drv_priv drv_priv = {
.hw_rev = ATH10K_HW_WCN3990,
@@ -53,7 +57,7 @@
 static struct ce_attr host_ce_config_wlan[] = {
/* CE0: host->target HTC control streams */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 16,
.src_sz_max = 2048,
.dest_nentries = 0,
@@ -62,25 +66,25 @@
 
/* CE1: target->host HTT + HTC control */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 512,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htt_htc_rx_cb,
},
 
/* CE2: target->host WMI */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 64,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htc_rx_cb,
},
 
/* CE3: host->target WMI */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 32,
.src_sz_max = 2048,
.dest_nentries = 0,
@@ -89,7 +93,7 @@
 
/* CE4: host->target HTT */
{
-   .flags = WCN3990_CE_ATTR_FLAGS | CE_ATTR_DIS_INTR,
+   .flags = CE_ATTR_FLAGS | CE_ATTR_DIS_INTR,
.src_nentries = 256,
.src_sz_max = 256,
.dest_nentries = 0,
@@ -98,16 +102,16 @@
 
/* CE5: target->host HTT (ipa_uc->target ) */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 512,
.dest_nentries = 512,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htt_rx_cb,
},
 
/* CE6: target autonomous hif_memcpy */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 0,
.dest_nentries = 0,
@@ -115,7 +119,7 @@
 
/* CE7: ce_diag, the Diagnostic Window */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 2,
.src_sz_max = 2048,
.dest_nentries = 2,
@@ -123,7 +127,7 @@
 
/* CE8: Target to uMC */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 128,
@@ -131,29 +135,29 @@
 
/* CE9 target->host HTT */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 512,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htt_htc_rx_cb,
},
 
/* CE10: target->host HTT */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 512,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htt_htc_rx_cb,
},
 
/* CE11: target -> host PKTLOG */
{
-   .flags = WCN3990_CE_ATTR_FLAGS,
+   .flags = CE_ATTR_FLAGS,
.src_nentries = 0,
.src_sz_max = 2048,
.dest_nentries = 512,
-   .recv_cb = NULL,
+   .recv_cb = ath10k_snoc_htt_htc_rx_cb,
},
 };
 
@@ -362,6 +366,82 @@ static void ath10k_snoc_rx_post(struct ath10k *ar)
ath10k_snoc_rx_po

[PATCH v2 06/13] ath10k: Add hif power-up/power-down methods

2018-03-22 Thread Govind Singh 
Add hif power-up/power-down methods for wcn3990
target.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 61 ++
 1 file changed, 61 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index a39eee7..9d402e4 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -519,6 +519,65 @@ static int ath10k_snoc_hif_start(struct ath10k *ar)
return 0;
 }
 
+static int ath10k_snoc_init_pipes(struct ath10k *ar)
+{
+   int i, ret;
+
+   for (i = 0; i < CE_COUNT; i++) {
+   ret = ath10k_ce_init_pipe(ar, i, &host_ce_config_wlan[i]);
+   if (ret) {
+   ath10k_err(ar, "failed to initialize copy engine pipe 
%d: %d\n",
+  i, ret);
+   return ret;
+   }
+   }
+
+   return 0;
+}
+
+static int ath10k_snoc_wlan_enable(struct ath10k *ar)
+{
+   return 0;
+}
+
+static void ath10k_snoc_wlan_disable(struct ath10k *ar)
+{
+}
+
+static void ath10k_snoc_hif_power_down(struct ath10k *ar)
+{
+   ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot hif power down\n");
+
+   ath10k_snoc_wlan_disable(ar);
+}
+
+static int ath10k_snoc_hif_power_up(struct ath10k *ar)
+{
+   int ret;
+
+   ath10k_dbg(ar, ATH10K_DBG_SNOC, "%s:WCN3990 driver state = %d\n",
+  __func__, ar->state);
+
+   ret = ath10k_snoc_wlan_enable(ar);
+   if (ret) {
+   ath10k_err(ar, "failed to enable wcn3990: %d\n", ret);
+   return ret;
+   }
+
+   ret = ath10k_snoc_init_pipes(ar);
+   if (ret) {
+   ath10k_err(ar, "failed to initialize CE: %d\n", ret);
+   goto err_wlan_enable;
+   }
+
+   return 0;
+
+err_wlan_enable:
+   ath10k_snoc_wlan_disable(ar);
+
+   return ret;
+}
+
 static const struct ath10k_hif_ops ath10k_snoc_hif_ops = {
.read32 = ath10k_snoc_read32,
.write32= ath10k_snoc_write32,
@@ -526,6 +585,8 @@ static int ath10k_snoc_hif_start(struct ath10k *ar)
.stop   = ath10k_snoc_hif_stop,
.map_service_to_pipe= ath10k_snoc_hif_map_service_to_pipe,
.get_default_pipe   = ath10k_snoc_hif_get_default_pipe,
+   .power_up   = ath10k_snoc_hif_power_up,
+   .power_down = ath10k_snoc_hif_power_down,
 };
 
 static const struct ath10k_bus_ops ath10k_snoc_bus_ops = {
-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 11/13] ath10k: Check all CE for data if irq summary is not retained

2018-03-22 Thread Govind Singh 
From: Rakesh Pillai 

WCN3990 has interrupts per CE and the interrupt summary
is not retained after the interrupt handler has finished
execution. We need to check if we received any
ce in rx and tx completion path.

Generate a interrupt summary with all CE interrupts if
the target does not retain interrupt summary after the
execution of interrupt handler.

Signed-off-by: Rakesh Pillai 
Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/ce.h   | 10 +++---
 drivers/net/wireless/ath/ath10k/core.c | 13 +
 drivers/net/wireless/ath/ath10k/hw.h   |  3 +++
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/ce.h 
b/drivers/net/wireless/ath/ath10k/ce.h
index 2c3c8f5..d8f9da3 100644
--- a/drivers/net/wireless/ath/ath10k/ce.h
+++ b/drivers/net/wireless/ath/ath10k/ce.h
@@ -355,14 +355,18 @@ static inline u32 ath10k_ce_base_address(struct ath10k 
*ar, unsigned int ce_id)
(((x) & CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_MASK) >> \
CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_LSB)
 #define CE_WRAPPER_INTERRUPT_SUMMARY_ADDRESS   0x
+#define CE_INTERRUPT_SUMMARY   (GENMASK(CE_COUNT_MAX - 1, 0))
 
 static inline u32 ath10k_ce_interrupt_summary(struct ath10k *ar)
 {
struct ath10k_ce *ce = ath10k_ce_priv(ar);
 
-   return CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_GET(
-   ce->bus_ops->read32((ar), CE_WRAPPER_BASE_ADDRESS +
-   CE_WRAPPER_INTERRUPT_SUMMARY_ADDRESS));
+   if (!ar->hw_params.per_ce_irq)
+   return CE_WRAPPER_INTERRUPT_SUMMARY_HOST_MSI_GET(
+   ce->bus_ops->read32((ar), CE_WRAPPER_BASE_ADDRESS +
+   CE_WRAPPER_INTERRUPT_SUMMARY_ADDRESS));
+   else
+   return CE_INTERRUPT_SUMMARY;
 }
 
 #endif /* _CE_H_ */
diff --git a/drivers/net/wireless/ath/ath10k/core.c 
b/drivers/net/wireless/ath/ath10k/core.c
index 61443f5..64479ac 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -119,6 +119,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA9887_HW_1_0_VERSION,
@@ -148,6 +149,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA6174_HW_2_1_VERSION,
@@ -176,6 +178,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA6174_HW_2_1_VERSION,
@@ -204,6 +207,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA6174_HW_3_0_VERSION,
@@ -232,6 +236,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA6174_HW_3_2_VERSION,
@@ -263,6 +268,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA99X0_HW_2_0_DEV_VERSION,
@@ -297,6 +303,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA9984_HW_1_0_DEV_VERSION,
@@ -336,6 +343,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA9888_HW_2_0_DEV_VERSION,
@@ -374,6 +382,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA9377_HW_1_0_DEV_VERSION,
@@ -402,6 +411,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA9377_HW_1_1_DEV_VERSION,
@@ -432,6 +442,7 @@
.num_wds_entries = 0x20,
.target_64bit = false,
.rx_ring_fill_level = HTT_RX_RING_FILL_LEVEL,
+   .per_ce_irq = false,
},
{
.id = QCA4019_HW_1_0_

[PATCH v2 07/13] ath10k: Add hif tx methods for wcn3990

2018-03-22 Thread Govind Singh 
Add hif tx/tx-complete methods for wcn3990
target.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 123 -
 1 file changed, 120 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 9d402e4..899f0a3 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -42,6 +42,9 @@
"WLAN_CE_11",
 };
 
+static void ath10k_snoc_htc_tx_cb(struct ath10k_ce_pipe *ce_state);
+static void ath10k_snoc_htt_tx_cb(struct ath10k_ce_pipe *ce_state);
+
 static const struct ath10k_snoc_drv_priv drv_priv = {
.hw_rev = ATH10K_HW_WCN3990,
.dma_mask = DMA_BIT_MASK(37),
@@ -54,7 +57,7 @@
.src_nentries = 16,
.src_sz_max = 2048,
.dest_nentries = 0,
-   .send_cb = NULL,
+   .send_cb = ath10k_snoc_htc_tx_cb,
},
 
/* CE1: target->host HTT + HTC control */
@@ -81,7 +84,7 @@
.src_nentries = 32,
.src_sz_max = 2048,
.dest_nentries = 0,
-   .send_cb = NULL,
+   .send_cb = ath10k_snoc_htc_tx_cb,
},
 
/* CE4: host->target HTT */
@@ -90,7 +93,7 @@
.src_nentries = 256,
.src_sz_max = 256,
.dest_nentries = 0,
-   .send_cb = NULL,
+   .send_cb = ath10k_snoc_htt_tx_cb,
},
 
/* CE5: target->host HTT (ipa_uc->target ) */
@@ -359,6 +362,117 @@ static void ath10k_snoc_rx_post(struct ath10k *ar)
ath10k_snoc_rx_post_pipe(&ar_snoc->pipe_info[i]);
 }
 
+static void ath10k_snoc_htc_tx_cb(struct ath10k_ce_pipe *ce_state)
+{
+   struct ath10k *ar = ce_state->ar;
+   struct sk_buff_head list;
+   struct sk_buff *skb;
+
+   __skb_queue_head_init(&list);
+   while (ath10k_ce_completed_send_next(ce_state, (void **)&skb) == 0) {
+   if (!skb)
+   continue;
+
+   __skb_queue_tail(&list, skb);
+   }
+
+   while ((skb = __skb_dequeue(&list)))
+   ath10k_htc_tx_completion_handler(ar, skb);
+}
+
+static void ath10k_snoc_htt_tx_cb(struct ath10k_ce_pipe *ce_state)
+{
+   struct ath10k *ar = ce_state->ar;
+   struct sk_buff *skb;
+
+   while (ath10k_ce_completed_send_next(ce_state, (void **)&skb) == 0) {
+   if (!skb)
+   continue;
+
+   dma_unmap_single(ar->dev, ATH10K_SKB_CB(skb)->paddr,
+skb->len, DMA_TO_DEVICE);
+   ath10k_htt_hif_tx_complete(ar, skb);
+   }
+}
+
+static int ath10k_snoc_hif_tx_sg(struct ath10k *ar, u8 pipe_id,
+struct ath10k_hif_sg_item *items, int n_items)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   struct ath10k_ce *ce = ath10k_ce_priv(ar);
+   struct ath10k_snoc_pipe *snoc_pipe;
+   struct ath10k_ce_pipe *ce_pipe;
+   int err, i = 0;
+
+   snoc_pipe = &ar_snoc->pipe_info[pipe_id];
+   ce_pipe = snoc_pipe->ce_hdl;
+   spin_lock_bh(&ce->ce_lock);
+
+   for (i = 0; i < n_items - 1; i++) {
+   ath10k_dbg(ar, ATH10K_DBG_SNOC,
+  "snoc tx item %d paddr %pad len %d n_items %d\n",
+  i, &items[i].paddr, items[i].len, n_items);
+
+   err = ath10k_ce_send_nolock(ce_pipe,
+   items[i].transfer_context,
+   items[i].paddr,
+   items[i].len,
+   items[i].transfer_id,
+   CE_SEND_FLAG_GATHER);
+   if (err)
+   goto err;
+   }
+
+   ath10k_dbg(ar, ATH10K_DBG_SNOC,
+  "snoc tx item %d paddr %pad len %d n_items %d\n",
+  i, &items[i].paddr, items[i].len, n_items);
+
+   err = ath10k_ce_send_nolock(ce_pipe,
+   items[i].transfer_context,
+   items[i].paddr,
+   items[i].len,
+   items[i].transfer_id,
+   0);
+   if (err)
+   goto err;
+
+   spin_unlock_bh(&ce->ce_lock);
+
+   return 0;
+
+err:
+   for (; i > 0; i--)
+   __ath10k_ce_send_revert(ce_pipe);
+
+   spin_unlock_bh(&ce->ce_lock);
+   return err;
+}
+
+static u16 ath10k_snoc_hif_get_free_queue_number(struct ath10k *ar, u8 pipe)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+
+   ath10k_dbg(ar, ATH10K_DBG_SNOC, "hif get free queue number\n");
+
+   return ath10k_ce_num_free_src_entries(ar_snoc->pipe_info[pipe].ce_hdl);
+}
+
+static void ath10k_snoc_hif_send_complete_check(struct ath10k *ar, u8 pipe,
+

[PATCH v2 10/13] ath10k: Add support to get target info from hif ops

2018-03-22 Thread Govind Singh 
From: Rakesh Pillai 

wcn3990 does not use bmi.
Add support to get target info from hif ops.

Signed-off-by: Rakesh Pillai 
Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/core.c |  8 
 drivers/net/wireless/ath/ath10k/hif.h  | 13 +
 drivers/net/wireless/ath/ath10k/snoc.c | 10 ++
 3 files changed, 31 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/core.c 
b/drivers/net/wireless/ath/ath10k/core.c
index 830b7fe..61443f5 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -2468,6 +2468,14 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
ar->hw->wiphy->hw_version = target_info.version;
break;
case ATH10K_BUS_SNOC:
+   memset(&target_info, 0, sizeof(target_info));
+   ret = ath10k_hif_get_target_info(ar, &target_info);
+   if (ret) {
+   ath10k_err(ar, "could not get target info (%d)\n", ret);
+   goto err_power_down;
+   }
+   ar->target_version = target_info.version;
+   ar->hw->wiphy->hw_version = target_info.version;
break;
default:
ath10k_err(ar, "incorrect hif bus type: %d\n", ar->hif.bus);
diff --git a/drivers/net/wireless/ath/ath10k/hif.h 
b/drivers/net/wireless/ath/ath10k/hif.h
index 7abb13c..1a59ea0 100644
--- a/drivers/net/wireless/ath/ath10k/hif.h
+++ b/drivers/net/wireless/ath/ath10k/hif.h
@@ -20,6 +20,7 @@
 
 #include 
 #include "core.h"
+#include "bmi.h"
 #include "debug.h"
 
 struct ath10k_hif_sg_item {
@@ -93,6 +94,9 @@ struct ath10k_hif_ops {
/* fetch calibration data from target eeprom */
int (*fetch_cal_eeprom)(struct ath10k *ar, void **data,
size_t *data_len);
+
+   int (*get_target_info)(struct ath10k *ar,
+  struct bmi_target_info *target_info);
 };
 
 static inline int ath10k_hif_tx_sg(struct ath10k *ar, u8 pipe_id,
@@ -218,4 +222,13 @@ static inline int ath10k_hif_fetch_cal_eeprom(struct 
ath10k *ar,
return ar->hif.ops->fetch_cal_eeprom(ar, data, data_len);
 }
 
+static inline int ath10k_hif_get_target_info(struct ath10k *ar,
+struct bmi_target_info *tgt_info)
+{
+   if (!ar->hif.ops->get_target_info)
+   return -EOPNOTSUPP;
+
+   return ar->hif.ops->get_target_info(ar, tgt_info);
+}
+
 #endif /* _HIF_H_ */
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 6d9ccce..1ef0d3b 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -528,6 +528,15 @@ static int ath10k_snoc_hif_tx_sg(struct ath10k *ar, u8 
pipe_id,
return err;
 }
 
+static int ath10k_snoc_hif_get_target_info(struct ath10k *ar,
+  struct bmi_target_info *target_info)
+{
+   target_info->version = ATH10K_HW_WCN3990;
+   target_info->type = ATH10K_HW_WCN3990;
+
+   return 0;
+}
+
 static u16 ath10k_snoc_hif_get_free_queue_number(struct ath10k *ar, u8 pipe)
 {
struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
@@ -787,6 +796,7 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar)
.tx_sg  = ath10k_snoc_hif_tx_sg,
.send_complete_check= ath10k_snoc_hif_send_complete_check,
.get_free_queue_number  = ath10k_snoc_hif_get_free_queue_number,
+   .get_target_info= ath10k_snoc_hif_get_target_info,
 };
 
 static const struct ath10k_bus_ops ath10k_snoc_bus_ops = {
-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block

2018-03-22 Thread Govind Singh 
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".

Signed-off-by: Govind Singh 
---
 .../bindings/net/wireless/qcom,ath10k.txt  | 31 ++
 1 file changed, 31 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt 
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 3d2a031..34e4f98 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Should be one of the following:
* "qcom,ath10k"
* "qcom,ipq4019-wifi"
+   * "qcom,wcn3990-wifi"
 
 PCI based devices uses compatible string "qcom,ath10k" and takes calibration
 data along with board specific data via "qcom,ath10k-calibration-data".
@@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
 "qcom,ath10k-calibration-data" conflict with each other and only one
 can be provided per device.
 
+SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
+
 Optional properties:
 - reg: Address and length of the register set for the device.
+- reg-names: Must include the list of following reg names,
+"membase"
 - resets: Must contain an entry for each entry in reset-names.
   See ../reset/reseti.txt for details.
 - reset-names: Must include the list of following reset names,
@@ -49,6 +54,8 @@ Optional properties:
 hw versions.
 - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
 the length can vary between hw versions.
+- -supply: handle to the regulator device tree node
+  optional "supply-name" is "vdd-0.8-cx-mx".
 
 Example (to supply the calibration data alone):
 
@@ -119,3 +126,27 @@ wifi0: wifi@a00 {
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
 };
+
+Example (to supply wcn3990 SoC wifi block details):
+
+qcom,wifi@1800 {
+   compatible = "qcom,wcn3990-wifi";
+   reg = <0x1880 0x80>;
+   reg-names = "membase";
+   clocks = <&clock_gcc clk_aggre2_noc_clk>;
+   clock-names = "smmu_aggre2_noc_clk"
+   interrupts =
+  <0 130 0 /* CE0 */ >,
+  <0 131 0 /* CE1 */ >,
+  <0 132 0 /* CE2 */ >,
+  <0 133 0 /* CE3 */ >,
+  <0 134 0 /* CE4 */ >,
+  <0 135 0 /* CE5 */ >,
+  <0 136 0 /* CE6 */ >,
+  <0 137 0 /* CE7 */ >,
+  <0 138 0 /* CE8 */ >,
+  <0 139 0 /* CE9 */ >,
+  <0 140 0 /* CE10 */ >,
+  <0 141 0 /* CE11 */ >;
+   vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+};
-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 05/13] ath10k: Map HTC services to tx/rx pipes for wcn3990

2018-03-22 Thread Govind Singh 
Add mapping of HTC endpoint services supported
by wcn3990 target to tx/rx pipe.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 168 +
 1 file changed, 168 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index dcd8bb7..a39eee7 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -154,6 +154,116 @@
},
 };
 
+static struct service_to_pipe target_service_to_ce_map_wlan[] = {
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_VO),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(3),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_VO),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_BK),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(3),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_BK),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_BE),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(3),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_BE),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_VI),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(3),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_DATA_VI),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_CONTROL),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(3),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_WMI_CONTROL),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_RSVD_CTRL),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(0),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_RSVD_CTRL),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   { /* not used */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_TEST_RAW_STREAMS),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(0),
+   },
+   { /* not used */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_TEST_RAW_STREAMS),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(2),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_HTT_DATA_MSG),
+   __cpu_to_le32(PIPEDIR_OUT), /* out = UL = host -> target */
+   __cpu_to_le32(4),
+   },
+   {
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_HTT_DATA_MSG),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(1),
+   },
+   { /* not used */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_TEST_RAW_STREAMS),
+   __cpu_to_le32(PIPEDIR_OUT),
+   __cpu_to_le32(5),
+   },
+   { /* in = DL = target -> host */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_HTT_DATA2_MSG),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(9),
+   },
+   { /* in = DL = target -> host */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_HTT_DATA3_MSG),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(10),
+   },
+   { /* in = DL = target -> host pktlog */
+   __cpu_to_le32(ATH10K_HTC_SVC_ID_HTT_LOG_MSG),
+   __cpu_to_le32(PIPEDIR_IN),  /* in = DL = target -> host */
+   __cpu_to_le32(11),
+   },
+   /* (Additions here) */
+
+   { /* must be last */
+   __cpu_to_le32(0),
+   __cpu_to_le32(0),
+   __cpu_to_le32(0),
+   },
+};
+
 void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value)
 {
struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
@@ -249,6 +359,62 @@ static void ath10k_snoc_rx_post(struct ath10k *ar)

[PATCH v2 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module

2018-03-22 Thread Govind Singh 
WCN3990 is integrated 802.11ac chipset with SNOC
bus interface. Add snoc layer driver registration
and associated ops.

WCN3990 support is not yet complete as cold-boot
handshake is done using qmi(Qualcomm-MSM-Interface)
and qmi client support will be added once qmi framework
is available.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/Kconfig  |   8 ++
 drivers/net/wireless/ath/ath10k/Makefile |   3 +
 drivers/net/wireless/ath/ath10k/snoc.c   | 153 +++
 drivers/net/wireless/ath/ath10k/snoc.h   |  76 +++
 4 files changed, 240 insertions(+)
 create mode 100644 drivers/net/wireless/ath/ath10k/snoc.c
 create mode 100644 drivers/net/wireless/ath/ath10k/snoc.h

diff --git a/drivers/net/wireless/ath/ath10k/Kconfig 
b/drivers/net/wireless/ath/ath10k/Kconfig
index d266f27..84f071a 100644
--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -40,6 +40,14 @@ config ATH10K_USB
  This module adds experimental support for USB bus. Currently
  work in progress and will not fully work.
 
+config ATH10K_SNOC
+tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
+depends on ATH10K && ARCH_QCOM
+---help---
+  This module adds support for integrated WCN3990 chip connected
+  to system NOC(SNOC). Currently work in progress and will not
+  fully work.
+
 config ATH10K_DEBUG
bool "Atheros ath10k debugging"
depends on ATH10K
diff --git a/drivers/net/wireless/ath/ath10k/Makefile 
b/drivers/net/wireless/ath/ath10k/Makefile
index 536f3df..44d60a6 100644
--- a/drivers/net/wireless/ath/ath10k/Makefile
+++ b/drivers/net/wireless/ath/ath10k/Makefile
@@ -35,5 +35,8 @@ ath10k_sdio-y += sdio.o
 obj-$(CONFIG_ATH10K_USB) += ath10k_usb.o
 ath10k_usb-y += usb.o
 
+obj-$(CONFIG_ATH10K_SNOC) += ath10k_snoc.o
+ath10k_snoc-y += snoc.o
+
 # for tracing framework to find trace.h
 CFLAGS_trace.o := -I$(src)
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
new file mode 100644
index 000..30354a6
--- /dev/null
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -0,0 +1,153 @@
+/*
+ * Copyright (c) 2018 The Linux Foundation. All rights reserved.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include 
+#include 
+#include "debug.h"
+#include "hif.h"
+#include "htc.h"
+#include "ce.h"
+#include "snoc.h"
+#include 
+#include 
+#include 
+
+static const struct ath10k_snoc_drv_priv drv_priv = {
+   .hw_rev = ATH10K_HW_WCN3990,
+   .dma_mask = DMA_BIT_MASK(37),
+};
+
+void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+
+   iowrite32(value, ar_snoc->mem + offset);
+}
+
+u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   u32 val;
+
+   val = ioread32(ar_snoc->mem + offset);
+
+   return val;
+}
+
+static const struct ath10k_hif_ops ath10k_snoc_hif_ops = {
+   .read32 = ath10k_snoc_read32,
+   .write32= ath10k_snoc_write32,
+};
+
+static const struct ath10k_bus_ops ath10k_snoc_bus_ops = {
+   .read32 = ath10k_snoc_read32,
+   .write32= ath10k_snoc_write32,
+};
+
+static const struct of_device_id ath10k_snoc_dt_match[] = {
+   { .compatible = "qcom,wcn3990-wifi",
+.data = &drv_priv,
+   },
+   { }
+};
+MODULE_DEVICE_TABLE(of, ath10k_snoc_dt_match);
+
+static int ath10k_snoc_probe(struct platform_device *pdev)
+{
+   const struct ath10k_snoc_drv_priv *drv_data;
+   const struct of_device_id *of_id;
+   struct ath10k_snoc *ar_snoc;
+   struct device *dev;
+   struct ath10k *ar;
+   int ret;
+
+   of_id = of_match_device(ath10k_snoc_dt_match, &pdev->dev);
+   if (!of_id) {
+   dev_err(&pdev->dev, "failed to find matching device tree id\n");
+   return -EINVAL;
+   }
+
+   drv_data = of_id->data;
+   dev = &pdev->dev;
+
+   ret = dma_set_mask_and_coherent(dev, drv_data->dma_mask);
+   if (ret) {
+   dev_err(dev, "failed to set dma mask: %d", ret);
+   return ret;
+   }
+
+   ar = ath10k_core

[PATCH v2 09/13] ath10k: Modify hif tx paddr to dma_addr_t type

2018-03-22 Thread Govind Singh 
Change type of hif sg tx paddr to dma_addr_t for
supporting target having addressing mode greater than
32 bit.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/hif.h | 2 +-
 drivers/net/wireless/ath/ath10k/pci.c | 8 
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/hif.h 
b/drivers/net/wireless/ath/ath10k/hif.h
index 6da4e33..7abb13c 100644
--- a/drivers/net/wireless/ath/ath10k/hif.h
+++ b/drivers/net/wireless/ath/ath10k/hif.h
@@ -26,7 +26,7 @@ struct ath10k_hif_sg_item {
u16 transfer_id;
void *transfer_context; /* NULL = tx completion callback not called */
void *vaddr; /* for debugging mostly */
-   u32 paddr;
+   dma_addr_t paddr;
u16 len;
 };
 
diff --git a/drivers/net/wireless/ath/ath10k/pci.c 
b/drivers/net/wireless/ath/ath10k/pci.c
index 808f3d6..e7c544b 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1379,8 +1379,8 @@ int ath10k_pci_hif_tx_sg(struct ath10k *ar, u8 pipe_id,
 
for (i = 0; i < n_items - 1; i++) {
ath10k_dbg(ar, ATH10K_DBG_PCI,
-  "pci tx item %d paddr 0x%08x len %d n_items %d\n",
-  i, items[i].paddr, items[i].len, n_items);
+  "pci tx item %d paddr %pad len %d n_items %d\n",
+  i, &items[i].paddr, items[i].len, n_items);
ath10k_dbg_dump(ar, ATH10K_DBG_PCI_DUMP, NULL, "pci tx data: ",
items[i].vaddr, items[i].len);
 
@@ -1397,8 +1397,8 @@ int ath10k_pci_hif_tx_sg(struct ath10k *ar, u8 pipe_id,
/* `i` is equal to `n_items -1` after for() */
 
ath10k_dbg(ar, ATH10K_DBG_PCI,
-  "pci tx item %d paddr 0x%08x len %d n_items %d\n",
-  i, items[i].paddr, items[i].len, n_items);
+  "pci tx item %d paddr %pad len %d n_items %d\n",
+  i, &items[i].paddr, items[i].len, n_items);
ath10k_dbg_dump(ar, ATH10K_DBG_PCI_DUMP, NULL, "pci tx data: ",
items[i].vaddr, items[i].len);
 
-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 02/13] ath10k: add resource init and deinit for WCN3990

2018-03-22 Thread Govind Singh 
Add methods for resource(memory, irq, HOST CE config)
initialization and de-initialization for WCN3990 target.

WCN3990 target uses 12 copy engine and following CE config.

[CE0] :host->target control and raw streams
[CE1] :target->host HTT
[CE2] :target->host WMI
[CE3] :host->target WMI
[CE4] :host->target HTT
[CE5] :reserved
[CE6] :Target autonomous HIF_memcpy
[CE7] :reserved
[CE8] :reserved
[CE9] :target->host HTT
[CE10] :target->host HTT
[CE11] :target -> host PKTLOG

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 271 +
 1 file changed, 271 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 30354a6..575355c 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -24,12 +24,135 @@
 #include 
 #include 
 #include 
+#define  WCN3990_CE_ATTR_FLAGS 0
+
+static char *const ce_name[] = {
+   "WLAN_CE_0",
+   "WLAN_CE_1",
+   "WLAN_CE_2",
+   "WLAN_CE_3",
+   "WLAN_CE_4",
+   "WLAN_CE_5",
+   "WLAN_CE_6",
+   "WLAN_CE_7",
+   "WLAN_CE_8",
+   "WLAN_CE_9",
+   "WLAN_CE_10",
+   "WLAN_CE_11",
+};
 
 static const struct ath10k_snoc_drv_priv drv_priv = {
.hw_rev = ATH10K_HW_WCN3990,
.dma_mask = DMA_BIT_MASK(37),
 };
 
+static struct ce_attr host_ce_config_wlan[] = {
+   /* CE0: host->target HTC control streams */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 16,
+   .src_sz_max = 2048,
+   .dest_nentries = 0,
+   .send_cb = NULL,
+   },
+
+   /* CE1: target->host HTT + HTC control */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 512,
+   .recv_cb = NULL,
+   },
+
+   /* CE2: target->host WMI */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 64,
+   .recv_cb = NULL,
+   },
+
+   /* CE3: host->target WMI */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 32,
+   .src_sz_max = 2048,
+   .dest_nentries = 0,
+   .send_cb = NULL,
+   },
+
+   /* CE4: host->target HTT */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS | CE_ATTR_DIS_INTR,
+   .src_nentries = 256,
+   .src_sz_max = 256,
+   .dest_nentries = 0,
+   .send_cb = NULL,
+   },
+
+   /* CE5: target->host HTT (ipa_uc->target ) */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 512,
+   .dest_nentries = 512,
+   .recv_cb = NULL,
+   },
+
+   /* CE6: target autonomous hif_memcpy */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 0,
+   .dest_nentries = 0,
+   },
+
+   /* CE7: ce_diag, the Diagnostic Window */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 2,
+   .src_sz_max = 2048,
+   .dest_nentries = 2,
+   },
+
+   /* CE8: Target to uMC */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 128,
+   },
+
+   /* CE9 target->host HTT */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 512,
+   .recv_cb = NULL,
+   },
+
+   /* CE10: target->host HTT */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 512,
+   .recv_cb = NULL,
+   },
+
+   /* CE11: target -> host PKTLOG */
+   {
+   .flags = WCN3990_CE_ATTR_FLAGS,
+   .src_nentries = 0,
+   .src_sz_max = 2048,
+   .dest_nentries = 512,
+   .recv_cb = NULL,
+   },
+};
+
 void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value)
 {
struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
@@ -57,6 +180,119 @@ u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset)
.write32= ath10k_snoc_write32,
 };
 
+static irqreturn_t ath10k_snoc_per_engine_handler(int irq, void *arg)
+{
+   return IRQ_HANDLED;
+}
+
+static int ath10k_snoc_request_irq(struct ath10k *ar)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   int irqflags = IRQF_TRIGGER_RISING;
+   int ret, id;
+
+   for (id = 0; id < CE_COUNT_MAX; id++) {
+

[PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support ***

2018-03-22 Thread Govind Singh 
This change adds support for integrated wcn3990 chipset on
MSM platforms. WCN3990 is 2x2 802.11ac chipset where wlan
subsystem is interfaced over system interconnect.
Wlan fw runs in Q6 DSP. WCN3990 chipset uses 12 copy engine
for host to target and target to host communication. It has
extra 2 copy engine in rx data path and packet log capability
is exposed via new HTC service over dedicated copy engine.
Each CE has dedicated interrupt of rx path and tx completion.

[CE0] :host->target control and raw streams
[CE1] :target->host HTT
[CE2] :target->host WMI
[CE3] :host->target WMI
[CE4] :host->target HTT
[CE5] :reserved
[CE6] :Target autonomous HIF_memcpy
[CE7] :reserved
[CE8] :reserved
[CE9] :target->host HTT
[CE10] :target->host HTT
[CE11] :target -> host PKTLOG

Changes in V2:
Rebased the set on top of https://patchwork.kernel.org/patch/10298657/.
Removed qcom,-config and minor clean up in dt binding documentation.

Govind Singh (11):
  ath10k: platform driver for WCN3990 SNOC WLAN module
  ath10k: add resource init and deinit for WCN3990
  ath10k: Add hif start/stop methods for wcn3990 snoc layer
  ath10k: Add HTC services for WCN3990
  ath10k: Map HTC services to tx/rx pipes for wcn3990
  ath10k: Add hif power-up/power-down methods
  ath10k: Add hif tx methods for wcn3990
  ath10k: Add hif rx methods for wcn3990
  ath10k: Modify hif tx paddr to dma_addr_t type
  ath10k: Vote for hardware resources for WCN3990
  dt: bindings: add bindings for wcn3990 wifi block

Rakesh Pillai (2):
  ath10k: Add support to get target info from hif ops
  ath10k: Check all CE for data if irq summary is not retained

 .../bindings/net/wireless/qcom,ath10k.txt  |   31 +
 drivers/net/wireless/ath/ath10k/Kconfig|8 +
 drivers/net/wireless/ath/ath10k/Makefile   |3 +
 drivers/net/wireless/ath/ath10k/ce.h   |   10 +-
 drivers/net/wireless/ath/ath10k/core.c |   21 +
 drivers/net/wireless/ath/ath10k/hif.h  |   15 +-
 drivers/net/wireless/ath/ath10k/htc.c  |6 +
 drivers/net/wireless/ath/ath10k/htc.h  |4 +
 drivers/net/wireless/ath/ath10k/hw.h   |3 +
 drivers/net/wireless/ath/ath10k/pci.c  |8 +-
 drivers/net/wireless/ath/ath10k/snoc.c | 1411 
 drivers/net/wireless/ath/ath10k/snoc.h |   95 ++
 12 files changed, 1607 insertions(+), 8 deletions(-)
 create mode 100644 drivers/net/wireless/ath/ath10k/snoc.c
 create mode 100644 drivers/net/wireless/ath/ath10k/snoc.h

-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 04/13] ath10k: Add HTC services for WCN3990

2018-03-22 Thread Govind Singh 
WCN3990 target uses 3 Copy engine(CE1/CE9/CE10) in RX path
and CE 11 for pktlog.
Add data path HTC ep services and PKTLOG services for WCN3990.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/htc.c | 6 ++
 drivers/net/wireless/ath/ath10k/htc.h | 4 
 2 files changed, 10 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/htc.c 
b/drivers/net/wireless/ath/ath10k/htc.c
index 492dc5b..8902720 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -542,8 +542,14 @@ static const char *htc_service_name(enum ath10k_htc_svc_id 
id)
return "NMI Data";
case ATH10K_HTC_SVC_ID_HTT_DATA_MSG:
return "HTT Data";
+   case ATH10K_HTC_SVC_ID_HTT_DATA2_MSG:
+   return "HTT Data";
+   case ATH10K_HTC_SVC_ID_HTT_DATA3_MSG:
+   return "HTT Data";
case ATH10K_HTC_SVC_ID_TEST_RAW_STREAMS:
return "RAW";
+   case ATH10K_HTC_SVC_ID_HTT_LOG_MSG:
+   return "PKTLOG";
}
 
return "Unknown";
diff --git a/drivers/net/wireless/ath/ath10k/htc.h 
b/drivers/net/wireless/ath/ath10k/htc.h
index a2f8814..3487759 100644
--- a/drivers/net/wireless/ath/ath10k/htc.h
+++ b/drivers/net/wireless/ath/ath10k/htc.h
@@ -248,6 +248,7 @@ enum ath10k_htc_svc_gid {
ATH10K_HTC_SVC_GRP_WMI = 1,
ATH10K_HTC_SVC_GRP_NMI = 2,
ATH10K_HTC_SVC_GRP_HTT = 3,
+   ATH10K_LOG_SERVICE_GROUP = 6,
 
ATH10K_HTC_SVC_GRP_TEST = 254,
ATH10K_HTC_SVC_GRP_LAST = 255,
@@ -273,6 +274,9 @@ enum ath10k_htc_svc_id {
 
ATH10K_HTC_SVC_ID_HTT_DATA_MSG  = SVC(ATH10K_HTC_SVC_GRP_HTT, 0),
 
+   ATH10K_HTC_SVC_ID_HTT_DATA2_MSG = SVC(ATH10K_HTC_SVC_GRP_HTT, 1),
+   ATH10K_HTC_SVC_ID_HTT_DATA3_MSG = SVC(ATH10K_HTC_SVC_GRP_HTT, 2),
+   ATH10K_HTC_SVC_ID_HTT_LOG_MSG = SVC(ATH10K_LOG_SERVICE_GROUP, 0),
/* raw stream service (i.e. flash, tcmd, calibration apps) */
ATH10K_HTC_SVC_ID_TEST_RAW_STREAMS = SVC(ATH10K_HTC_SVC_GRP_TEST, 0),
 };
-- 
1.9.1


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH v2 03/13] ath10k: Add hif start/stop methods for wcn3990 snoc layer

2018-03-22 Thread Govind Singh 
Add hif start/stop callback for allocating/freeing buffers
on tx/rx pipe and enabling/disabling the tx/rx pipe
interrupts.

Signed-off-by: Govind Singh 
---
 drivers/net/wireless/ath/ath10k/snoc.c | 189 -
 1 file changed, 187 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c 
b/drivers/net/wireless/ath/ath10k/snoc.c
index 575355c..dcd8bb7 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -25,6 +25,7 @@
 #include 
 #include 
 #define  WCN3990_CE_ATTR_FLAGS 0
+#define ATH10K_SNOC_RX_POST_RETRY_MS 50
 
 static char *const ce_name[] = {
"WLAN_CE_0",
@@ -170,9 +171,193 @@ u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset)
return val;
 }
 
+static int __ath10k_snoc_rx_post_buf(struct ath10k_snoc_pipe *pipe)
+{
+   struct ath10k_ce_pipe *ce_pipe = pipe->ce_hdl;
+   struct ath10k *ar = pipe->hif_ce_state;
+   struct ath10k_ce *ce = ath10k_ce_priv(ar);
+   struct sk_buff *skb;
+   dma_addr_t paddr;
+   int ret;
+
+   skb = dev_alloc_skb(pipe->buf_sz);
+   if (!skb)
+   return -ENOMEM;
+
+   WARN_ONCE((unsigned long)skb->data & 3, "unaligned skb");
+
+   paddr = dma_map_single(ar->dev, skb->data,
+  skb->len + skb_tailroom(skb),
+  DMA_FROM_DEVICE);
+   if (unlikely(dma_mapping_error(ar->dev, paddr))) {
+   ath10k_warn(ar, "failed to dma map snoc rx buf\n");
+   dev_kfree_skb_any(skb);
+   return -EIO;
+   }
+
+   ATH10K_SKB_RXCB(skb)->paddr = paddr;
+
+   spin_lock_bh(&ce->ce_lock);
+   ret = ce_pipe->ops->ce_rx_post_buf(ce_pipe, skb, paddr);
+   spin_unlock_bh(&ce->ce_lock);
+   if (ret) {
+   dma_unmap_single(ar->dev, paddr, skb->len + skb_tailroom(skb),
+DMA_FROM_DEVICE);
+   dev_kfree_skb_any(skb);
+   return ret;
+   }
+
+   return 0;
+}
+
+static void ath10k_snoc_rx_post_pipe(struct ath10k_snoc_pipe *pipe)
+{
+   struct ath10k *ar = pipe->hif_ce_state;
+   struct ath10k_ce *ce = ath10k_ce_priv(ar);
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   struct ath10k_ce_pipe *ce_pipe = pipe->ce_hdl;
+   int ret, num;
+
+   if (pipe->buf_sz == 0)
+   return;
+
+   if (!ce_pipe->dest_ring)
+   return;
+
+   spin_lock_bh(&ce->ce_lock);
+   num = __ath10k_ce_rx_num_free_bufs(ce_pipe);
+   spin_unlock_bh(&ce->ce_lock);
+   while (num--) {
+   ret = __ath10k_snoc_rx_post_buf(pipe);
+   if (ret) {
+   if (ret == -ENOSPC)
+   break;
+   ath10k_warn(ar, "failed to post rx buf: %d\n", ret);
+   mod_timer(&ar_snoc->rx_post_retry, jiffies +
+ ATH10K_SNOC_RX_POST_RETRY_MS);
+   break;
+   }
+   }
+}
+
+static void ath10k_snoc_rx_post(struct ath10k *ar)
+{
+   struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+   int i;
+
+   for (i = 0; i < CE_COUNT; i++)
+   ath10k_snoc_rx_post_pipe(&ar_snoc->pipe_info[i]);
+}
+
+static inline void ath10k_snoc_irq_disable(struct ath10k *ar)
+{
+   ath10k_ce_disable_interrupts(ar);
+}
+
+static inline void ath10k_snoc_irq_enable(struct ath10k *ar)
+{
+   ath10k_ce_enable_interrupts(ar);
+}
+
+static void ath10k_snoc_rx_pipe_cleanup(struct ath10k_snoc_pipe *snoc_pipe)
+{
+   struct ath10k_ce_pipe *ce_pipe;
+   struct ath10k_ce_ring *ce_ring;
+   struct sk_buff *skb;
+   struct ath10k *ar;
+   int i;
+
+   ar = snoc_pipe->hif_ce_state;
+   ce_pipe = snoc_pipe->ce_hdl;
+   ce_ring = ce_pipe->dest_ring;
+
+   if (!ce_ring)
+   return;
+
+   if (!snoc_pipe->buf_sz)
+   return;
+
+   for (i = 0; i < ce_ring->nentries; i++) {
+   skb = ce_ring->per_transfer_context[i];
+   if (!skb)
+   continue;
+
+   ce_ring->per_transfer_context[i] = NULL;
+
+   dma_unmap_single(ar->dev, ATH10K_SKB_RXCB(skb)->paddr,
+skb->len + skb_tailroom(skb),
+DMA_FROM_DEVICE);
+   dev_kfree_skb_any(skb);
+   }
+}
+
+static void ath10k_snoc_tx_pipe_cleanup(struct ath10k_snoc_pipe *snoc_pipe)
+{
+   struct ath10k_ce_pipe *ce_pipe;
+   struct ath10k_ce_ring *ce_ring;
+   struct ath10k_snoc *ar_snoc;
+   struct sk_buff *skb;
+   struct ath10k *ar;
+   int i;
+
+   ar = snoc_pipe->hif_ce_state;
+   ar_snoc = ath10k_snoc_priv(ar);
+   ce_pipe = snoc_pipe->ce_hdl;
+   ce_ring = ce_pipe->src_ring;
+
+   if (!ce_ring)
+   return;
+
+   if (!snoc_pipe->buf_sz)
+   return;
+
+   for (i = 0;

RE: [ath10k throughput] low throughput in multi-user mode

2018-03-22 Thread gary 

Hi Ben,

Thank you for your reply.
My wireless driver is compat-wireless_2017-10-6, and kernel is 4.9.58.

The test result with your firmware:
Get throughput 1.13Gbps with 16 users.
And get almost 0 with 32 users.

By my observation, in one try, ath10k_htt_rx_tx_mode_switch_ind is invoked
only twice.
As a result, the ath10k driver can't get the latest num_push_allowed(always
zero).

Do you have any idea of it?

-Original Message-
From: ath10k [mailto:ath10k-boun...@lists.infradead.org] On Behalf Of Ben
Greear
Sent: 2018年3月22日 0:31
To: gary; linux-wirel...@vger.kernel.org; ath10k@lists.infradead.org
Subject: Re: [ath10k throughput] low throughput in multi-user mode


On 03/20/2018 06:44 PM, gary wrote:
>
> Hi all,
> I have run the throughput test on veriwave.(from Ethernet to wireless) 
> My AP suports 4*4, 11ac, mu-mimo.,wireless chip is QCA9984.
> At first, the throughput is about 80Mbps only with 16 users, so I 
> force to return true in function ath10k_mac_tx_can_push().
> As a result, when the user number is 1~16, the udp throughput is about 
> 1.2Gbps ~1.4Gbps.
> But when the user number is 32, the udp throughput is only 520Mbps.
>
> So I try to substitute ath10k-firmware.
> With firmware 10.4-3.4-0082 and above, the throughput is around 520Mbps.
> But with firmware 10.4-3.4-0072, the throughput gets 1.1Gbps.
>
> Do I miss something in configuration?
> Any comment is appreciated.

What kernel version (or backports, if you are using that?) are you using?

And, I'd be curious how the latest ath10k-CT (beta) firmware compares if you
have time to try that:

http://www.candelatech.com/ath10k-10.4.php

At least in upload testing, we get better throughput with lots of virtual
stations if we tune the number of tx descriptors to be larger as that will
generate larger AMPDUs on air.

You might also check your rate-ctrl logic to make sure all of your stations
are using higher MCS rates.

Thanks,
Ben

--
Ben Greear 
Candela Technologies Inc  http://www.candelatech.com


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k




___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

RE: [ath10k throughput] low throughput in multi-user mode

2018-03-22 Thread gary 

Hi Ben,

Thank you for your reply.
My wireless driver is compat-wireless_2017-10-6, and kernel is 4.9.58.
The firmware can't work on my testbed.
By my observation, in one try, ath10k_htt_rx_tx_mode_switch_ind is invoked
only twice.
As a result, the ath10k driver can't get the latest num_push_allowed(always
zero).

Do you have any idea of it?
 

-Original Message-
From: ath10k [mailto:ath10k-boun...@lists.infradead.org] On Behalf Of Ben
Greear
Sent: 2018年3月22日 0:31
To: gary; linux-wirel...@vger.kernel.org; ath10k@lists.infradead.org
Subject: Re: [ath10k throughput] low throughput in multi-user mode


On 03/20/2018 06:44 PM, gary wrote:
>
> Hi all,
> I have run the throughput test on veriwave.(from Ethernet to wireless) 
> My AP suports 4*4, 11ac, mu-mimo.,wireless chip is QCA9984.
> At first, the throughput is about 80Mbps only with 16 users, so I 
> force to return true in function ath10k_mac_tx_can_push().
> As a result, when the user number is 1~16, the udp throughput is about 
> 1.2Gbps ~1.4Gbps.
> But when the user number is 32, the udp throughput is only 520Mbps.
>
> So I try to substitute ath10k-firmware.
> With firmware 10.4-3.4-0082 and above, the throughput is around 520Mbps.
> But with firmware 10.4-3.4-0072, the throughput gets 1.1Gbps.
>
> Do I miss something in configuration?
> Any comment is appreciated.

What kernel version (or backports, if you are using that?) are you using?

And, I'd be curious how the latest ath10k-CT (beta) firmware compares if you
have time to try that:

http://www.candelatech.com/ath10k-10.4.php

At least in upload testing, we get better throughput with lots of virtual
stations if we tune the number of tx descriptors to be larger as that will
generate larger AMPDUs on air.

You might also check your rate-ctrl logic to make sure all of your stations
are using higher MCS rates.

Thanks,
Ben

--
Ben Greear 
Candela Technologies Inc  http://www.candelatech.com


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k




___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

qca6174 hw 2.1 firmware version SW_RM.1.1.1-00157-QCARMSWPZ-1 crash on deauthenticating from wireless network

2018-03-22 Thread Nick Hu 
Hello,

I am experiencing the following crash when deauthenticating (manually,
disconnect in Network Manager):

[   36.711973] wlp1s0: deauthenticating from 00:81:c4:85:0a:7f by local choice 
(Reason: 3=DEAUTH_LEAVING)
[   36.717973] ath10k_pci :01:00.0: firmware crashed! (uuid n/a)
[   36.717979] ath10k_pci :01:00.0: qca6174 hw2.1 target 0x0501 chip_id 
0x003405ff sub 144d:4125
[   36.717981] ath10k_pci :01:00.0: kconfig debug 0 debugfs 0 tracing 0 dfs 
0 testmode 0
[   36.718308] ath10k_pci :01:00.0: firmware ver 
SW_RM.1.1.1-00157-QCARMSWPZ-1 api 5 features ignore-otp,no-4addr-pad crc32 
10bf8e08
[   36.718477] ath10k_pci :01:00.0: board_file api 2 bmi_id N/A crc32 
ae2e275a
[   36.718479] ath10k_pci :01:00.0: htt-ver 3.1 wmi-op 4 htt-op 3 cal otp 
max-sta 32 raw 0 hwcrypto 1
[   36.720498] ath10k_pci :01:00.0: firmware register dump:
[   36.720502] ath10k_pci :01:00.0: [00]: 0x0501 0x 0x0092E4DC 
0x6F19C0E9
[   36.720505] ath10k_pci :01:00.0: [04]: 0x0092E4DC 0x00060130 0x0018 
0x0041A760
[   36.720507] ath10k_pci :01:00.0: [08]: 0x6F19C0D5 0x0040 0x 
0x000A5C88
[   36.720509] ath10k_pci :01:00.0: [12]: 0x0009 0x 0x0096C09C 
0x0096C0A7
[   36.720512] ath10k_pci :01:00.0: [16]: 0x0096BDBC 0x00991FCD 0x 
0x009287BD
[   36.720514] ath10k_pci :01:00.0: [20]: 0x4092E4DC 0x0041A710 0x 
0x0F00
[   36.720516] ath10k_pci :01:00.0: [24]: 0x809432A7 0x0041A770 0x0040D400 
0xC092E4DC
[   36.720518] ath10k_pci :01:00.0: [28]: 0x80942BC4 0x0041A790 0x6F19C0D5 
0x0040
[   36.720521] ath10k_pci :01:00.0: [32]: 0x80947BA7 0x0041A7B0 0x004050A8 
0x0040E074
[   36.720523] ath10k_pci :01:00.0: [36]: 0x809BDECC 0x0041A7D0 0x004050A8 
0x0040E074
[   36.720525] ath10k_pci :01:00.0: [40]: 0x8099638C 0x0041A7F0 0x004050A8 
0x
[   36.720527] ath10k_pci :01:00.0: [44]: 0x80992076 0x0041A810 0x0044FD68 
0x0046FFE8
[   36.720529] ath10k_pci :01:00.0: [48]: 0x80996BD3 0x0041A830 0x0044FD68 
0x
[   36.720531] ath10k_pci :01:00.0: [52]: 0x800B4405 0x0041A850 0x00422318 
0x5002
[   36.720533] ath10k_pci :01:00.0: [56]: 0x809A6C34 0x0041A8E0 0x0042932C 
0x0042CA20
[   36.720534] ath10k_pci :01:00.0: Copy Engine register dump:
[   36.720543] ath10k_pci :01:00.0: [00]: 0x00034400   1   1   3   3
[   36.720551] ath10k_pci :01:00.0: [01]: 0x00034800  12  12 399 400
[   36.720559] ath10k_pci :01:00.0: [02]: 0x00034c00  24  24  87  88
[   36.720567] ath10k_pci :01:00.0: [03]: 0x00035000  13  13  13  13
[   36.720575] ath10k_pci :01:00.0: [04]: 0x00035400  49  49  90  26
[   36.720583] ath10k_pci :01:00.0: [05]: 0x00035800   0   0   0   0
[   36.720591] ath10k_pci :01:00.0: [06]: 0x00035c00  29  29  29  29
[   36.720599] ath10k_pci :01:00.0: [07]: 0x00036000   1   1   1   1
[   36.725270] ath10k_pci :01:00.0: failed to submit keepalive on vdev 0: 
-108
[   36.725273] ath10k_pci :01:00.0: failed to disable keepalive on vdev 0: 
-108
[   36.786431] ieee80211 phy0: Hardware restart was requested
[   38.143264] ath10k_pci :01:00.0: device successfully recovered
[   39.775437] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   40.697423] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   41.209485] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   44.997864] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   58.617361] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   66.573886] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   69.200682] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   73.683270] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   77.814585] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   84.000475] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   85.755609] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   90.122704] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!
[   93.201172] ath10k_pci :01:00.0: no channel configured; ignoring 
frame(s)!

At this point, the wireless device is unresponsive until I disable and then
reenable Wi-Fi in Network Manager (or alternatively rmmod ath10k_pci; modprobe
ath10k_pci). Full dmesg available at 
https://bugzilla.kernel.org/attachment.cgi?id=260313
- this bug report mirrors https://bugzilla.kernel.org/show_bug.cgi?id=195987,
but it feels like it was better to reach out to the mailing list too.

The network adapter is

# lspci -nnkv

01:00.0 Network controller [0280]: Qualcomm Atheros QCA6174 802.11ac Wireless 
Network Adapter [168c:003e] (rev 20)
Subsystem: Samsung Electronics Co Ltd Device [144d:4125]
Flags: bus master, fast devsel, latency 0, IRQ 48
Memory at f700 (64-bit, non-prefetc

Interest in getting ath10k-ct firmware support upstream?

2018-03-22 Thread Ben Greear 

Hello Kalle,

I'm in the midst of porting my out-of-tree ath10k patches forward to the 4.16 
kernel.

In case you are interested in allowing support for ath10k-ct firmware
in the upstream kernel, now would be a good time for me to work on
this.

Please let me know if you are interested.

Thanks,
Ben

--
Ben Greear 
Candela Technologies Inc  http://www.candelatech.com


___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

QCA9880 driver crash with FW 10.2.4-1.0-00029

2018-03-22 Thread Hauke Mehrtens 
Hi,

I am using a BT home Hub 5A (Lantiq VR9 MIPS BE SoC). The wifi provided
by the QCA9880 chip is unstable with OpenWrt master from 26. Feb 2018.

With FW 10.2.4-1.0-00033 and 10.2.4-1.0-00037 the wifi stops working
after about 1 to 3 days and I do not get any error message. With FW
10.2.4-1.0-00029 I got this error message. FW 10.2.4.70.54 crashes
immediately.

The 2.4 GHz wifi provided by ath9k is very stable.

The wireless drivers shipped in OpenWrt master, which I am suing, are
based on backports with a snapshot of wireless testing from 1. November
2017, and I am running kernel 4.9.85.

.
[   11.198963] Loading modules backported from Linux version
wt-2017-11-01-0-gfe248fc2c180
[   11.205607] Backport generated by backports.git v4.14-rc2-1-31-g86cf0e5d

[   11.684780] PCI: Enabling device :01:00.0 ( -> 0002)
[   11.689195] PCI: Enabling device :02:00.0 ( -> 0002)
[   11.695034] ath10k_pci :02:00.0: pci irq legacy oper_irq_mode 1
irq_mode 0 reset_mode 0
[   11.951059] ath10k_pci :02:00.0: Direct firmware load for
ath10k/pre-cal-pci-:02:00.0.bin failed with error -2
[   11.960430] ath10k_pci :02:00.0: Falling back to user helper
[   12.364711] firmware ath10k!pre-cal-pci-:02:00.0.bin:
firmware_loading_store: map pages failed
[   12.375000] ath10k_pci :02:00.0: Direct firmware load for
ath10k/QCA988X/hw2.0/firmware-6.bin failed with error -2
[   12.384405] ath10k_pci :02:00.0: Falling back to user helper
[   12.635750] firmware ath10k!QCA988X!hw2.0!firmware-6.bin:
firmware_loading_store: map pages failed
[   12.714150] ath10k_pci :02:00.0: qca988x hw2.0 target 0x4100016c
chip_id 0x043202ff sub :
[   12.722030] ath10k_pci :02:00.0: kconfig debug 0 debugfs 1
tracing 0 dfs 1 testmode 1
[   12.741364] ath10k_pci :02:00.0: firmware ver 10.2.4-1.0-00029
api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 88595bb8
[   12.785020] ath10k_pci :02:00.0: Direct firmware load for
ath10k/QCA988X/hw2.0/board-2.bin failed with error -2
[   12.794137] ath10k_pci :02:00.0: Falling back to user helper
[   12.959872] firmware ath10k!QCA988X!hw2.0!board-2.bin:
firmware_loading_store: map pages failed
[   13.005579] ath10k_pci :02:00.0: board_file api 1 bmi_id N/A
crc32 bebc7c08
[   14.046516] ath10k_pci :02:00.0: htt-ver 2.1 wmi-op 5 htt-op 2
cal file max-sta 128 raw 0 hwcrypto 1
[   14.157074] ath: EEPROM regdomain: 0x833a
[   14.157085] ath: EEPROM indicates we should expect a country code
[   14.157100] ath: doing EEPROM country->regdmn map search
[   14.157108] ath: country maps to regdmn code: 0x37
[   14.157115] ath: Country alpha2 being used: GB
[   14.157120] ath: Regpair used: 0x37
[   14.221263] PCI: Enabling device :00:0e.0 ( -> 0002)
[   14.231888] ath: phy1: Ignoring endianness difference in EEPROM magic
bytes.
[   14.239421] ath: EEPROM regdomain: 0x833a
[   14.239434] ath: EEPROM indicates we should expect a country code
[   14.239455] ath: doing EEPROM country->regdmn map search
[   14.239468] ath: country maps to regdmn code: 0x37
[   14.239478] ath: Country alpha2 being used: GB
[   14.239487] ath: Regpair used: 0x37
[   14.259234] ieee80211 phy1: Selected rate control algorithm 'minstrel_ht'
[   14.265204] ieee80211 phy1: Atheros AR9287 Rev:2 mem=0xb800, irq=30
[   14.273585] kmodloader: done loading kernel modules from /etc/modules.d/*
[   21.011304] random: crng init done
[   24.650023] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[   24.662381] device eth0 entered promiscuous mode
[   24.669727] br-lan: port 1(eth0.1) entered blocking state
[   24.673834] br-lan: port 1(eth0.1) entered disabled state
[   24.680262] device eth0.1 entered promiscuous mode
[   24.689370] IPv6: ADDRCONF(NETDEV_UP): br-lan: link is not ready
[   27.109825] ath: EEPROM regdomain: 0x8114
[   27.112539] ath: EEPROM indicates we should expect a country code
[   27.118694] ath: doing EEPROM country->regdmn map search
[   27.123893] ath: country maps to regdmn code: 0x37
[   27.128691] ath: Country alpha2 being used: DE
[   27.133122] ath: Regpair used: 0x37
[   27.136621] ath: regdomain 0x8114 dynamically updated by user
[   27.142570] ath: EEPROM regdomain: 0x8114
[   27.146372] ath: EEPROM indicates we should expect a country code
[   27.152457] ath: doing EEPROM country->regdmn map search
[   27.157747] ath: country maps to regdmn code: 0x37
[   27.162550] ath: Country alpha2 being used: DE
[   27.167023] ath: Regpair used: 0x37
[   27.170494] ath: regdomain 0x8114 dynamically updated by user
.
[175128.394427] ath10k_pci :02:00.0: failed to delete peer
f0:27:65:3d:03:cd for vdev 0: -145
[175128.401703] ath10k_pci :02:00.0: found sta peer
f0:27:65:3d:03:cd (ptr 86b89600 id 157) entry on vdev 0 after it was
supposedly removed
[175128.415066] [ cut here ]
[175128.419116] WARNING: CPU: 1 PID: 3219 at
backports-2017-11-01/net/mac80211/sta_info.c:1001
sta_set_sinfo+0xa98/0xb40 [mac8021

[PATCHv2] ath10k: fix kernel panic while reading tpc_stats

2018-03-22 Thread Tamizh chelvam 
When attempt to read tpc_stats for the chipsets which support
more than 3 tx chain will trigger kernel panic(kernel stack is corrupted)
due to writing values on rate_code array out of range.
This patch changes the array size depends on the WMI_TPC_TX_N_CHAIN and
added check to avoid write values on the array if the num tx chain
get in tpc config event is greater than WMI_TPC_TX_N_CHAIN.

Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00057

Kernel panic log :

[  323.510944] Kernel panic - not syncing: stack-protector: Kernel stack is 
corrupted in: bf90c654
[  323.510944]
[  323.524390] CPU: 0 PID: 1908 Comm: cat Not tainted 3.14.77 #31
[  323.530224] [] (unwind_backtrace) from [] 
(show_stack+0x10/0x14)
[  323.537941] [] (show_stack) from [] 
(dump_stack+0x80/0xa0)
[  323.545146] [] (dump_stack) from [] (panic+0x84/0x1e4)
[  323.552000] [] (panic) from [] 
(__stack_chk_fail+0x10/0x14)
[  323.559350] [] (__stack_chk_fail) from [] 
(ath10k_wmi_event_pdev_tpc_config+0x424/0x438 [ath10k_core])
[  323.570471] [] (ath10k_wmi_event_pdev_tpc_config [ath10k_core]) 
from [] (ath10k_wmi_10_4_op_rx+0x2f0/0x39c [ath10k_core])
[  323.583047] [] (ath10k_wmi_10_4_op_rx [ath10k_core]) from 
[] (ath10k_htc_rx_completion_handler+0x170/0x1a0 [ath10k_core])
[  323.595702] [] (ath10k_htc_rx_completion_handler [ath10k_core]) 
from [] (ath10k_pci_hif_send_complete_check+0x1f0/0x220 [ath10k_pci])
[  323.609421] [] (ath10k_pci_hif_send_complete_check [ath10k_pci]) 
from [] (ath10k_ce_per_engine_service+0x74/0xc4 [ath10k_pci])
[  323.622490] [] (ath10k_ce_per_engine_service [ath10k_pci]) from 
[] (ath10k_ce_per_engine_service_any+0x74/0x80 [ath10k_pci])
[  323.635423] [] (ath10k_ce_per_engine_service_any [ath10k_pci]) 
from [] (ath10k_pci_napi_poll+0x44/0xe8 [ath10k_pci])
[  323.647665] [] (ath10k_pci_napi_poll [ath10k_pci]) from 
[] (net_rx_action+0xac/0x160)
[  323.657208] [] (net_rx_action) from [] 
(__do_softirq+0x104/0x294)
[  323.665017] [] (__do_softirq) from [] 
(irq_exit+0x9c/0x11c)
[  323.672314] [] (irq_exit) from [] (handle_IRQ+0x6c/0x90)
[  323.679341] [] (handle_IRQ) from [] 
(gic_handle_irq+0x3c/0x60)
[  323.686893] [] (gic_handle_irq) from [] 
(__irq_svc+0x40/0x70)
[  323.694349] Exception stack(0xdd489c58 to 0xdd489ca0)
[  323.699384] 9c40:   
 a013
[  323.707547] 9c60:  dc4bce40 6013 ddc1d800 dd488000 0990 
 c085c800
[  323.715707] 9c80:  dd489d44 092d dd489ca0 c026e664 c026e668 
6013 
[  323.723877] [] (__irq_svc) from [] 
(rcu_note_context_switch+0x170/0x184)
[  323.732298] [] (rcu_note_context_switch) from [] 
(__schedule+0x50/0x4d4)
[  323.740716] [] (__schedule) from [] 
(schedule_timeout+0x148/0x178)
[  323.748611] [] (schedule_timeout) from [] 
(wait_for_common+0x114/0x154)
[  323.756972] [] (wait_for_common) from [] 
(ath10k_tpc_stats_open+0xc8/0x340 [ath10k_core])
[  323.766873] [] (ath10k_tpc_stats_open [ath10k_core]) from 
[] (do_dentry_open+0x1ac/0x274)
[  323.776741] [] (do_dentry_open) from [] 
(do_last+0x8c0/0xb08)
[  323.784201] [] (do_last) from [] 
(path_openat+0x210/0x598)
[  323.791408] [] (path_openat) from [] 
(do_filp_open+0x2c/0x78)
[  323.798873] [] (do_filp_open) from [] 
(do_sys_open+0x114/0x1b4)
[  323.806509] [] (do_sys_open) from [] 
(ret_fast_syscall+0x0/0x44)
[  323.814241] CPU1: stopping
[  323.816927] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.14.77 #31
[  323.823008] [] (unwind_backtrace) from [] 
(show_stack+0x10/0x14)
[  323.830731] [] (show_stack) from [] 
(dump_stack+0x80/0xa0)
[  323.837934] [] (dump_stack) from [] 
(handle_IPI+0xb8/0x140)
[  323.845224] [] (handle_IPI) from [] 
(gic_handle_irq+0x58/0x60)
[  323.852774] [] (gic_handle_irq) from [] 
(__irq_svc+0x40/0x70)
[  323.860233] Exception stack(0xdd499fa0 to 0xdd499fe8)
[  323.865273] 9fa0: ffed  1d3c9000  dd498000 dd498030 
10c0387d c08b62c8
[  323.873432] 9fc0: 4220406a 512f04d0   0001 dd499fe8 
c021838c c0218390
[  323.881588] 9fe0: 6013 
[  323.885070] [] (__irq_svc) from [] 
(arch_cpu_idle+0x30/0x50)
[  323.892454] [] (arch_cpu_idle) from [] 
(cpu_startup_entry+0xa4/0x108)
[  323.900690] [] (cpu_startup_entry) from [<422085a4>] (0x422085a4)

Signed-off-by: Tamizh chelvam 
---
v2:
  * Removed unnecessary '\n' in the beginning of the format string 

 drivers/net/wireless/ath/ath10k/debug.c |  8 +++-
 drivers/net/wireless/ath/ath10k/wmi.c   | 10 +-
 drivers/net/wireless/ath/ath10k/wmi.h   |  2 +-
 3 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c 
b/drivers/net/wireless/ath/ath10k/debug.c
index 554cd78..d816299 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -1506,7 +1506,13 @@ static void ath10k_tpc_stats_print(struct 
ath10k_tpc_stats *tpc_stats,
*len += scnprintf(buf + *len, buf_len - *len,
  "**

[PATCH] ath10k: fix kernel panic while reading tpc_stats

2018-03-22 Thread Tamizh chelvam 
When attempt to read tpc_stats for the chipsets which support
more than 3 tx chain will trigger kernel panic(kernel stack is corrupted)
due to writing values on rate_code array out of range.
This patch changes the array size depends on the WMI_TPC_TX_N_CHAIN and
added check to avoid write values on the array if the num tx chain
get in tpc config event is greater than WMI_TPC_TX_N_CHAIN.

Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00057

Kernel panic log :

[  323.510944] Kernel panic - not syncing: stack-protector: Kernel stack is 
corrupted in: bf90c654
[  323.510944]
[  323.524390] CPU: 0 PID: 1908 Comm: cat Not tainted 3.14.77 #31
[  323.530224] [] (unwind_backtrace) from [] 
(show_stack+0x10/0x14)
[  323.537941] [] (show_stack) from [] 
(dump_stack+0x80/0xa0)
[  323.545146] [] (dump_stack) from [] (panic+0x84/0x1e4)
[  323.552000] [] (panic) from [] 
(__stack_chk_fail+0x10/0x14)
[  323.559350] [] (__stack_chk_fail) from [] 
(ath10k_wmi_event_pdev_tpc_config+0x424/0x438 [ath10k_core])
[  323.570471] [] (ath10k_wmi_event_pdev_tpc_config [ath10k_core]) 
from [] (ath10k_wmi_10_4_op_rx+0x2f0/0x39c [ath10k_core])
[  323.583047] [] (ath10k_wmi_10_4_op_rx [ath10k_core]) from 
[] (ath10k_htc_rx_completion_handler+0x170/0x1a0 [ath10k_core])
[  323.595702] [] (ath10k_htc_rx_completion_handler [ath10k_core]) 
from [] (ath10k_pci_hif_send_complete_check+0x1f0/0x220 [ath10k_pci])
[  323.609421] [] (ath10k_pci_hif_send_complete_check [ath10k_pci]) 
from [] (ath10k_ce_per_engine_service+0x74/0xc4 [ath10k_pci])
[  323.622490] [] (ath10k_ce_per_engine_service [ath10k_pci]) from 
[] (ath10k_ce_per_engine_service_any+0x74/0x80 [ath10k_pci])
[  323.635423] [] (ath10k_ce_per_engine_service_any [ath10k_pci]) 
from [] (ath10k_pci_napi_poll+0x44/0xe8 [ath10k_pci])
[  323.647665] [] (ath10k_pci_napi_poll [ath10k_pci]) from 
[] (net_rx_action+0xac/0x160)
[  323.657208] [] (net_rx_action) from [] 
(__do_softirq+0x104/0x294)
[  323.665017] [] (__do_softirq) from [] 
(irq_exit+0x9c/0x11c)
[  323.672314] [] (irq_exit) from [] (handle_IRQ+0x6c/0x90)
[  323.679341] [] (handle_IRQ) from [] 
(gic_handle_irq+0x3c/0x60)
[  323.686893] [] (gic_handle_irq) from [] 
(__irq_svc+0x40/0x70)
[  323.694349] Exception stack(0xdd489c58 to 0xdd489ca0)
[  323.699384] 9c40:   
 a013
[  323.707547] 9c60:  dc4bce40 6013 ddc1d800 dd488000 0990 
 c085c800
[  323.715707] 9c80:  dd489d44 092d dd489ca0 c026e664 c026e668 
6013 
[  323.723877] [] (__irq_svc) from [] 
(rcu_note_context_switch+0x170/0x184)
[  323.732298] [] (rcu_note_context_switch) from [] 
(__schedule+0x50/0x4d4)
[  323.740716] [] (__schedule) from [] 
(schedule_timeout+0x148/0x178)
[  323.748611] [] (schedule_timeout) from [] 
(wait_for_common+0x114/0x154)
[  323.756972] [] (wait_for_common) from [] 
(ath10k_tpc_stats_open+0xc8/0x340 [ath10k_core])
[  323.766873] [] (ath10k_tpc_stats_open [ath10k_core]) from 
[] (do_dentry_open+0x1ac/0x274)
[  323.776741] [] (do_dentry_open) from [] 
(do_last+0x8c0/0xb08)
[  323.784201] [] (do_last) from [] 
(path_openat+0x210/0x598)
[  323.791408] [] (path_openat) from [] 
(do_filp_open+0x2c/0x78)
[  323.798873] [] (do_filp_open) from [] 
(do_sys_open+0x114/0x1b4)
[  323.806509] [] (do_sys_open) from [] 
(ret_fast_syscall+0x0/0x44)
[  323.814241] CPU1: stopping
[  323.816927] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.14.77 #31
[  323.823008] [] (unwind_backtrace) from [] 
(show_stack+0x10/0x14)
[  323.830731] [] (show_stack) from [] 
(dump_stack+0x80/0xa0)
[  323.837934] [] (dump_stack) from [] 
(handle_IPI+0xb8/0x140)
[  323.845224] [] (handle_IPI) from [] 
(gic_handle_irq+0x58/0x60)
[  323.852774] [] (gic_handle_irq) from [] 
(__irq_svc+0x40/0x70)
[  323.860233] Exception stack(0xdd499fa0 to 0xdd499fe8)
[  323.865273] 9fa0: ffed  1d3c9000  dd498000 dd498030 
10c0387d c08b62c8
[  323.873432] 9fc0: 4220406a 512f04d0   0001 dd499fe8 
c021838c c0218390
[  323.881588] 9fe0: 6013 
[  323.885070] [] (__irq_svc) from [] 
(arch_cpu_idle+0x30/0x50)
[  323.892454] [] (arch_cpu_idle) from [] 
(cpu_startup_entry+0xa4/0x108)
[  323.900690] [] (cpu_startup_entry) from [<422085a4>] (0x422085a4)

Signed-off-by: Tamizh chelvam 
---
 drivers/net/wireless/ath/ath10k/debug.c | 12 +---
 drivers/net/wireless/ath/ath10k/wmi.c   | 10 +-
 drivers/net/wireless/ath/ath10k/wmi.h   |  2 +-
 3 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c 
b/drivers/net/wireless/ath/ath10k/debug.c
index 554cd78..8c41c81 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -1506,18 +1506,24 @@ static void ath10k_tpc_stats_print(struct 
ath10k_tpc_stats *tpc_stats,
*len += scnprintf(buf + *len, buf_len - *len,
  "\n");
*len += scnprintf(buf + *len