Re: [PATCH] wifi: ath10k: simplify SDIO async handling
On 9/18/2023 7:37 AM, Dmitry Antipov wrote: This is an initial attempt to fix TODO found in SDIO bus support code. As original comment says, an idea is to store SDIO-specific 'struct ath10k_sdio_bus_request' data within skb control buffer instead of managing (a relatively large, 1024-items for now) free list of the aforementioned structures. Compile tested only so TESTERS WANTED. While the maintainers like code to be as clean as possible, there is also the "if it isn't broke, don't fix it" mantra. This is especially true for older drivers that are in pure maintenance mode. So unless you can show you are fixing a problem and you can actually test your patches (or recruit someone to do so), any patches to ath10k, especially to SDIO, won't be accepted. Your team is doing some nice work, but I suggest you focus on drivers that are under active development, and preferably ones where you actually have the hardware to test. /jeff ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 06/13] Bluetooth: hci_bcm4377: Convert aspm disable to quirk
Hi, On Mon, Sep 18, 2023, at 15:10, Ilpo Järvinen wrote: > pci_disable_link_state() was made reliable regardless of ASPM CONFIG > and OS being disallowed to change ASPM states to allow drivers to rely > on pci_disable_link_state() working. > > Remove driver working around unreliable pci_disable_link_state() from > hci_bcm4377 driver and add a PCI quirk to disable ASPM. > > Signed-off-by: Ilpo Järvinen > --- Acked-by: Sven Peter Thanks, Sven ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 11/13] wifi: ath12k: Use pci_disable/enable_link_state()
Ilpo Järvinen writes: > ath12k driver adjusts ASPM state itself which leaves ASPM service > driver in PCI core unaware of the link state changes the driver > implemented. > > Call pci_disable_link_state() and pci_enable_link_state() instead of > adjusting ASPMC field in LNKCTL directly in the driver and let PCI core > handle the ASPM state management. > > Signed-off-by: Ilpo Järvinen Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 10/13] wifi: ath11k: Use pci_disable/enable_link_state()
Ilpo Järvinen writes: > ath11k driver adjusts ASPM state itself which leaves ASPM service > driver in PCI core unaware of the link state changes the driver > implemented. > > Call pci_disable_link_state() and pci_enable_link_state() instead of > adjusting ASPMC field in LNKCTL directly in the driver and let PCI core > handle the ASPM state management. > > Signed-off-by: Ilpo Järvinen Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 09/13] wifi: ath10k: Use pci_disable/enable_link_state()
Ilpo Järvinen writes: > ath10k driver adjusts ASPM state itself which leaves ASPM service > driver in PCI core unaware of the link state changes the driver > implemented. > > Call pci_disable_link_state() and pci_enable_link_state() instead of > adjusting ASPMC field in LNKCTL directly in the driver and let PCI core > handle the ASPM state management. > > Signed-off-by: Ilpo Järvinen Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
