Re: [PATCH v4 0/2] ath10k: testmode support
On Fri, Nov 14, 2014 at 7:09 AM, Kalle Valo kv...@qca.qualcomm.com wrote: Pushpal Sidhu psi...@gateworks.com writes: On Thu, Sep 11, 2014 at 1:43 PM, Kalle Valo kv...@qca.qualcomm.com wrote: Kalle Valo kv...@qca.qualcomm.com writes: latest version of my testmode patches. Getting closer, more or less cosmetic changes this time :) While looking through this patchset (sorry it took two months), I have to wonder: what's this utf.bin blob? It seems in order to use testmode, we need this binary blob that I can't seem to find (I looked in linux-firmware and https://github.com/kvalo/ath10k-firmware). If, for whatever reason, this binary blob is not releasable, what's the point of adding in testmode to this driver? testmode is for functionality needed in the factory, it's not meant for normal users. That's why all distros should have CONFIG_NL80211_TESTMODE disabled. Kalle, So what your saying is that 'the factory' (Quallcomm I assume) is using the ath10k driver with some firmware it deems not publicly releasable and the rest of us are paying for the extra lines of code and thrash in the open source driver? This sounds kind of dirty. It seems to me that QCA should either release the firmware or we should remove any special handling in the driver for it. Is this practice used in other Linux wireless drivers? I've cc'd John to see if he has any comments on that. Personally, I would rather see QCA document and release the uts firmware which is likely useful for others rather than removing the support for it. We have users often as for a continuous transmit mode switch so that they can get through certification testing. But really, deep down I would much rather QCA simply open up the firmware so that developers that are trying really hard to make this a quality driver can succeed and we can all benefit. Tim -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v4 0/2] ath10k: testmode support
Kalle Valo kv...@qca.qualcomm.com writes: latest version of my testmode patches. Getting closer, more or less cosmetic changes this time :) [...] Kalle Valo (2): ath10k: make ath10k_wmi_cmd_send() public ath10k: add testmode Applied, with an addition of the small change in patch 2 suggested by Michal. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH v4 0/2] ath10k: testmode support
Hi, latest version of my testmode patches. Getting closer, more or less cosmetic changes this time :) v4: * fix comment style (Michal) * add extra checks for at-testmode.utf (Michal) * add __ath10k_tm_cmd_utf_stop() and call it from ath10k_testmode_destroy() (Michal) v3: * remove false fall through comment in ath10k_start() (Michal) * fix multiline comment style (Michal) * put testmode interface definitions to testmode_uapi.h (or similar) (Johannes) * document __set_bit(ar-fw_features) better (Michal) * ath10k_tm_cmd_utf_start(): return ar-fw_feature value if there's an error * free firmware in ath10k_tm_cmd_utf_start() when an error happens (Michal) * ath10k_tm_cmd_utf_start(): move hif_power_down() to err_power_down label v2: * check error from ath10k_wmi_alloc_skb() (Michal) * int err - int ret (Michal) * fix conflicts in core.c * add ar-testmode.utf_monitor to check if ath10k_tm_event_wmi() should deliver WMI events or not * print mode in ath10k_download_fw() log messages * set ar-testmode.utf to NULL after it's released (Michal) * release ar-testmode.utf also in ath10k_tm_cmd_utf_stop() * rename ath10k_testmode_unregister() to ath10k_testmode_destroy() * call ath10k_core_stop() in ath10k_testmode_destroy() (Michal) * document wmi packet format in testmode commands (Michal) * consume WMI packets so that mac80211 calls are not made in UTF mode (Michal) * force to use 10x WMI interface with UTF firmware * API change: remove ATH10K_TM_CMD_EVENT_WMI, use ATH10K_TM_CMD_WMI also for events * API change: add major and minor version numbers to ATH10K_TM_CMD_GET_VERSION for the user space more easily to detect interface changes * use conf_mutex in ath10k_tm_cmd_wmi() * print UTF firmware started and UTF firmware stopped * print testmode %d in ath10k_print_driver_info() * don't call ath10k_wait_for_suspend() in UTF mode --- Kalle Valo (2): ath10k: make ath10k_wmi_cmd_send() public ath10k: add testmode drivers/net/wireless/ath/ath10k/Makefile |1 drivers/net/wireless/ath/ath10k/core.c | 88 -- drivers/net/wireless/ath/ath10k/core.h | 22 +- drivers/net/wireless/ath/ath10k/debug.c |5 drivers/net/wireless/ath/ath10k/debug.h |1 drivers/net/wireless/ath/ath10k/hw.h |2 drivers/net/wireless/ath/ath10k/mac.c|9 + drivers/net/wireless/ath/ath10k/testmode.c | 381 ++ drivers/net/wireless/ath/ath10k/testmode.h | 46 +++ drivers/net/wireless/ath/ath10k/testmode_i.h | 70 + drivers/net/wireless/ath/ath10k/wmi.c| 23 +- drivers/net/wireless/ath/ath10k/wmi.h|4 12 files changed, 619 insertions(+), 33 deletions(-) create mode 100644 drivers/net/wireless/ath/ath10k/testmode.c create mode 100644 drivers/net/wireless/ath/ath10k/testmode.h create mode 100644 drivers/net/wireless/ath/ath10k/testmode_i.h ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
