Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Shahar Or
On Tue, Dec 8, 2009 at 6:30 PM, Luis R. Rodriguez
lrodrig...@atheros.com wrote:
 IIRC this is all mapped in the INF file, I thought I had released an
 INF file under the ISC license but it seems that's not the case, I can
 try to do that if it helps. Anyway, if we can move this sort of map to
 userspace it'd be neat as you'd just need a userspace file update.
 Only thing is how to do this in a generic way for all wireless drivers
 and if this is indeed useful for other drivers.

 Export something through sysfs and use a udev rule?

 True. Is sysfs the preferred fs nowadays, what about configfs? Or
 maybe even udev rule -- nl80211 ?

If we have all the IDs from the INF file, then why do we need this in
userspace? Is the list growing?
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel


Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Luis R. Rodriguez
On Fri, Dec 18, 2009 at 07:37:24AM -0800, Luis Rodriguez wrote:
 On Fri, Dec 18, 2009 at 3:42 AM, Shahar Or mightyiamprese...@gmail.com 
 wrote:
  On Tue, Dec 8, 2009 at 6:30 PM, Luis R. Rodriguez
  lrodrig...@atheros.com wrote:
  IIRC this is all mapped in the INF file, I thought I had released an
  INF file under the ISC license but it seems that's not the case, I can
  try to do that if it helps. Anyway, if we can move this sort of map to
  userspace it'd be neat as you'd just need a userspace file update.
  Only thing is how to do this in a generic way for all wireless drivers
  and if this is indeed useful for other drivers.
 
  Export something through sysfs and use a udev rule?
 
  True. Is sysfs the preferred fs nowadays, what about configfs? Or
  maybe even udev rule -- nl80211 ?
 
  If we have all the IDs from the INF file, then why do we need this in
  userspace? Is the list growing?
 
 No, but for other newer hardware/drivers it can likely grow, so my
 comment was more of a generic driver approach to this.

Actually AR2425 still sells it seems, so yeah I guess it can grow even
for ath5k.

  Luis
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel


Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Shahar Or
On Fri, Dec 18, 2009 at 5:37 PM, Luis R. Rodriguez
lrodrig...@atheros.com wrote:
 If we have all the IDs from the INF file, then why do we need this in
 userspace? Is the list growing?

 No, but for other newer hardware/drivers it can likely grow, so my
 comment was more of a generic driver approach to this.

Is this a linux-wireless thing, or do other areas of linux keep some
data in userspace?
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel


Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-18 Thread Luis R. Rodriguez
On Fri, Dec 18, 2009 at 09:03:26AM -0800, Shahar Or wrote:
 On Fri, Dec 18, 2009 at 5:37 PM, Luis R. Rodriguez
 lrodrig...@atheros.com wrote:
  If we have all the IDs from the INF file, then why do we need this in
  userspace? Is the list growing?
 
  No, but for other newer hardware/drivers it can likely grow, so my
  comment was more of a generic driver approach to this.
 
 Is this a linux-wireless thing

You mean my suggestion? It depends, I personally am not aware of
upstream drivers keeping tabs on knobs in userspace currently
but I do think things like configs are used to tweak, for example
Oracle db stuff. configs can technically also be used to expose
knobs for example for non-generic device configuration stuff
for example but as far as I can tell no one has really used it
yet for this. It does' mean its not possible. The other question
is where do we stuff this in userspace and if it really makes
sense to start following that practice. For GPIO pin mapping,
perhaps given the number of patches I see for it but since its
the only thing I see a good use of perhaps its not worth it.
The kernel should always use default sensible values but since
this is more of database thing it makes sence to start thinking
istead of userspace for a better solution. Examples of moving
large dbs to userspace could be the preference on USB side to
not keep the USB vendor/device IDs names in the kernel, and also
the regulatory database stuff.

 or do other areas of linux keep some
 data in userspace?

I gave a few examples, not sure what else the kernel keeps in
userspace for data which is generic like that. Moving PCI device
vendor/device names might be good example.

  Luis
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel


Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread John W. Linville
On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote:
 On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland m...@bobcopeland.com wrote:
  On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville linvi...@tuxdriver.com 
  wrote:
  On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote:
  Adds support for the WiFi activity LED on the Dell Vostro A860 laptop.
 
  Signed-off-by: Shahar Or sha...@shahar-or.co.il
  ---
  I hope this one is perfect.
 
  Thanks for the patch.  As for getting a better solution to LEDs, I
  trolled through the ACPI spec and code, and while various modules
  do set up LED pins, there doesn't seem to be a way to generally
  get that information from another module and it appears different
  between each vendor.  I am by no stretch expert in ACPI stuff
  though.
 
  Luis, I've asked this before but maybe you know better now or know
  whom to ask on your side.  Atheros must have a way on Windows to
  figure out the LED pin/polarity -- do you have any idea?  Ath9k
  uses the SREV but that seems to be insufficient for ath5k judging
  by all the quirks.
 
 IIRC this is all mapped in the INF file, I thought I had released an
 INF file under the ISC license but it seems that's not the case, I can
 try to do that if it helps. Anyway, if we can move this sort of map to
 userspace it'd be neat as you'd just need a userspace file update.
 Only thing is how to do this in a generic way for all wireless drivers
 and if this is indeed useful for other drivers.

Export something through sysfs and use a udev rule?

John
-- 
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com  might be all we have.  Be ready.
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel


Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED

2009-12-08 Thread Luis R. Rodriguez
On Tue, Dec 8, 2009 at 8:06 AM, John W. Linville linvi...@tuxdriver.com wrote:
 On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote:
 On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland m...@bobcopeland.com wrote:
  On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville linvi...@tuxdriver.com 
  wrote:
  On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote:
  Adds support for the WiFi activity LED on the Dell Vostro A860 laptop.
 
  Signed-off-by: Shahar Or sha...@shahar-or.co.il
  ---
  I hope this one is perfect.
 
  Thanks for the patch.  As for getting a better solution to LEDs, I
  trolled through the ACPI spec and code, and while various modules
  do set up LED pins, there doesn't seem to be a way to generally
  get that information from another module and it appears different
  between each vendor.  I am by no stretch expert in ACPI stuff
  though.
 
  Luis, I've asked this before but maybe you know better now or know
  whom to ask on your side.  Atheros must have a way on Windows to
  figure out the LED pin/polarity -- do you have any idea?  Ath9k
  uses the SREV but that seems to be insufficient for ath5k judging
  by all the quirks.

 IIRC this is all mapped in the INF file, I thought I had released an
 INF file under the ISC license but it seems that's not the case, I can
 try to do that if it helps. Anyway, if we can move this sort of map to
 userspace it'd be neat as you'd just need a userspace file update.
 Only thing is how to do this in a generic way for all wireless drivers
 and if this is indeed useful for other drivers.

 Export something through sysfs and use a udev rule?

True. Is sysfs the preferred fs nowadays, what about configfs? Or
maybe even udev rule -- nl80211 ?

  Luis
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel