Re: [ath9k-devel] [v2] RANDOM: ATH9K RNG delivers zero bits of entropy
Am Dienstag, 27. September 2016, 16:44:16 CEST schrieb Kalle Valo: Hi Kalle, > Stephan Mueller wrote: > > The ATH9K driver implements an RNG which is completely bypassing the > > standard Linux HW generator logic. > > > > The RNG may or may not deliver entropy. Considering the conservative > > approach in treating entropy with respect to non-auditable sources, this > > patch changes the delivered entropy value to zero. The RNG still feeds > > data into the input_pool but it is assumed to have no entropy. > > > > When the ATH9K RNG changes to use the HW RNG framework, it may re-enable > > the entropy estimation considering that a user can change that value at > > boot and runtime. > > > > Reviewed-by: Jason Cooper > > Signed-off-by: Stephan Mueller > > Based on the discussion I'm dropping this patch. But the discussion was > hard to follow so please let me know if I misunderstood. I guess the rejection is appropriate, but something needs to be done: add_hwgenerator_randomness should not be used in this scenario. > > Patch set to Rejected. Ciao Stephan ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [v2] RANDOM: ATH9K RNG delivers zero bits of entropy
Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources, this > patch changes the delivered entropy value to zero. The RNG still feeds > data into the input_pool but it is assumed to have no entropy. > > When the ATH9K RNG changes to use the HW RNG framework, it may re-enable > the entropy estimation considering that a user can change that value at > boot and runtime. > > Reviewed-by: Jason Cooper > Signed-off-by: Stephan Mueller Based on the discussion I'm dropping this patch. But the discussion was hard to follow so please let me know if I misunderstood. Patch set to Rejected. -- https://patchwork.kernel.org/patch/9266265/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
