Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
On Wednesday 30 November 2011 12:17 PM, Kalle Valo wrote: > Mohammed Shafi Shajakhan writes: > >> unassociated state for station. >> >> but I observed this when i tested ad-hoc mode. I just started an >> ad-hoc mode creator and left it for some time with no one joining. i >> observed there are few frames in rx_tasklet of ath9k driver which seem >> to be beacons and their BSSID is '0', as our curbssid is also '0' they >> seem to be wrongly identified as 'my_beacons'. > > This is a perfect addition to the commit log. Remember that the commit > log should especially answer the question "why?". > Kalle, thanks. I will properly test this in STA and IBSS mode, and add this commit log. -- thanks, shafi ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
Mohammed Shafi Shajakhan writes: > unassociated state for station. > > but I observed this when i tested ad-hoc mode. I just started an > ad-hoc mode creator and left it for some time with no one joining. i > observed there are few frames in rx_tasklet of ath9k driver which seem > to be beacons and their BSSID is '0', as our curbssid is also '0' they > seem to be wrongly identified as 'my_beacons'. This is a perfect addition to the commit log. Remember that the commit log should especially answer the question "why?". -- Kalle Valo ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
Hi Peter, On Wednesday 30 November 2011 08:06 AM, Peter Stuge wrote: > Mohammed Shafi Shajakhan wrote: >> before concluding that the recieved beacon is for us, let us make sure >> that the BSSID is non-zero. > > Under what circumstances would the BSSID be zero? > > > //Peter unassociated state for station. but I observed this when i tested ad-hoc mode. I just started an ad-hoc mode creator and left it for some time with no one joining. i observed there are few frames in rx_tasklet of ath9k driver which seem to be beacons and their BSSID is '0', as our curbssid is also '0' they seem to be wrongly identified as 'my_beacons'. let me also verify it in STA mode and find the effect of this before sending it as a PATCH. let me also check if it has any effect in ath9k_process_rssi and ath_rx_ps. -- thanks, shafi ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
Mohammed Shafi Shajakhan wrote: > before concluding that the recieved beacon is for us, let us make sure > that the BSSID is non-zero. Under what circumstances would the BSSID be zero? //Peter ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
