Re: [can't compile the main branch]

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> Thanks, applied with the minor change that I use $(wildcard *.el)
> instead of listing all lisp files and binding them to AUCSRC.

Thanks.  Yes, $(wildcard *.el) is easier.  I removed also some code
remainder.

Best, Arash



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Uwe Brauer

> Uwe Brauer  writes:

> If you have more than those, yes:

> In bib-find-next:
> bib-cite.el:944:8: Warning: ‘find-tag’ is an obsolete function (as of 25.1); 
> use ‘xref-find-definitions’ instead.

> In end of data:
> tex-info.el: Warning: the function ‘cl-member’ might not be defined at 
> runtime.

> In toolbarx-process-dropdown-group:
> toolbar-x.el:886:10: Warning: in defcustom: missing :type keyword parameter
> toolbar-x.el:886:10: Warning: in defcustom: fails to specify containing
> group


These are mine 

plain-tex.el:46:6: Warning: the function ‘TeX-install-toolbar’ is not known to 
be defined.
tex.el:5155:38: Warning: the function ‘TeX-fold-mode’ is not known to be 
defined.
tex.el:3690:36: Warning: the function ‘font-latex-setup’ is not known to be 
defined.
latex.el:7137:6: Warning: the function ‘LaTeX-install-toolbar’ is not known to 
be defined.
latex.el:3494:4: Warning: the function ‘multi-prompt-key-value’ is not known to 
be defined.
latex.el:2491:17: Warning: the function ‘multi-prompt’ is not known to be 
defined.
style/pstricks.el:655:15: Warning: the function ‘multi-prompt-key-value’ is not 
known to be defined.


> No, certainly not.  Getting rid of all that complicated stuff no one of
> the current auctex maintainers understands and which is basically not
> needed anymore, is exactly the purpose of the exercise.

😭

So I have to use the developer version in place, and testing it at the
same time, uuuh


>   Tassilo

-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 



smime.p7s
Description: S/MIME cryptographic signature


Re: main branch: why not have make elpa or ./confiure --with-elpa

2024-04-25 Thread Tassilo Horn
Uwe Brauer  writes:

> Given the current difficulties of compiling the main branch, for users
> that don't use Emacs > 29.1 or don't use git, but would like to test
> and contribute say style files:

The issues have been resolved.

> 1. Could we leave things as if were, that is
>
>1. .configure stays,
>
>2. make
>
>3. make install
>
> 2. But make elpa is added?
>
> 3. Or add and option to configure ./configure --with-elpa
>
> Unfortunately I don't know how to achieve that myself

Me neither.  And that's exactly the point why we want to let the
autotools build and standalone tarball releases behind.

Bye,
Tassilo



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Uwe Brauer  writes:

> First of all thanks Arash, that might have been a bit complicated. I
> appreciate it.

You're welcome.  Actually not, I took most of it from our old
Makefile.in.

> I was late yesterday night, so since Tassilo already applied the patch,
>
> * From my git clone 
>
> I pulled
> and run using my <29.1:
>
> time make -j8
>
>
> 1. It compiled, there were some errors about functions not to be
>known. Shall I send these byte compilation errors?

I see them as well.  I will address them, but probably on the master
branch.

Best, Arash



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Tassilo Horn
Uwe Brauer  writes:

>> No, certainly not.  Getting rid of all that complicated stuff no one
>> of the current auctex maintainers understands and which is basically
>> not needed anymore, is exactly the purpose of the exercise.
>
> 😭
>
> So I have to use the developer version in place, and testing it at the
> same time, uuuh

Where's the problem?  I run every elisp project (including emacs itself)
where I have a checkout from the clone itself.  Why would someone want
to copy/duplicate the files to somewhere below /usr/local/?

  Tassilo



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> If you have more than those, yes:
>
> In bib-find-next:
> bib-cite.el:944:8: Warning: ‘find-tag’ is an obsolete function (as of
> 25.1); use ‘xref-find-definitions’ instead.
>
> In end of data:
> tex-info.el: Warning: the function ‘cl-member’ might not be defined at 
> runtime.
>
> In toolbarx-process-dropdown-group:
> toolbar-x.el:886:10: Warning: in defcustom: missing :type keyword parameter
> toolbar-x.el:886:10: Warning: in defcustom: fails to specify containing
> group

Would it make sense to add the dynvars-check rule to the GNUmakefile?  I
never really understood how that works.  Can you have a look at it,
please?

Best, Arash



Re: [can't compile the main branch]

2024-04-25 Thread Tassilo Horn
Tassilo Horn  writes:

>> The original problem was that elpa.gnu.org did not have TeX
>> installed.  After fixing it there was another problem of access
>> rights when running TeX.  I believe it is now fixed and it should get
>> built within the next 6 hours.  Knocking on wood.  🙂
>
> Sadly, the last build failed with the same error as the previous one:

Oh, now some new version (from 2024-04-23 built today) has appeared!  So
I guess within the next 6 hours there will be a new release.

  Tassilo



main b1da63be: Add dynvars-check make target

2024-04-25 Thread Tassilo Horn
branch: main
commit b1da63be543aae20530fbaa90c04fbc7222040c3
Author: Tassilo Horn 
Commit: Tassilo Horn 

Add dynvars-check make target
---
 GNUmakefile | 12 
 1 file changed, 12 insertions(+)

diff --git a/GNUmakefile b/GNUmakefile
index 1b4499a3..892d1c3c 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -135,3 +135,15 @@ dir: $(INFO_FILES)
 $(LATEX_FILES): latex/preview.dtx latex/bootstrap.ins
cd latex; $(TEX) '\nonstopmode \input bootstrap.ins'
cd latex; $(TEX) '\nonstopmode \input preview-mk.ins'
+
+DYNVARSFILES = *.dynvars style/*.dynvars auctex-dynvars
+dynvars-check:
+   rm -f $(wildcard *.elc) $(wildcard style/*elc) $(DYNVARSFILES)
+   EMACS_GENERATE_DYNVARS=1 $(EMACS) -f batch-byte-compile \
+   $(wildcard *.el) $(wildcard style/*el) \
+   > /dev/null 2>&1
+   cat *.dynvars style/*.dynvars > auctex-dynvars
+   rm -f $(wildcard *.elc) $(wildcard style/*elc)
+   EMACS_DYNVARS_FILE=auctex-dynvars $(EMACS) \
+   -f batch-byte-compile \
+   $(wildcard *.el) $(wildcard style/*el)



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Tassilo Horn
Arash Esbati  writes:

>> If you have more than those, yes:
>>
>> In bib-find-next:
>> bib-cite.el:944:8: Warning: ‘find-tag’ is an obsolete function (as of
>> 25.1); use ‘xref-find-definitions’ instead.
>>
>> In end of data:
>> tex-info.el: Warning: the function ‘cl-member’ might not be defined at
>> runtime.
>>
>> In toolbarx-process-dropdown-group:
>> toolbar-x.el:886:10: Warning: in defcustom: missing :type keyword parameter
>> toolbar-x.el:886:10: Warning: in defcustom: fails to specify containing
>> group
>
> Would it make sense to add the dynvars-check rule to the GNUmakefile?
> I never really understood how that works.  Can you have a look at it,
> please?

Done.  Strange enough, it doesn't catch the cl-member warning above and
also not the ones Uwe mentioned, i.e.;

--8<---cut here---start->8---
plain-tex.el:46:6: Warning: the function ‘TeX-install-toolbar’ is not known to 
be defined.
tex.el:5155:38: Warning: the function ‘TeX-fold-mode’ is not known to be 
defined.
tex.el:3690:36: Warning: the function ‘font-latex-setup’ is not known to be 
defined.
latex.el:7137:6: Warning: the function ‘LaTeX-install-toolbar’ is not known to 
be defined.
latex.el:3494:4: Warning: the function ‘multi-prompt-key-value’ is not known to 
be defined.
latex.el:2491:17: Warning: the function ‘multi-prompt’ is not known to be 
defined.
style/pstricks.el:655:15: Warning: the function ‘multi-prompt-key-value’ is not
known to be defined.
--8<---cut here---end--->8---

That's what I get:

❯ make dynvars-check
...
--8<---cut here---start->8---
In bib-find-next:
bib-cite.el:944:8: Warning: ‘find-tag’ is an obsolete function (as of 25.1); 
use ‘xref-find-definitions’ instead.

In TeX-Omega-mode:
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1664:23: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1660:20: Warning: ‘TeX-Omega-mode’ is an obsolete variable (as of 
11.86); use ‘TeX-engine’ instead.
tex.el:1665:29: Warning: ‘TeX-Omega-mode’ is an obsolete function (as of 
11.86); use ‘TeX-engine-set’ instead.
tex.el:6077:45: Warning: ‘TeX-dollar-sign’ is an obsolete variable (as of 
AUCTeX 9.9d++).
tex.el:6079:29: Warning: ‘TeX-dollar-string’ is an obsolete variable (as of 
AUCTeX 9.9d++).
tex.el:6080:25: Warning: ‘TeX-dollar-string’ is an obsolete variable (as of 
AUCTeX 9.9d++).

In toolbarx-process-dropdown-group:
toolbar-x.el:886:10: Warning: in defcustom: missing :type keyword parameter
toolbar-x.el:886:10: Warning: in defcustom: fails to specify containing group
--8<---cut here---end--->8---

Bye,
  Tassilo



Re: [can't compile the main branch]

2024-04-25 Thread Tassilo Horn
Tassilo Horn  writes:

>>> The original problem was that elpa.gnu.org did not have TeX
>>> installed.  After fixing it there was another problem of access
>>> rights when running TeX.  I believe it is now fixed and it should get
>>> built within the next 6 hours.  Knocking on wood.  🙂
>>
>> Sadly, the last build failed with the same error as the previous one:
>
> Oh, now some new version (from 2024-04-23 built today) has appeared!  So
> I guess within the next 6 hours there will be a new release.

And there it is!  So it seems to work now; you can stop knocking. ;-)

Thanks,
  Tassilo



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> Done.

Thanks.  Do you mind if I add this change to it:

--8<---cut here---start->8---
diff --git a/GNUmakefile b/GNUmakefile
index 892d1c3c..999861cb 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -83,7 +83,8 @@ clean:
rm -f $(ALL_GENERATED_FILES) \
$(wildcard *.elc style/*.elc) \
auctex-autoloads.el \
-   ChangeLog
+   ChangeLog \
+   $(DYNVARSFILES)

 # Copied&adapted from doc/Makefile.in.
 MAKEINFO_PLAIN=$(MAKEINFO) -D rawfile --no-headers
@@ -138,12 +139,12 @@ $(LATEX_FILES): latex/preview.dtx latex/bootstrap.ins

 DYNVARSFILES = *.dynvars style/*.dynvars auctex-dynvars
 dynvars-check:
-   rm -f $(wildcard *.elc) $(wildcard style/*elc) $(DYNVARSFILES)
+   rm -f $(wildcard *.elc) $(wildcard style/*.elc) $(DYNVARSFILES)
EMACS_GENERATE_DYNVARS=1 $(EMACS) -f batch-byte-compile \
-   $(wildcard *.el) $(wildcard style/*el) \
+   $(wildcard *.el) $(wildcard style/*.el) \
> /dev/null 2>&1
cat *.dynvars style/*.dynvars > auctex-dynvars
-   rm -f $(wildcard *.elc) $(wildcard style/*elc)
+   rm -f $(wildcard *.elc) $(wildcard style/*.elc)
EMACS_DYNVARS_FILE=auctex-dynvars $(EMACS) \
-f batch-byte-compile \
-   $(wildcard *.el) $(wildcard style/*el)
+   $(wildcard *.el) $(wildcard style/*.el)
--8<---cut here---end--->8---


> Strange enough, it doesn't catch the cl-member warning above and also
> not the ones Uwe mentioned

I see what Uwe reported when I run the regular make, with dynvars-check
I get the same results as you.

Best, Arash



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Tassilo Horn
Arash Esbati  writes:

> Thanks.  Do you mind if I add this change to it:

I totally don't mind when you fix my errors and oversights.  That's
exactly why I've hired you. ;-)

>> Strange enough, it doesn't catch the cl-member warning above and also
>> not the ones Uwe mentioned
>
> I see what Uwe reported when I run the regular make, with
> dynvars-check I get the same results as you.

I don't get them with regular make either.  Maybe because I run emacs
master which is a bit more clever?

Thanks,
  Tassilo



main 16a5896f: ; * GNUmakefile: Fix last change.

2024-04-25 Thread Arash Esbati
branch: main
commit 16a5896f6d61c3ab693bfe374608b088163a2b69
Author: Arash Esbati 
Commit: Arash Esbati 

; * GNUmakefile: Fix last change.
---
 GNUmakefile | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/GNUmakefile b/GNUmakefile
index 892d1c3c..999861cb 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -83,7 +83,8 @@ clean:
rm -f $(ALL_GENERATED_FILES) \
$(wildcard *.elc style/*.elc) \
auctex-autoloads.el \
-   ChangeLog
+   ChangeLog \
+   $(DYNVARSFILES)
 
 # Copied&adapted from doc/Makefile.in.
 MAKEINFO_PLAIN=$(MAKEINFO) -D rawfile --no-headers
@@ -138,12 +139,12 @@ $(LATEX_FILES): latex/preview.dtx latex/bootstrap.ins
 
 DYNVARSFILES = *.dynvars style/*.dynvars auctex-dynvars
 dynvars-check:
-   rm -f $(wildcard *.elc) $(wildcard style/*elc) $(DYNVARSFILES)
+   rm -f $(wildcard *.elc) $(wildcard style/*.elc) $(DYNVARSFILES)
EMACS_GENERATE_DYNVARS=1 $(EMACS) -f batch-byte-compile \
-   $(wildcard *.el) $(wildcard style/*el) \
+   $(wildcard *.el) $(wildcard style/*.el) \
> /dev/null 2>&1
cat *.dynvars style/*.dynvars > auctex-dynvars
-   rm -f $(wildcard *.elc) $(wildcard style/*elc)
+   rm -f $(wildcard *.elc) $(wildcard style/*.elc)
EMACS_DYNVARS_FILE=auctex-dynvars $(EMACS) \
-f batch-byte-compile \
-   $(wildcard *.el) $(wildcard style/*el)
+   $(wildcard *.el) $(wildcard style/*.el)



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> I totally don't mind when you fix my errors and oversights.  That's
> exactly why I've hired you. ;-)

And I rely on Keita looknig after me ;-)

I have another question about this rule:

clean:
rm -f $(ALL_GENERATED_FILES) \
$(wildcard *.elc style/*.elc) \
auctex-autoloads.el \
ChangeLog \
$(DYNVARSFILES)

Is it necessary to delete ChangeLog here?  This rule just killed my
local ChangeLog :-(  We still have:

ChangeLog:
rm -f $@
./build-aux/gitlog-to-auctexlog && cat ChangeLog.1 >> $@

elpa: $(MAIN_GENERATED_FILES) ChangeLog

which should do the job, or am I missing something?

> I don't get them with regular make either.  Maybe because I run emacs
> master which is a bit more clever?

My Emacs is from master and 9c01da56a5 smart.

Best, Arash



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Tassilo Horn
Arash Esbati  writes:

>> I totally don't mind when you fix my errors and oversights.  That's
>> exactly why I've hired you. ;-)
>
> And I rely on Keita looknig after me ;-)

We are lucky.  Good that we have him.

> I have another question about this rule:
>
> clean:
> rm -f $(ALL_GENERATED_FILES) \
> $(wildcard *.elc style/*.elc) \
> auctex-autoloads.el \
> ChangeLog \
> $(DYNVARSFILES)
>
> Is it necessary to delete ChangeLog here?  This rule just killed my
> local ChangeLog :-(

It depends on how clean the clean target should make.  I went for very
clean but wouldn't mind if the ChangeLog was kept.  For what purpose?

>> I don't get them with regular make either.  Maybe because I run emacs
>> master which is a bit more clever?
>
> My Emacs is from master and 9c01da56a5 smart.

And you get Uwe's additional warnings with that, too?

Bye,
  Tassilo



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> We are lucky.  Good that we have him.

👍

> It depends on how clean the clean target should make.  I went for very
> clean but wouldn't mind if the ChangeLog was kept.  For what purpose?

I maintain a ChangeLog: I use 'C-x 4 a' to make a ChangeLog entry and
depending on how I make a commit, I plonk that entry into the commit
message (vc or copy&paste); I don't use Magit.  So I rely on that file.

> And you get Uwe's additional warnings with that, too?

Yes, I see them as well.

Best, Arash



Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Tassilo Horn
Arash Esbati  writes:

>> It depends on how clean the clean target should make.  I went for
>> very clean but wouldn't mind if the ChangeLog was kept.  For what
>> purpose?
>
> I maintain a ChangeLog: I use 'C-x 4 a' to make a ChangeLog entry and
> depending on how I make a commit, I plonk that entry into the commit
> message (vc or copy&paste); I don't use Magit.  So I rely on that
> file.

Ah, ok, and you do that probably over multiple emacs sessions so that
the buffer isn't there anymore.  You might as well customize
change-log-default-name to "MyTmpChangeLog" or something so that the
name doesn't clash with a generated, untracked file which might be
deleted or re-generated at will.

Bye,
  Tassilo



main 80f47a4b: * GNUmakefile (clean): Don't clean up ChangeLog.

2024-04-25 Thread Arash Esbati
branch: main
commit 80f47a4b72eeac0d1b5a83badfa7482b5f9378eb
Author: Arash Esbati 
Commit: Arash Esbati 

* GNUmakefile (clean): Don't clean up ChangeLog.
---
 GNUmakefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/GNUmakefile b/GNUmakefile
index 999861cb..507d69fd 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -83,7 +83,6 @@ clean:
rm -f $(ALL_GENERATED_FILES) \
$(wildcard *.elc style/*.elc) \
auctex-autoloads.el \
-   ChangeLog \
$(DYNVARSFILES)
 
 # Copied&adapted from doc/Makefile.in.



Re: [can't compile the main branch]

2024-04-25 Thread Stefan Monnier
> And there it is!  So it seems to work now; you can stop knocking. ;-)

Yay!  That wood should is happy,


Stefan




tex-continuous.el

2024-04-25 Thread Uwe Brauer


Hi

A couple of days ago Paul posted about a new (at least for me) package,
that allows via latexmk to actualise the generated pdf file, if the
corresponding LateX source file is saved.

I tested it in the last days and like it quite a bit. Preview.el is also
part of auctex, so the question is, could tex-continuous be included in
AuCTex.

What do others think about that package?

Regards

Uwe Brauer 

-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 




master 0e315c7f: Support indirect buffer

2024-04-25 Thread Ikumi Keita
branch: master
commit 0e315c7fbeed081addf369fd42e7206d83580bc5
Author: Vangelis Evangelou 
Commit: Ikumi Keita 

Support indirect buffer

* tex.el (TeX-buffer-file-name): New wrapper function for
`buffer-file-name'.  It returns base buffer's file name in indirect
buffer.
(TeX-master-file, TeX-normal-mode): Wrap the body in
`with-current-buffer' in case called in indirect buffer.
Omit an unused return value in `save-excursion' form.
(TeX-master-directory): Omit redundant optional argument for
`expand-file-name'.
* bib-cite.el:
* latex.el:
* preview.el.in:
* style/catchfilebetweentags.el:
* style/pdfsync.el:
* tex-info.el:
* tex.el:
* toolbar-x.el:
Replace call to `buffer-file-name' and reference to `buffer-file-name'
with call to `TeX-buffer-file-name' (or equivalent form).

Copyright-paperwork-exempt: yes
---
 bib-cite.el   |   2 +-
 doc/changes.texi  |  12 +++
 latex.el  |   4 +-
 preview.el.in |   8 +-
 style/catchfilebetweentags.el |   2 +-
 style/pdfsync.el  |   2 +-
 tex-info.el   |   2 +-
 tex.el| 223 ++
 toolbar-x.el  |   6 +-
 9 files changed, 142 insertions(+), 119 deletions(-)

diff --git a/bib-cite.el b/bib-cite.el
index 5a7de98f..7b425cac 100644
--- a/bib-cite.el
+++ b/bib-cite.el
@@ -1903,7 +1903,7 @@ If no master file, then return current default."
 ;; rather than\input file
 (re-search-forward "^[ \t]*\\(include\\|input\\){"
nil t
-   (buffer-file-name))
+   (TeX-buffer-file-name))
   (t
nil
 (cond
diff --git a/doc/changes.texi b/doc/changes.texi
index cae91aa2..0d57a654 100644
--- a/doc/changes.texi
+++ b/doc/changes.texi
@@ -11,6 +11,18 @@
 @heading News in 14.1
 
 @itemize @bullet
+@item
+@AUCTeX{} can be used with indirect buffers cloned from buffers visiting a
+file.  This feature allows having different perspectives of the same
+buffer (narrowing, folding, previewing, etc).  The indirect buffer has the
+same master file as its base buffer.
+
+In indirect buffer, @previewlatex{} works naturally for region preview
+such as @code{preview-region} (@kbd{C-c C-p C-r}), but document preview
+@code{preview-document} (@kbd{C-c C-p C-d}) puts preview images in the
+base buffer, not in the indirect buffer itself.  We expect this behavior
+doesn't matter because of the users' intent.
+
 @item
 @AUCTeX{} changes major mode names.  Its primary purpose is to avoid
 conflicts with Emacs built-in @TeX{} major modes.  It also improves
diff --git a/latex.el b/latex.el
index c5965b05..9e769e97 100644
--- a/latex.el
+++ b/latex.el
@@ -2569,7 +2569,7 @@ string."
 Initial input is the name of the file being visited in the
 current buffer, with extension.  If OPTIONAL is non-nil, insert
 it as an optional argument.  Use PROMPT as the prompt string."
-  (let ((name (file-name-nondirectory buffer-file-name)))
+  (let ((name (file-name-nondirectory (TeX-buffer-file-name
 (TeX-argument-insert
  (TeX-read-string
   (TeX-argument-prompt optional
@@ -2590,7 +2590,7 @@ current buffer, without extension.  If OPTIONAL is 
non-nil,
 insert it as an optional argument.  Use PROMPT as the prompt
 string."
   (let ((name (file-name-sans-extension
-   (file-name-nondirectory buffer-file-name
+   (file-name-nondirectory (TeX-buffer-file-name)
 (TeX-argument-insert
  (TeX-read-string
   (TeX-argument-prompt optional
diff --git a/preview.el.in b/preview.el.in
index 12500011..7b59a3de 100644
--- a/preview.el.in
+++ b/preview.el.in
@@ -3079,8 +3079,8 @@ pp")
#'desktop-buffer-preview-misc-data)
   (add-hook 'pre-command-hook #'preview-mark-point nil t)
   (add-hook 'post-command-hook #'preview-move-point nil t)
-  (when buffer-file-name
-(let* ((filename (expand-file-name buffer-file-name))
+  (when (TeX-buffer-file-name)
+(let* ((filename (expand-file-name (TeX-buffer-file-name)))
format-cons)
   (when (string-match (concat "\\." TeX-default-extension "\\'")
   filename)
@@ -4128,8 +4128,8 @@ The function bound to this variable will be called inside
  (if preview-preprocess-function
  (funcall preview-preprocess-function str)
str))
-   (if buffer-file-name
-   (file-name-nondirectory buffer-file-name)
+   (if (TeX-buffer-file-name)
+   (file-name-nondirectory (TeX-buffer-file-name))
  "")
(TeX-current-offset begin)))
   (setq TeX-current-process-region-p t)
diff --git a/style/catchfilebetweentags.el b/style/

Re: [can't compile the main branch]: SOLVED

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> Ah, ok, and you do that probably over multiple emacs sessions so that
> the buffer isn't there anymore.

Yes, my workflow is to write the ChangeLog entry directly after the
change and not before the actual commit, hence I need a file.

> You might as well customize change-log-default-name to
> "MyTmpChangeLog" or something so that the name doesn't clash with a
> generated, untracked file which might be deleted or re-generated at
> will.

It worked quite well until now, and loosing that file isn't a big deal,
but that shouldn't happen on a regular basis.  I pushed that change.

Best, Arash



Re: [can't compile the main branch]

2024-04-25 Thread Arash Esbati
Tassilo Horn  writes:

> And there it is!  So it seems to work now; you can stop knocking. ;-)

And I like the way the manual is formatted.  Compare this:

https://www.gnu.org/software/auctex/manual/auctex.html

with this:

https://elpa.gnu.org/devel/doc/auctex.html

Thanks!

Best, Arash



Re: [can't compile the main branch]

2024-04-25 Thread Uwe Brauer
>>> "AE" == Arash Esbati  writes:

> Tassilo Horn  writes:
>> And there it is!  So it seems to work now; you can stop knocking. ;-)

> And I like the way the manual is formatted.  Compare this:

> https://www.gnu.org/software/auctex/manual/auctex.html

> with this:

> https://elpa.gnu.org/devel/doc/auctex.html

> Thanks!

I agree!! Thanks 
-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 



smime.p7s
Description: S/MIME cryptographic signature


Re: emacs 29.1 more problems

2024-04-25 Thread Arash Esbati
Hi Uwe,

Uwe Brauer  writes:

> I concentrated on the repository that I cloned with git.
>
> I compiled and installed GNU emacs 
> commit 1d4e90341782
> 31.05.2022, where the function loaddefs-generate-batch was introduced.

If you look at this page, you'll see that the function/functionality
went through some improvement loops.

https://git.savannah.gnu.org/cgit/emacs.git/log/lisp/emacs-lisp/loaddefs-gen.el

I don't think that the issue below is related to your Emacs, but you've
been warned ;-)

> 2. Compilation fails with error 
>
>
> lisp/debug-early.el") nil t)
>   loaddefs-generate-batch()
>   command-line-1(("-l" "lpath.el" "-f" "loaddefs-generate-batch" 
> "loaddefs.el" "."))
>   command-line()
>   normal-top-level()
> Opening output file: Permission denied, 
> /opt/emacs29.1/share/emacs/29.0.50/lisp/loaddefs.el
> GNUmakefile:47: recipe for target 'autoloads' failed
> make: *** [autoloads] Error 255
> make: *** Waiting for unfinished jobs
> 267.572u 26.032s 1:21.80 358.9% 0+0k 0+10696io 0pf+0w

I somehow lost track, but IIUC this issue isn't present anymore and
you're back in business, right?

Best, Arash



Re: [can't compile the main branch]

2024-04-25 Thread Stefan Monnier
> And I like the way the manual is formatted.  Compare this:
> https://www.gnu.org/software/auctex/manual/auctex.html
> with this:
> https://elpa.gnu.org/devel/doc/auctex.html

Hmm... nice.  FWIW, the elpa rendering is the same as that of

https://www.gnu.org/software/emacs/manual/html_node/emacs/index.html

not sure why https://www.gnu.org/software/auctex/manual/auctex.html is
not as nice.

While I'm here, I think with the new setup we can get rid of
`Makefile.in` and `auctex.el.in`.


Stefan




Re: emacs 29.1 more problems

2024-04-25 Thread Uwe Brauer

> Hi Uwe,
> Uwe Brauer  writes:


> If you look at this page, you'll see that the function/functionality
> went through some improvement loops.

> https://git.savannah.gnu.org/cgit/emacs.git/log/lisp/emacs-lisp/loaddefs-gen.el

> I don't think that the issue below is related to your Emacs, but you've
> been warned ;-)


> I somehow lost track, but IIUC this issue isn't present anymore and
> you're back in business, right?


Indeed after pulling the latest main branch, both emacses I currently
use my pre 29 and the one were that function was introduced first,
compiled without problems, even from a mercurial repository. 

So back to business.

Thanks 
> Best, Arash

-- 
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the EU and NATO membership of Ukraine. 



smime.p7s
Description: S/MIME cryptographic signature


master a401c3fc: Silence the compiler for the "main" branch

2024-04-25 Thread Arash Esbati
branch: master
commit a401c3fcc678541384b0cda915069c7998729fe0
Author: Arash Esbati 
Commit: Arash Esbati 

Silence the compiler for the "main" branch

* latex.el:
* plain-tex.el:
* tex.el: Declare functions which are reported as not known to
be defined when compiling the "main" branch.

* style/pstricks.el (LaTeX-pst-env-pspicture): Use
`TeX-read-key-val' instead of `multi-prompt-key-value'.
---
 latex.el  | 12 ++--
 plain-tex.el  |  3 +++
 style/pstricks.el |  9 +
 tex.el| 14 --
 4 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/latex.el b/latex.el
index 9e769e97..e2d2d88e 100644
--- a/latex.el
+++ b/latex.el
@@ -39,12 +39,12 @@
 (require 'subr-x)))
 
 ;; Silence the compiler for functions:
-(declare-function outline-level "ext:outline"
-  nil)
-(declare-function outline-mark-subtree "ext:outline"
-  nil)
-(declare-function turn-off-filladapt-mode "ext:filladapt"
-  nil)
+(declare-function multi-prompt "multi-prompt")
+(declare-function multi-prompt-key-value "multi-prompt")
+(declare-function LaTeX-install-toolbar "tex-bar" nil)
+(declare-function outline-level "ext:outline" nil)
+(declare-function outline-mark-subtree "ext:outline" nil)
+(declare-function turn-off-filladapt-mode "ext:filladapt" nil)
 
 ;; Silence the compiler for variables:
 (defvar outline-heading-alist)
diff --git a/plain-tex.el b/plain-tex.el
index 5691859d..2b777869 100644
--- a/plain-tex.el
+++ b/plain-tex.el
@@ -30,6 +30,9 @@
 
 (require 'tex)
 
+;; Silence the compiler for functions:
+(declare-function TeX-install-toolbar "tex-bar" nil)
+
 ;;; Tool bar
 
 (defcustom plain-TeX-enable-toolbar t
diff --git a/style/pstricks.el b/style/pstricks.el
index b5b93df6..f40db099 100644
--- a/style/pstricks.el
+++ b/style/pstricks.el
@@ -1,6 +1,6 @@
 ;;; pstricks.el --- AUCTeX style for the `pstricks' package.  -*- 
lexical-binding: t; -*-
 
-;; Copyright (C) 2007-2022  Free Software Foundation, Inc.
+;; Copyright (C) 2007-2024  Free Software Foundation, Inc.
 
 ;; Author: Holger Sparr 
 ;; Maintainer: auctex-devel@gnu.org
@@ -652,9 +652,10 @@ package PNAME"
 ;;; Environments
 (defun LaTeX-pst-env-pspicture (env)
   "Create new pspicure environment."
-  (let ((opt (multi-prompt-key-value
-  (TeX-argument-prompt t "Options" nil)
-  '(("showgrid") ("shift"
+  (let ((opt (TeX-read-key-val t
+   '(("showgrid" ("true" "false"))
+ ("shift"))
+   "Options"))
 (p0 (LaTeX-pst-what "point" "Lower left (default 0,0)" "0,0"))
 (p1 (LaTeX-pst-what "point" "Upper right (default 1,1)" "1,1"))
 corn)
diff --git a/tex.el b/tex.el
index 325f883b..9fb533ff 100644
--- a/tex.el
+++ b/tex.el
@@ -54,11 +54,13 @@
   (bus service path interface method &rest args))
 (declare-function dbus-register-signal "ext:dbus"
   (bus service path interface signal handler &rest args))
+(declare-function font-latex-setup "font-latex" nil)
 (declare-function LaTeX-environment-list "latex" nil)
 (declare-function LaTeX-bibliography-list "latex" nil)
 (declare-function LaTeX-completion-label-annotation-function "latex" (label))
 (declare-function LaTeX-completion-label-list "latex" nil)
 (declare-function LaTeX-section-name "latex" (level))
+(declare-function TeX-fold-mode "tex-fold" (&optional arg))
 (declare-function comint-exec "ext:comint"
   (buffer name command startfile switches))
 (declare-function comint-mode "ext:comint" nil)
@@ -801,12 +803,12 @@ emacs 24.1 and is then later run by emacs 24.5."
 (advice-add 'hack-one-local-variable :after #'TeX--call-minor-mode)
 (defun TeX--call-minor-mode (var val &rest _)
   "Call minor mode function if minor mode variable is found."
-;; Instead of checking for each mode explicitly `minor-mode-list'
-;; could be used.  But this may make the byte compiler pop up.
-(when (memq var '(TeX-PDF-mode
-  TeX-source-correlate-mode TeX-interactive-mode
-  TeX-fold-mode LaTeX-math-mode))
-  (funcall var (if (symbol-value val) 1 0
+  ;; Instead of checking for each mode explicitly `minor-mode-list'
+  ;; could be used.  But this may make the byte compiler pop up.
+  (when (memq var '(TeX-PDF-mode
+TeX-source-correlate-mode TeX-interactive-mode
+TeX-fold-mode LaTeX-math-mode))
+(funcall var (if (symbol-value val) 1 0
 
 (defvar TeX-overlay-priority-step 16
   "Numerical difference of priorities between nested overlays.



master f5546d1d: ; * NEWS.org: Update the file.

2024-04-25 Thread Arash Esbati
branch: master
commit f5546d1da0feacc43d0673dab262a7a7f44f26e9
Author: Arash Esbati 
Commit: Arash Esbati 

; * NEWS.org: Update the file.
---
 NEWS.org | 4 
 1 file changed, 4 insertions(+)

diff --git a/NEWS.org b/NEWS.org
index 21b98e30..10e890e0 100644
--- a/NEWS.org
+++ b/NEWS.org
@@ -10,6 +10,10 @@
 
 ** Added
 
+- Add support for indirect buffers cloned from buffers visiting a file.
+  In indirect buffer, preview-latex works correctly when the command
+  ~preview-region~ is invoked.  The command ~preview-document~ puts
+  preview images in the base buffer, not in the indirect buffer itself.
 - Add preliminary support for processing files with latexmk.  Support
   for =dvipdfmx= and the choice for viewer after compilation are not
   optimal, yet.  Overall, the support comes close to what the



Re: [can't compile the main branch]

2024-04-25 Thread Ikumi Keita
Hi all,

> Stefan Monnier  writes:
>> And I like the way the manual is formatted.  Compare this:
>> https://www.gnu.org/software/auctex/manual/auctex.html
>> with this:
>> https://elpa.gnu.org/devel/doc/auctex.html

> Hmm... nice.  FWIW, the elpa rendering is the same as that of

> https://www.gnu.org/software/emacs/manual/html_node/emacs/index.html

> not sure why https://www.gnu.org/software/auctex/manual/auctex.html is
> not as nice.

The reason must be that the traditional AUCTeX html manuals are
generated with texi2html, not makeinfo.

A while ago, I noticed that the preview-latex html manual lacks its
contents in the FAQ section[1] and am preparing to propose the attached
change to use makeinfo rather than texi2html, so that others can test
it. But it seems it's no longer necessary :-)

[1] all nodes below 
https://www.gnu.org/software/auctex/manual/preview-latex/Frequently-Asked-Questions.html

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW

>From 37a225843d9995b308a36942f3d38fdfbaec9a46 Mon Sep 17 00:00:00 2001
From: Ikumi Keita 
Date: Thu, 18 Apr 2024 22:18:24 +0900
Subject: [PATCH] Immigrate from texi2html to makeinfo

* gendocs.sh.patch: New file. Copy from gendocspatch branch and arrange
for use with makeinfo.
* Makefile.in (www-doc): Arrange options for gendocs.sh for makeinfo.
Change URL to retrieve gendocs.sh.patch from master branch.
---
 Makefile.in  | 12 -
 gendocs.sh.patch | 67 
 2 files changed, 73 insertions(+), 6 deletions(-)
 create mode 100644 gendocs.sh.patch

diff --git a/Makefile.in b/Makefile.in
index bc2ea951..c2c8bf83 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -605,17 +605,17 @@ www-doc: check-tag
 	$(CP) auctex-$(TAG)/doc/*.texi $(WWWDIR)/manual
 	cd $(WWWDIR)/manual \
 	&& wget -O gendocs.sh 'https://cvs.savannah.gnu.org/viewvc/%2acheckout%2a/texinfo/texinfo/util/gendocs.sh' \
-	&& wget -O gendocs.sh.patch 'https://git.savannah.gnu.org/gitweb/?p=auctex.git;a=blob_plain;f=gendocs.sh.patch;hb=gendocspatch' \
+	&& wget -O gendocs.sh.patch 'https://git.savannah.gnu.org/gitweb/?p=auctex.git;a=blob_plain;f=gendocs.sh.patch;hb=master' \
 	&& patch https://cvs.savannah.gnu.org/viewvc/%2acheckout%2a/texinfo/texinfo/util/gendocs_template' \
 	&& sed -i -e 's/html_node\/index\.html/%%PACKAGE%%\/index.html/' gendocs_template \
 	&& mkdir .texinfo \
-	&& echo -e "emacs split https://www.gnu.org/software/emacs/manual/html_node/emacs/\nemacs mono https://www.gnu.org/software/emacs/manual/html_mono/emacs.html\nreftex split https://www.gnu.org/software/auctex/manual/reftex/\nreftex mono https://www.gnu.org/software/auctex/manual/reftex.html\n"; > .texinfo/htmlxref.cnf \
-	&& ./gendocs.sh --email bug-auc...@gnu.org --texi2html \
-	  --html --use-nodes auctex "AUCTeX Manual" \
-	&& ./gendocs.sh --email bug-auc...@gnu.org --texi2html \
-	  --html --use-nodes preview-latex "preview-latex Manual"
+	&& echo -e "emacs node https://www.gnu.org/software/emacs/manual/html_node/emacs/\nemacs mono https://www.gnu.org/software/emacs/manual/html_mono/emacs.html\nreftex node https://www.gnu.org/software/auctex/manual/reftex/\nreftex mono https://www.gnu.org/software/auctex/manual/reftex.html\n"; > .texinfo/htmlxref.cnf \
+	&& ./gendocs.sh --email bug-auc...@gnu.org \
+	  auctex "AUCTeX Manual" \
+	&& ./gendocs.sh --email bug-auc...@gnu.org \
+	  preview-latex "preview-latex Manual"
 
 preview-ball: check-tag
 	test ! -d $(PREVIEW_BUILD_DIR) || rm -r $(PREVIEW_BUILD_DIR)
diff --git a/gendocs.sh.patch b/gendocs.sh.patch
new file mode 100644
index ..3c3967ce
--- /dev/null
+++ b/gendocs.sh.patch
@@ -0,0 +1,67 @@
+--- gendocs.sh.orig	2014-10-29 14:25:47.404620794 +0100
 gendocs.sh	2014-10-29 14:35:45.812600075 +0100
+@@ -320,9 +320,9 @@
+ tar -czf "$abs_outdir/${PACKAGE}.html_$1.tar.gz" -- *.html
+   )
+   eval html_$1_tgz_size=`calcsize "$outdir/${PACKAGE}.html_$1.tar.gz"`
+-  rm -f "$outdir"/html_$1/*.html
+-  mkdir -p "$outdir/html_$1/"
+-  mv ${split_html_dir}/*.html "$outdir/html_$1/"
++  rm -f "$outdir"/${PACKAGE}/*.html
++  mkdir -p "$outdir/${PACKAGE}/"
++  mv ${split_html_dir}/*.html "$outdir/${PACKAGE}/"
+   rmdir ${split_html_dir}
+ }
+ 
+@@ -351,9 +351,9 @@
+   )
+   eval \
+ html_${split}_tgz_size=`calcsize "$outdir/$PACKAGE.html_$split.tar.gz"`
+-  rm -rf "$outdir/html_$split/"
+-  mv $split_html_dir "$outdir/html_$split/"
+-  du -s "$outdir/html_$split/"
++  rm -rf "$outdir/${PACKAGE}/"
++  mv $split_html_dir "$outdir/${PACKAGE}/"
++  du -s "$outdir/${PACKAGE}/"
+   ls -l "$outdir/$PACKAGE.html_$split.tar.gz"
+ 
+ else # use texi2html:
+@@ -368,8 +368,8 @@
+   mv $PACKAGE.html "$outdir/"
+ 
+   html_split node
+-  html_split chapter
+-  html_split section
++#   html_split chapter
++#   html_split section
+ fi
+ 
+ printf "\nMaking .tar.gz for sources...\n"
+@@ -421,13 +421,13 @@
+ fi
+ 
+ printf "\nMaking index file...\n"
+-if test -z "$use_texi2html"; then