Re: [AUCTeX-devel] font-latex.el [1/4]: Improve the code generated by font-latex-make-match-defun

[Ikumi Keita]

Hi Arash,

> Sigh, sorry for the dumb question!  I was looking at the source and your
> patch at the same time and lost track there.

No problem.  Feel free to give any other comments if you find somthing
other to ask.

Bye,
Ikumi Keita

___
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

Re: [AUCTeX-devel] font-latex.el [1/4]: Improve the code generated by font-latex-make-match-defun

[Arash Esbati]

Hi Keita,

Ikumi Keita  writes:

> It is there in order for the following ",face" to be expanded as
> intended.

Sigh, sorry for the dumb question!  I was looking at the source and your
patch at the same time and lost track there.

Thanks for taking your time.

Best, Arash

___
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

Re: [AUCTeX-devel] font-latex.el [1/4]: Improve the code generated by font-latex-make-match-defun

[Ikumi Keita]

Hi Arash,

> first of all, a big thank you for diving into this and your profound
> analysis.  font-latex.el is not my strongest point, but I think I
> understood your findings and they make sense to me.  Maybe others could
> confirm.  

Thank you for taking a look and giving encouraging comments.

> I have a question reg. your patch and sorry if I'm missing something
> here:

>> diff --git a/font-latex.el b/font-latex.el
>> --- a/font-latex.el
>> +++ b/font-latex.el
>> @@ -502,9 +502,9 @@
>> ,(intern (concat prefix name "-keywords")))
>> ;; `face' can be a face symbol, a form returning
>> ;; a face symbol, or a list of face attributes.
>> - (if (and (listp ,face) (functionp (car ,face)))
>> - (eval ,face)
>> -   ,face)
>> + ,(if (and (listp face) (fboundp (car face)))
>> + face
>> +`',face)
> __^__
> Why do you need this extra backtick here?

It is there in order for the following ",face" to be expanded as
intended.  Since the point is inside the form ",(if ... )", which begins
with a comma, a backquote is necessary for another comma-preceding
expression ",face" to evaluate to the valuce of the variable "face".

I tested with this backquote deleted, then the generated code became
 (\, face)
instead of the value of the variable "face".

Bye,
Ikumi Keita

___
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

Re: [AUCTeX-devel] font-latex.el [1/4]: Improve the code generated by font-latex-make-match-defun

[Arash Esbati]

Hi Keita,

Ikumi Keita  writes:

first of all, a big thank you for diving into this and your profound
analysis.  font-latex.el is not my strongest point, but I think I
understood your findings and they make sense to me.  Maybe others could
confirm.  

I have a question reg. your patch and sorry if I'm missing something
here:

> diff --git a/font-latex.el b/font-latex.el
> --- a/font-latex.el
> +++ b/font-latex.el
> @@ -502,9 +502,9 @@
> ,(intern (concat prefix name "-keywords")))
>;; `face' can be a face symbol, a form returning
>;; a face symbol, or a list of face attributes.
> -  (if (and (listp ,face) (functionp (car ,face)))
> -  (eval ,face)
> -,face)
> +  ,(if (and (listp face) (fboundp (car face)))
> +  face
> + `',face)
  __^__
Why do you need this extra backtick here?

Best, Arash

___
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel