[aur-general] Signoff report for [community-testing]

[Arch Website Notification]

=== Signoff report for [community-testing] ===
https://www.archlinux.org/packages/signoffs/

There are currently:
* 0 new packages in last 24 hours
* 0 known bad packages
* 0 packages not accepting signoffs
* 0 fully signed off packages
* 36 packages missing signoffs
* 12 packages older than 14 days

(Note: the word 'package' as used here refers to packages as grouped by
pkgbase, architecture, and repository; e.g., one PKGBUILD produces one
package per architecture, even if it is a split package.)



== Incomplete signoffs for [community] (36 total) ==

* sage-notebook-0.11.6.1-1 (any)
0/2 signoffs
* sagemath-doc-7.0-1 (any)
0/2 signoffs
* acpi_call-1.1.0-38 (i686)
0/1 signoffs
* arm-none-eabi-binutils-2.26-1 (i686)
0/1 signoffs
* avr-binutils-2.26-1 (i686)
0/1 signoffs
* bbswitch-0.8-40 (i686)
0/1 signoffs
* eclib-20160101-1 (i686)
0/1 signoffs
* gdal-2.0.1-7 (i686)
0/1 signoffs
* lcalc-1.23-10 (i686)
0/1 signoffs
* libfplll-20160107-1 (i686)
0/1 signoffs
* pari-sage-2.8.2044.g89b0f1e-1 (i686)
0/1 signoffs
* postgis-2.2.1-2 (i686)
0/1 signoffs
* pynac-0.6.0-1 (i686)
0/1 signoffs
* r8168-8.041.00-3 (i686)
0/1 signoffs
* rt3562sta-2.4.1.1_r3-3 (i686)
0/1 signoffs
* sagemath-7.0-2 (i686)
0/1 signoffs
* tp_smapi-0.41-77 (i686)
0/1 signoffs
* vhba-module-20140928-21 (i686)
0/1 signoffs
* virtualbox-modules-5.0.14-2 (i686)
0/1 signoffs
* acpi_call-1.1.0-38 (x86_64)
0/2 signoffs
* arm-none-eabi-binutils-2.26-1 (x86_64)
0/2 signoffs
* avr-binutils-2.26-1 (x86_64)
0/2 signoffs
* bbswitch-0.8-40 (x86_64)
0/2 signoffs
* eclib-20160101-1 (x86_64)
0/2 signoffs
* gdal-2.0.1-7 (x86_64)
0/2 signoffs
* lcalc-1.23-10 (x86_64)
0/2 signoffs
* libfplll-20160107-1 (x86_64)
0/2 signoffs
* pari-sage-2.8.2044.g89b0f1e-1 (x86_64)
0/2 signoffs
* postgis-2.2.1-2 (x86_64)
0/2 signoffs
* pynac-0.6.0-1 (x86_64)
0/2 signoffs
* r8168-8.041.00-3 (x86_64)
0/2 signoffs
* rt3562sta-2.4.1.1_r3-3 (x86_64)
0/2 signoffs
* sagemath-7.0-2 (x86_64)
0/2 signoffs
* tp_smapi-0.41-77 (x86_64)
0/2 signoffs
* vhba-module-20140928-21 (x86_64)
0/2 signoffs
* virtualbox-modules-5.0.14-2 (x86_64)
0/2 signoffs


== All packages in [community-testing] for more than 14 days (12 total) ==

* acpi_call-1.1.0-38 (i686), since 2016-01-14
* tp_smapi-0.41-77 (i686), since 2016-01-14
* acpi_call-1.1.0-38 (x86_64), since 2016-01-14
* bbswitch-0.8-40 (i686), since 2016-01-14
* tp_smapi-0.41-77 (x86_64), since 2016-01-14
* bbswitch-0.8-40 (x86_64), since 2016-01-14
* vhba-module-20140928-21 (i686), since 2016-01-14
* vhba-module-20140928-21 (x86_64), since 2016-01-14
* rt3562sta-2.4.1.1_r3-3 (i686), since 2016-01-14
* rt3562sta-2.4.1.1_r3-3 (x86_64), since 2016-01-14
* r8168-8.041.00-3 (i686), since 2016-01-14
* r8168-8.041.00-3 (x86_64), since 2016-01-14


== Top five in signoffs in last 24 hours ==

1. foutrelis - 2 signoffs
2. anthraxx - 2 signoffs
3. eworm - 1 signoffs

Re: [aur-general] PKGBUILD review

[Victor Dmitriyev]

On 30.01.2016 00:53, Ryan Whited wrote:

Greetings,

I've written my first PKGBUILD that I think is acceptable to submit
and while I tried to make sure I followed the guidelines, I wanted to
submit it for review here.


Sorry, but this PKGBUILD looks unacceptable to me.

Quotes are from 
https://wiki.archlinux.org/index.php/Arch_packaging_standards



Packages should not contain any of the following directories:
...
/home
You shouldn't install anything in home directories, install it in 
/usr/share/${pkgname} or /opt/${pkgname} instead



All important messages should be echoed during install using an
.install file. For example, if a package needs extra setup to work,
directions should be included.
If you need to copy files to /home/$USER/.godot/templates/ for programs 
to work correctly put message about it in the .install file.



Do not introduce new variables into PKGBUILD build scripts, unless
the package cannot be built without doing so, as these could possibly
conflict with variables used in makepkg itself. If a new variable is
absolutely required, prefix the variable name with an underscore (_).


You create LICENSE file by copying part of main/main.cpp but you 
probably should just use LICENSE.md included in the archive. Also you 
don't copy it anywhere.



The license file(s) should be included in /usr/share/licenses/$pkgname/
e.g. /usr/share/licenses/dibfoo/LICENSE. One good way to do this is
by using:
install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"


In conclusion, you made big mistakes in this PKGBUILD. I think you 
should probably rewrite most of it after reading ArchWiki packaging 
guidelines carefully.


Regards,
Victor