Re: [aur-general] PKGBUILD review
You've still got references to OS X and windows installs Also instead of if test _arch == '32'; then scons -j $cores platform=server target=release_debug tools=no bits=32 else scons -j $cores platform=server target=release_debug tools=no bits=64 fi you can just do scons -j $cores platform=server target=release_debug tools=no bits=$_arch You're setting _arch in 3 places even though it can only have 2 values; it's also in an array for no apparent reason, you can shorten it to _arch=32 [[ $CARCH == x86_64 ]] && _arch=64 Or some such variation. The same goes in the install, you have a bunch of 'if _arch == 32' and then using 32 twice in a string; just substitute that with the variable. Regards, Justin
[aur-general] PKGBUILD review
Couldn't figure out how to reply from digest (turned that off now) so
I guess I'm starting a new thread. I've completely overhauled the
PKGBUILD taking in critiques that I've received and some things I've
learned on my own.
As before, you can view the PKGBUILD at
https://github.com/godofgrunts/arch-PKGBUILDs/blob/master/godot-export
# Maintainer: Ryan Whited @god_of_grunts
pkgname=godot-export
_rname=godot
pkgver=1.1
pkgrel=1
pkgdesc="Export templates for the stable release of the Godot engine 1.1"
url="http://www.godotengine.org;
license=('MIT')
arch=('i686' 'x86_64')
makedepends=('scons' 'mingw-w64-binutils' 'mingw-w64-crt'
'mingw-w64-gcc' 'mingw-w64-headers' 'mingw-w64-headers-bootstrap'
'mingw-w64-winpthreads' 'upx') #'emscripten'
depends=('glu' 'libxcursor' 'alsa-lib' 'freetype2' 'mesa')
optdepends=('godot: Cannot export without it')
conflicts=('godot-export-git' 'godot-git')
install=$pkgname.install
_arch=''
if test "$CARCH" == x86_64; then
_arch=('64')
else
_arch=('32')
fi
source=("https://github.com/godotengine/godot/archive/${pkgver}-stable.tar.gz;)
md5sums=('87eb2fc3518ce7a27957fada1ba003e9')
build() {
export MINGW64_PREFIX="x86_64-w64-mingw32-"
export MINGW32_PREFIX="i686-w64-mingw32-"
#export EMSCRIPTEN_ROOT=/usr/lib/emscripten
cores=$(nproc)
cd "${srcdir}"/${_rname}-${pkgver}-stable
#linux
if test _arch == '32'; then
scons -j $cores platform=x11 tools=no target=release bits=32
#linux_x11_32_release
scons -j $cores platform=x11 tools=no target=release_debug
bits=32 #linux_x11_32_debug
else
scons -j $cores platform=x11 tools=no target=release bits=64
#linux_x11_64_release
scons -j $cores platform=x11 tools=no target=release_debug
bits=64 #linux_x11_64_debug
fi
#linux-server
if test _arch == '32'; then
scons -j $cores platform=server target=release_debug tools=no bits=32
else
scons -j $cores platform=server target=release_debug tools=no bits=64
fi
#Windows
export MINGW32_PREFIX="i686-w64-mingw32-"
export MINGW64_PREFIX="x86_64-w64-mingw32-"
scons -j $cores platform=windows tools=no target=release bits=32
#windows_32_release.exe
scons -j $cores platform=windows tools=no target=release_debug
bits=32 #windows_32_debug.exe
scons -j $cores platform=windows tools=no target=release bits=64
#windows_64_release.exe
scons -j $cores platform=windows tools=no target=release_debug
bits=64 #windows_64_debug.exe
#OS X
#I'll put code here when
https://github.com/godotengine/godot/wiki/compiling_osx is updated
#Android
#Probably should do this yourself, I'm not about to mess with your
Android SDK
#https://github.com/godotengine/godot/wiki/export_android
#WinRT
#Can't do this on Linux sorry
#Blackberry 10
#Currently disabled by Godot
#HTML5
#Currently broken per https://github.com/godotengine/godot/issues/3510
#scons -j $cores platform=javascript tools=no target=release
#scons -j $cores platform=javascript tools=no target=release_debug
}
package() {
install -D -m644 "${srcdir}"/${_rname}-${pkgver}-stable/LICENSE.md
"${pkgdir}/usr/share/licenses/${_rname}/LICENSE"
#Linux
if test _arch == '32'; then
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.x11.opt.32
${pkgdir}/usr/lib/godot/linux_x11_32_release
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.x11.opt.debug.32
${pkgdir}/usr/lib/godot/linux_x11_32_debug
upx ${pkgdir}/usr/lib/godot/linux_x11_32_release
upx ${pkgdir}/usr/lib/godot/linux_x11_32_debug
else
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.x11.opt.64
${pkgdir}/usr/lib/godot/linux_x11_64_release
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.x11.opt.debug.64
${pkgdir}/usr/lib/godot/linux_x11_64_debug
upx ${pkgdir}/usr/lib/godot/linux_x11_64_release
upx ${pkgdir}/usr/lib/godot/linux_x11_64_debug
fi
#Linux Server
if test _arch == '32'; then
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot_server.server.opt.debug.32
${pkgdir}/usr/lib/godot/linux_server_32
upx ${pkgdir}/usr/lib/godot/linux_server_32
else
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot_server.server.opt.debug.64
${pkgdir}/usr/lib/godot/linux_server_64
upx ${pkgdir}/usr/lib/godot/linux_server_64
fi
#Windows
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.windows.opt.64.exe
${pkgdir}/usr/lib/godot/windows_64_release.exe
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.windows.opt.debug.64.exe
${pkgdir}/usr/lib/godot/windows_64_debug.exe
install -D -m755
"${srcdir}"/${_rname}-${pkgver}-stable/bin/godot.windows.opt.32.exe
${pkgdir}/usr/lib/godot/windows_32_release.exe
install -D -m755
[aur-general] Signoff report for [community-testing]
=== Signoff report for [community-testing] === https://www.archlinux.org/packages/signoffs/ There are currently: * 2 new packages in last 24 hours * 0 known bad packages * 0 packages not accepting signoffs * 1 fully signed off package * 13 packages missing signoffs * 0 packages older than 14 days (Note: the word 'package' as used here refers to packages as grouped by pkgbase, architecture, and repository; e.g., one PKGBUILD produces one package per architecture, even if it is a split package.) == New packages in [community-testing] in last 24 hours (2 total) == * pcurses-4-5 (i686) * pcurses-4-5 (x86_64) == Incomplete signoffs for [community] (13 total) == * python-colorama-0.3.6-1 (any) 0/2 signoffs * shadowsocks-2.8.2.20160112-1 (any) 0/2 signoffs * gdal-2.0.1-7 (i686) 0/1 signoffs * mythplugins-1:0.27.6-1 (i686) 0/1 signoffs * mythtv-1:0.27.6-1 (i686) 0/1 signoffs * pcurses-4-5 (i686) 0/1 signoffs * postgis-2.2.1-2 (i686) 0/1 signoffs * gdal-2.0.1-7 (x86_64) 0/2 signoffs * go-2:1.5.3-3 (x86_64) 1/2 signoffs * mythplugins-1:0.27.6-1 (x86_64) 0/2 signoffs * mythtv-1:0.27.6-1 (x86_64) 0/2 signoffs * pcurses-4-5 (x86_64) 0/2 signoffs * postgis-2.2.1-2 (x86_64) 0/2 signoffs == Completed signoffs (1 total) == * go-2:1.5.3-3 (i686) == Top five in signoffs in last 24 hours == 1. arodseth - 2 signoffs 2. foutrelis - 1 signoffs 3. pierre - 1 signoffs 4. ambrevar - 1 signoffs
